From nobody Tue Apr 7 08:08:03 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C155A37C10D for ; Sun, 15 Mar 2026 21:53:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773611607; cv=none; b=qWz7DJ4oTFxkmLsoMG3zq2ui2F63D6W/zbsj1jarpAzRq7RB2jdy/ZIOIMJi8SZcGcY8EqRkq5/ZwB/jjKq8QfPCJDIdUkOD+cdpdTbkPzm6+52qkLLXwBRmubuHmUcGi+73wGmHS++RJkUgXV8tVjCjAor+gzQcxXrEdDet+dY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773611607; c=relaxed/simple; bh=IBDYUK+3O1y5VL1z6GzT5aRoM2+wTLMn0ghXsNI6iG0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NwZ1S5f5unHPfDospRYMowOQ9KR9C2C8JKWEBnsH3SNunYGVprVvv4S0dVSCHkWxiNKn9dw0lWUqRijlcrJhc5pLiyFfPNkRW0qf4YSF8+PTBX+9G/Ja32WXBph/61omPQUixqOFp5RXiOS5ARDRDbKj6lRZeICxQnPeD+59U7k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BP1DUyCy; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BP1DUyCy" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-35a04d6aeb0so2350019a91.0 for ; Sun, 15 Mar 2026 14:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773611606; x=1774216406; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cXUioPAqGCi/G7aJUPOn/95wAygcdDsF9zmaY+F6+Nc=; b=BP1DUyCy6qjgkEJ3qgba6JOxkZFgdWn3EWp3cyU3eZEMWKES+ljoamOpMNjrcOvTBL sHq03gDDtFj3OCdBVJXwNVEqLSigHsWzc45VW+jJb1czsNFvdgkD7x9PsHWG+IJ3JUfD iXGsfb4CK72PEZv/syyqg1TFlbOyHw5USbX1qBklhg96V4h7gTupbaO8imu9ej9y0ER9 YP5zaNvoUN9oVT9WDqCrEKdyhjKspE5wjh67oN6zvOM9Gixb4PBh1lny8duW6pVy0a4L zBP6fLU5PasQBdHB2HTxQXKQgAXCsPX4v2yvU3opqMOWumA86yssLCbRzCB27bcP8MUd IGSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773611606; x=1774216406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cXUioPAqGCi/G7aJUPOn/95wAygcdDsF9zmaY+F6+Nc=; b=I3rz8ULDdiJc1rKQq/xkT+vc7hPshcQLr4nlPMuvs/9KAmsBx8x5UlkKvgtPttBoCP Sq1an+VxaN7byTyKU87WD9eR19ObkQRl+21TTQD6bKRiVa1wiKZUPkns5ADBhXf6pOPX IHEfgXlix1H8HbK7CEKNUEQTD3lsv1FC1d/F6piT6tneh3nCxmeMM+Cpg57qA4e8G3pE EfswFuBZolzoAjnY42LspnNfFdd/md7yCzT2n3HVkqJoyWta1OtTpzd3ofajApvQwNHN xCGRqtdq1lYa0GO5ibRigh+VqhYKaaD3BH9h01NDOodOXrqs/40ytx+V2Altar3nV9kv qccg== X-Forwarded-Encrypted: i=1; AJvYcCVUw+gY8n4w1QD9aazdD4gRt2TCsrb83mV7IYwySBAkjqsZcL2RgN+Gqk1PlybSiHOsfwvJY8mvnrJCjHI=@vger.kernel.org X-Gm-Message-State: AOJu0YwG4nHzS9Incig429/E3zZtjidBiyZjv0EFnEIV7mB5wrMokFjM 4EYt0LMsp2G62m+3Z/bK/VAPuySp8DkGBK8QwvztJaUG/HI/+8AClns= X-Gm-Gg: ATEYQzyBx9SLNPiiPl8Hf7DgeUEgGingq3m+xQeYjrRQysPvQWwEtOD5BcaBkffTR19 /rn5GiVSx/mDsYPmmr4IoHswnOsp4Ky4/e1nQV8PapuYOpoBZZi8/IPnAM9/Hya57pYWr8e4yLw PaPGXHOORjy/iOed9/fWDU7Pr/XmIGjRdknZCnJyoCZt+rOmOWKnEdlQ0WXUgiQfGvfXp8sWsRC La4OHOqM+qMaxWONlMIM9wFHkJq8boBbJJdgeBTIw+Br+XJbH9E93IPpi/19iDDq4eYIbPcLgXy MNNFdYO82TgemSFHFTd1ewnIAC6SHlTfQUMKyXqx7BTVaF9hGpM7NtFXeExg5nki79NwNgCs7wc crspvD38mJl1K+1spX8hAq6rCNbZmaTrE0A4URdc53gmJiExT9speEOv0ml6SpC5en7fRgbplzO yLBbwV3UtnHsLAjCNH9HfPJ1l6mEgjZb/cSSCMPZ/A+S9dlDlP32zBBoFGeFO1ygA= X-Received: by 2002:a17:90b:1d08:b0:359:409:49bf with SMTP id 98e67ed59e1d1-35a22063fb8mr10339166a91.21.1773611606207; Sun, 15 Mar 2026 14:53:26 -0700 (PDT) Received: from at-Standard-PC-Q35-ICH9-2009.. ([171.61.163.197]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35b9303eb9bsm3074980a91.8.2026.03.15.14.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 14:53:25 -0700 (PDT) From: Atharva Tiwari To: Cc: Atharva Tiwari , Ard Biesheuvel , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH v2 2/2] platform/apple-gmux: use apple_brightness to save brightness to EFI Date: Mon, 16 Mar 2026 03:22:42 +0530 Message-ID: <20260315215302.24087-3-atharvatiwarilinuxdev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260315215302.24087-1-atharvatiwarilinuxdev@gmail.com> References: <20260315215302.24087-1-atharvatiwarilinuxdev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" use apple_brightness to save brightness to EFI. (tested on iMac20,1) Signed-off-by: Atharva Tiwari --- drivers/platform/x86/apple-gmux.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple= -gmux.c index 1417e230edbd..5a13c917c496 100644 --- a/drivers/platform/x86/apple-gmux.c +++ b/drivers/platform/x86/apple-gmux.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include =20 @@ -78,6 +79,8 @@ struct apple_gmux_data { /* debugfs data */ u8 selected_port; struct dentry *debug_dentry; + + bool save_efi; }; =20 static struct apple_gmux_data *apple_gmux_data; @@ -960,6 +963,13 @@ static int gmux_probe(struct pnp_dev *pnp, const struc= t pnp_device_id *id) } =20 gmux_init_debugfs(gmux_data); + if (IS_ENABLED(CONFIG_APPLE_BRIGHTNESS)) { + ret =3D apple_brightness_probe(gmux_data->bdev, &gmux_get_brightness); + if (ret) + pr_warn("Unable to Enable EFI brightness save: %d\n", ret); + + gmux_data->save_efi =3D true; + } return 0; =20 err_register_handler: @@ -1012,6 +1022,16 @@ static void gmux_remove(struct pnp_dev *pnp) kfree(gmux_data); } =20 +static void gmux_shutdown(struct pnp_dev *pnp) +{ + struct apple_gmux_data *gmux_data =3D pnp_get_drvdata(pnp); + + if (gmux_data->save_efi) + apple_brightness_shutdown(); + + gmux_remove(pnp); +} + static const struct pnp_device_id gmux_device_ids[] =3D { {GMUX_ACPI_HID, 0}, {"", 0} @@ -1026,6 +1046,7 @@ static struct pnp_driver gmux_pnp_driver =3D { .name =3D "apple-gmux", .probe =3D gmux_probe, .remove =3D gmux_remove, + .shutdown =3D gmux_shutdown, .id_table =3D gmux_device_ids, .driver =3D { .pm =3D &gmux_dev_pm_ops, --=20 2.43.0