From nobody Tue Apr 7 07:55:39 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5F3E37C106 for ; Sun, 15 Mar 2026 20:45:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773607518; cv=none; b=NaTTd1Lk4b1r/gO6p5hcNrT7KWAiA2IWBIQ0Dw2HrKJw9glDyJ139G0Iyk8YwMF7gzwesY3KHfm3RNw9gvp0bmBcj8TKax9rgLGqw6YBy2LEuP058/LC81HYA4PKV3HxSCIWBVsTucezJwDQaVno8biR/940E8fMR9ls+XUmSFo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773607518; c=relaxed/simple; bh=rPpgtG8br7dbeLmqjLEppfzKOI+OoaBXSnHrSGxltFQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Vh4GwWYHW9zV2HkZxx+CksYSLJRpFrJb8hTQfCpQgU03n5J2WBzjk8BjXqKImqM1COzGdWSqNTHxa/Vq0kVUzzC9xuGp9tmfAxPunXPaokc2u6c0HaR6EWbBWbSPI7xV6foxJmtGxa7kw33vk5qafq3TF95hv3fa1Eg0d/AbNKU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y4A4fwmL; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y4A4fwmL" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4852b81c73aso34501965e9.3 for ; Sun, 15 Mar 2026 13:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773607515; x=1774212315; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PahM13Z+gyHUBDfHr8IMBngyQQ9TTRxFfOobW8O16HE=; b=Y4A4fwmLolCuMzJIuWE8jtjayeiOP8tLQSVqAc4EimyiV5ZggfBfOhB+TSAUA6M2EC B5BMth8KQCsfuXSsj8O/qQIK2FCWxKhyD0obXjOXEpK+XywkSr4T6i8OCj8upkbEKIW/ SzEdRxsox61P9oFLUx7dSV4lElLJe2mEHnNjrfPuQQvMgXF9woxoUUsQXR4vLwzADDbm SrvCbYabYUpvfJe1gq3Ce3EyZP/dQOCYDYFc2WonqCcMjjIDes8F6ucJwHgeAuUQh8nF vMtlGYyVLROJnGC5iSclyNNwtU+KkFZXyunzRqdwfo8kzZi1S5nhRlYDBRoO+h5dJmLM gNeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773607515; x=1774212315; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PahM13Z+gyHUBDfHr8IMBngyQQ9TTRxFfOobW8O16HE=; b=surYG7GepinlcDaya8uIoeqUn5D6G0QsP4W1GiKgHFLj9uKDXvQxLAmuV/V+H0yQ0i //h48iSJVr5AeZsDfssoCxA5ovfgAoLCoZDEumzQp/qDEe7w47izgdzBr1+buxRCmhTj HtB63G4uAfuKe34KX5dUOBKTm1B5h6s5URjPIt4EthAlEaPvVBrxQd12ap6mv/rpmHaD oIfDV9YPq9YPzMlR8rktbP7bFrpFK3tmRtYxjgmfWnMhI7OXgL0Qu3e0QGR9qkKYRSdx y3A8QcmWuzC9iERVEoh2VVt8fqjtjLmraJwqKl49EfZptFsfyRAz3CAgplZhkHkIr+hx Jn6w== X-Forwarded-Encrypted: i=1; AJvYcCUGQVAZhynzt9FK9uAPA5V29gNwLJldIgA4bs/NK22ISeZtlBX/c4po7LRNh8XydrO25cCf3zm2kzns870=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0ZOwLW/zVF+nThQiPCxqlgLfY3ZhLx1JIfpYP3YS/NzdrgopC oySlstcGnWJqJVXtGmota9mtr19liVJumYS6PhohDC87635knc3Z6p6d X-Gm-Gg: ATEYQzziULJwoHdYaMjwKI+UiMHEyJiFtq18CrXAPWQlEhunaKly3yHVcuyCmTEnOt+ oSVKpMER9rHTh6t++t8s3oReUuxZE0p/mfQ1ewCmZen01EhpiiEHoY7YnJQh5s2Kx0xYrapPIdf W1Yvl8QNUO5eB+c41aMe1OzhqI0L4J+JJ/ZrPcnnV6xsN47LEpbEWGzp2r47V8OCBTBht6d8hmR bWbBMHn/XVi79Vj+Ta07lsKM1+QxoSsXlaoROnqCOMSA21+n5XQ0xsBMwRx9mB3ien5mNXgtIhp Uv6Hr6P6d9kWCoXbj0+Qn29/zS0NZ+FoQEshHIUoFNcdxfwCDlf1RCxwzDts+MVTWv+AQa4ZR7b NDngq9uG7ReHNKoLXo7fGzEu5/E3o2VjOTD2wockE2HYWJb87MdlOL6LYQkMXF/UTsWOMcM+kN0 IRsKZa/39QuD65ju9En0H+Pas0YqQlMxwAnA== X-Received: by 2002:a05:600c:8b46:b0:485:557d:9fe with SMTP id 5b1f17b1804b1-485566d6e3emr174688435e9.12.1773607515215; Sun, 15 Mar 2026 13:45:15 -0700 (PDT) Received: from nas.local ([2001:912:1ac0:1e00:c662:37ff:fe09:93df]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485563f8c23sm132043885e9.1.2026.03.15.13.45.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 13:45:14 -0700 (PDT) From: Damien Dejean To: andrew@lunn.ch, krzk+dt@kernel.org, robh@kernel.org, kuba@kernel.org, maxime.chevallier@bootlin.com, pabeni@redhat.com Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, davem@davemloft.net, hkallweit1@gmail.com, Damien Dejean Subject: [PATCH net-next v8 4/4] net: phy: realtek: add RTL8224 polarity support Date: Sun, 15 Mar 2026 21:44:54 +0100 Message-ID: <20260315204454.124544-5-dam.dejean@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260315204454.124544-1-dam.dejean@gmail.com> References: <20260315204454.124544-1-dam.dejean@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The RTL8224 has a register to configure the polarity of every pair of each port. It provides device designers more flexbility when wiring the chip. Unfortunately, the register is left in an unknown state after a reset. Thus on devices where the bootloader don't initialize it, the driver has to do it to detect and use a link. The MDI polarity swap can be set in the device tree using the property enet-phy-pair-polarity. The u32 value is a bitfield where bit[0..3] control the polarity of pairs A..D. Signed-off-by: Damien Dejean --- drivers/net/phy/realtek/realtek_main.c | 34 +++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realt= ek/realtek_main.c index 2feb085f5c9e..a3691f9c19a5 100644 --- a/drivers/net/phy/realtek/realtek_main.c +++ b/drivers/net/phy/realtek/realtek_main.c @@ -172,6 +172,7 @@ #define RTL8224_SRAM_RTCT_LEN(pair) (0x8028 + (pair) * 4) =20 #define RTL8224_VND1_MDI_PAIR_SWAP 0xa90 +#define RTL8224_VND1_MDI_POLARITY_SWAP 0xa94 =20 #define RTL8366RB_POWER_SAVE 0x15 #define RTL8366RB_POWER_SAVE_ON BIT(12) @@ -1870,9 +1871,40 @@ static int rtl8224_mdi_config_order(struct phy_devic= e *phydev) order ? BIT(port_offset) : 0); } =20 +static int rtl8224_mdi_config_polarity(struct phy_device *phydev) +{ + struct device_node *np =3D phydev->mdio.dev.of_node; + u8 offset =3D (phydev->mdio.addr & 3) * 4; + u32 polarity =3D 0; + int ret; + + ret =3D of_property_read_u32(np, "enet-phy-pair-polarity", &polarity); + + /* Do nothing if the property is not present */ + if (ret =3D=3D -EINVAL) + return 0; + + if (ret) + return ret; + + if (polarity & ~0xf) + return -EINVAL; + + return rtl8224_package_modify_mmd(phydev, MDIO_MMD_VEND1, + RTL8224_VND1_MDI_POLARITY_SWAP, + 0xf << offset, + polarity << offset); +} + static int rtl8224_config_init(struct phy_device *phydev) { - return rtl8224_mdi_config_order(phydev); + int ret; + + ret =3D rtl8224_mdi_config_order(phydev); + if (ret) + return ret; + + return rtl8224_mdi_config_polarity(phydev); } =20 static int rtl8224_probe(struct phy_device *phydev) --=20 2.47.3