From nobody Tue Apr 7 07:07:55 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A9A219CC0C for ; Sun, 15 Mar 2026 19:48:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773604105; cv=none; b=LGgeHetsdyyn7UQAiPscJicKJl9BTd9FbQ2L/3rUQv9HTZjHYVNuaqgxT2HmuS1w+zbL/GY/sgAtMxAAPOrI196gUcvU9FZhqMuO6yjYtiyLpz4TegOgl915RQgS7qzLkC5CsXf8Y2WegQ0UV04YpGogSMR2HBOZIXrrucgSAG4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773604105; c=relaxed/simple; bh=gHDJ36QPykvS3xO3QZ/KLGfToUNHfLkIMyX0bCEKbA8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nPQE6snpFYLVfVzv86K3GQHPGOzYAoVaYzhgBom70i9+I9T1Ic2Gr+yJfwgYieHkpNYopEB4OWMVxIG1LPUOiQL9pCMKztAWQHF20WBTHZFEt2/qr4ELPyRpedLoNJ9BX2Kxe8P/vLxbUSAvqdCDHR6fNxHtxtIzIIKawpV4jqQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gdFPAJQJ; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gdFPAJQJ" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4852b81c73aso34255745e9.3 for ; Sun, 15 Mar 2026 12:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773604102; x=1774208902; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eDa+1bVuIqzJ9zEFM2cwV5Ez23sgmv4PTl6ruXCXLoc=; b=gdFPAJQJFwJBWONZJxUl6/wQsqEQw15PXzBzcZBN8DjJXbZbzyR8auaAO8CGJnsCbc ylClZja5fuQIMlmYkedcjKbfAElc8EYQoHYIBp3rwOUMPyz3IQe419DWsdfm2RoQvh40 IbKk8Kuqj6Dx4v2m7akHLHIVWkmROJdho1jXcq1LOjTEpUVB9ZdoIXIYONdwYKGisHtd r1uA7VFDDJGLQnHCqya0tMZLJDZkHkOICRq01MmpE58C4RqnqohuDbwkFmMrJtxH3Bp+ x6CiRYMok+XfnEo+4RsJgPiwMPyvnaeyWGPYvnFCnRCoAGaOGn/YZY/rhB0c+wL5/6P1 ww9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773604102; x=1774208902; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eDa+1bVuIqzJ9zEFM2cwV5Ez23sgmv4PTl6ruXCXLoc=; b=ECt9AWc/UiwaOcc0RjjD3soncQ8cdBiztKwVb49KV5nYrF3N7cTGV8qpIfO7BqUQs7 3rtcqBJqMUGkQLFtzY5VtWe588xO17bvkvERpaYLJk8LGFyERwFG5+px1uIv6qfiYkOq N2ZVMk1wWSUpLOSXEQxCQs/04miaj+Fl7iQDOKvuprjCnWeV2YJJGR24UUxotlkP31ob xZau0sICPpCHB9y3wbjlIjgfm8c3l7xNjkmpt5dX+mWkFQAjkdCjAj8eBSocdNnyYS8e DlakrKwDGawQjNVw5fOgfaQmNVxpkXkWnzAVHt+EPIS0U0gm2pWKJg5bYLZGYzZwj35z lTxg== X-Forwarded-Encrypted: i=1; AJvYcCUeLCcTnkxkltRax84o1tfjQmzkZx3quC0BHvR8nybeb/lC5hIKqhbj4A+ViM+BvA/q+gWb7ibUwwg1vTw=@vger.kernel.org X-Gm-Message-State: AOJu0YzddZzHPm1Wr1C34ooI2FT99vzO1qLVDMybkXxtsYivkdkX14v2 GcKsvx8N7owkybcny7EgqWZoezDo2nMWifTpnP8CLbftgF8+TP6EgvIQ X-Gm-Gg: ATEYQzxkDqOvGeD2gPplu9d8YBMGJPgcvI42yvasAhyLuq4lL/DQj/5HNxR/Yo+hf2h LBdjoUp356eZGVVGEjtJhUiSM6SqWAXFDxo3bDRagt6cYeDQh8S2Y0bHN+sGsPCl01hCDilSX20 LIUtcec32GggYAvAncamqaVKlW/iQTGdLAlfHjDg7nUKkI6xWdm21V6W+ibmPw36gfVcvADNvQS tDj+vcoubvVGeNMS7QieEPbHTD/s1O4zhPDG5UrYkClOKLXO908JuYKb06j6jZ1JRNgdzRHGTBk LWkVxzibT+c0o2jivF1mlRCH2uuC3NYIDbFBjO3Xc7kGvNLuP25VDoeWJb31xQpujoLyU29lBdM U9yplst+NQaNU3/c6ytd9DnwEP7wQueDMSXhJ6k2pl+tb5U8EBuWq+V6JVGGWquwP6ygvdkx2dU F9ogDd/Tlc7WzIMFZu+XhscDKL+9EFrIVmkDvPg03/I/oJRZRQf3VClu4= X-Received: by 2002:a05:600c:8486:b0:485:4136:99a8 with SMTP id 5b1f17b1804b1-48556700ca5mr172516905e9.22.1773604102306; Sun, 15 Mar 2026 12:48:22 -0700 (PDT) Received: from OaroraEtimis.tail60902c.ts.net ([2408:8956:4c20:952e:71d2:7185:4299:35a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48558fd09d8sm210510095e9.7.2026.03.15.12.48.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 12:48:21 -0700 (PDT) From: Oarora Etimis X-Google-Original-From: Oarora Etimis To: Greg Kroah-Hartman Cc: Minu Jin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Oarora Etimis Subject: [PATCH] staging: rtl8723bs: Use kmemdup() to replace kzalloc() followed by memcpy() Date: Mon, 16 Mar 2026 03:47:38 +0800 Message-ID: <20260315194738.154324-1-OaroraEtimis@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The kzalloc() function allocates memory and zero-initializes it. However, in rtw_cfg80211_set_wpa_ie(), the allocated buffer is immediately overwritten by memcpy(). This makes the zero-initialization completely unnecessary, wasting CPU cycles. Use kmemdup() to simplify the code, eliminate the redundant memcpy(), and remove the unnecessary zeroing overhead. Signed-off-by: Oarora Etimis --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 7cb0c6f22bf3..2f7fa5841578 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -1430,16 +1430,14 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *= padapter, u8 *pie, size_t iel goto exit; } =20 - buf =3D kzalloc(ielen, GFP_KERNEL); + buf =3D kmemdup(pie, ielen, GFP_KERNEL); if (!buf) { - ret =3D -ENOMEM; + ret =3D -ENOMEM; goto exit; } =20 - memcpy(buf, pie, ielen); - if (ielen < RSN_HEADER_LEN) { - ret =3D -1; + ret =3D -1; goto exit; } =20 --=20 2.47.3