From nobody Tue Apr 7 06:21:32 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BFBF366071 for ; Sun, 15 Mar 2026 15:07:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773587222; cv=none; b=l23YWh4IFmp7hTcW2Qt6AS1Pe3DEsifZCOygqGAsn1hLRuyBXDS25knuXQqyI2WAqj3EU2G2+CLEAsLKKRQqgBjj15zhgNCKI4ZBshFEBbqwriQe9Au0/ugyuJZVgMJ29dyoVcIB59gDZbRWBQWhz6zowlNPZBNl4tzdbBZuZsE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773587222; c=relaxed/simple; bh=lHBKOQBGm6Fxx9EJIkZRGsrEONe2639UKB4uauCnkoI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JevzxGvoFSZfMGj614gD8HwgYS9IDWaZgSkymsFiraM8LzV9EU9k64Xsw1QimsSapiJ4/dNBO2iU7nksW9Mawc5Cp5F0l5NLx3NaTKLaUDgM6FLnLJXZulLjnGn/8mYYy1m204Cb6E/mxuo9s74Kfes5s79nUbSstYIQPBOo6L0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fGGO4a+P; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fGGO4a+P" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4853e1ce427so42447185e9.3 for ; Sun, 15 Mar 2026 08:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773587219; x=1774192019; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R+oFKCqczy45ErhHsr9BjH0dVnyXksSjS9S6Ban9x4A=; b=fGGO4a+P5BbLZyW7yBlLpIJYbZabiAsIdg98E+w3ZvhvforLH8B8ad6pnk3BX+cNNG O1J4L4EscqOSpQLVgbXQhyCzdNtIkPouWY1pU7cyBrM47owa9Q0kB2t06QjP03BOnRIJ LG7r93swcKKFEgbhadEL1rOFUELIqgJUj/VaNx31kby6Hp6RZvuc7uaqH8FZBpLm8KCL 0Wk2hQU23uIod04p7nUo3cL1JMzIcDvuKkyVGCzJwFxOov73LwNyA9sJKtT52Uytrhfh o8O4JPqB9LLI2uvIGpedHbaAITObAjdZRxzQioqmWLEkOsGOQW7wRfkqs4iQThVYRTHC SLXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773587219; x=1774192019; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R+oFKCqczy45ErhHsr9BjH0dVnyXksSjS9S6Ban9x4A=; b=JHlMGAcAMJtfsqgL6scwZZ1V5s3oWYL4QVccISJ51qkXpyMW/ke8sGSnIbCVh7mVAD CNXEdqhgpYhPpINYJEHOQEBNSdR++Q+jQD/RLDECpZP/I2xAtoJ7MJh/4A/A9WAIzuxQ ykQd+56XlrqNQGMrA/8I8BjCGDtSj5Cmc/u8M3ujUAnA9NiztS6fo1uzSN7U8z3kEFMF a9R0Pcww+l/l6Pgb1NyXWMCeKzOs+Hh9Asczgl9MtRbbeau4Q81/+EWz79Uxa47WbMNx F7wd0SEzUR56anoRDhKpQ0PTfg0a6JRCWmTRvuD3ufuKx5nNgQ3wUmIGPNXO6/1m5eFh bpYA== X-Forwarded-Encrypted: i=1; AJvYcCXPiL8D/jsajiPsRDCGGxoD8JyheAca2213YWRCcD76SeQI9OD1tGPcv63KHtU7/clPCl1LztLF9zFlJ3U=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8krdXHTC4H4IFMQ5fV2qlMnGg6r4Grp0E5BRciyAstUxCX21K s6t/Pk4U0RmBhVt05tZ0ZzGimn50r0iu7Iy5yMAq0nsq4zInPpWok02L X-Gm-Gg: ATEYQzzVr/jfJrEUAAAjl0tqtrHr2v0VL2/OQls6giTrZpV5ELUPcST1/EQjhqL8fd/ imhnF4w4ypl24TczhZuRglWgXRnpIRI5CQPhSmc7c/Fv1ly2omO6h6ZrSRPHijfiyBLYmdKf2ir bm6Uyoo2ul+sxOdu7JtFLZ6iGvPE8/JC/sGsOp+yA5wg3dyTawp0Ua6IY+jqzAmk8AT0JbzHex9 eKXV+txOrn8pzbKIyLgvpgWijutfmPE3OX2gA6pvfo9ZiGKC1QXvHMGKXVxz80e1edMvxZX2J/c b2prC9OCGGLg+D88qiLbUe8GMTEmYY8G6gRF2vRSyLIVW4IOfTC0ZMdXG9BIYgMgPq6z/UtABjr vd3UlcF01Kv+UJkMNig5HGyqHGeNC9ZQhvwIiRopSJPKxMtV77FRF2+YK2q3WOKF5lN4M2h4j77 B893Vn6P7Q4qGbf0Haznr/GdE0I02gKo73/Z/ur0w3oNHBWBdJ3/wMHew= X-Received: by 2002:a05:600c:a46:b0:485:358b:e80c with SMTP id 5b1f17b1804b1-4855649971bmr180990195e9.0.1773587219183; Sun, 15 Mar 2026 08:06:59 -0700 (PDT) Received: from OaroraEtimis.tail60902c.ts.net ([2408:8956:4c20:952e:71d2:7185:4299:35a7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe20c0b4sm36924829f8f.25.2026.03.15.08.06.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 08:06:58 -0700 (PDT) From: OaroraEtimis X-Google-Original-From: OaroraEtimis To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, OaroraEtimis Subject: [PATCH] staging: sm750fb: Replace busy-wait loop with udelay() Date: Sun, 15 Mar 2026 23:05:32 +0800 Message-ID: <20260315150532.87280-1-OaroraEtimis@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The empty for-loop in sw_i2c_wait() triggers a -Wunused-but-set-variable warning and can be optimized away by modern compilers. Fix this by replacing the unreliable loop with a standard udelay(2). This also cleans up the unused 'tmp' variable and outdated comments. Include to resolve the implicit function declaration. Signed-off-by: OaroraEtimis --- drivers/staging/sm750fb/ddk750_swi2c.c | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750= fb/ddk750_swi2c.c index 0ef8d4ff2ef9..d0aeb917be92 100644 --- a/drivers/staging/sm750fb/ddk750_swi2c.c +++ b/drivers/staging/sm750fb/ddk750_swi2c.c @@ -11,6 +11,7 @@ #include "ddk750_reg.h" #include "ddk750_swi2c.h" #include "ddk750_power.h" +#include =20 /* * I2C Software Master Driver: @@ -80,24 +81,7 @@ static unsigned long sw_i2c_data_gpio_data_dir_reg =3D G= PIO_DATA_DIRECTION; */ static void sw_i2c_wait(void) { - /* find a bug: - * peekIO method works well before suspend/resume - * but after suspend, peekIO(0x3ce,0x61) & 0x10 - * always be non-zero,which makes the while loop - * never finish. - * use non-ultimate for loop below is safe - */ - - /* Change wait algorithm to use PCI bus clock, - * it's more reliable than counter loop .. - * write 0x61 to 0x3ce and read from 0x3cf - */ - int i, tmp; - - for (i =3D 0; i < 600; i++) { - tmp =3D i; - tmp +=3D i; - } + udelay(2); } =20 /* --=20 2.47.3