From nobody Tue Apr 7 08:03:00 2026 Received: from mail-qv1-f97.google.com (mail-qv1-f97.google.com [209.85.219.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03F1F366825 for ; Sun, 15 Mar 2026 14:18:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773584314; cv=none; b=qZz8JGx95gA/EX2S6zWxp0dTB/y2NN9cPRW4v62xYXCz3VKxfq7+aVx395QqrMk2CRzGj7PRRY9YPAYsWu8ig38Ov0ViilKGpl/ymmcmkltVdqg92h84E5fO3E8OyPrYayi5bngBBpr9feEl/LIvV/uDqar22uzVJFPmrk/hBaE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773584314; c=relaxed/simple; bh=uNBl9Psxva5SJPexCKlx/63Rr8yoHyHROPl3twU89Vw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FTh0p/LRj/z+oFSy0Ppn7REXKRbvRutV0vKRM6dwOZPjO6fxxQa6PcXkRp8SKhMGMzS1EG0xuhnnhnjC+fCyqAIRt54rlS4MF6t3J/Ztp7niGJsJnPiT3kVJKfOQKrnjhtPVHhrMl8s9IB77pFf0SAVeP3N951nzu3nF3pOKCuI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=P0Pb/6eQ; arc=none smtp.client-ip=209.85.219.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="P0Pb/6eQ" Received: by mail-qv1-f97.google.com with SMTP id 6a1803df08f44-89c4feaaeb4so2759656d6.2 for ; Sun, 15 Mar 2026 07:18:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773584312; x=1774189112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kebxp6wh4nYYGznvwFFSyNwKbOSUnFEmSaJutA9Bji8=; b=haLc2OXYN0a8aLkiVTRXXz6yZIwA3xX2V5VKG2DjiMKSjBPT2UwmQ7c5F8R3RWbL10 WQKJDYPSO98Qlq72yDshSj3CiM/5hctugx21xQUm7rdgXQh17nGQrdIpCfGl+5sABFsq 4avpbBmqLZ7/c88EKfejNJVVMIF+DX4w082CoJa1/7/C1V0ooVBLbcYimzYNZnu+3dVY JAEHZjp3lkmPm3SkNBzwsmdQ1gAEUBizBbNou1Cts/w5FBeRqHDA3khSWShmWYk7R/fz QwH0Y2ggCUz2ipj5EiJ3irdrhcVnIhXoc9pKWunu4uEl/WCg2NDN7Pp65lyQ6q+Oxvn3 gxOQ== X-Forwarded-Encrypted: i=1; AJvYcCXqnqbVzNBlWDsy1EMct1aoinzagfvKvKMPn4kjFAxPWTYe2Qz3HEt+p3erGpduKFdmbc7W5Nn2ykdv1pw=@vger.kernel.org X-Gm-Message-State: AOJu0YyTYyyEWb+ln8W0R5lSecC1Dd7cdvVWHuwlqiH8vJT42zKE+3zT ns9Evgn1lVwidaEHM3iaAiQkKxlxlcC9OF1DPD5Xs0GrUJcyaw6mI72A01CsC200Goh3yN+gvY1 6AlbMHoagSUqjhBxb409hvA96uPRX3zvc1gyT3641zUuGaW1gTD38GRY1zhwoW7PVLA1U1E5IYt QJRdMrFRyzAuxrCJLoWv2Zl5S77XpwBkWZ+PO5rPtr7FRFU5mHYry+QQKMA8S2ushjUqxk46sl+ gykjAqUhuPWkIMOQA== X-Gm-Gg: ATEYQzxqGcuPOpn03c26MgYtwqPqSfQzmUjsgCDUSs/jnJ79v2XTPPihBX5D6ySHvOb itVIR8SkY2ubRMTFD8GpGdb1DLS3b23PlKBd3pSFoNsapwXBgRa3s3ht/jBDJnV6DIa4cO3gR4u aWXmXVXpqDWhs5MQALnszg1Qjv0f4nKr6sRsQvpXvPN41FUrUjS421WbMMXlIA5puWv6xyFczRK kAMfJq+mKpie3/lV4zJpLFCnxkUWSQg6hB85HEAIIauNNriSDmjQETBvGHgr+Kdj7oXAt98KiF4 +JoGNssN0fyUiSQaYIsk/NixUoy2aB0pg9w3gBf64Ino2XfHYYAg0/99DOnwDWPydBWmqNxDQIF jkQvNQW8ycH16pOESjRRV2AhGf3sx2lgSDyAHGl5u98LvAaFjH6vHoVJj681tnadEnlNFVmm5PI 1p1i9rNU67ipB7hpMa+UfOYvUx359QoiFDwSU3TOlRVcjDLPf5S5WO4Bc= X-Received: by 2002:a05:6214:f01:b0:89a:1031:383d with SMTP id 6a1803df08f44-89a81ea691fmr148001876d6.31.1773584311796; Sun, 15 Mar 2026 07:18:31 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-63.dlp.protect.broadcom.com. [144.49.247.63]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-89a65d04b76sm13706216d6.14.2026.03.15.07.18.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Mar 2026 07:18:31 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2aeaabedbc3so292922665ad.3 for ; Sun, 15 Mar 2026 07:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773584310; x=1774189110; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Kebxp6wh4nYYGznvwFFSyNwKbOSUnFEmSaJutA9Bji8=; b=P0Pb/6eQLoedK1EYR2rwEKk1gA4vmNlc/9rOM1H8VkVTNisSuYzjaf4eOkJeAnd8rC YtgbPj0abm0xdcVU2WVXrRGJ3zeXRDfhExffmjKt3ZCUcp+yMk/7h1pGxoq2xhke9sHR B1yJmWOLSonzR3Q3LIx459C9FOV/1wGMdjLQk= X-Forwarded-Encrypted: i=1; AJvYcCVdncBt7Apikxf9P1JyFJ0r3x2ZQ/e8JouzMCB8s9kmXHsgmjIi80Qg9dhL0UG2tL8GzFt01/gJ0JeEZIM=@vger.kernel.org X-Received: by 2002:a17:902:d504:b0:2ae:bcf8:c338 with SMTP id d9443c01a7336-2aeca9db5dbmr99253575ad.21.1773584310574; Sun, 15 Mar 2026 07:18:30 -0700 (PDT) X-Received: by 2002:a17:902:d504:b0:2ae:bcf8:c338 with SMTP id d9443c01a7336-2aeca9db5dbmr99253445ad.21.1773584310210; Sun, 15 Mar 2026 07:18:30 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece56c393sm76185395ad.17.2026.03.15.07.18.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 07:18:29 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, ajit.khaparde@broadcom.com, Bhargava Marreddy , Vikas Gupta Subject: [PATCH net-next v7 07/10] bng_en: periodically fetch and accumulate hardware statistics Date: Sun, 15 Mar 2026 19:46:02 +0530 Message-ID: <20260315141605.410878-8-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260315141605.410878-1-vikas.gupta@broadcom.com> References: <20260315141605.410878-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Bhargava Marreddy Use the timer to schedule periodic stats collection via the workqueue when the link is up. Fetch fresh counters from hardware via DMA and accumulate them into 64-bit software shadows, handling wrap-around for counters narrower than 64 bits. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 90 +++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + 2 files changed, 91 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 9f62b5f19a2e..93f0149bd775 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -313,9 +313,93 @@ static void bnge_timer(struct timer_list *t) } } =20 + if (BNGE_LINK_IS_UP(bd) && bn->stats_coal_ticks) + bnge_queue_sp_work(bn, BNGE_PERIODIC_STATS_SP_EVENT); + mod_timer(&bn->timer, jiffies + bn->current_interval); } =20 +static void bnge_add_one_ctr(u64 hw, u64 *sw, u64 mask) +{ + u64 sw_tmp, sw_val; + + hw &=3D mask; + sw_val =3D READ_ONCE(*sw); + sw_tmp =3D (sw_val & ~mask) | hw; + if (hw < (sw_val & mask)) + sw_tmp +=3D mask + 1; + WRITE_ONCE(*sw, sw_tmp); +} + +static void __bnge_accumulate_stats(__le64 *hw_stats, u64 *sw_stats, u64 *= masks, + int count) +{ + int i; + + for (i =3D 0; i < count; i++) { + u64 hw =3D le64_to_cpu(READ_ONCE(hw_stats[i])); + + if (masks[i] =3D=3D -1ULL) + sw_stats[i] =3D hw; + else + bnge_add_one_ctr(hw, &sw_stats[i], masks[i]); + } +} + +static void bnge_accumulate_stats(struct bnge_stats_mem *stats) +{ + if (!stats->hw_stats) + return; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + stats->hw_masks, stats->len / 8); +} + +static void bnge_accumulate_all_stats(struct bnge_dev *bd) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + struct bnge_stats_mem *ring0_stats =3D NULL; + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + struct bnge_stats_mem *stats; + + nqr =3D &bnapi->nq_ring; + stats =3D &nqr->stats; + + if (!ring0_stats) + ring0_stats =3D &bn->bnapi[0]->nq_ring.stats; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + ring0_stats->hw_masks, + ring0_stats->len / 8); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + struct bnge_stats_mem *stats =3D &bn->port_stats; + __le64 *hw_stats =3D stats->hw_stats; + u64 *sw_stats =3D stats->sw_stats; + u64 *masks =3D stats->hw_masks; + u16 cnt; + + cnt =3D sizeof(struct rx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + + hw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + sw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + masks +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + cnt =3D sizeof(struct tx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS_EXT) { + bnge_accumulate_stats(&bn->rx_port_stats_ext); + bnge_accumulate_stats(&bn->tx_port_stats_ext); + } +} + static void bnge_sp_task(struct work_struct *work) { struct bnge_net *bn =3D container_of(work, struct bnge_net, sp_task); @@ -327,6 +411,12 @@ static void bnge_sp_task(struct work_struct *work) return; } =20 + if (test_and_clear_bit(BNGE_PERIODIC_STATS_SP_EVENT, &bn->sp_event)) { + bnge_hwrm_port_qstats(bd, 0); + bnge_hwrm_port_qstats_ext(bd, 0); + bnge_accumulate_all_stats(bd); + } + if (test_and_clear_bit(BNGE_UPDATE_PHY_SP_EVENT, &bn->sp_event)) { int rc; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 74b08d492c53..548c5a77e76a 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -276,6 +276,7 @@ enum bnge_sp_event { BNGE_LINK_SPEED_CHNG_SP_EVENT, BNGE_LINK_CFG_CHANGE_SP_EVENT, BNGE_UPDATE_PHY_SP_EVENT, + BNGE_PERIODIC_STATS_SP_EVENT, }; =20 struct bnge_net { --=20 2.47.1