From nobody Tue Apr 7 07:50:44 2026 Received: from mail-pg1-f226.google.com (mail-pg1-f226.google.com [209.85.215.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AFBA3624B5 for ; Sun, 15 Mar 2026 14:18:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.226 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773584286; cv=none; b=mmqS7jkWWGeLI5Cg4/5Z4/qH7uQs6JmKlKBZLIBDHpiHQyFRT4KWfX+BM543gKfSJoRr5bdSlzfD2Jn8+kpO6rRaMkAZomXtnSbRW08jUHCl6wCkKs4Mcn2nFzyeroxMoM1z2R/APWjeUxW3g002QvEFJgwJMMasUKXnPcgzxz8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773584286; c=relaxed/simple; bh=GHj4gnVfqLy1HeDDSWCa+CadU5S47idNlQd8tGCXirA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eORlx4v3J/0OGpA2Ri11L8aUOvEfP/l7qZrdgSCDtYIp+tMWgNbrN0NGesjy998ax6fw6DmoxBuaDHsW+EWrDh5opkPdQLFrrtD00NQbLIbzoe1k5fByNepyuX8j1BVDgJSerVjI4thzpYc+27ni16LQ9gjzqrXlrleEL/KVMnc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Xj4IYUpy; arc=none smtp.client-ip=209.85.215.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Xj4IYUpy" Received: by mail-pg1-f226.google.com with SMTP id 41be03b00d2f7-c6dd5b01e14so1385405a12.0 for ; Sun, 15 Mar 2026 07:18:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773584284; x=1774189084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LnswXBu4PbkASqLN0BN/EfUVHnS5f3Y0TgpC6FNdc64=; b=BQDtap7vNk8SITMBt5SgMVmwQgdN2idXE7XD2ED/ZU64xs363shzgcwWFq2pAel3xl KyCebdxCXYStMYbPT0vts8h24f2bcIT3mzhI7dXj0a+GeV7Avmgo/RwNx+QxEYoDkDW+ 6U63z/50Hj6b9OEjURvgKYVyPBqkrbeLuD1R7XU+Iq6Qqd1MzxUbDfh+b4MaBr+alMFu gK6pEhSZMt43gIljBHLMcKAFFpJE+xY64Vok0kujZM/oB5ucrKgIoVd4F264NtzKUz7m +LXQF0bkC3/8YNJRg0w8Sazhn2L2P0MFofBY/jgSC6ZdHMP5TSVh2qYTG5mfRGx5PjqP HrOA== X-Forwarded-Encrypted: i=1; AJvYcCXFemiI3LA8Gne5bVPLrJslQKe63AHvcm5NclK6KNdNDbjlGpx+LgG01H4JBU8op6HNhXN9s6NJ5x+t6aY=@vger.kernel.org X-Gm-Message-State: AOJu0Yye1la0VY4obAZgUwBLD3LGgxDsmiHnk5kRDQ1SJnR8yaVKayUE dt0h0XnMIIUSG+azFDvDMPamuOlGE3XncrFc1F1BYHAn9Kw+LKEvbUS5LY+kFwlLYl4xmkNmr5x xczePOkmiR3M//rYIqeZAFcoGlWDvBUkWPLLUYQ00pg/4GDiohIK70khzo3eMS76lKkdH066MN8 0tqykhbMdBfwLtQgec6c5oc81YgTDiSGIgmYiT70wUAMad7kObJ/DBYyXUs2P6cQu1asrFBPEjy fWsPntsZkaf0H0uHQ== X-Gm-Gg: ATEYQzwXtg/js5/Kl+vZTVs1vNW08uBrW8/HMkr7HEHu7adn+MqSYcnYv7hAIK5Xscg IJYYv2x3vC69RZqCJrSsZsdRKycqFHGIyoRJTVPCrYCwZKsLtvJ0tBEzR09vSOhFvcMdECh7gy9 B5RMThmcn15lHOptOwOq60YE7dSBcu9gmYF9VhIAxen5JRqfw4zqa/zl3ftbaEybWje8IABpBYS mqvcr62prAFcNX0V6z/zRoKviujq/+dRujjz0RyThLKvof3+tDSocx3txd8uLp2qDy5uywLLT8Q P+cs9oe+CqARdEijU+vy0MI6Yyz5MslPF+Vec7TFRpbBpB+wWhpSEZd4xqV1MRaf6MdHRgJ6KaY hIa/anf+YKkXwI/nDvuJ9Pahp2etplwv5CgoJb6VYptzTeP2s3XbTsRMIzXeTKST6xgIil/JVnx WxDsxM8AJ9leoeDo6/sHtXv8sMqWRiWCuoOSJYCqnUKe2lQf6L1RMYxsc= X-Received: by 2002:a17:90b:3d01:b0:340:66f9:381 with SMTP id 98e67ed59e1d1-35a21eb739dmr8735989a91.10.1773584283565; Sun, 15 Mar 2026 07:18:03 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-14.dlp.protect.broadcom.com. [144.49.247.14]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-35a030047d1sm1636677a91.5.2026.03.15.07.18.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Mar 2026 07:18:03 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ae47b3adacso42790215ad.3 for ; Sun, 15 Mar 2026 07:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773584282; x=1774189082; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LnswXBu4PbkASqLN0BN/EfUVHnS5f3Y0TgpC6FNdc64=; b=Xj4IYUpyRAIDgFSVReNWDXUMvDN4Jo//bWEL6CYJzFXYobGwnux8StUs70f/h3IjFy GS7MDnQgExPTmrqilHXiZdIbgcaRh9QXlgbEmrgK0PWuT+Krst5Spa0J5qTI1vd3rSWQ XSrugW++qAst9nhSQYgrHWpcGs7C92l81UjpQ= X-Forwarded-Encrypted: i=1; AJvYcCWPgAYsVoKHVni5UCZCq4hNwGQ5bOJBYtTT8FR+GQaUmFTo/YlDNcOpRX4rdlcb69CFHBeMpyHk/6vscXM=@vger.kernel.org X-Received: by 2002:a17:902:d48b:b0:2ae:4d23:3364 with SMTP id d9443c01a7336-2aecaca2054mr95737905ad.52.1773584281645; Sun, 15 Mar 2026 07:18:01 -0700 (PDT) X-Received: by 2002:a17:902:d48b:b0:2ae:4d23:3364 with SMTP id d9443c01a7336-2aecaca2054mr95737645ad.52.1773584281196; Sun, 15 Mar 2026 07:18:01 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece56c393sm76185395ad.17.2026.03.15.07.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 07:18:00 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, ajit.khaparde@broadcom.com, Bhargava Marreddy , Vikas Gupta Subject: [PATCH net-next v7 01/10] bng_en: add per-PF workqueue, timer, and slow-path task Date: Sun, 15 Mar 2026 19:45:56 +0530 Message-ID: <20260315141605.410878-2-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260315141605.410878-1-vikas.gupta@broadcom.com> References: <20260315141605.410878-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Bhargava Marreddy Add a dedicated single-thread workqueue and a timer for each PF to drive deferred slow-path work such as link event handling and stats collection. The timer is stopped via timer_delete_sync() when interrupts are disabled and restarted on open. The open and close paths now start and drain these resources. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 74 ++++++++++++++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 12 ++- 2 files changed, 84 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index a20dc3ca640c..edbb42efb70b 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -101,6 +101,36 @@ static int bnge_alloc_ring_stats(struct bnge_net *bn) return rc; } =20 +static void bnge_timer(struct timer_list *t) +{ + struct bnge_net *bn =3D timer_container_of(bn, t, timer); + struct bnge_dev *bd =3D bn->bd; + + if (!netif_running(bn->netdev) || + !test_bit(BNGE_STATE_OPEN, &bd->state)) + return; + + /* Periodic work added by later patches */ + + mod_timer(&bn->timer, jiffies + bn->current_interval); +} + +static void bnge_sp_task(struct work_struct *work) +{ + struct bnge_net *bn =3D container_of(work, struct bnge_net, sp_task); + struct bnge_dev *bd =3D bn->bd; + + netdev_lock(bn->netdev); + if (!test_bit(BNGE_STATE_OPEN, &bd->state)) { + netdev_unlock(bn->netdev); + return; + } + + /* Event handling work added by later patches */ + + netdev_unlock(bn->netdev); +} + static void bnge_free_nq_desc_arr(struct bnge_nq_ring_info *nqr) { struct bnge_ring_struct *ring =3D &nqr->ring_struct; @@ -2507,6 +2537,9 @@ static int bnge_open_core(struct bnge_net *bn) bnge_enable_int(bn); =20 bnge_tx_enable(bn); + + mod_timer(&bn->timer, jiffies + bn->current_interval); + return 0; =20 err_free_irq: @@ -2542,6 +2575,8 @@ static void bnge_close_core(struct bnge_net *bn) bnge_tx_disable(bn); =20 clear_bit(BNGE_STATE_OPEN, &bd->state); + + timer_delete_sync(&bn->timer); bnge_shutdown_nic(bn); bnge_disable_napi(bn); bnge_free_all_rings_bufs(bn); @@ -2690,6 +2725,23 @@ static void bnge_init_ring_params(struct bnge_net *b= n) bn->netdev->cfg->hds_thresh =3D max(BNGE_DEFAULT_RX_COPYBREAK, rx_size); } =20 +static struct workqueue_struct * +bnge_create_workqueue_thread(struct bnge_dev *bd, const char *thread_name) +{ + struct workqueue_struct *wq; + char *wq_name; + + wq_name =3D kasprintf(GFP_KERNEL, "%s-%s", thread_name, + dev_name(bd->dev)); + if (!wq_name) + return NULL; + + wq =3D create_singlethread_workqueue(wq_name); + kfree(wq_name); + + return wq; +} + int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) { struct net_device *netdev; @@ -2774,6 +2826,17 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_i= rqs) if (bd->tso_max_segs) netif_set_tso_max_segs(netdev, bd->tso_max_segs); =20 + INIT_WORK(&bn->sp_task, bnge_sp_task); + timer_setup(&bn->timer, bnge_timer, 0); + bn->current_interval =3D BNGE_TIMER_INTERVAL; + + bn->bnge_pf_wq =3D bnge_create_workqueue_thread(bd, "bnge_pf_wq"); + if (!bn->bnge_pf_wq) { + netdev_err(netdev, "Unable to create workqueue.\n"); + rc =3D -ENOMEM; + goto err_netdev; + } + bn->rx_ring_size =3D BNGE_DEFAULT_RX_RING_SIZE; bn->tx_ring_size =3D BNGE_DEFAULT_TX_RING_SIZE; bn->rx_dir =3D DMA_FROM_DEVICE; @@ -2789,11 +2852,13 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_= irqs) rc =3D register_netdev(netdev); if (rc) { dev_err(bd->dev, "Register netdev failed rc: %d\n", rc); - goto err_netdev; + goto err_free_workq; } =20 return 0; =20 +err_free_workq: + destroy_workqueue(bn->bnge_pf_wq); err_netdev: free_netdev(netdev); return rc; @@ -2802,8 +2867,15 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_i= rqs) void bnge_netdev_free(struct bnge_dev *bd) { struct net_device *netdev =3D bd->netdev; + struct bnge_net *bn; + + bn =3D netdev_priv(netdev); =20 unregister_netdev(netdev); + + cancel_work_sync(&bn->sp_task); + destroy_workqueue(bn->bnge_pf_wq); + free_netdev(netdev); bd->netdev =3D NULL; } diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 70f1a7c24814..d2ccee725454 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -224,6 +224,12 @@ struct bnge_tpa_info { #define BNGE_NQ_HDL_TYPE(hdl) (((hdl) & BNGE_NQ_HDL_TYPE_MASK) >> \ BNGE_NQ_HDL_TYPE_SHIFT) =20 +enum bnge_net_state { + BNGE_STATE_NAPI_DISABLED, +}; + +#define BNGE_TIMER_INTERVAL HZ + struct bnge_net { struct bnge_dev *bd; struct net_device *netdev; @@ -281,13 +287,17 @@ struct bnge_net { u32 stats_coal_ticks; =20 unsigned long state; -#define BNGE_STATE_NAPI_DISABLED 0 =20 u32 msg_enable; u16 max_tpa; __be16 vxlan_port; __be16 nge_port; __be16 vxlan_gpe_port; + + unsigned int current_interval; + struct timer_list timer; + struct workqueue_struct *bnge_pf_wq; + struct work_struct sp_task; }; =20 #define BNGE_DEFAULT_RX_RING_SIZE 511 --=20 2.47.1