From nobody Tue Apr 7 08:03:31 2026 Received: from mail-vs1-f97.google.com (mail-vs1-f97.google.com [209.85.217.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94656367F28 for ; Sun, 15 Mar 2026 14:18:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773584325; cv=none; b=DXwXdP4LXMI4DJCr0JRvZhYzhS2AeMUqQUCyGvvmTg2+oGLqZeseNqFzTC+R3Y3Y16vI53ft+iDz07cxWfblHYhP9FjGV+GcUq3ZJfd96NHRtpuhyb9Vp0SL1LsTS0r2aP8r3Dh2lFqmXHjfoGH4Qllab9HuorVMc1PUExLdDeY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773584325; c=relaxed/simple; bh=6pVUObxKJcpqyg60HNgCKSEoCpNjAVM+AGL3wGaoVXg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=izK1YG7wMTS6wYaUc7ZIgAHlp8k3FbyHDpPdT50J+KxtMmKSZtJO7cOdfqUWahHLarBo5q/XfP+QezloNnaaSN6yeLc4kQHDyZJzqsYCVZDdcDEmDbyuAnRO8uM2hMSdeqIKzDsVa62Mfr+m1duYeP0x3jiNUjuQ8yrGlLsZptM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Gor0XqMk; arc=none smtp.client-ip=209.85.217.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Gor0XqMk" Received: by mail-vs1-f97.google.com with SMTP id ada2fe7eead31-5ffc8987050so2534197137.0 for ; Sun, 15 Mar 2026 07:18:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773584321; x=1774189121; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K7FaWhADbrt2uVZb4x2KUlFR/3vOeNIrrqP+sLNFjXo=; b=YIvA7y/ZQSnYI2kZkAygdXhOhmLvH4dP5fY0P/yStcaayWQkS/K1JRC4BFBedKjpc4 K8+beLJAiiPmw5Zjgb9AEa2GNZ9OX7PS5XgvXdBvQmx+GypWF+y0IoQr0Y+UIOhkXE/r 1lp3Arp2/Dm3YofG9aGOBMo9PPAltFZ98fKTCcOzLYH8lHqZ0dLmbQ3xlSztKvJZFZOd /dA5uSbWzjfW0e6jjsxm/P/ezzTgGCOktyXAGcAHPQ1AtsTTh696O7JWkIPRCxcKkKVx 6wRxI/nz5XAQZGJTdcH6bulcZssABk5zslHETe3lR8seXzC+8dXlgQvsMFQH8yhK7vNm Nq8w== X-Forwarded-Encrypted: i=1; AJvYcCUrfZ8DSqP+5jU/nqoZvbAM+AUId1JZ1La4xW0R0UMxFP5sOjcO845QVifoT6T6yTNK3hmuHxnFe3vouNk=@vger.kernel.org X-Gm-Message-State: AOJu0YzmRZcnnge9kgBAuZ3s/aVgmo/fWogOcmKYpwvHENaIeVluh4Df PTlR+x3oakpPskovYAeQt2ePdsfzh+Bp5ql6f04QsxppDeYhgj+Alnx/PxYHavncr81699pnnl7 kCRa8Ufcze7L6Zc0wlhn+zBsOZQ2kyif5fTcr3WWG1p2boLNMEd+XQ5c2R4bHaNVsgWZGRRRD1l 7XSf+MEP7cQVXBFN0VtkAriuru3semWJhoMMZe1Wqx1n0DoL15S2CjKJ+rP7RsF3AfKx9erpTGw u+is0PzegFenpRRqA== X-Gm-Gg: ATEYQzxqepteEcGvddbx7QkauP3m6q5a9IGHmSHMJmPO9G34JX4wrfvYLcBUc3GNMVq Qkq/p0qJYtzk6fhUuTA2lrpfMexJUbcoQnxd/VM8iDjw3YvjzUIoEOK9kyGD9yEh8DU42yMWZrH rPQ7wbGa8UWaWG0/N0zYey98HsMM7R1DCzIK27eaylnbwONc0dZPXx+bZxtEDKB+mJSuupFuirC SqadDU9KtSvSzxntnmueEIPOdmIIi8RpErGj6tm+pBRAMYptyxwq1aOhj8Hcp8vmXol14IRjSUr 8waCbbDov9SAwtToUuoQos3aEr/GSSnT2esHVCxl2xwhUotawIc/bmItk7hwnH2xd3y44LAv/UT Nr4EySZJntlUH4NZuUlMCyze+Ll6wpj+f3cK3nE7pwb5hV6X/ZXZUCj+Nyl/HviJUP5jKV6cxQy sWOH5T72imPI+2d/lSFcIXijvlGPvkOKXazclmxX0KoMuXymOcdSL0rI4= X-Received: by 2002:a05:6102:3a06:b0:5ef:ac78:3c77 with SMTP id ada2fe7eead31-6020e23f7c7mr4389299137.18.1773584321266; Sun, 15 Mar 2026 07:18:41 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-14.dlp.protect.broadcom.com. [144.49.247.14]) by smtp-relay.gmail.com with ESMTPS id ada2fe7eead31-601deaedc1csm1130380137.5.2026.03.15.07.18.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Mar 2026 07:18:41 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ae59e057f1so50144615ad.1 for ; Sun, 15 Mar 2026 07:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773584320; x=1774189120; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K7FaWhADbrt2uVZb4x2KUlFR/3vOeNIrrqP+sLNFjXo=; b=Gor0XqMk8U4UmqZnJKc2jv9LZea4+CaP335dsxc1UYdAeSSvxof5nBIAzyZj29BUTC Z4GtI9H4cEqdbarpVZRHo64Yt7aL30W1l2Eyot6w/NbG6OLLxmzaKMSUsRI6DEAGI/wA sYK7/52aI/y4xcYEyn7c8DzaKB0WzTvcXBZeI= X-Forwarded-Encrypted: i=1; AJvYcCUGTDFENcrfQxe/xAjkKtnWDDRRWpLUK3hS4ovYL7qq2uJCm2F0kGq7rXxFscpeJdktT49u5FHzhkaDy4M=@vger.kernel.org X-Received: by 2002:a17:902:e841:b0:2ae:a45b:42f7 with SMTP id d9443c01a7336-2aecaaf604amr102709985ad.36.1773584320148; Sun, 15 Mar 2026 07:18:40 -0700 (PDT) X-Received: by 2002:a17:902:e841:b0:2ae:a45b:42f7 with SMTP id d9443c01a7336-2aecaaf604amr102709795ad.36.1773584319727; Sun, 15 Mar 2026 07:18:39 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece56c393sm76185395ad.17.2026.03.15.07.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 07:18:39 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, ajit.khaparde@broadcom.com, Bhargava Marreddy , Vikas Gupta Subject: [PATCH net-next v7 09/10] bng_en: implement netdev_stat_ops Date: Sun, 15 Mar 2026 19:46:04 +0530 Message-ID: <20260315141605.410878-10-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260315141605.410878-1-vikas.gupta@broadcom.com> References: <20260315141605.410878-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Bhargava Marreddy Implement netdev_stat_ops to provide standardized per-queue statistics via the Netlink API. Below is the description of the hardware drop counters: rx-hw-drop-overruns: Packets dropped by HW due to resource limitations (e.g., no BDs available in the host ring). rx-hw-drops: Total packets dropped by HW (sum of overruns and error drops). tx-hw-drop-errors: Packets dropped by HW because they were invalid or malformed. tx-hw-drops: Total packets dropped by HW (sum of resource limitations and error drops). The implementation was verified using the ynl tool: ./tools/net/ynl/pyynl/cli.py --spec \ Documentation/netlink/specs/netdev.yaml --dump qstats-get --json \ '{"ifindex":14, "scope":"queue"}' [{'ifindex': 14, 'queue-id': 0, 'queue-type': 'rx', 'rx-bytes': 758, 'rx-hw-drop-overruns': 0, 'rx-hw-drops': 0, 'rx-packets': 11}, {'ifindex': 14, 'queue-id': 1, 'queue-type': 'rx', 'rx-bytes': 0, 'rx-hw-drop-overruns': 0, 'rx-hw-drops': 0, 'rx-packets': 0}, {'ifindex': 14, 'queue-id': 0, 'queue-type': 'tx', 'tx-bytes': 0, 'tx-hw-drop-errors': 0, 'tx-hw-drops': 0, 'tx-packets': 0}, {'ifindex': 14, 'queue-id': 1, 'queue-type': 'tx', 'tx-bytes': 0, 'tx-hw-drop-errors': 0, 'tx-hw-drops': 0, 'tx-packets': 0}, {'ifindex': 14, 'queue-id': 2, 'queue-type': 'tx', 'tx-bytes': 810, 'tx-hw-drop-errors': 0, 'tx-hw-drops': 0, 'tx-packets': 10},] Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 76 +++++++++++++++++++ 1 file changed, 76 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 2513b0907693..fa732b99358e 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -3031,6 +3031,81 @@ static int bnge_close(struct net_device *dev) return 0; } =20 +static void bnge_get_queue_stats_rx(struct net_device *dev, int i, + struct netdev_queue_stats_rx *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_nq_ring_info *nqr; + u64 *sw; + + if (!bn->bnapi) + return; + + nqr =3D &bn->bnapi[i]->nq_ring; + sw =3D nqr->stats.sw_stats; + + stats->packets =3D 0; + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + stats->bytes =3D 0; + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + stats->hw_drop_overruns =3D BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + stats->hw_drops =3D BNGE_GET_RING_STATS64(sw, rx_error_pkts) + + stats->hw_drop_overruns; +} + +static void bnge_get_queue_stats_tx(struct net_device *dev, int i, + struct netdev_queue_stats_tx *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_napi *bnapi; + u64 *sw; + + if (!bn->tx_ring) + return; + + bnapi =3D bn->tx_ring[bn->tx_ring_map[i]].bnapi; + sw =3D bnapi->nq_ring.stats.sw_stats; + + stats->packets =3D 0; + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + stats->bytes =3D 0; + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + + stats->hw_drop_errors =3D BNGE_GET_RING_STATS64(sw, tx_error_pkts); + stats->hw_drops =3D BNGE_GET_RING_STATS64(sw, tx_discard_pkts) + + stats->hw_drop_errors; +} + +static void bnge_get_base_stats(struct net_device *dev, + struct netdev_queue_stats_rx *rx, + struct netdev_queue_stats_tx *tx) +{ + struct bnge_net *bn =3D netdev_priv(dev); + + rx->packets =3D bn->net_stats_prev.rx_packets; + rx->bytes =3D bn->net_stats_prev.rx_bytes; + + tx->packets =3D bn->net_stats_prev.tx_packets; + tx->bytes =3D bn->net_stats_prev.tx_bytes; +} + +static const struct netdev_stat_ops bnge_stat_ops =3D { + .get_queue_stats_rx =3D bnge_get_queue_stats_rx, + .get_queue_stats_tx =3D bnge_get_queue_stats_tx, + .get_base_stats =3D bnge_get_base_stats, +}; + static const struct net_device_ops bnge_netdev_ops =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, @@ -3194,6 +3269,7 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_ir= qs) bd->netdev =3D netdev; =20 netdev->netdev_ops =3D &bnge_netdev_ops; + netdev->stat_ops =3D &bnge_stat_ops; =20 bnge_set_ethtool_ops(netdev); =20 --=20 2.47.1