From nobody Tue Apr 7 07:49:53 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC2A93612D2 for ; Sun, 15 Mar 2026 12:55:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773579320; cv=none; b=Kx3LMq6ptDfmwdp7ygXCd0Z5D7jI/LC+H2J4GdZmC+ddBHdZI414bNI6G8trO2tYGoB2Gafyqmn/jDyd+9QlRK1HQ2UpnkfTYFJsvSaiGIh8gpQWuh8CUuMPXK9hH7/36CiuWg8PLtcZx6QHzR6+DO/Jp/upidLTh3dG6dVUFoI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773579320; c=relaxed/simple; bh=3WIdw0h3pg9FZq0IKUhtfsTSwjcxqvQJIay/X4ecUas=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=U5MqGGyosoWUvzoZO4frr9hdXAE4ER5JdcGCNo5iAN+0Xh6ctJr1nWde1tiqB2TpFQ9AXlc27va3yM/0hj9UORlwBX7rhnXAHTnNjKpD7tJ8DKNjA2EHJhlvrcqes+jpyY85i24uaT+S1fyJELmNYnWtzCe+efg99Gpst55/Hak= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=af7BsNsq; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="af7BsNsq" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2adbfab4501so16160995ad.2 for ; Sun, 15 Mar 2026 05:55:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773579318; x=1774184118; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nuALGFM1dkmjL3yoaur9WlxMxVFFTalIvqYZT+766K4=; b=af7BsNsqL9L7gw2CTXNZp0tnCP78MYsC7C4HRYo3cbxJz88seCRteYhNGK0q2HJzWq 92lzo/tbJaMeTvTHZwvrsKCiDyPsfXUBWjbN4RWv0DVtu8amzGjEWeUs/MSOgNSlkxKi loLUJ8h8TV59mGsGwvd/sfHdf8volgQcN8BIYkuoU7+HGZP1FXFIzCcupp+H/eQZezkh MvkRlcbT+zLhIJ5bmDxkrTiLonKUKGSb+wGyeXwgp+yDwPz/orGo7Nh341G6wQr7ESaI pcag1a2hE2SYu8t7V0o+/NN8XESmnJxZ7cxLCsGjQkD3LL6UMBta+lFtnBltsceOi2BC yC2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773579318; x=1774184118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nuALGFM1dkmjL3yoaur9WlxMxVFFTalIvqYZT+766K4=; b=kdJHOLeAihRCTjyoZpLadenB5hJqWYq/4i30oud37BTSmzsmYEH2oJrmntylHDvbyM sF9uTN9RkyjrOXxlGAHYxKCozyNJBE+jQ3xcuIStpk6e9ELHZU7OcVFRDfj6QIqhPpcZ MmT6qaiAOGKV5cNDmHID0/XbsorlQzfAUmq9ODPyzia2uCaudBl7+cUBSWJMVf3x+WPI rWbwrG9AVQy3aBZ0BsddUq0Bsyp7Wk2vGB90EEQ90/7V3hJ+qeQAhW1wMelTIooghXPZ QSYYvLEB/n7a2MznldFOmvoSnm4cg/G3gQqynksjkbv4ngN9+vuytdva3JfxXJaSKubt fIPA== X-Forwarded-Encrypted: i=1; AJvYcCVk2E3GvFiUrk79IkQqe1RaB0irh8K4mNpw8/IhdRH0GGtqpGjS1j+2+8S2zDg48sT5Pfyteh4wRI4R200=@vger.kernel.org X-Gm-Message-State: AOJu0Yykx9wJpvN6qtNA7ss2ryPEdbuWSZyavNVYN2NuiIyNHGZEu67H DODHyZNSY298ANt0BwG2jaKUVwYTyfP747aFBxy5XWv8OpQKTi51XUDH X-Gm-Gg: ATEYQzzNNTdohNpKHAflN18RypLDWKcN3qzjBiUU8r7AdnFdU4x/yC2npjkUrmBOgmw ZWhpa2cIWh3JhHvJuKdcBj+fIQJ7mcJ2eme+qgx2VghWCFX4czoIXxC0a7bvosXVu8/a337DVQk u8FMq5FO4R8DqJBF/dYQens34/a6CbCB1Rru5bisCJ8Ljkgfprd9wKLwN0oNqkdHT2PgSHQPQa/ EVu31caxBKz92vJmkvVgh/0mhS3vqgG4pLAws5pG18aaVGKLs0DNRCPh73NM2gkrDaPWT1D6YMr FZidyJyxYcWP/bvPVd0OqeeDaCitz6aHk1+UGhhmc7cCzzqbK0uefdG9pLJGh2J5R1MTnNvFoDW xdsl1E31PeWNPNnpvDXNr8QEEzI4sJsP/3yBAVLng0hyYCDZrAmSjQF7d62moEwe5cz41C1BcA0 aeUjxsv21eX+cR7vJ1I23AfmaGGGDNLARqQFck5ro4TXKbcB6pwtqIUPglUXk= X-Received: by 2002:a17:902:da8f:b0:2ae:504c:ae8a with SMTP id d9443c01a7336-2aeca936252mr100903295ad.16.1773579318173; Sun, 15 Mar 2026 05:55:18 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece594b4fsm72931565ad.20.2026.03.15.05.55.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 05:55:17 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Cc: kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, sanjayembeddedse@gmail.com Subject: [PATCH v3 1/3] iio: ssp_sensors: ssp_spi: use guard() to release mutexes Date: Sun, 15 Mar 2026 18:25:07 +0530 Message-Id: <20260315125509.857195-2-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260315125509.857195-1-sanjayembedded@gmail.com> References: <20260315125509.857195-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Replace explicit mutex_lock() and mutex_unlock() with the guard() macro for cleaner and safer mutex handling. Signed-off-by: Sanjay Chitroda --- drivers/iio/common/ssp_sensors/ssp_spi.c | 54 ++++++++++-------------- 1 file changed, 22 insertions(+), 32 deletions(-) diff --git a/drivers/iio/common/ssp_sensors/ssp_spi.c b/drivers/iio/common/= ssp_sensors/ssp_spi.c index 6c81c0385fb5..87a38002b218 100644 --- a/drivers/iio/common/ssp_sensors/ssp_spi.c +++ b/drivers/iio/common/ssp_sensors/ssp_spi.c @@ -2,6 +2,7 @@ /* * Copyright (C) 2014, Samsung Electronics Co. Ltd. All Rights Reserved. */ +#include =20 #include "ssp.h" =20 @@ -189,55 +190,49 @@ static int ssp_do_transfer(struct ssp_data *data, str= uct ssp_msg *msg, =20 msg->done =3D done; =20 - mutex_lock(&data->comm_lock); + guard(mutex)(&data->comm_lock); =20 status =3D ssp_check_lines(data, false); - if (status < 0) - goto _error_locked; + if (status < 0) { + data->timeout_cnt++; + return status; + } =20 status =3D spi_write(data->spi, msg->buffer, SSP_HEADER_SIZE); if (status < 0) { gpiod_set_value_cansleep(data->ap_mcu_gpiod, 1); dev_err(SSP_DEV, "%s spi_write fail\n", __func__); - goto _error_locked; + data->timeout_cnt++; + return status; } =20 if (!use_no_irq) { - mutex_lock(&data->pending_lock); - list_add_tail(&msg->list, &data->pending_list); - mutex_unlock(&data->pending_lock); + scoped_guard(mutex, &data->pending_lock) + list_add_tail(&msg->list, &data->pending_list); } =20 status =3D ssp_check_lines(data, true); if (status < 0) { if (!use_no_irq) { - mutex_lock(&data->pending_lock); - list_del(&msg->list); - mutex_unlock(&data->pending_lock); + scoped_guard(mutex, &data->pending_lock) + list_add_tail(&msg->list, &data->pending_list); } - goto _error_locked; + data->timeout_cnt++; + return status; } =20 - mutex_unlock(&data->comm_lock); - if (!use_no_irq && done) if (wait_for_completion_timeout(done, msecs_to_jiffies(timeout)) =3D=3D 0) { - mutex_lock(&data->pending_lock); - list_del(&msg->list); - mutex_unlock(&data->pending_lock); + scoped_guard(mutex, &data->pending_lock) + list_add_tail(&msg->list, &data->pending_list); =20 data->timeout_cnt++; return -ETIMEDOUT; } =20 return 0; - -_error_locked: - mutex_unlock(&data->comm_lock); - data->timeout_cnt++; - return status; } =20 static inline int ssp_spi_sync_command(struct ssp_data *data, @@ -360,7 +355,7 @@ int ssp_irq_msg(struct ssp_data *data) * this is a small list, a few elements - the packets can be * received with no order */ - mutex_lock(&data->pending_lock); + guard(mutex)(&data->pending_lock); list_for_each_entry_safe(iter, n, &data->pending_list, list) { if (iter->options =3D=3D msg_options) { list_del(&iter->list); @@ -376,10 +371,8 @@ int ssp_irq_msg(struct ssp_data *data) * check but let's handle this */ buffer =3D kmalloc(length, GFP_KERNEL | GFP_DMA); - if (!buffer) { - ret =3D -ENOMEM; - goto _unlock; - } + if (!buffer) + return -ENOMEM; =20 /* got dead packet so it is always an error */ ret =3D spi_read(data->spi, buffer, length); @@ -391,7 +384,7 @@ int ssp_irq_msg(struct ssp_data *data) dev_err(SSP_DEV, "No match error %x\n", msg_options); =20 - goto _unlock; + return ret; } =20 if (msg_type =3D=3D SSP_AP2HUB_READ) @@ -409,15 +402,13 @@ int ssp_irq_msg(struct ssp_data *data) msg->length =3D 1; =20 list_add_tail(&msg->list, &data->pending_list); - goto _unlock; + return ret; } } =20 if (msg->done) if (!completion_done(msg->done)) complete(msg->done); -_unlock: - mutex_unlock(&data->pending_lock); break; case SSP_HUB2AP_WRITE: buffer =3D kzalloc(length, GFP_KERNEL | GFP_DMA); @@ -448,7 +439,7 @@ void ssp_clean_pending_list(struct ssp_data *data) { struct ssp_msg *msg, *n; =20 - mutex_lock(&data->pending_lock); + guard(mutex)(&data->pending_lock); list_for_each_entry_safe(msg, n, &data->pending_list, list) { list_del(&msg->list); =20 @@ -456,7 +447,6 @@ void ssp_clean_pending_list(struct ssp_data *data) if (!completion_done(msg->done)) complete(msg->done); } - mutex_unlock(&data->pending_lock); } =20 int ssp_command(struct ssp_data *data, char command, int arg) --=20 2.34.1