From nobody Tue Apr 7 06:23:05 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 335F513C918 for ; Sun, 15 Mar 2026 10:45:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773571529; cv=none; b=LPp0UjFcYc0RJo6ZR4Hw3Em30RZ2dusAZDypvXcvMNBW+VDjk4Sl7DWmJAI5ene4J1NbZhD3Ud12+tLMUUupaO9R23I3InBeusYrf/EnK3YySOyhrinnr66hk6BJYeioQg7l86ji3dTwQiqS35VTBWynVpz7obn1Qk6ApX/vAck= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773571529; c=relaxed/simple; bh=WrjYdAZ1gpPUidP+ex11mExhhOG06gOKsCA4QYX1FA0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=c2rkWZtz1of1/19hrmdk8ySW9Uv/KX2fE+ASWaGejAsGQnjgMuL6LX4kuxlc7cocmLLGrnZ2lIy9PeAH/8BrjdpdsO37dEkOMg3wAmQk/oSOTxM8PbNGvP1NeI/dW22mbjwE3tGYachaabeqxF1rzNZ01esobyT3TQT4YuuPeXQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OOuPHZLx; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OOuPHZLx" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-829a568f3ccso1913600b3a.0 for ; Sun, 15 Mar 2026 03:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773571527; x=1774176327; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FlSTVkt2Hr9uFmMrTVFBqTieBRyNKp6QC6tkoO2VILU=; b=OOuPHZLxtLPcMuPJH8AMczRvkZU28kzoJgkXKbz1jXFFP6LZ/EM1cTOcjRxwSXxBUE fHwfhe6yhzaccLPKbe26YCmgEOH+zDsLujkOPuPNdwwwmW7ArjPPcd8aGMfrOpZuk2uM o+jIFM0iqbEIeuc5XcxNOp8Wesvc7FcMQARvCDUp62k/wb0JB4hxe4cphQJDkoe6jNku BbmUjSFjjYgwP6W0xffCaZ49RKQkb7rIKU/AsmYRAnzHmUKFopknCzoskqzaC+7BjCrs fpX8X3Mh45DgFcxAC2hY8yZm1yHYlrDP44K2Mt5rZO7GQ+77ywn1rkDeJR1EbX3U+P/j nRkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773571527; x=1774176327; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FlSTVkt2Hr9uFmMrTVFBqTieBRyNKp6QC6tkoO2VILU=; b=UHmgCbAMGXns4MpLfB+IhyIrn6CNYubdHhpZWKnxQi5AokydCm7gdRUow+szow3k19 O8vSCHE2Ch5jWAvmoM9hyWjiBm+BYcbPK1goda34mL+tz5yu8zKDjHXG6nVoNgFv/hmh 8f7hGLsWnZtOwKKOVQlit9Byts4a/AqNGTZrU0QePlOnl02cSpLlv8bIWlnsp+zwihde ohWXQIiPwS3dyl6P2qo7/DTF7WoJ4XwXSXMmAGiFNhMwo+iJsGsoOfoccO90uXO7ieec nh/7+J/jKys14XfVT9uUxnRt+aOq29AaZFgy8WuxYXIPGYPt2mHuMVlJpuTqn9LvhPux KIGg== X-Forwarded-Encrypted: i=1; AJvYcCWpAmEucdTp34Svt7r5NiOsg/3NfAI/xcSQ+BEgjrPjIl9k3pZk5O0rWIfwe0vPvMtkNLCtoX7kNBYBZ7E=@vger.kernel.org X-Gm-Message-State: AOJu0Yxeao4a2noDx1wb/N6ZvuHRbjPQ+zMlg9ZlPCRsltipHg4MbusG sxeGhSWi3SKpFy0Mz7WbuwIWVnrH7jcTYjrFveahfjOkS6gZCBVAiY34 X-Gm-Gg: ATEYQzwJpVR9fTsxFkmPtZ00SYJhBS4CUTLZcQVbDynJpWrcVzxGUJktrO7H+L6EiHt Hl64yW7hiqVnmDRsd3AF9jan8qBb2JKj2+fVMvAAbjyKPyD4aOmPWapPdDhwsSfNLV06qxb28SU dniIxQQb15og9czAK9X7tkcBG/LB8GN5cp4Lqi8rA/hpEXBrgyG9UgI+N3/d4ObQmJ11zAalXBb lR2vVz84JDbNONQWXBRpITyrTe0gJxD6wYXoiZp5EtuFGiQbta0KCWmtSjbQeU7SzBXp/h1v4lK TXmTQ2ilpraEGrVt1T1/n/4+pfOzsD7oGH9cqU64GgrtbKhrV88qb6DApkT5Xp7rUBWhFGrMqhC XVeynUwOJyu3nwEbfJhAnwtZXNcTJ26oFrJywXAT+zqUCic2PB9DKf4t7WAaquosWkHrZlbHY37 Tbtm41Urs2x8TVOGOwCb+NtvjUFdo= X-Received: by 2002:a05:6a00:4189:b0:827:4bca:f1a2 with SMTP id d2e1a72fcca58-82a19704166mr7796908b3a.10.1773571527291; Sun, 15 Mar 2026 03:45:27 -0700 (PDT) Received: from ubuntu.. ([152.58.129.240]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a07241bbesm10483700b3a.10.2026.03.15.03.45.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 03:45:26 -0700 (PDT) From: Anas Iqbal To: linux-bluetooth@vger.kernel.org Cc: marcel@holtmann.org, luiz.dentz@gmail.com, pmenzel@molgen.mpg.de, linux-kernel@vger.kernel.org, Anas Iqbal Subject: [PATCH] Bluetooth: hci_ll: Fix firmware leak on error path Date: Sun, 15 Mar 2026 10:45:13 +0000 Message-ID: <20260315104513.1668-1-mohd.abd.6602@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Smatch reports: drivers/bluetooth/hci_ll.c:587 download_firmware() warn: 'fw' from request_firmware() not released on lines: 544. In download_firmware(), if request_firmware() succeeds but the returned firmware content is invalid (no data or zero size), the function returns without releasing the firmware, resulting in a resource leak. Fix this by calling release_firmware() before returning when request_firmware() succeeded but the firmware content is invalid. Fixes: 371805522f87 ("bluetooth: hci_uart: add LL protocol serdev driver su= pport") Reviewed-by: Paul Menzel Signed-off-by: Anas Iqbal --- v2: - Fix grammar ("content is") - Add Fixes tag - Add Reviewed-by tag from Paul Menzel --- drivers/bluetooth/hci_ll.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c index 91acf24f1ef5..91c96ad12342 100644 --- a/drivers/bluetooth/hci_ll.c +++ b/drivers/bluetooth/hci_ll.c @@ -541,6 +541,8 @@ static int download_firmware(struct ll_device *lldev) if (err || !fw->data || !fw->size) { bt_dev_err(lldev->hu.hdev, "request_firmware failed(errno %d) for %s", err, bts_scr_name); + if (!err) + release_firmware(fw); return -EINVAL; } ptr =3D (void *)fw->data; --=20 2.43.0