From nobody Tue Apr 7 09:06:15 2026 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EF1F1A682E for ; Sun, 15 Mar 2026 02:10:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773540611; cv=none; b=YMXhXZalei8pQqmjkgXIzrdbsWtws44EW+ALyUk70mWPdhFV34Bp1IZ2CExEz1ZJI788HomeOp3sNf7lS1EOGekasJUBN6QyTeltF3Clejg0W56uHBUN1HSLrfudjWUnQIB5YhnuJD/9LGb7O5hFXtDQnd/otVzznktYbKMFkTw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773540611; c=relaxed/simple; bh=ORJ4rscuuIawNtI4GPO1EVEu5tcsSDq0QVd96Pbwsqk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P04B6lWnrOjdjlb5poMgggElTZqLnJxB7f6KTa65K5UqZ6d2EdUaes9nn5FlVTbXsbIRCgqLXD4Q2fDub1drSeqZghwSBjZHGD+DH/T1KcE1HhES/TqniMlrKEWbglJqagC0mcqipPGQ9Y/O0KQTyK+D/PLIcMR5K6eOmqnL3ao= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iA8Po+ud; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iA8Po+ud" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-2be06c02f66so1472940eec.1 for ; Sat, 14 Mar 2026 19:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773540609; x=1774145409; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=akRjWY59n5sMvUNDaGckavPhAPsTROKRG/B6t9OT1vw=; b=iA8Po+udX3eA5JsH1Y3U2YkZXtuKRo7HL7kNSbt2HSTpv1c1Siv3DuZL/0WgkkN6LA ZFuVo665/N6UvhGlnzPm3VtAMLI5qcMHczxSFLuBM9iyduWaczjqv9/vSTf4+eZtgcB3 j1zgbgwxPH2gmhuhOahFt1q02hYlzZFvKTMEl8jvFjxRaZZT0+D3Om7ytQXzHsAyT1oh NVzfqjs2sMPrb9SwQFcOKsouAxcwaIpDbdsGTvPr3JIc9TgV3DLDA+7Dbhoptg/0pbgZ 8WBvYcAo6Fc75FCxGO5HuQ+ml5SO1Cj/bDuJosgZotIEWYQ0f+NEWRmArwCh+yhjhcoP PbOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773540609; x=1774145409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=akRjWY59n5sMvUNDaGckavPhAPsTROKRG/B6t9OT1vw=; b=gMwNjXv7DribNGmVy86q+/yLGWcjn7H6ugytU5wxRt+TO3ADfKK22E1blQZhb7Zm9R KKbLY1XFVlu7tpfJnuRhwPN5Zh0sPCNAqlizyZfYgrg+UzDFzDMoy3RQgw+xvkt8ELEr 9H+lCHVmZkCaworSfg8gjRANEgCeC5DCREDJ6w0or6ZHoUuEN02SBv0aIEtRyldnvmEp leSokjHqZvlTsqdjV5rsqk5ByjgyZ60vRZsRLSw1dTiqiBRFKWp9GMZXBtDwGSpgoa3r 9ctyR3k79tTzDIym/AEaziMlFabV3DATGqMfT5f/jdTUL9j4AGUybd72UQ2zjmAhXObg 6EPg== X-Forwarded-Encrypted: i=1; AJvYcCUUW5KZGQ36FJGHwwvoJxrAEPaJrSVaYRSUE0fbxX1wkW6oDSQIrW3hIvY7Gx7AN0VIzFFEgDVAy5toiL4=@vger.kernel.org X-Gm-Message-State: AOJu0YxqpdZHPiOxkJX0bYaHoKIEzZH8PDB6D2hYGH8lnl7QFgaAlkUe KBgnNGKp2hAF/cu40xqAFdcUSUrnNRWV5abVVw6SXzUxqCRy3W+kzX0aFF86zQ== X-Gm-Gg: ATEYQzwudBqm0Jzl2FYxweqYHqzkaqEhqIefFehDIbC/vTN7SZzbD+GB1Wmzos66zPj dDMTEZpvxLieNmOusGy5xQmKB1qCqJ/FKyJ7bIcoMl7ZXreCrRNPfgoTg0ec6Fx3iuuAZJZReov QYMfI3ETGcWJf4H4OdBBhPnw5Tsnm/nK3icSNJiHutfwDfyfDGodG5YKJc2WUzc1Nr3GfauuGxH VThSyPWC5RNnSp8/lsShWvlAWg66eeM5Iu2t2KwAkoDIP/rhpBMZaaPzrhcYji5vlcapkl/S1Rj PSU/Wj4E0hBDVTjgyLUykls8Yd0khGJvmy6gD/OHFdxpIeOiBkLKDpeCV4YBHoXtx14u8MBVWMV VmdifA1YZv24fygPilOY4MdoHwJKnq/fWsPF52F8h1TNp2XRLHu6jA07qzTe4YQl4Nu1bl0d7gx Av7zPhtWin2F4VtyDozhwWdzZo0dJ2TJDsdclpedSI6c924xM= X-Received: by 2002:a05:7301:3f19:b0:2b8:66f3:2502 with SMTP id 5a478bee46e88-2bea5418f4fmr3867429eec.1.1773540609231; Sat, 14 Mar 2026 19:10:09 -0700 (PDT) Received: from mjmachine.localdomain ([131.255.96.240]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2beab526f9asm11012192eec.19.2026.03.14.19.10.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 19:10:08 -0700 (PDT) From: Marcos Andrade To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ethantidmore06@gmail.com, Marcos Andrade Subject: [PATCH v3 1/2] staging: rtl8723bs: Replace network magic numbers with EtherType macros Date: Sat, 14 Mar 2026 23:09:48 -0300 Message-ID: <20260315020949.50149-2-marcosandrade95963@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260315020949.50149-1-marcosandrade95963@gmail.com> References: <20260315020949.50149-1-marcosandrade95963@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace hardcoded magic numbers for network protocols (e.g., 0x0806 for ARP, 0x888e for EAPOL) with their standard EtherType macro equivalents (ETH_P_ARP, ETH_P_PAE) defined in . This change improves code readability and aligns the driver with standard Linux networking definitions. Signed-off-by: Marcos Andrade --- Changes in v3: - Included in a patch series. Changes in v2: - Changed include from "" to <> for linux/if_ether.h. - Sorted includes alphabetically. drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 7b18be891..4062fe0c1 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -5,6 +5,7 @@ * *************************************************************************= *****/ #include +#include =20 static u8 P802_1H_OUI[P80211_OUI_LEN] =3D { 0x00, 0x00, 0xf8 }; static u8 RFC1042_OUI[P80211_OUI_LEN] =3D { 0x00, 0x00, 0x00 }; @@ -2026,8 +2027,8 @@ inline bool xmitframe_hiq_filter(struct xmit_frame *x= mitframe) if (registry->hiq_filter =3D=3D RTW_HIQ_FILTER_ALLOW_SPECIAL) { struct pkt_attrib *attrib =3D &xmitframe->attrib; =20 - if (attrib->ether_type =3D=3D 0x0806 || - attrib->ether_type =3D=3D 0x888e || + if (attrib->ether_type =3D=3D ETH_P_ARP || + attrib->ether_type =3D=3D ETH_P_PAE || attrib->dhcp_pkt ) allow =3D true; --=20 2.53.0