From nobody Tue Apr 7 08:52:52 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BE5137B3F6; Sun, 15 Mar 2026 18:52:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773600773; cv=none; b=pO/4Rcu5aUz57qZt6vU1SC06nCe8PzIL5YYZnSSIBZlQtUDKBS3WS99p1Z5WXp50wWBW49k1UmWNOFlr12JlGXiacmQve9yfUWGc530b3wE9R5R1uLLwTzKq90JCeBODbpoxr8NT8HQ5K10MkSe9rs22N8RYBonGxDvLBbgDDbY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773600773; c=relaxed/simple; bh=qua4z1+dduswjPIAqw2Xaw9gznNNtYVooXIHVFd03DU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=amQJ6WwSk0IzHRrCsaQITq0Tcbz6m8SN2IH6D7dm/EEYP0jwq3m7mzXOceVFuOnyiGcG4VhUZY0X95q8IvUvHolX5t9Y1fyQYoLs8hL3nVToVRPsid3XY3okFufR2VeA2AtPDYTY/yBeppsgsgfvp0mE3UzEXve0AEACgiY0BL0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mu9zAYsA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mu9zAYsA" Received: by smtp.kernel.org (Postfix) with ESMTPS id 42D4BC2BCF4; Sun, 15 Mar 2026 18:52:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773600773; bh=qua4z1+dduswjPIAqw2Xaw9gznNNtYVooXIHVFd03DU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=mu9zAYsAmWH3q/tekgJujaeA7dI3wlszIc9DBz6N5F3G5aNGtvZLkCWkt95qbscT0 x8iBPfD1uu8DtQDQKkVrrwW9WqFodijpsoXQDxYY9u07BPq7zf4CP2VKan200Ha/Kj blJQOiF1/gMhVDti8ceDWZqhsvbzUSf/CCsTmnvIzy8DRYicw3bxJ0hl5bqYHzedwD OYUPGFXhIGVkL16f+kPf6jRr8j0dFyllHmg2ge8z2b8Joc6fT1n3qrZ+wjkSlmp8MV +Zc/a+TtGYgx3xXGFW4tzzOENw1uvrTLDrOmjpuO0IgzaNxtQBLnrmN6k9F4lIWc66 4P2ao1vqdq35g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3933FF3027F; Sun, 15 Mar 2026 18:52:53 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Sun, 15 Mar 2026 19:52:41 +0100 Subject: [PATCH WIP v2 05/11] Input: stmfts - disable regulators when power on fails Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260315-stmfts5-v2-5-70bc83ee9591@ixit.cz> References: <20260315-stmfts5-v2-0-70bc83ee9591@ixit.cz> In-Reply-To: <20260315-stmfts5-v2-0-70bc83ee9591@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bjorn Andersson , Konrad Dybcio Cc: Petr Hodina , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1598; i=david@ixit.cz; h=from:subject:message-id; bh=2qW8ngTjzm302YCB/fjirEd8lBZHppTYTL/irHDu0sU=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBptv/53lQgPZkVE/1ff0MlL4oM6tmmzYpj7LZkM I5gtNehdp6JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCabb/+QAKCRBgAj/E00kg ckTBD/9d4Fas9MuxGRDBXkRc2fYIYSoRcXx3TcyfKoIpKrnKUiK8rzfIU0SlAg599HVJq/cpPA8 t507y5DmYEyhyMwSGAFKUnp366aMbjBfX68OV3Zd1ofuv/IpqFwITPliK0N7EuNo/RSQZCBo6m4 n7TqvPnXGYBJdg51oS9ZYyFhfvmRYm/JMuHTv9EE/hlgOEMS0h40CbticIBAnLqUGaRIxCJNU2L Ita88L14n5Qj7eKV9XF08aiVVC9jfT5WPnNmMZFkkYRrQA2ux729GVwUJc7dywNMBl5c8cMjfJR hqAOcTfglNYc4X3LYx8p+HrWv9yEsU8X+qyztoXxay7qriMRC7uwBXLjUnpGTg3XE5f3JF0j34u /uKRr5zUPrL8805QQF2HKlEXb+Tl2ldFi7ZrsIKivSpuVxSkOOkK4B4g9jlIcRsmT6MwqcWGRMa gVS53sC9SIrVRjrAXzw7DSIfjijn4seWDo1QMA5u1zsP8ST2iK2o7MqUphqIgldofokB4bON/v8 lbgb3wImj5mUgeykHlkU1IkqmlKtBMF4Vl6ATvDNjAw3u3AgXDwAVhtwU3YGZi4fGym3hnG0XNE ugj0bO65jbRvjTbAa+LtkKMdq0uOylPQrE0W7tAYp1GJgUfhAtZk52ortLkepchu4YQMZofd4wu dPGniMVnb5dUODg== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg We must power off regulators after failing at power on phase. Signed-off-by: David Heidelberg --- drivers/input/touchscreen/stmfts.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen= /stmfts.c index c1c9570ddea2d..bf176907177d0 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -558,7 +558,7 @@ static int stmfts_power_on(struct stmfts_data *sdata) =20 err =3D stmfts_read_system_info(sdata); if (err) - return err; + goto power_off; =20 enable_irq(sdata->client->irq); =20 @@ -566,11 +566,11 @@ static int stmfts_power_on(struct stmfts_data *sdata) =20 err =3D stmfts_command(sdata, STMFTS_SYSTEM_RESET); if (err) - return err; + goto power_off; =20 err =3D stmfts_command(sdata, STMFTS_SLEEP_OUT); if (err) - return err; + goto power_off; =20 /* optional tuning */ err =3D stmfts_command(sdata, STMFTS_MS_CX_TUNING); @@ -586,7 +586,7 @@ static int stmfts_power_on(struct stmfts_data *sdata) =20 err =3D stmfts_command(sdata, STMFTS_FULL_FORCE_CALIBRATION); if (err) - return err; + goto power_off; =20 /* * At this point no one is using the touchscreen @@ -595,6 +595,11 @@ static int stmfts_power_on(struct stmfts_data *sdata) (void) i2c_smbus_write_byte(sdata->client, STMFTS_SLEEP_IN); =20 return 0; + +power_off: + regulator_bulk_disable(ARRAY_SIZE(stmfts_supplies), + sdata->supplies); + return err; } =20 static void stmfts_power_off(void *data) --=20 2.53.0