From nobody Tue Apr 7 07:33:17 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8ECE139D for ; Sat, 14 Mar 2026 22:31:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773527511; cv=none; b=Gdoi/l/sxVNmdnG9x/EWdVCA4qVvn1bSdqhDqQMIqHUpRcDGx/aZ3Xr88HrwftJPgo9sD2xoFtc/ZVu2nRy0brpBV9bBsvZ42Z5zbGuhthncjvDaJQCneyVgxnlNq0BNM4zW7vGgZAtf3XVQWuATbn85Xjh37VqUcOvquaZ+eN8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773527511; c=relaxed/simple; bh=vk7vDIfIyDmX2vUb7k/XMNrhlPtlzSj78UsXzICjXjg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=q8luYV6jv44P8zCrOeub3Pyk47jg//z/FbMVfeSCxQseFP2F47wCm7yhQkOKWG7AvsLcH7t1GzvsVSIuygBojwtsNv/o19YYQde8QSGRuHuoe5oOztAVR9ns0mArzz4eZ+vzjSFneFJqSFgOaIU5zXyElYqZE2V+qz97G8/5aSc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GOtTN5EN; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GOtTN5EN" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4853c3c2fe7so20221795e9.0 for ; Sat, 14 Mar 2026 15:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773527509; x=1774132309; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gJ7hVQIRD6vEHOsR3AJFX+E3NnIhhIwHbuPfNg+Gnww=; b=GOtTN5ENkRqOvibYgnxREa+RilIIXTEIAp2xR9nqpaanhB1g+Zb6Ay114HA3rdj36v jYW0wkRWi9QfegNck1flUR0300WN0zGnuzQSF3r0P8KFsG1RUsAG1qzvQ4YARphzk+Q0 dWgMiTObBGnuLA5vWInUjoLZZsIUnL2Ievvu00bwxjHWhNVESH6PnVlxC8Z7OBa+0Gpz 44JxzH0zbjJUNShfsm3kdqvxwtb63PN7FqR6YlfTms8InoFKs43EAnFc0CGetQZvyCxH WhnNZ2jesPCjaVkDE+st//gRupVHHDFe6H0WdBvfXG85/a6zj/NIyajaNwMN69IgMFc1 rfeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773527509; x=1774132309; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gJ7hVQIRD6vEHOsR3AJFX+E3NnIhhIwHbuPfNg+Gnww=; b=Y9QLWJyqkTEKZFmWDz10gaHUFW9Bk8kVr7rUEjBlU2ALqiPsuk2OnD3OFla1glVDdX NNW8bjotfgQBYXS8fW9LsFC03KtqO8sxxHDiBPBVtixxuaTcQIk/UwX3VnKno5R60t/e kyx7ddjWI+iZQLQQk8Dn4W+QeVVLojwuscxvbimR2UVgfHHob+8rw901uHI3eUeOHu/6 R9vEm0U3euVVBlbSgqWZeEZNwpniz7EVczUkxgSf4EFsEU04ZBj/4tWmapayfozjON2D I/YuypPtJQLbPNtZykrf3eg48M2aRXCX6kYPVlu3BiK6QU+HJwCfdpFTbfD9n5ZwzfEV RU7g== X-Forwarded-Encrypted: i=1; AJvYcCUOjnF27YGBXlZdSmRusqDmwxi6QGMDR9vltwNViIeXX2YwuShbmrBG0aqWAHarGdaobYDqJU11Cf/q6JI=@vger.kernel.org X-Gm-Message-State: AOJu0YyC7+DYJ4Kcee+1e0X+J4Do/EL/7yZASXjiD0Uot1DH3ZpkTV99 87qQaZncam1ddREGQNNsTbDdwvC/vq7geIK6u71NY04FczOaqxczcylN X-Gm-Gg: ATEYQzyimSS7m0R6jhLMyHwDWrtUAQpNFRJJP9P3YpdOXBVtVkBvD6GqGWAB43xxUkz +f67QrVcZYYPgYj82VqWuXahQ9lY0wdpEHDStCeY/hRC9ZsyWbtSYjaEL0t5yBG6iCSLuyPkrQ9 7hWfYZw8v7mvmHj/gcj4kavQl18SnJo/ISpWKfsR9DFjoo4CWwyPHFZ1jiX9++MgGNcIwzADd3e gzqgv7ZNKENf4/5NOE2MnuKh9VcZKDvLSaEbxBo+vZSVRqHH3wGcsK+yYrN0AT+xmEo92VKGLsn E/PICfj8UDOQQ4dM5ynk5jsabJ0ad9B8fFrnSHISKVWUG35BhYYgdjNl3Dyw9jN3J9kAPIigNk0 k6k2OZFe3z4FQXSFuRTsZvA+zkux7JKHnfb/+Wo0NUVGUCRkT443ulIrGfXSWEROMMNKb5O5RPC MLIx1KvhDuXkULdS152R+niFO9Y4N2EZ3YZHLVt6auyBl9VfAOv5WqOj1xVOOaFz78X3hbKA== X-Received: by 2002:a05:600c:6287:b0:485:3f72:323f with SMTP id 5b1f17b1804b1-485566d2ff2mr132595095e9.11.1773527508820; Sat, 14 Mar 2026 15:31:48 -0700 (PDT) Received: from osama.. ([41.238.114.180]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48558fd09d8sm149314455e9.7.2026.03.14.15.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 15:31:48 -0700 (PDT) From: Osama Abdelkader To: Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH] riscv: kvm: fix vector context allocation leak Date: Sat, 14 Mar 2026 23:31:43 +0100 Message-ID: <20260314223144.154349-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When the second kzalloc (host_context.vector.datap) fails in kvm_riscv_vcpu_alloc_vector_context, the first allocation (guest_context.vector.datap) is leaked. Free it before returning. Signed-off-by: Osama Abdelkader --- arch/riscv/kvm/vcpu_vector.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/riscv/kvm/vcpu_vector.c b/arch/riscv/kvm/vcpu_vector.c index 05f3cc2d8e31..5b6ad82d47be 100644 --- a/arch/riscv/kvm/vcpu_vector.c +++ b/arch/riscv/kvm/vcpu_vector.c @@ -80,8 +80,11 @@ int kvm_riscv_vcpu_alloc_vector_context(struct kvm_vcpu = *vcpu) return -ENOMEM; =20 vcpu->arch.host_context.vector.datap =3D kzalloc(riscv_v_vsize, GFP_KERNE= L); - if (!vcpu->arch.host_context.vector.datap) + if (!vcpu->arch.host_context.vector.datap) { + kfree(vcpu->arch.guest_context.vector.datap); + vcpu->arch.guest_context.vector.datap =3D NULL; return -ENOMEM; + } =20 return 0; } --=20 2.43.0