From nobody Tue Apr 7 07:33:18 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38BC3388E49 for ; Sat, 14 Mar 2026 22:11:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773526264; cv=none; b=oBorLjvLkf+Hufo6eJyjKRgyoo5ic9PDb1z5npdFLWZL0uOm/ZMVoul7XV7kyzFis41syhYwoj68/lEeESb07iY3U8kOv2m2sLJPSdrxgXB8v3zbBYsg0PGgR6s+R66q8VQSRdTZZGt2PMD6bNXjtf8LM2TUKWLa9P26qb1Fj40= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773526264; c=relaxed/simple; bh=zfWBb2gzdNn0PhhVUKdPsJYBOm5sizTs1LPG8K092Fc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=W7OarSdHy60uAH+oEHZG7dt2EAPaQ/Z+FVePVTRhMYHTKwqkIZbnQ083sUypWtVi13gsi28S4D1urizfOzn235G+1qvjsdU0nyVKETIQ52HdVknIVTKY61SQhHs8zautZAMIXPYU9l5oNZFFeTryRExONGMotVrZyU5fRmNmWdE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W+5s7V20; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W+5s7V20" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-439b9cf8cb5so3778224f8f.0 for ; Sat, 14 Mar 2026 15:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773526260; x=1774131060; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gYHENs7oYh3Ieeryh1d39XShMklYVG+5PCHFmQooVBg=; b=W+5s7V20lTZm+Sv3mtAUHNyWHJB1NrO9rmwgDjcd0ezKqHUJ7fd9Bz6dYNQu54y6iR gufL9J8ESAHR61XpP+1sYkwvKIsu0rIy9dK/O7nusLeP4Lz2WDFmmQXb3bhTbJANYV27 O2J2Zbs48rVgeXc5Y2DpkSrhU0buWEjHt0ypgxVhksark2JOPlVfYPnHHfKg3dzwuGUS h9x2Dyo1ECGWoqsGHKi1CxImRtjQ2JdjA6JDv+oPvkqRb7KT6aE5RzhT/nPInbaK0yYY +Ap1spsaHJ+TUIcSKTPJn34K/FpdRb+Tc1OeGqS866gtk00J+TsmDYKdZ/Th0q1MyZIt FFvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773526260; x=1774131060; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gYHENs7oYh3Ieeryh1d39XShMklYVG+5PCHFmQooVBg=; b=hFNYnvz7nKe1dF1YPRWfR1UcIxFbK0PrB0ECIlvrKSSGyPr4CYlRlcEHlPUmrG+d6l MbyOOCT2Ktv8eGiyuDiFSpZoh3l6QSPoftdR9yyzyVr2JJVMR2Ujjv5unST5nRiDhJrt +VU4ocTfMK4co9HNMj2PlRNiTPEkm+fnla7GJCuNB+dWXNIAyARbzofIx9ni9NwIfUnZ QX6A3l4vFiIwAUSDUmVpVxnvVdISRmmtaXT2M01ovDoIpKh4NGks8W4rqhhLVEVd0Vqm aitQLpmFpZyLgXyEDtoQEKtDE4inJBRniMsO/zKvXXJxCtvdBIkWpHF0Lq0jjlFWZK7Y mU6g== X-Forwarded-Encrypted: i=1; AJvYcCVyLW9vmj57+hUhdfrHHJwRke0B915MTlDOHRMiUFtjyPMgWydKGRe04PwMaAsLPaFhZAp1mDv1BaWGaeI=@vger.kernel.org X-Gm-Message-State: AOJu0YzZF3mplzupW62sQHMhrLUL52d55G7A4fc6TVr2O+S/EYsuNXAy sedE8qnt4hzNzXnxF/XnJeid36Boqk18V3w/vrxTKQCyQdrlXnWByilZ X-Gm-Gg: ATEYQzzohX6N/nLQcGXmxxEjX5IZ7GVxcS1Sn2vicWnVauGfaie7gTv4cbB2KD7HBoD pFVpheHHs8H7beYL8JSUX/2CASFpUid+KOvWysafurORH0SclFC+ClakowmX0H+A9IJEEWMsJYh mduLmyeMzYuxQVlpHs5vfWh2G/AapL+9ILdgZGJx2kALeEX5Jd2cfLv2Y+5SGo6pI8Dg6/scrjA 9MmKC5TJo1to9mSKngZfT9ZeTLKPZOZmm5KYsgTLpCwHCSqG4bvxNsQ5qX306o4270YWK17Cu0D +zJqyiW9+l+xApCS/VHaYX3AWDt/nWUnHRZWQo3/1IB/dPPbr0mh9z26/zX23FKGIQdy5E8gbHi Y5zj+nqQUqJE1zNqxARHDPqDdBu41m5ckqEMVHqxRLwfvcxbYSNFqJzbU00/nEyisMAjVOjleSD 7L0yFJWqBoxJBRbWy2Pa/+rnOCsq5S9bJl78k6hq5EW6FEPVENlPPO0W2M4FU= X-Received: by 2002:a05:6000:1acd:b0:439:ddc0:4bf1 with SMTP id ffacd0b85a97d-43a04dcbf4cmr14628177f8f.55.1773526260557; Sat, 14 Mar 2026 15:11:00 -0700 (PDT) Received: from osama.. ([41.238.114.180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe1a78cesm28064825f8f.11.2026.03.14.15.10.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 15:11:00 -0700 (PDT) From: Osama Abdelkader To: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH] n_tty: add null check for tty->link in packet mode Date: Sat, 14 Mar 2026 23:10:44 +0100 Message-ID: <20260314221044.148442-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add null check for tty->link before dereferencing in n_tty_read and n_tty_poll. When the pty master closes, tty->link can be NULL while the slave is still reading, causing a null pointer dereference. Signed-off-by: Osama Abdelkader --- drivers/tty/n_tty.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c index e6a0f5b40d0a..dc04b87364f6 100644 --- a/drivers/tty/n_tty.c +++ b/drivers/tty/n_tty.c @@ -2232,7 +2232,7 @@ static ssize_t n_tty_read(struct tty_struct *tty, str= uct file *file, u8 *kbuf, add_wait_queue(&tty->read_wait, &wait); while (nr) { /* First test for status change. */ - if (packet && tty->link->ctrl.pktstatus) { + if (packet && tty->link && tty->link->ctrl.pktstatus) { u8 cs; if (kb !=3D kbuf) break; @@ -2444,7 +2444,7 @@ static __poll_t n_tty_poll(struct tty_struct *tty, st= ruct file *file, if (input_available_p(tty, 1)) mask |=3D EPOLLIN | EPOLLRDNORM; } - if (tty->ctrl.packet && tty->link->ctrl.pktstatus) + if (tty->ctrl.packet && tty->link && tty->link->ctrl.pktstatus) mask |=3D EPOLLPRI | EPOLLIN | EPOLLRDNORM; if (test_bit(TTY_OTHER_CLOSED, &tty->flags)) mask |=3D EPOLLHUP; --=20 2.43.0