From nobody Tue Apr 7 07:29:19 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ACA9385536 for ; Sat, 14 Mar 2026 21:54:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773525283; cv=none; b=LGBkja73BAm8ar6SvvKyzBUPIHN7Y97TXo9/L9aPtc/ZpiqL8Aae767cHBXtHbPMunb+/RDur2CGzmXYFQksj8somumJlMInpcvLpteVYndgV2foYxwtFlGKhrsjiRwWnARhTGpyot7HEmY1LXEds01ML0L6OZ3+xEgAL5btwiw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773525283; c=relaxed/simple; bh=zyBvR66gBNHj30TAvIUG+Ee3ZkIChPpji7xJjFmHr/w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qVC9/ak1iOIsUT0uSeKDkye0Mty9GGbgIKnnza3EAB96FOspC1mUDRHcqgbHgnrsepPfdNrUIE6NxwbpL6KC6pDCzGGLSIAl7+s8NCvwVQh9DulQ1ufLF+GP3fSJ8ZJi5JWM1g2FynG9XzbEpQiR0oAWVPVmpuxAzsBh3QNYeIw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D2I1SjAC; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D2I1SjAC" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2ad9516a653so14316745ad.0 for ; Sat, 14 Mar 2026 14:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773525281; x=1774130081; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Q2MZxltuowMU3t5Y9YR+g7TQKDjpiH5GQi6XASz0zH0=; b=D2I1SjACXRUvYqurV7N1vg7Pa1dGO9C+b6GtfWuCWRcNqt941Q6dFZSU3Sc9y6180I 7oY7KSHdZkTK+Qvj1CzozLUHN42gCD6g2ILem469oVfFIm0kPScJYlONGul5AboXeRFw mYv9mfomLW5R4B5Li5xYs9MiEu4CQb7KsDze6ZFqfSr/O0ygGh/sL3h7hy7heLZOU2qU RlkJybwNakZZ58YEbv8EVICPkUcBut/Z6FVrmV7JiGbwDNhS1Kje+uzbDmyl7bZQR3yj w7PjclJn/XCTpEX3kIDowVBgJNuuIDDCdGrbMN0s5cJ4mVso3VABeZViJuxpF/BPL7YQ dX/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773525281; x=1774130081; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q2MZxltuowMU3t5Y9YR+g7TQKDjpiH5GQi6XASz0zH0=; b=fzaiC5+HtWwXYqCQFghHDgXZnIJuTpRwhqwF8ftruzs475zkfIS80Swkz1QZs+0nLH 12I5BPUMv96tlqDy0Axe1loebuhiw5e/KFzP0qzHM3XFmHec4Dp6gVjt/WpQHFyRY/88 nsB2lCx+qNnY6KeJrX6C8Un+6hiSxef6ciUB3277mnFA9c9W7C6TcgaVnrTxy/ww46f8 Qk/AWQ2idmgCgwWR3JgPtzbnomUwwOpJowyhUaqws8flDpKZJVv6J6KToImiMGNUTyqB gLaOR5ECyFANTxtOft0kKb6KxUpsIsVFe9p9gpTCr8RCk4uPebkUnGzJ7lbjqXzrLF/Z GCyQ== X-Forwarded-Encrypted: i=1; AJvYcCUMiBMAEfTCWKZW9h5pCMr8u8Ye0lzYJ9WCS9h7zspg1YuOYmvtx4DhZQrRpJYsOi/plU4eNTcV5atMl4E=@vger.kernel.org X-Gm-Message-State: AOJu0YwbN95alJ0pGnUumzQg4gk9MvSSGetkeyz72DOLq+ExGeuZgjkj XbYjSH+zMLnk+Z0x3SU6r0o6g/5JM/PbXE5KS8PAmN/sK7TCK7mgcZk= X-Gm-Gg: ATEYQzykoBrHQIXrBFo7QUJEIvs6l96BjVJmMl5D/mVV5FXrmYbGiK34kqZZCWhvghC 6Xm9E1GZIRh8RjT2+uJUhfEPcb25+o9302Mlhl8DWFHgRuNHTTo9reRnNnkKSLgflB2Ap+Ov60M cbZ8/exXxlCW3RT9XGH52CTQLoBPoWFkTj/XnlKG0rWAljmvirlnhRFUJbXfmn+7R46UkuOTEZb rAGQNb/uBBsIOElPrsWQh6DDxUWsGxN7YkZgHFQ6WCQs+M4CtMknNW9Z5YmrM86UagVFFfjJHb/ 7SNd2nIK9HViaD6UpyEFN9KiWse4rLcFu8Ip27YwUCtMY0+x4yN8xkNYk9mOQG+poERdxu1Nzxn dlflD4SX0NBYjSR6Dea/dun0EAREQOitu26yIPwtByWt8tLXbfD39auP5b77MaOgRWV+KkLz8i8 udPpKleA8uO0dNTbisJe+8KboZ+3dhWIlYOJzcpaXa9jAuMhuGIm5nkAFtrGffjQoPrOJXj4Mlr Q== X-Received: by 2002:a17:903:3d0f:b0:2a9:62ce:1c15 with SMTP id d9443c01a7336-2aeca796da3mr73368685ad.0.1773525281384; Sat, 14 Mar 2026 14:54:41 -0700 (PDT) Received: from at-Standard-PC-Q35-ICH9-2009.. ([171.61.163.197]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece594b4fsm57292725ad.20.2026.03.14.14.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 14:54:40 -0700 (PDT) From: Atharva Tiwari To: Cc: Atharva Tiwari , Rishon Jonathan R , Vincent MORVAN , Paul SAGE , Pavan Chebbi , Michael Chan , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4] tg3: replace placeholder MAC address with device property Date: Sun, 15 Mar 2026 03:24:30 +0530 Message-ID: <20260314215432.3589-1-atharvatiwarilinuxdev@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Paul SAGE On some systems (e.g. iMac 20,1 with BCM57766), the tg3 driver reads a default placeholder mac address (00:10:18:00:00:00) from the mailbox. The correct value on those systems are stored in the 'local-mac-address' property. This patch, detect the default value and tries to retrieve the correct address from the device_get_mac_address function instead. The patch has been tested on two different systems: - iMac 20,1 (BCM57766) model which use the local-mac-address property - iMac 13,2 (BCM57766) model which can use the mailbox, NVRAM or MAC control registers Tested-by: Rishon Jonathan R Co-developed-by: Vincent MORVAN Signed-off-by: Vincent MORVAN Signed-off-by: Paul SAGE Signed-off-by: Atharva Tiwari Reviewed-by: Michael Chan --- --- v4: - Used static for default_mac_address - Returned the value of device_get_mac_address in tg3_get_device_address v3: - Used ether_addr_equal v2: - Wrapped commit message to 70 characters - Removed BROADCOM_OUI constant --- --- drivers/net/ethernet/broadcom/tg3.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/bro= adcom/tg3.c index 75f66587983d..a80f27e66ab5 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -17030,6 +17030,13 @@ static int tg3_get_invariants(struct tg3 *tp, cons= t struct pci_device_id *ent) return err; } =20 +static int tg3_is_default_mac_address(u8 *addr) +{ + static const u8 default_mac_address[ETH_ALEN] =3D { 0x00, 0x10, 0x18, 0x0= 0, 0x00, 0x00 }; + + return ether_addr_equal(default_mac_address, addr); +} + static int tg3_get_device_address(struct tg3 *tp, u8 *addr) { u32 hi, lo, mac_offset; @@ -17103,6 +17110,10 @@ static int tg3_get_device_address(struct tg3 *tp, = u8 *addr) =20 if (!is_valid_ether_addr(addr)) return -EINVAL; + + if (tg3_is_default_mac_address(addr)) + return device_get_mac_address(&tp->pdev->dev, addr); + return 0; } =20 --=20 2.43.0