From nobody Tue Apr 7 07:33:18 2026 Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC0B91DE3DC for ; Sat, 14 Mar 2026 21:47:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773524852; cv=none; b=DWDNDCcws7Z+3ZiBs4sJS7pvXb22T59BiAgPC+XhffGsY7je4IBxHrYbzhG/WUw43/Ag6iezypnJQ09+hqAjwi8FIIEPKWho6iEmsy0xrz88lUtHG0Hn1/+z/rduXZt8XlpNuObCWse9EEOHSeJYUqpVDlFbcCL+TInzzapKnEA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773524852; c=relaxed/simple; bh=4bfBXQfPbkU7JmL1qRRsnrm3Pf4KvJXqpjwGHWRNqyg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hwZtjnHPnIcYoztxj3ljNWsUE79AGTKyEmbomVxj6N8g61AE+Nf9EQO7Qpaxxfy3bJdI94rTLwKfEEqysh1eD/fLxK0VHxJQ6KYIucIal6e09i83RUMKmHD+QSt+RiX4gnV0lPuVokx3JSbQIh0GjWZo+n1AOPtaZW1qWP1hF9o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=my0jQNYD; arc=none smtp.client-ip=209.85.222.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="my0jQNYD" Received: by mail-ua1-f51.google.com with SMTP id a1e0cc1a2514c-94aca174532so741934241.3 for ; Sat, 14 Mar 2026 14:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773524850; x=1774129650; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=alGyACKRVvN5aaPDRz/bs51HwfBDN0Y0PQTNwWDzjFc=; b=my0jQNYDYYgVYvBaYT/DpNOfEad4Oi/uVXhZCpNIeaeD4T5gQ+GRwkoulHIWA30f/V 2ZDJj3xesEY9rMq2l+rQMHKqqYkq/SjPewjgyReYcEWBxHCWIYpLjbeYDsMVN0uK2xCk 6dk2ffR4jT4g/4XVBTIffvlMUC76xL6ORJ1ffXtkkwKdFEFnp1s7qt9FsxazyxVmMLzR bs6AnVU4dcjJIYqERnqR+tw/mZcJa8L271g/Fs1hWTbSvLwrq2NxDO3WZR2iJJzY1Bcv Rqt1J2bAhMawXxaqPDCtpxkIrJPG0NxhSNjmZaLseR/PFiYO94PI+8maxvv/X7A0I5qu 5Pfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773524850; x=1774129650; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=alGyACKRVvN5aaPDRz/bs51HwfBDN0Y0PQTNwWDzjFc=; b=K2MPS3cVHWZzVpzvuOoTdE1eLXVTcxzVDFp1s355VLMcqO/jbnMz2xxVbOE5J/3lTn prdFY2XdZ3e8lSxSNDqUrYlyOJ4f+ZZJ80eZRhBjxpH2NoIEs4voMRQHYa02UaMgibn2 R1s3b5AWQJo8YR+kUc0JKKGLOCQw5Qs8fRlh6BicsxLfU23mzt/2j8NtPjl8opK+BqOI 47D9ZBQBHqPuDU8fE/8R5gmGJLw0aDbwWwP/EI/W+Urfhdzr0dRuGMb5d5ljIwffZwHd l8EYkrV3itNk5fZWFEg9qNvvZ7DiptuJYAbnNwOuX+nLR2NRD7/N9/iddpeMPXlqUbnz Yc8A== X-Forwarded-Encrypted: i=1; AJvYcCVFNUBwNb/KMt9TK6Tt0E7c6iN1YbhDfT1G3BmevcgILWlwUscAYtj0IpwfYc1cZVUVy48q6MIrHXAJuOk=@vger.kernel.org X-Gm-Message-State: AOJu0YzgBV5TOQBYH2E5ZumwE3HB6iYwCuZNIPJCB6CRd4To/z2Na1Ee Od4Rh+MN1qUTPH5lakdVmjR02aE67sULNaQ4FBKGNW7GqSU0uS9UB6k4 X-Gm-Gg: ATEYQzyhkHt2mJrP07GyPf3QURgnSc+Rdd5bEqHLOOk4YSC0x4kiCvakEvL8IIdMlk0 daK/WHwnhBc0guc183SJatYKmW1nGRz0N65xSbKQTTHxt3PfXMd4rSHgjXZByBHV/UJP2lYtezm 9jlmhWNACgcVnzEJCWWpGJJpaLIDSH6Qfgf21wztoWM5WJ0dQA5+AsET6c6+gypz7hoCtO727Gx v+WfLXUYDZQQH5yU+N/QcROLPCQg/EjGSA4/IQ7A3h15tF1RZhvIZdTOLRencEGKV1z7M8pFKbc LrVFwBAEQ6SZbnS//NspkI+sS7yNzC7MFSXTOS/hKRtlMpxqqiY6CN2uvuVKtnrGvsCD2E4U9y5 jwtd7/W/CSPS9Xan0bS1eHGmgFBnJa4rBwHEEmD+NhH1F5Yw3hul0oOmHhhqRJJtbdxtvXk0TlP xmy6WnUcTvZgeFGHRwejUNVnAAmpX6FEOyEjnfb6/uu2TR08c= X-Received: by 2002:a05:6102:6cc:b0:5ff:2391:45c0 with SMTP id ada2fe7eead31-6020e5a1084mr2725732137.31.1773524850635; Sat, 14 Mar 2026 14:47:30 -0700 (PDT) Received: from mjmachine.localdomain ([131.255.96.240]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-94ecfc4ecabsm4319988241.3.2026.03.14.14.47.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 14:47:30 -0700 (PDT) From: Marcos Andrade To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ethantidmore06@gmail.com, Marcos Andrade Subject: [PATCH v2] staging: rtl8723bs: Replace network magic numbers with EtherType macros Date: Sat, 14 Mar 2026 18:47:19 -0300 Message-ID: <20260314214719.45853-1-marcosandrade95963@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace hardcoded magic numbers for network protocols (e.g., 0x0806 for ARP, 0x888e for EAPOL) with their standard EtherType macro equivalents (ETH_P_ARP, ETH_P_PAE) defined in . This change improves code readability and aligns the driver with standard Linux networking definitions. Signed-off-by: Marcos Andrade --- Changes in v2: - Changed include from "" to <> for linux/if_ether.h. - Sorted includes alphabetically. - Removed unrelated usleep_range/delay.h changes (will be sent in a separa= te patch). drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 7b18be891..4062fe0c1 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -5,6 +5,7 @@ * *************************************************************************= *****/ #include +#include =20 static u8 P802_1H_OUI[P80211_OUI_LEN] =3D { 0x00, 0x00, 0xf8 }; static u8 RFC1042_OUI[P80211_OUI_LEN] =3D { 0x00, 0x00, 0x00 }; @@ -2026,8 +2027,8 @@ inline bool xmitframe_hiq_filter(struct xmit_frame *x= mitframe) if (registry->hiq_filter =3D=3D RTW_HIQ_FILTER_ALLOW_SPECIAL) { struct pkt_attrib *attrib =3D &xmitframe->attrib; =20 - if (attrib->ether_type =3D=3D 0x0806 || - attrib->ether_type =3D=3D 0x888e || + if (attrib->ether_type =3D=3D ETH_P_ARP || + attrib->ether_type =3D=3D ETH_P_PAE || attrib->dhcp_pkt ) allow =3D true; --=20 2.53.0