From nobody Tue Apr 7 07:33:17 2026 Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC438255F52 for ; Sat, 14 Mar 2026 21:07:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773522458; cv=none; b=mMPZ4Q3vBupJ6U7+b8UVFdG8ea6xtsBVb5eAwnKd/Qb0vYTthBKGzWQeq4jxqSU/IZI7vYuk6tIiCeuA7UumfGMUGaV5Zgev/NR0R39j1Q/WcI1HSMZMWuPgJIcAEHZ6NLwTzlVw6YZG26g7HntdvRfxDjNW9SmahJ+sIsE2jNE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773522458; c=relaxed/simple; bh=9DDMenW0vPqf5+5xZn3R/D3TLty3tgMEZVUg1GjdBnk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=msSMSh8b6xjFFccXXv/D5IOOCWBX+Qfz7AruUG9WU0wBbt8QJaf5jn67/ysn6X079dAoAzRl9dPyo29dhyK1i8ag1KlydYoSU5wHpKyp/XZBqicpcM/ox88xEtxX0z1T5Au4frt+4vREkYjYsbVs28Z5HWM1ibj0iAW9vXaCjss= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=clp76mOW; arc=none smtp.client-ip=209.85.221.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="clp76mOW" Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-56b6c3e0166so1358154e0c.0 for ; Sat, 14 Mar 2026 14:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773522456; x=1774127256; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=U8R2pGjILFy8GTgK2aL2ly1h4FzvaEh9yan4utzdYfY=; b=clp76mOWY9yRI1ysLSOEfWQfjn9dIv/3a5y49irsZ3kE08MhzSuHoDu3pTHBk3TlRV EUnvBmtIOxFZPc/eceYvMFQGCyUXLQvl1RU3jZFb7ysysniVjZbPPrglY07Gi5IgybsT j75I+MPE1mBVDLT5BSm9UJ1DM0T1CUKS1OSq4g77AO0HRUdcRS5IJHLA2tlJLDh0wtSk Q5s9RZc4IWcstHDmFQG42U/qD1AwRFemgrbgIVfQbbctwasDZfMeFmTaO1a+6VLwky5M gKpw1pfuIF62aFN06IjYoZVMiAN7wUL//nFLF5HXRxLRsU/8CggZI8v7Azb0D5Ob78kV 1YgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773522456; x=1774127256; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U8R2pGjILFy8GTgK2aL2ly1h4FzvaEh9yan4utzdYfY=; b=hMkHMJiJoprlB7RHZCNLaJM8TXELt7LKUsJJxt1+8fHRFitrQSvzenmDupOv4DMOZS boGjdvfcxcC03ek8/G2vuJKePZdN9CNCUuqoLWE43sjBXMKMnrQoyWnynHXW/S7d7rkG ZgGXIhwU6ryZKAEYDjHky2vqkgW96uWyTHN9gkpOQdv7Se59zpWZATbKSaAwwokIKuZ+ FgtArJcI4Y7YBfXZFkaD8xRezEzQ8cYAnQxhlcaVCNrMEKogLXyAKGr19SxhZK+E9fzq pMb3EDVJhwlGJkGvvDCfcshGCGw3Je0RI0WE8RmSBIGBAiV2ijU7fuE5ZmSgyIdleJRj ILZQ== X-Forwarded-Encrypted: i=1; AJvYcCVLMSMjitW9Y3Mw/+U7hAls/dw4AAuUSHat3XJQDUyvcT+nat9iaAwsc0wE1XZ/HO7pVXYl56kzdfWYi+Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxeK5uSEJYgYbp969X52UN5WAFe7RnvYRx6C6lL3of4yPyxLHJb 8QotzVWQ6B0cryAKtVMpX12Lbr3I0/wk9p2YGcCzOQ0XSVd/E6x9YxP5 X-Gm-Gg: ATEYQzxJ1k67B1G/XtSgwu5pcdCr+HsMIJ7y+OG+KFnNM5iTAe2QMb550xH9AjoKSfm PbFu1qcvE7VpLNlznN5EwMVWTE7gSGKtXID5sW5MVoz2A5J4bkfm92pekpjyH7BPa7slcSQ4sr4 qoQcXQlZwSkrOElkso+E000r9fdk3h0qzJlRBr5Y24VV6ssFcyub7b3+m/Wql8938Q31e+ELTc7 Qexp38a/gP5GOHhCiMVssj/VBsx7m8YILB80TaZHtBr3LKzB/i9SOV1aYl/Am+dZemY/irlmWMS U9Zta2JEBQG5CYFYSKFEexhUmq4F+qESyvEzXwsy8HauKZnO4VaOjxe80XtnCkXBFgDyVLoaOQo qtxsjkv7cDiWEd8VB7mUlAXJPCxkMsMrKpWs2Ya1s9TogSjk0Ti1Q67lDD8Sjys/4lU6ti15vpR ThYh92Ynr8EPmQeX0tYwsNAgYi4T9p5kqUAgvq93c1FPhL2jfJKcOYsdU2PA== X-Received: by 2002:a05:6122:1d43:b0:56a:8f7c:49aa with SMTP id 71dfb90a1353d-56b61566e5amr2851584e0c.4.1773522455918; Sat, 14 Mar 2026 14:07:35 -0700 (PDT) Received: from mjmachine.localdomain ([131.255.96.240]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56b4649c813sm5606083e0c.15.2026.03.14.14.07.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 14:07:35 -0700 (PDT) From: Marcos Andrade To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marcos Andrade Subject: [PATCH] staging: rtl8723bs: Replace network magic numbers with EtherType macros Date: Sat, 14 Mar 2026 18:04:26 -0300 Message-ID: <20260314210426.42532-1-marcosandrade95963@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace hardcoded magic numbers for network protocols (e.g., 0x0806 for ARP, 0x888e for EAPOL) with their standard EtherType macro equivalents (ETH_P_ARP, ETH_P_PAE) defined in . This change improves code readability and aligns the driver with standard Linux networking definitions. Signed-off-by: Marcos Andrade --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 7b18be891..313d8b80b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -4,6 +4,8 @@ * Copyright(c) 2007 - 2012 Realtek Corporation. All rights reserved. * *************************************************************************= *****/ +#include "linux/delay.h" +#include "linux/if_ether.h" #include =20 static u8 P802_1H_OUI[P80211_OUI_LEN] =3D { 0x00, 0x00, 0xf8 }; @@ -128,7 +130,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) /* Tx buf allocation may fail sometimes, so sleep and retry. */ res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ += XMITBUF_ALIGN_SZ), true); if (res =3D=3D _FAIL) { - msleep(10); + usleep_range(10000, 11000); res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ = + XMITBUF_ALIGN_SZ), true); if (res =3D=3D _FAIL) goto exit; @@ -2026,8 +2028,8 @@ inline bool xmitframe_hiq_filter(struct xmit_frame *x= mitframe) if (registry->hiq_filter =3D=3D RTW_HIQ_FILTER_ALLOW_SPECIAL) { struct pkt_attrib *attrib =3D &xmitframe->attrib; =20 - if (attrib->ether_type =3D=3D 0x0806 || - attrib->ether_type =3D=3D 0x888e || + if (attrib->ether_type =3D=3D ETH_P_ARP || + attrib->ether_type =3D=3D ETH_P_PAE || attrib->dhcp_pkt ) allow =3D true; --=20 2.53.0