From nobody Tue Apr 7 07:33:17 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADFF826E711 for ; Sat, 14 Mar 2026 19:34:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773516880; cv=none; b=QpwayGAiwRlrLSukrXD13h6faVs5nlA5r48x23Ng53LwC72Jpl7fJvwLpHHm7a7M8CLohgb2NPWQxvznFpMPyyk9G65qM/9Khpf1kghaHPa61DOJVjKIbePLCdmGqOs9DcTDydFOocv7oz+vPVvn3/dYKkg0nNrMQIxkijOTpTs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773516880; c=relaxed/simple; bh=Lth7EWEsIwF3SHUznewcoYh8/uieBTo0wCYgQOHwZOU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=df+Rt4If5ubgaJfywSobskfQlfG25fAwXqyLULonw/Nw+MMLQpXOAgUnRLrqIyKRhlqRSXPEeVqcCZyZLYyUKLnEX5gBOqC4QSi0MG+g2Hx/r7cGF9QZr26iMCfEaLrP9MR1sxMISPonteuwVgNhYR879F51GlrUTw1MCoT7vkg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b=oOrYGXNH; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b="oOrYGXNH" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4852e9ca034so29079115e9.2 for ; Sat, 14 Mar 2026 12:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20230601.gappssmtp.com; s=20230601; t=1773516877; x=1774121677; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qgRUv7skzvgM5JyNiSXlTpUT4tb6CMtOEKVYPn7SPuE=; b=oOrYGXNH4tHKJZzG9pGXRI8e5OGXu9dGvRRKYdVHZIqtB+1v9212xAXRNN1D2c8de/ Yi/ZvS1QYlCVvk0V14/JFXF0qHC0vEaNaNUXA0WclLE9V2OI4kCEA+9eGvsx7elzMu2W B/poDsM5PUPSRI+rHnqH+i8A5pQLMmaKVuB+XA2JwnF9Lp60Xse+5KKVlDlVRELKwTmD 8qTU8iNQVCC/OVsAhswTDKpHM9PQ7n0k7dUNnn9T1onkOYszEyiL8zOZLvymdjKOBmrp cR6grObWtyv0HUu9EermOx3RMqqEyC6HO3MqQXJpNbvnnSRP03DbwpLsONdecB1k0ehc N57g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773516877; x=1774121677; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qgRUv7skzvgM5JyNiSXlTpUT4tb6CMtOEKVYPn7SPuE=; b=oiSw0EsY4fHJerjWMrToFd5mSLmWo1zjTvnu0QTLrLSpLF5Eiz4Gccse5QQvzPkpm8 89KlbuekLw6ibpCqPhWhVJr/VXcKRmctOqttfYu8K3vuOUFKwixOir+X8XNLoNsHTTVf KWaax5L0UW3lJ8C5gmUZaNYj6LOh3GaeCltZ3CCPjhFd7lrL4bYDQQ2zqr56yNW0AAAW mZ6nKkDpMhn3C+tywTOlZvBnRFQoA9zEE3PidLokCR00C3EglySD5WIZy1TOyRchNUHW 1jsbQRNJ/K4ZybhBovYWG+vwixG5AgJ2PZ1y8rPveVT72zqnZFp08E9PYrvpDOUHuasf F6MQ== X-Gm-Message-State: AOJu0YxYUVIFZ73b+esQW06RIfMDri/71LPok9/7CZNFvYAeW/IXn7E+ W6mA2DgKszRU0NGNLIZ50X1AmeKVqJEpRPSVFTW10TzMk6g/HWVKxyRk5cKHMTWoBJ4bbb5M6LX doVU= X-Gm-Gg: ATEYQzx+EIc4LGsMD8p21nrC1J4REohcw6yoykfBBjBEq7kZ04OpZbkgV578IAKAkx/ lnVDpgpYGs7B9ifACpkIzpC8UgmkMyKm1tVClg421FlE4wCJ8U7S6zAeQ3K9x3UrfTHCmQZdSQu pBIACiWCjUdLbZMduOrJSKHw+OQ1WX4r1s+dnT2NhoP9GNmUvpyI/V81qn/wbWd4LrW52Vf/aig W6CR8KWkdtpTLYuMJyGb8KMwl4QL/YWm+quW/aMPxW71sNr8cCV+D0Jnueg4GPW+HhJ/gvcF7OY dEwlGtIXWpAdvCWq5AiEBtRaqZF0Cdkxe3ybpH9HfmWWqlmv+/WtsXWUOHfpFhjI4SrW/hBOy5r YJaL58L0OyQ3/IKVG4h5GMo38p0nMkr9sdHC1I5EitRo00DcWEjBMHREPU+/tke73ZuO24pUvKi 7a5hK/mn+Q8+ayRc40rxiUMDKFo2HnKaDxlmi9ptlwP5JKU1u06HA= X-Received: by 2002:a05:600c:a46:b0:480:4d38:7abc with SMTP id 5b1f17b1804b1-485566d6ec5mr131769375e9.11.1773516876504; Sat, 14 Mar 2026 12:34:36 -0700 (PDT) Received: from starbook ([217.155.46.38]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4855638cebcsm105647415e9.0.2026.03.14.12.34.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 12:34:35 -0700 (PDT) From: Sean Rhodes To: linux-kernel@vger.kernel.org Cc: Jaroslav Kysela , Takashi Iwai , Chris Chiu , Kailang Yang , Stefan Binding , Edip Hazuri , Zhang Heng , linux-sound@vger.kernel.org Subject: [PATCH v3] ALSA: hda/realtek: Sequence GPIO2 on Star Labs StarFighter Date: Sat, 14 Mar 2026 19:34:34 +0000 Message-ID: <20260314193434.8237-1-sean@starlabs.systems> X-Mailer: git-send-email 2.51.0 In-Reply-To: <4d5fb71b132bb283fd41c622b8413770b2065242.1771532060.git.sean@starlabs.systems> References: <4d5fb71b132bb283fd41c622b8413770b2065242.1771532060.git.sean@starlabs.systems> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The initial StarFighter quirk fixed the runtime suspend pop by muting speakers in the shutup callback before power-down. Further hardware validation showed that the speaker path is controlled directly by LINE2 EAPD on NID 0x1b together with GPIO2 for the external amplifier. Replace the shutup-delay workaround with explicit sequencing of those controls at playback start and stop: - assert LINE2 EAPD and drive GPIO2 high on PREPARE - deassert LINE2 EAPD and drive GPIO2 low on CLEANUP This avoids the runtime suspend pop without a sleep, and also fixes pops around G3 entry and display-manager start that the original workaround did not cover. Fixes: 1cb3c20688fc ("ALSA: hda/realtek: Fix speaker pop on Star Labs StarF= ighter") Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Stefan Binding Cc: Kailang Yang Cc: Chris Chiu Cc: Edip Hazuri Cc: linux-sound@vger.kernel.org Cc: linux-kernel@vger.kernel.org Tested-by: Sean Rhodes Signed-off-by: Sean Rhodes --- sound/hda/codecs/realtek/alc269.c | 64 ++++++++++++++++++++++--------- 1 file changed, 45 insertions(+), 19 deletions(-) diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/a= lc269.c index 4c49f1195e1b..901314a7af51 100644 --- a/sound/hda/codecs/realtek/alc269.c +++ b/sound/hda/codecs/realtek/alc269.c @@ -1017,24 +1017,6 @@ static int alc269_resume(struct hda_codec *codec) return 0; } =20 -#define STARLABS_STARFIGHTER_SHUTUP_DELAY_MS 30 - -static void starlabs_starfighter_shutup(struct hda_codec *codec) -{ - if (snd_hda_gen_shutup_speakers(codec)) - msleep(STARLABS_STARFIGHTER_SHUTUP_DELAY_MS); -} - -static void alc233_fixup_starlabs_starfighter(struct hda_codec *codec, - const struct hda_fixup *fix, - int action) -{ - struct alc_spec *spec =3D codec->spec; - - if (action =3D=3D HDA_FIXUP_ACT_PRE_PROBE) - spec->shutup =3D starlabs_starfighter_shutup; -} - static void alc269_fixup_pincfg_no_hp_to_lineout(struct hda_codec *codec, const struct hda_fixup *fix, int action) { @@ -1454,6 +1436,32 @@ static void alc274_hp_envy_pcm_hook(struct hda_pcm_s= tream *hinfo, } } =20 +#define ALC233_STARFIGHTER_SPK_PIN 0x1b +#define ALC233_STARFIGHTER_GPIO2 0x04 + +static void alc233_starfighter_update_amp(struct hda_codec *codec, bool on) +{ + snd_hda_codec_write(codec, ALC233_STARFIGHTER_SPK_PIN, 0, + AC_VERB_SET_EAPD_BTLENABLE, + on ? AC_EAPDBTL_EAPD : 0); + alc_update_gpio_data(codec, ALC233_STARFIGHTER_GPIO2, on); +} + +static void alc233_starfighter_pcm_hook(struct hda_pcm_stream *hinfo, + struct hda_codec *codec, + struct snd_pcm_substream *substream, + int action) +{ + switch (action) { + case HDA_GEN_PCM_ACT_PREPARE: + alc233_starfighter_update_amp(codec, true); + break; + case HDA_GEN_PCM_ACT_CLEANUP: + alc233_starfighter_update_amp(codec, false); + break; + } +} + static void alc274_fixup_hp_envy_gpio(struct hda_codec *codec, const struct hda_fixup *fix, int action) @@ -1467,6 +1475,24 @@ static void alc274_fixup_hp_envy_gpio(struct hda_cod= ec *codec, } } =20 +static void alc233_fixup_starlabs_starfighter(struct hda_codec *codec, + const struct hda_fixup *fix, + int action) +{ + struct alc_spec *spec =3D codec->spec; + + switch (action) { + case HDA_FIXUP_ACT_PRE_PROBE: + spec->gpio_mask |=3D ALC233_STARFIGHTER_GPIO2; + spec->gpio_dir |=3D ALC233_STARFIGHTER_GPIO2; + spec->gpio_data &=3D ~ALC233_STARFIGHTER_GPIO2; + break; + case HDA_FIXUP_ACT_PROBE: + spec->gen.pcm_playback_hook =3D alc233_starfighter_pcm_hook; + break; + } +} + static void alc_update_coef_led(struct hda_codec *codec, struct alc_coef_led *led, bool polarity, bool on) @@ -4058,7 +4084,6 @@ enum { ALC245_FIXUP_CLEVO_NOISY_MIC, ALC269_FIXUP_VAIO_VJFH52_MIC_NO_PRESENCE, ALC233_FIXUP_MEDION_MTL_SPK, - ALC233_FIXUP_STARLABS_STARFIGHTER, ALC294_FIXUP_BASS_SPEAKER_15, ALC283_FIXUP_DELL_HP_RESUME, ALC294_FIXUP_ASUS_CS35L41_SPI_2, @@ -4074,6 +4099,7 @@ enum { ALC288_FIXUP_SURFACE_SWAP_DACS, ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO, ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY, + ALC233_FIXUP_STARLABS_STARFIGHTER, ALC245_FIXUP_BASS_HP_DAC, ALC245_FIXUP_ACER_MICMUTE_LED, }; --=20 2.51.0