From nobody Tue Apr 7 09:18:43 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BF48BA21 for ; Sat, 14 Mar 2026 18:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773512970; cv=none; b=eFqrfKmvUemZdb+yqSfGQjlmE8p3BnVNfHUOGMYeDhvJp6UQZ117XkFHtXhVIHQPuqxF+XqyvkoJFALJb6MQti8Wha3JzPybF56HTMfIfymLUdwgNKkMmLe9qSFez3xTgIDe9UFvn1iRWZDVSgY/jIJQpS9Olpox6oM6n6SMZCk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773512970; c=relaxed/simple; bh=QLZYYEoj+5kLfwWS2IqKub9BTqN23yPeZ2bW6yAB0N4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mRkkifSJ0ngaFxf630E+LX0QiwLCNbZ4sapHTWtAX5SHVTT4DlmX8XJqPAo2yJSWqpoz2RBIHnw096CaHJ48T88RHX30imTHw+Fkf1ev3CJJpebL2rKQJMc2ydCz0r0neUXiuJBIaKLpAappryLw/QyOw/thTSMP2SYM2wxmmOU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FMxYfnhi; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FMxYfnhi" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2b04b4974abso2543325ad.1 for ; Sat, 14 Mar 2026 11:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773512969; x=1774117769; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IB6x/lr1ek9kI9gI1prPQzKFPvlqHQ7Z+jL2sCBy488=; b=FMxYfnhi+21QvpNVJLMxrxfpYn3MFU1yIWd0SaDIllEPzEYag8eWm0OnHDVkw4oqo5 ZKddlHnxTnuB/klDtPkQ+DTYpMclDFn5km+vdZcbFwwicwWJvLnDzVaTW7cABi6+6VKi WBIYaySPmcowSec2oNIiMUPr/BvZIxnsJBdsQZBqcYr6r8CJCnciOJxOfrdHqKUBK7ax Yy4Wr7sa/TXEBDGcBBa6ypzAUdkXlj1rB/F9/GDmuRoHS0vy4KoCvfj8nzVAMbbpjNpj wy0t9uVa5iZvloU3tg1uHmeBzGqCxBiphUbmZK119U6/duD6yvWJdInRUfxIs7W+axxl CQPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773512969; x=1774117769; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IB6x/lr1ek9kI9gI1prPQzKFPvlqHQ7Z+jL2sCBy488=; b=mXTLdcGHdzYCqJSfXUzKee6t1SApBzHfcFVj4J3y7pUFqv6yrDGGYaRc2rL1hFoGRJ /7glbiKSvRttoP7D5pMXTEg3BFXzCRaQ/cIQw6EGhhQsY2doWQjWmubaFJ6vLnSzEmOi Nh6JPDAgRq7q1pr9aWcqj5864ySMsSyBdir9iqiOfWsQnwO81eT/JgCRty58f/wBH/Vk sUjsrh2J/kYIwj0mIPKolrp815d/Jbxy2Bea6N61GU4UFFllNPGEkOMv/h//d0SwwGjZ 5VDcdWMXgJCGsjDOdLiV1bzI8vkKwmnsJi3gSxwKvL0g1XAzDIWUrs6IaXCY878D89hv Nzpg== X-Forwarded-Encrypted: i=1; AJvYcCXGVFTGho0YXnizzyU6lIAzU9AenK4f5zgU93I5U/n8rcc/Ag3FJHqMBp0LM8ZWdgAP4iFdxwWqyi/icEc=@vger.kernel.org X-Gm-Message-State: AOJu0YzW2nHoHb/TeLZt5fQz57rdjbomA4nD1OIfkqIxc2MLZ47iI/5F itfWotFs9tiIPEcQJMTjShbvlxP2zyrPC/amU0uuBh9Ha2CreIsm7L3M X-Gm-Gg: ATEYQzzNSbzv5GtCfi1J60bMYuWPVUJIEYXRNJV4q47Ea/UI5irQ/mJRB4Qe9+RrXtM wxPdoXVuVUcTbED/QrXTY8MjGFgdYMAGEPJmT7MOSBGijczb2BSefOjpZS2hmaUFvYnMKNchN0K X5QZNXnl93unfIzyI2L1xyogDTrKRhNSlc6GaKj98Zh3gxBOsw/NKKlOSHrCRAUgjWXt0zdeH1J AjZFrr15LBM7kC8UFaH5rCP3VtNCngD4+CgOMDQ+sV8BMhcLkMqrTyfYTZDAb6jreecwuiurVfy XTDGK0wed8FtY3n9BPfWA/CxBzjL0ywUl2OyvGxBe3cQskA77ulDfwxdozdjpUUZtrGTUFsv44W jAvebmmAD0OdMKOgHLcbYQSLvmpjHCKGlLHCWKkiuXtp2gN7R++mhfLqlZiJ2n2DBXDp/GczJTe 7Osj8h/YQnedeiaOK8TqdoZQVfD5DBxAKbKXnJdshLyFLn8m8DXNvzOa4UJikkCAPPvVHVCc+Fx oT6Ng== X-Received: by 2002:a17:902:d592:b0:2ae:5ec4:2f78 with SMTP id d9443c01a7336-2aecaaa860dmr85707515ad.33.1773512968776; Sat, 14 Mar 2026 11:29:28 -0700 (PDT) Received: from localhost.localdomain ([122.168.66.151]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece62c581sm77673525ad.33.2026.03.14.11.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 11:29:27 -0700 (PDT) From: I Viswanath To: stfomichev@gmail.com, horms@kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, kuba@kernel.org, davem@davemloft.net, eperezma@redhat.com, xuanzhuo@linux.alibaba.com, jasowang@redhat.com, mst@redhat.com, przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com, jacob.e.keller@intel.com, ronak.doshi@broadcom.com, pcnet32@frontier.com Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, virtualization@lists.linux.dev, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, I Viswanath Subject: [PATCH net-next v9 5/7] 8139cp: Implement ndo_set_rx_mode_async callback Date: Sat, 14 Mar 2026 23:58:07 +0530 Message-ID: <20260314182809.362808-6-viswanathiyyappan@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260314182809.362808-1-viswanathiyyappan@gmail.com> References: <20260314182809.362808-1-viswanathiyyappan@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Implement the ndo_set_rx_mode_async callback and update the driver to use the snapshot/commit model for RX mode update. Signed-off-by: I Viswanath --- =20 Call paths involving netif_set_rx_mode in 8139cp netif_set_rx_mode |-- cp_init_hw | |-- cp_open (ndo_open, takes lock) | | `-- cp_change_mtu (ndo_change_mtu, takes lock) | | | `-- cp_resume (lock added) | `-- cp_tx_timeout (ndo_tx_timeout, takes lock) drivers/net/ethernet/realtek/8139cp.c | 49 ++++++++++++++++++--------- 1 file changed, 33 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/realtek/8139cp.c b/drivers/net/ethernet/r= ealtek/8139cp.c index 5652da8a178c..9651a0d9d8f0 100644 --- a/drivers/net/ethernet/realtek/8139cp.c +++ b/drivers/net/ethernet/realtek/8139cp.c @@ -372,7 +372,6 @@ struct cp_private { } while (0) =20 =20 -static void __cp_set_rx_mode (struct net_device *dev); static void cp_tx (struct cp_private *cp); static void cp_clean_rings (struct cp_private *cp); #ifdef CONFIG_NET_POLL_CONTROLLER @@ -885,30 +884,31 @@ static netdev_tx_t cp_start_xmit (struct sk_buff *skb, /* Set or clear the multicast filter for this adaptor. This routine is not state sensitive and need not be SMP locked. */ =20 -static void __cp_set_rx_mode (struct net_device *dev) +static void cp_set_rx_mode_async(struct net_device *dev) { struct cp_private *cp =3D netdev_priv(dev); u32 mc_filter[2]; /* Multicast hash filter */ + char *ha_addr; int rx_mode; + int ni; =20 /* Note: do not reorder, GCC is clever about common statements. */ - if (dev->flags & IFF_PROMISC) { + if (netif_get_rx_mode_cfg(dev, NETIF_RX_MODE_CFG_PROMISC)) { /* Unconditionally log net taps. */ rx_mode =3D AcceptBroadcast | AcceptMulticast | AcceptMyPhys | AcceptAllPhys; mc_filter[1] =3D mc_filter[0] =3D 0xffffffff; - } else if ((netdev_mc_count(dev) > multicast_filter_limit) || - (dev->flags & IFF_ALLMULTI)) { + } else if ((netif_rx_mode_mc_count(dev) > multicast_filter_limit) || + netif_get_rx_mode_cfg(dev, NETIF_RX_MODE_CFG_ALLMULTI)) { /* Too many to filter perfectly -- accept all multicasts. */ rx_mode =3D AcceptBroadcast | AcceptMulticast | AcceptMyPhys; mc_filter[1] =3D mc_filter[0] =3D 0xffffffff; } else { - struct netdev_hw_addr *ha; rx_mode =3D AcceptBroadcast | AcceptMyPhys; mc_filter[1] =3D mc_filter[0] =3D 0; - netdev_for_each_mc_addr(ha, dev) { - int bit_nr =3D ether_crc(ETH_ALEN, ha->addr) >> 26; + netif_rx_mode_for_each_mc_addr(ha_addr, dev, ni) { + int bit_nr =3D ether_crc(ETH_ALEN, ha_addr) >> 26; =20 mc_filter[bit_nr >> 5] |=3D 1 << (bit_nr & 31); rx_mode |=3D AcceptMulticast; @@ -925,12 +925,14 @@ static void __cp_set_rx_mode (struct net_device *dev) =20 static void cp_set_rx_mode (struct net_device *dev) { - unsigned long flags; - struct cp_private *cp =3D netdev_priv(dev); + bool allmulti =3D !!(dev->flags & IFF_ALLMULTI); + bool promisc =3D !!(dev->flags & IFF_PROMISC); =20 - spin_lock_irqsave (&cp->lock, flags); - __cp_set_rx_mode(dev); - spin_unlock_irqrestore (&cp->lock, flags); + netif_set_rx_mode_flag(dev, NETIF_RX_MODE_UC_SKIP, true); + netif_set_rx_mode_flag(dev, NETIF_RX_MODE_MC_SKIP, promisc | allmulti); + + netif_set_rx_mode_cfg(dev, NETIF_RX_MODE_CFG_ALLMULTI, allmulti); + netif_set_rx_mode_cfg(dev, NETIF_RX_MODE_CFG_PROMISC, promisc); } =20 static void __cp_get_stats(struct cp_private *cp) @@ -1040,7 +1042,7 @@ static void cp_init_hw (struct cp_private *cp) cp_start_hw(cp); cpw8(TxThresh, 0x06); /* XXX convert magic num to a constant */ =20 - __cp_set_rx_mode(dev); + netif_set_rx_mode(dev); cpw32_f (TxConfig, IFG | (TX_DMA_BURST << TxDMAShift)); =20 cpw8(Config1, cpr8(Config1) | DriverLoaded | PMEnable); @@ -1262,7 +1264,7 @@ static void cp_tx_timeout(struct net_device *dev, uns= igned int txqueue) cp_clean_rings(cp); cp_init_rings(cp); cp_start_hw(cp); - __cp_set_rx_mode(dev); + netif_set_rx_mode(dev); cpw16_f(IntrMask, cp_norx_intr_mask); =20 netif_wake_queue(dev); @@ -1870,6 +1872,7 @@ static const struct net_device_ops cp_netdev_ops =3D { .ndo_validate_addr =3D eth_validate_addr, .ndo_set_mac_address =3D cp_set_mac_address, .ndo_set_rx_mode =3D cp_set_rx_mode, + .ndo_set_rx_mode_async =3D cp_set_rx_mode_async, .ndo_get_stats =3D cp_get_stats, .ndo_eth_ioctl =3D cp_ioctl, .ndo_start_xmit =3D cp_start_xmit, @@ -2071,7 +2074,7 @@ static int __maybe_unused cp_suspend(struct device *d= evice) spin_unlock_irqrestore (&cp->lock, flags); =20 device_set_wakeup_enable(device, cp->wol_enabled); - + netif_disable_async_ops(dev); return 0; } =20 @@ -2081,6 +2084,8 @@ static int __maybe_unused cp_resume(struct device *de= vice) struct cp_private *cp =3D netdev_priv(dev); unsigned long flags; =20 + netif_enable_async_ops(dev); + if (!netif_running(dev)) return 0; =20 @@ -2088,7 +2093,11 @@ static int __maybe_unused cp_resume(struct device *d= evice) =20 /* FIXME: sh*t may happen if the Rx ring buffer is depleted */ cp_init_rings_index (cp); + + rtnl_lock(); cp_init_hw (cp); + rtnl_unlock(); + cp_enable_irq(cp); netif_start_queue (dev); =20 @@ -2101,6 +2110,13 @@ static int __maybe_unused cp_resume(struct device *d= evice) return 0; } =20 +static void cp_shutdown(struct pci_dev *pdev) +{ + struct net_device *dev =3D pci_get_drvdata(pdev); + + netif_disable_async_ops(dev); +} + static const struct pci_device_id cp_pci_tbl[] =3D { { PCI_DEVICE(PCI_VENDOR_ID_REALTEK, PCI_DEVICE_ID_REALTEK_8139= ), }, { PCI_DEVICE(PCI_VENDOR_ID_TTTECH, PCI_DEVICE_ID_TTTECH_MC322= ), }, @@ -2116,6 +2132,7 @@ static struct pci_driver cp_driver =3D { .probe =3D cp_init_one, .remove =3D cp_remove_one, .driver.pm =3D &cp_pm_ops, + .shutdown =3D &cp_shutdown }; =20 module_pci_driver(cp_driver); --=20 2.47.3