From nobody Tue Apr 7 09:17:53 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D485132E12E for ; Sat, 14 Mar 2026 17:07:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508055; cv=none; b=P75jnouRwDRp7LXZTQEzZvAKJbZ2tPMxUoAM4XpmbRpgcRSMlXiEh03fk2/m3zMkSvLlvKt+i/8jdKAmW05cg20eblucjs8wfCUEIaYZvCI/H1wznzH858WjhEwPJlE5Sli50BXi8+BS0uLGOSB3yzHO54M4eTe+vcLPk7IZ1Aw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508055; c=relaxed/simple; bh=yrd9gnH4G4XboAvtH3+r2nhqv/wL64oMNG1tqzjyoYM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pCqL0WN2Widw66gmoJoxq6OwRPxN8/++954jKDlGiG6wq5OyrDsJz7D1v+RupMBMKPr+fLuuiV5CAiB7t8kx+HZWHkkn0mnfPIyODfWINUsC3Nz5xDbWKiPocRPrQhqtJCBy6JAR00JJVpgbtGnPGJgG4xq4dbBOg2SVBH212JE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aCnvGKGu; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aCnvGKGu" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3590042fa8eso2096528a91.1 for ; Sat, 14 Mar 2026 10:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773508054; x=1774112854; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yddq5l/1nbJ4rOJNrryOQK4alZgEnsRtcdvwC6K0IHU=; b=aCnvGKGu23RK5IeczwngLAIVKbnJXWmua7pFW6+4QGT/tFRfRZCoPbCe9KIXsTLThT Rm9mURvvu67SDF+F75GBZzcP1iyvxjHUPvACGlbi3ho1RXiE/A0AT9tqz0YJsgT/tP5U mHNfCBwk4T21EzSZIjm6zs9kVAWjNgcmvNn9SeMxKXiVzredI719ofABUornruj/SXtw yBO77gl3ne5vimllFpS5NzzCO+oI6USnee2u5t4+LubOnic9xSLvrMAlD86NE27gfdj6 DY0LXyzCHwFVJEgmziDGR6ulw14aN5lyUjTcfpNbsOqp6/zE3Mhk7zlMYiVcty8UJMOv lhdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773508054; x=1774112854; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yddq5l/1nbJ4rOJNrryOQK4alZgEnsRtcdvwC6K0IHU=; b=F5mWzbdhCBJlBOR8kGn7AKzvWgG/s5BukQ17Uj6z0mSzHIEkrPCt1yKDaed5Ls7Xmo mPTlrhiIdwvDJEUrKYtMy7cSP2tdeLfgFpTxj9HtAna9IVV9MgFo0oxgMwMOi8sr4iD7 c6nH9zij9bBWor7Ee/NN33TY5ZniVIj87JBxYxCCwvZ5y1+42yjz6tcE0llZCihyNjWm d4W9Vh426Q57t7dcNX2m/dLhPdoNI9KTCAGeWZouI2M4hBxE+NB6ugLcrgjmg/G9hHJn Y2iVBS7roy1/91JHVwiFIaeYUgYMn3w2hARs7f2CPEDN3/OzgdR88uOY8+CdObNp/tWs fZ3A== X-Forwarded-Encrypted: i=1; AJvYcCWxymuoYDHllDX0Ezk7uMHJJje4Jnb2koZI0pzoYijKaL9iVCBxH8OAxlusxw9AQAjvU2T4tWCgl1eCKaI=@vger.kernel.org X-Gm-Message-State: AOJu0YwYxjlVodOPAo97npXbXr2heuS9a1IH4rPxYK2HjLMl/Wv3zRnQ 1K6pAJIaKC0KwVlzW7GHiTbZ3Ay9jnsvYZPhVLNlLgtD+b8NEYT6BphF X-Gm-Gg: ATEYQzzDoDhkzbhue0bG07MgRsPXSAFVRbGXudkjC3bLBc7NpzDGbKZYvG46SIAJ9FA Nbw1WNLikBFXD+5DUAwWRBMTpQDpHvTmZ8GcbwV+fY+N+EeitfA0lezQG2rmXWr3PLcZi4rC/Gx 7o5NyzN0QgypnvyY/IgjjwZItHrmizPJl0hdEH/7ilZDIpHoBJWgbdnE78+7mzBjtHjrRKVntX8 pi1H6J7giP+HSjowYfK3ODtja/dYG2xW39Yfp+HRSQnkPul3M/4Eqezr0f7f5R8u45tpIbhoKok ZmuRV985j14GF5zFQSrAZvRvoHSTcrIr0eBvjmpIbPWabpdDDuaZc3kR2gqdmE4bDg67E4zwmZK x7sRBkTIibsXCjKZuZ7U0gfZRQcTM6jY4u8cNa6ukH0nZbtoZBeVaKRqy35hsx8IRKSS9Tw3dbT B86fLXPCtsXcZeDHhH/tyelS8sSRPrfNE4/+Wwenr/iA5Df4ZZ+v8UGMjav5HdE4p77L/vZ2hEd pfCUptBHavTtVA6vZ4zMjbnC+o= X-Received: by 2002:a17:90b:35c3:b0:359:9cb8:db5 with SMTP id 98e67ed59e1d1-35a2200d7bamr6243213a91.26.1773508054194; Sat, 14 Mar 2026 10:07:34 -0700 (PDT) Received: from fedora ([2401:4900:8898:a35f:15b4:3058:14c8:4287]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35b90d3f572sm1600116a91.14.2026.03.14.10.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 10:07:33 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH v4 6/8] iio: accel: mma9551: convert to guard(mutex) Date: Sat, 14 Mar 2026 22:36:07 +0530 Message-ID: <20260314170609.26827-7-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> References: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in mma9551_event_handler(). This ensures the mutex is released on all return paths and allows returning directly without a goto label. Signed-off-by: Rajveer Chaudhari --- v4: No Changes v3: No Changes v2: Dropped Header alignment change --- drivers/iio/accel/mma9551.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c index 31e5c3699c19..0936b148e424 100644 --- a/drivers/iio/accel/mma9551.c +++ b/drivers/iio/accel/mma9551.c @@ -341,7 +341,7 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) u16 reg; u8 val; =20 - mutex_lock(&data->mutex); + guard(mutex)(&data->mutex); =20 for (i =3D 0; i < 3; i++) if (irq =3D=3D data->irqs[i]) { @@ -353,7 +353,7 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) /* IRQ was triggered on 4th line, which we don't use. */ dev_warn(&data->client->dev, "irq triggered on unused line %d\n", data->irqs[3]); - goto out; + return IRQ_HANDLED; } =20 switch (mma_axis) { @@ -377,7 +377,7 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) if (ret < 0) { dev_err(&data->client->dev, "error %d reading tilt register in IRQ\n", ret); - goto out; + return IRQ_HANDLED; } =20 iio_push_event(indio_dev, @@ -385,9 +385,6 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) IIO_EV_TYPE_ROC, IIO_EV_DIR_RISING), iio_get_time_ns(indio_dev)); =20 -out: - mutex_unlock(&data->mutex); - return IRQ_HANDLED; } =20 --=20 2.53.0