From nobody Tue Apr 7 07:32:09 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29DEE31B130 for ; Sat, 14 Mar 2026 17:07:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508023; cv=none; b=glDJ/m0/9MjmRzXZgRdrzjMMAAkz2RLs9jd2CrTvoKTmv7thHGW2EsBMUVjV52cIdIBZptN3wghsrsACXp3G70M8ZokhIqMGmy/0pnL+oFpWsZZo1nBMOqtd9trkSlUlyaVOnrYrgsgk+/qpzaB9o8CEAFkOjyjSmxHof1W6plo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508023; c=relaxed/simple; bh=KE7Z7cx4nctVTMLw7OR5xaT3+rD4CxWaBg7rIVfSHC4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HkAu77y01yqWPeGwaWOG3i0oSi8mwh//ShnfjMV1pjCmF68VBPdf920NNhJWy5ckUata/d7THvMJc+VsOnhdMR8pMxee7YtwVR1gs6tqIQT2EjXnCax8y+cA1EXX1/sNAPd3XAaWig6+2g7SMA60u1Jxf9NPGWd94foNMoEIsEk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jB2L9GcO; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jB2L9GcO" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-35a09e0dd63so3419679a91.3 for ; Sat, 14 Mar 2026 10:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773508020; x=1774112820; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O0WZvcr8z2ScNIiVKlO93t9t9l4r1I3AeV73VTHXtOg=; b=jB2L9GcOeDJaYTfa/vg8Fvc/Zj3cdqnLAAo5g3rVaJdv+vepj+VkjNciJ+5akXEhR2 Vl4hgZrF0el8R/jjVQ5zxqJuGWT7W+4z6AyEDBc1/RwB3T3YKaQhxeyZwCAOsXH0KHap WvpkXn6sRuh3TQHZag6zTXA1wqfCKkTgVr6QzUoR1UBuSGxLz8j2ZV5om8uA0NMwOtWg hbEziTV3OQRKAq7lO391gHyxwYLocghvezoMjU/gIAPILlbwKE1hYZ+QDViTKjM7zAKq pynbkpnwYvfVE8k9ncCTO4ZHX/Mwuh9EukUlC/3kqXELB5WG4FD7QoRl8SWDmZEJaeGl 8W4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773508020; x=1774112820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=O0WZvcr8z2ScNIiVKlO93t9t9l4r1I3AeV73VTHXtOg=; b=IBiOUIuKrPVGRhxTjK08CGfO8ADPq4A1WP4ZJSSGwxz/jW3riqaIU3OCKtEeKVMYJ1 ucrY2EzPJVdEKA56qYN/zkmR82u+lguT6CQ1zzXRqxiM0QkVghpdKRvCbI2W3l8oIwrb /VC9i30V9HfnsnTJgj+Rs5ZLxyfGOJArynCYMB7Ox97phQvxM04qsYbTMf7sSlGHrNEg W5AP40LGzTDr0eylaWgJLfQfb2XhPawwPENzmhJYSxb1CE7uurbpT3Whae9Jxwhxo4P/ r75KMgNC5a7T6SuNBO8T61OgF3U1KbEexhMZKlIH5pcDhqtSIlNkr6BHGbGDcajyYNdE Sh5w== X-Forwarded-Encrypted: i=1; AJvYcCWKQkM3dAdstWFI75bcXppB5LAgCSKUKuGkQFn5Ew+L7tjJJbN4Qv+i5/0fFtlY7/elx3JglthhIUwnuis=@vger.kernel.org X-Gm-Message-State: AOJu0YxVRdVXTXLYFqcwd0dJUR6CIY1TvRfE61mIe83cpeuGRg6tJHUf Rzag2h+c3U2JjYk/WeGsCkv9igtPkAT3R1X76wREXKT+x2O1lzOXzcRdRy0jCw== X-Gm-Gg: ATEYQzxHVEoWyciEJy1KwR8u4DvuyJjTncJ95JnNaqftlRATKqGHr0FwKaYTJERBhJA txpCjM0den7Hj4tInVSrkE+ZRLBSORDRrKDp2I0HhGY4eAp72h3mA/uhVpeYkyCKyAhbOjZ9jln rkD5NLYufJYbTMVEC6ZBZQ9rFuLCWB6ClPoJLi1fEin7sdLrUi0gtODF+dK9oo3ZvFlEVywo2YZ Ax71ourluARrWPhovjJV4tkTDrCzFeIwE1aYVVJXcPb6ip/JmBuwldCpiEO1yV1QRkm33HH+j9t 2gdLzXwGMq27fRnxMtrAL1WgsO3GEwIhaJIwP6ScSOnmtWxSnfAinxju9/ALzGAzny3Xmi7OxWM ci2q1WtlLKu2aWShMyk/rmAzv162/VX/eLwPMVJqi+9DvwujYELm4PX2o8TGfCEvT9ZdKhBIWna BMtxmHVA+hQUXPsfQeX9rVcc7UI+h6IKQKT29dZe+ftJ1ezfb+/vepE8UiNJmGQnOu91zquXEVQ ziJpr8iMOQWfNqNF9ZxpZC9PBI= X-Received: by 2002:a17:90b:1b10:b0:356:3ba2:122c with SMTP id 98e67ed59e1d1-35a21efa8cdmr7049842a91.9.1773508020512; Sat, 14 Mar 2026 10:07:00 -0700 (PDT) Received: from fedora ([2401:4900:8898:a35f:15b4:3058:14c8:4287]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35b90d3f572sm1600116a91.14.2026.03.14.10.06.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 10:07:00 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH v4 1/8] iio: accel: bmc150: sort headers alphabetically Date: Sat, 14 Mar 2026 22:36:02 +0530 Message-ID: <20260314170609.26827-2-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> References: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Rajveer Chaudhari --- v4 : Patch added in v4 --- drivers/iio/accel/bmc150-accel-core.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc1= 50-accel-core.c index 42ccf0316ce5..4eb4293a741d 100644 --- a/drivers/iio/accel/bmc150-accel-core.c +++ b/drivers/iio/accel/bmc150-accel-core.c @@ -4,23 +4,26 @@ * Copyright (c) 2014, Intel Corporation. */ =20 -#include +#include +#include +#include #include #include -#include -#include -#include +#include #include #include #include -#include -#include +#include +#include + #include #include +#include +#include #include #include #include -#include + #include =20 #include "bmc150-accel.h" --=20 2.53.0 From nobody Tue Apr 7 07:32:09 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EBFE326938 for ; Sat, 14 Mar 2026 17:07:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508029; cv=none; b=aRY3t0RSrYWoQ77ZP2w9hKtbCN9q6nnqJ7RLT+FJamT+t/sP6hXvGhxaXCBkEwoVZQR7GmJ+SOYSAFzLJC0DbgGAudPuAdHdbTWQ0+Bu5QbgUTv9CBk5bcc0+nYJMw9ORfZfj9N9aTeVzJcE06A+CIqN8sl4a8tmmkFm3FWooKE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508029; c=relaxed/simple; bh=HmPTsqb/9N1Z/ajgv8obZI9UP3kG09bBiRK3FZTbKPI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cae3Bsj+Rx7TuVk0+9KIr5bzvh/um0tH05Kuo+B6vsoyOMdzQ70+a/ox89pm9DToTE0LmKojjSAf2fE2z4oVOw4vrfPohcUO9dXSt8sVOXxAHXAkYY/6jnQk33izrB7pvMXI327XGBG930tOnkCJ3AbyiTuR3aGuqH1/ZHKBCOk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gaGEp5yE; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gaGEp5yE" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-354a18c48b5so3187257a91.1 for ; Sat, 14 Mar 2026 10:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773508028; x=1774112828; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cXBXAYup5bMGRbC7TQhDOWWRHU3wjPm9XP+UjoBzfnM=; b=gaGEp5yEA+TBSMUREIndaKUfhOzviMu4ecd9EDZi7NTK3qoqAFhBkr5QfLxRQWYomT rJgkzSEhx109TprHgaQgmZSixazGF/XkO0A3dH4+ocr43z9LPONj1AIz5p8GxrtHIRH8 kbZWMXNeBzJmu1A4+cn8BSANWc8SOEBKf2ehKmsgJdrXZB5DZdc3RORpuMC4cLUvZUad d5w9WSfODwHpDbRvZyltn9nUPA7Y/7q3MSVgob8/AS9s/beMnUXLs9lNDN2bgyBOutVr gHAnDUx8yIUtlbIfR+KmfPnatcTDpKWufde0T0Xwov7iHAh1CjMkWL12ccMC3QDTREbL EHZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773508028; x=1774112828; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cXBXAYup5bMGRbC7TQhDOWWRHU3wjPm9XP+UjoBzfnM=; b=aCCBRdhjHevpHkCJIo9hm63CQOWxxMnj9HZvozdX7itdh0bzMbg8M0dN7SFgYiJPr+ lqfEZy2suwAStS1CiBevNx0UZDjQrMKhTeF0WW6mzGkqTnzUZEDNT1VQMuNwyhm8pvGj 2/Pxmp9OZWFOGJOHf6CDYND32rtj2p3TurTRuO4y/M1A6RONU8AEtN0trXMdFDhnCUf3 +PpnTZqz2W66mI8rXxuhmbZi1B+11ynjYubbD5di6r1lpcoMI80A5EqCmAAnWKgbHSx5 TEuuhDTpYvQBB4Yjmj6FdueXDy4aZ2WG5Z7LNHw5OUiE6HT6UoaVO7fsziOTB/gw7RET p3NQ== X-Forwarded-Encrypted: i=1; AJvYcCUimEnj4QODy4hGK5InpXiGVSTEOEmGjJRwdm1PiP+0Jx+NcdasXmpZngWru/Li8OX4cvW/FNw1qYnRMtE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz36pFKtV02HHa+4tEviSQEPQq/G/X5qtFP+Yu9qhkcix9w7yjZ uEWXLdmxT3T+l0HhNs5Xb7arkyMHWV1LNMh38rcW9pZabVxtI2axoJJ3 X-Gm-Gg: ATEYQzzIgG3bJGt8OZlKWZLDPldjCrP6DmV5mdqb39IM75DIJL7ZUBA6bvQ1H0pva7n QpUPuvWvIqyLqbfL2RoqxGPRrdgRETSDmN1rBr9IYNwqvq29dIZaD0to2oRPacOvZ6q83b3g53Y EDwaZapAvva82fMef+svPZpzRUY6+LAiOLgPDqxirPfrnbCP2s2fCtGqM9VDeGAJAuBvU04dUfW CpRVBuR4fAHVHZYHp/Re6SsKY8OmS47tjxL+Ya1A15GLJIjuFyfrn0txyhw9Ry1PFSORdtz2dig ellohHwj9uMU0+5vdPQuke6PedoovsRks//EIPAP9vIC5/qzdfC58Xq/HNNnhpjrqehgVACcfMU XjOhw/Bp8YrW01UvPmPsrheTj4jR89xTzCN1Be4/XLym5RUobfidevnbETk5DDv1tZzAlBQO1LU wyptQLhjkYZsEeheCUep1+pWFWlOekdgY9cniDLdJrWveXAv+EBhKrnjR91hCjvfghL48brSX7h /4SVyv4pMo8u8MLI9eu35IpP2g= X-Received: by 2002:a17:90b:3c10:b0:359:92b5:da70 with SMTP id 98e67ed59e1d1-35a21ed3a60mr6694324a91.9.1773508027792; Sat, 14 Mar 2026 10:07:07 -0700 (PDT) Received: from fedora ([2401:4900:8898:a35f:15b4:3058:14c8:4287]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35b90d3f572sm1600116a91.14.2026.03.14.10.07.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 10:07:07 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH v4 2/8] iio: accel: bmc150: convert to guard(mutex) Date: Sat, 14 Mar 2026 22:36:03 +0530 Message-ID: <20260314170609.26827-3-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> References: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in bmc150_accel_buffer_predisable() and bmc150_accel_buffer_postenable(). This ensures the mutex is released on all return paths and allows returning directly without a goto label. Signed-off-by: Rajveer Chaudhari Reviewed-by: Linus Walleij --- v4: No changes v3: stop initialising ret=3D0 at start, making clear about good path. moved return ret up into the if (ret) {} block in bmc150_accel_buffer_postenable(). v2: Cleaned mutex_unlock and goto in bmc150_accel_buffer_postenable(), Dropped Header alignment change. --- drivers/iio/accel/bmc150-accel-core.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc1= 50-accel-core.c index 4eb4293a741d..d3214be54819 100644 --- a/drivers/iio/accel/bmc150-accel-core.c +++ b/drivers/iio/accel/bmc150-accel-core.c @@ -1483,20 +1483,20 @@ static int bmc150_accel_buffer_preenable(struct iio= _dev *indio_dev) static int bmc150_accel_buffer_postenable(struct iio_dev *indio_dev) { struct bmc150_accel_data *data =3D iio_priv(indio_dev); - int ret =3D 0; + int ret; =20 if (iio_device_get_current_mode(indio_dev) =3D=3D INDIO_BUFFER_TRIGGERED) return 0; =20 - mutex_lock(&data->mutex); + guard(mutex)(&data->mutex); =20 if (!data->watermark) - goto out; + return 0; =20 ret =3D bmc150_accel_set_interrupt(data, BMC150_ACCEL_INT_WATERMARK, true); if (ret) - goto out; + return ret; =20 data->fifo_mode =3D BMC150_ACCEL_FIFO_MODE_FIFO; =20 @@ -1505,12 +1505,10 @@ static int bmc150_accel_buffer_postenable(struct ii= o_dev *indio_dev) data->fifo_mode =3D 0; bmc150_accel_set_interrupt(data, BMC150_ACCEL_INT_WATERMARK, false); + return ret; } =20 -out: - mutex_unlock(&data->mutex); - - return ret; + return 0; } =20 static int bmc150_accel_buffer_predisable(struct iio_dev *indio_dev) @@ -1520,19 +1518,16 @@ static int bmc150_accel_buffer_predisable(struct ii= o_dev *indio_dev) if (iio_device_get_current_mode(indio_dev) =3D=3D INDIO_BUFFER_TRIGGERED) return 0; =20 - mutex_lock(&data->mutex); + guard(mutex)(&data->mutex); =20 if (!data->fifo_mode) - goto out; + return 0; =20 bmc150_accel_set_interrupt(data, BMC150_ACCEL_INT_WATERMARK, false); __bmc150_accel_fifo_flush(indio_dev, BMC150_ACCEL_FIFO_LENGTH, false); data->fifo_mode =3D 0; bmc150_accel_fifo_set_mode(data); =20 -out: - mutex_unlock(&data->mutex); - return 0; } =20 --=20 2.53.0 From nobody Tue Apr 7 07:32:09 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0114933066A for ; Sat, 14 Mar 2026 17:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508037; cv=none; b=l/OX/TCQlQ1YVjFwiXVjPlx/hw2mx0Kddixb4aHDvVHSyE4M3sJvF14pnS8trFYscOPy+d8SWcD4MEEDqX6XhqXGn2u6lX+UC6nACQmHL0SS2j0Dv1pJljWAK+6kTvEOzb9fv4a0lNl2OaQc/Lglme7InQlDPwuGZ49mCBKm7OA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508037; c=relaxed/simple; bh=WjaDMGSZe9UYhGr/JU0UvpxZ+V3tph9q5anJ+xy2UFQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rMdvntGR2dEMqtAbtxvb+xQKCpPssVeiNkX0NtSaxJC9Ar4+xrP4uunBqLUw7nVzLfLdhntnNrBM5jHBn0ZOvX3z7ql5KTe56YLE+yoYIRDbvETQ1lTCh6IjC5L4suaj4hZMqfeOEhLvhPX9oCOpvSX3bB9aLuuErKkx4/azzeE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F112dR5J; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F112dR5J" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-35a1749728dso1145141a91.2 for ; Sat, 14 Mar 2026 10:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773508034; x=1774112834; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uhlr9nT/SHch836dV6HJr/QlJmVXAVlUY7mUE3f0unI=; b=F112dR5JDrS10ZOAF0Te5maN4JkM0xjrGghuJih0LoH3m3k2ZinTNlrJwXUYzeglSK HxZ0npfdam9sNt4fYqEATC3AwHn72TlY7TLPL806Cr85vHWDuzFcVBEi9Ul49KjS3yRF CNc/fTLxSAXcDVGZr0SlPi/b77sseyLI77mcYXI4hdmAFWxNEsy+SkgUb0q91x/wCDEC 3ABzqgt+vMViSn53OT7QdJo/nMEsVJNJ2cucGYgmiTq2fNIKhXt9uZpxrjALZeMsNlt+ JEm8nUfdMCtW7/DfdwtlewGR5EAeKDxhrPV3NjtbUii+bLmsSCEq9+kdlMZ4WYcPLBKb ZbPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773508034; x=1774112834; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uhlr9nT/SHch836dV6HJr/QlJmVXAVlUY7mUE3f0unI=; b=fpclUMT78rsNzUkVH1gN7GlCHQE6JE3+XqFeSyuIS9+9edyTV9ajUFduFfmuKD+XbT W60KZBjS5D5TlODr/rI7ay/mHP+EpBY0WEPquWIHKTKskuGNE51g+G4FgWwrRE3mfAxQ FMvcC8r3kf/sE7mg0gQ8CMswt5LeJWZOOkExQ7a8HZ67/RCG0M2cQiCgNfTmzgBMATfB Ox16mONbh+gwRIa88K8lESUnFeM4jotaeLrhrpxFTzTECojs+Dx9VpAm+8PlRa6rnPVY 4tgdd5KrIhSit0ekuumxpuTvjsCdxdQiaauTUoW6TYMfuvpeVM0rSqXT3jkryQXb9LQj /Y8A== X-Forwarded-Encrypted: i=1; AJvYcCVGxNr7pqWviZ3Iu8FO8jO6uJr0dXoKmQoLFjzG6dQSdgtfELhnBWr48oxc5cdgb9C4jLPsPdq/GS5E6Zg=@vger.kernel.org X-Gm-Message-State: AOJu0YwtXc/avSs5joxCjyCqYipS6aI+iqUsc7VEbDe0JytSYdk7n0xQ MDdMZ6aXstgv1qBGMGi2f3HLIto3iu6JJuOmisbpcwdZVeYq+YpuMx9U X-Gm-Gg: ATEYQzy5AURdJ6lkexKCNfaFL9KrmHBIg0QL06plVhxb1axQ4+IDhsqq/Dsp1MbZq5c aizj/rX/h+Bv3WiRP0xZPiaoQhQklmO9bpjq370AlhDRtrBt+UyEcI6heZ1NSvzIORaEIefpYPY Zhj4ta0xjx6bifkzVDt8fq6tX6r9AVL4Gl+D7xo3bddfv6TYKlPRo5TRntsF3i0fg0NXfdMpZBK PiHCaYxrAosi35VE1or9d6n35BxDDSPtzQiEibyGbWfEcF7BchT0HlIIm4axOQGYLfmTC63URqv fKzkMQcpanP3tP7Lklz94zTHJLDGdzGAAhwVnEpH/LOvxRFBGHF3ZCG7MCTHss1bRX/KXDVB2fe qOHaCeNA/txmeijabj0JGckWKRvhgJ8S/qUElhGl846RCRv2WJnga0ZdNO05it1ITDEF28b7khF uGApPrAWECX5UeMti5gmFwpHy9sScPIidCqMS11boM0UOSxSa3QGGXylu6+TiDNGc+ruDZCNiB2 +uGDGHrp1WA9V71LPuV3HH3UnE= X-Received: by 2002:a17:90b:4fcd:b0:359:d54:846f with SMTP id 98e67ed59e1d1-35a21e39599mr6486053a91.7.1773508034363; Sat, 14 Mar 2026 10:07:14 -0700 (PDT) Received: from fedora ([2401:4900:8898:a35f:15b4:3058:14c8:4287]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35b90d3f572sm1600116a91.14.2026.03.14.10.07.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 10:07:14 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH v4 3/8] iio: accel: mma8452: sort headers alphabetically Date: Sat, 14 Mar 2026 22:36:04 +0530 Message-ID: <20260314170609.26827-4-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> References: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Rajveer Chaudhari --- v4 : Patch added in v4 --- drivers/iio/accel/mma8452.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 15172ba2972c..79ee4dff0ff6 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -17,22 +17,24 @@ * * TODO: orientation events */ - -#include +#include +#include +#include #include +#include +#include #include -#include +#include + +#include +#include #include #include -#include #include #include #include -#include -#include -#include + #include -#include =20 #define MMA8452_STATUS 0x00 #define MMA8452_STATUS_DRDY (BIT(2) | BIT(1) | BIT(0)) --=20 2.53.0 From nobody Tue Apr 7 07:32:09 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A813B32D0FC for ; Sat, 14 Mar 2026 17:07:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508042; cv=none; b=ktB/h9ZgNwi7M/ZNzSMHfzURQpdhGWT7DofBDn7NSIf8LxQaSUStF9wK/LkSB/yjLHbvwVYHZ+ahrYUqZUzbUiiL3ZQd2QVstxCdmFg4tg91/B6k9ZM3eD3jwuLm7yCnuiMVqB03pE2fXBfq8r1gJ/bWZC+5LspioDoBgNRWE1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508042; c=relaxed/simple; bh=ZMGQz8p+WMx9gntwb21iw9j21CSaitzQfChDCBCMzLY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bQvd+t0OwMymGvAnfay+B7+H0qDgh3DyPpr2mQ/dvEpOS4asz4svUuv2awddlnSrYij10ZVsnkO9LUmXCCBLG+fydvvhPFWto42vAxjqshC6Fs8GN4n9qzIqCsPr9/Aptgkc72qsPnFJdMP882+KnZd4pdtRDnN/qeGzUAa3SmU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UNV6huM9; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UNV6huM9" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-35a08ce49dcso3010249a91.2 for ; Sat, 14 Mar 2026 10:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773508041; x=1774112841; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w1PBY/NwbNLWWh1/jD23nm9avcwnxhc3WMg+rhw5oy8=; b=UNV6huM93WT9PD5iKGfsD6QbyTzQmLb9BFWtUfDhSXKV94YvEFZopEoRwdzFmXXDC8 Lb/h6xaokzO8wy9Z3L4jInZ/K7x03iQoIhUcenEZT3J0qEvAB1eaYjvP9eYkS5udKDgJ AAwMAuickiF3hAxgUyp0WnA1Ezd46eqAh9pQLcFxxgyF4A00NRZl441v2vkwdEkfthMJ 5z4LcRBgUASEAjmndfMo4mUNhZMumiKsOx5bziiUJsAN1UyoUZmKr7E9dAxaS32t2SbY ESdhxnbdwcFvDtf3DD8LGQh/B/t38roAt84e8P7GPhSxYD+08OcjRSWgks0nCrl4/NjS L9Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773508041; x=1774112841; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=w1PBY/NwbNLWWh1/jD23nm9avcwnxhc3WMg+rhw5oy8=; b=fB6jsfqdhi5u0rHEftqJRIPu08i0/r96fbciXHrio56f+tugsd9jPj6K4kGdYEqODM Qpxi1UDjghe0pS2u4Baz3UM+Bkf//XzcYARF5yXZITRlMIafdWqRoP+WZI6vg8pL2G+w AdylCyll2kIkPJ44jK0DCe0xKxHQO59qf3AnNvDkYh7Ch+57eVbNSW/vOs0GWjuRgL2T 8PQ3arvgD4JePI95q8TMOjOMJTwf4CkXQTj/8YQ8oz3TfHc4lbEL0Sn6m0smXthOiWmm eptPh0ygtXBA4emWWSYJwFCcxIC/51n07Ce1vYHJarRSv12LJZZTwGZDv085AXWqDhul T2Iw== X-Forwarded-Encrypted: i=1; AJvYcCX6nf59fTEMcUBi6wZMzghWrdvVOu1X2spTBFo9VaYKUcPCcaRMV3a8c0L/X7ez5km9x8pfRPkVWEhK9DY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxrylw5XlMw5HgZoGF3VZgGa86kv1Omkfv5IM3GKTXjrxsTMlr8 2e7j6w8sMTBYbi8hq3vyc9Blw6MvhBOPmkCbQQDTJPkQVeJftpa6vWgo X-Gm-Gg: ATEYQzy3qyN7T5XxCDk2RrvaPOFU3eHyopVShGWg1YU3ox3g2UWVqfLi+0z7X8P4t0E eDKRSld41Vakrt5xFEOzb6hxJ1KLO1lep9H7RtkFAMvrZHsQxc+h9tIq+w9uYXXd/YpkyVriCil Oa9ATeeKo0ClPhBn+Rd1CbmE1Icm+Z6m++QjaR7kjMvsCHRhZe032c5gA9uCZZ57KPx6gLtw0Y0 PyGIH36sG7oViXtAKfjFCTQV17P2jBR0uaxeqKObQyAgKn2j3aVrpc79JxkBGwkT7Tej2ZptycH 9MXDw6Gfu5028MLERCpCpp6rpcpBze0Qp/9dz1J0/I41reotvtv3Xqg/nyzhm8mBwK58jRtbtAW osCffT08yBtYc7FbIXkPdh0aq8ujFFZ/yl304KiEF8+cP5Frgu3rMRq2OyQpt4mywUQ7dXeBJsV LwVmsf3I2k/d2WwcCZMSJWG0eFCXBE4h13mYLoZ0cnNNOk9k2mIjufa3kxjTZkGJ7WFqH0uoS/W d9RBrlpavoET5/FOROVzyYVZH0= X-Received: by 2002:a17:90a:e710:b0:343:7714:4ca8 with SMTP id 98e67ed59e1d1-35a21f21635mr7388738a91.15.1773508040966; Sat, 14 Mar 2026 10:07:20 -0700 (PDT) Received: from fedora ([2401:4900:8898:a35f:15b4:3058:14c8:4287]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35b90d3f572sm1600116a91.14.2026.03.14.10.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 10:07:20 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH v4 4/8] iio: accel: mma8452: convert to guard(mutex) Date: Sat, 14 Mar 2026 22:36:05 +0530 Message-ID: <20260314170609.26827-5-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> References: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in mma8452_change_config(). This ensures the mutex is released on all return paths and allows returning directly without a goto label. Signed-off-by: Rajveer Chaudhari --- v4: No changes v3 : No changes v2 : Dropped Header alignment change --- drivers/iio/accel/mma8452.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 79ee4dff0ff6..16d9124b844c 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -599,36 +599,30 @@ static int mma8452_change_config(struct mma8452_data = *data, u8 reg, u8 val) int ret; int is_active; =20 - mutex_lock(&data->lock); + guard(mutex)(&data->lock); =20 is_active =3D mma8452_is_active(data); - if (is_active < 0) { - ret =3D is_active; - goto fail; - } + if (is_active < 0) + return is_active; =20 /* config can only be changed when in standby */ if (is_active > 0) { ret =3D mma8452_standby(data); if (ret < 0) - goto fail; + return ret; } =20 ret =3D i2c_smbus_write_byte_data(data->client, reg, val); if (ret < 0) - goto fail; + return ret; =20 if (is_active > 0) { ret =3D mma8452_active(data); if (ret < 0) - goto fail; + return ret; } =20 - ret =3D 0; -fail: - mutex_unlock(&data->lock); - - return ret; + return 0; } =20 static int mma8452_set_power_mode(struct mma8452_data *data, u8 mode) --=20 2.53.0 From nobody Tue Apr 7 07:32:09 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DD2E326938 for ; Sat, 14 Mar 2026 17:07:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508049; cv=none; b=arzXsGZ+45G76pLZxhpb2peItLSQ+r0dFOo0STDKPBN0x3VeC5Evtcbhl5D1qkLeB9wXAJHefS0z5RgmkQVOlIihdwlVT2Hgm1bqM0LYZFExJP08qNuIfAsisbRm3xOKBgDGrHs5A2SgCox4k8i3D40m5WZnRv5VtmnN3D0JeF4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508049; c=relaxed/simple; bh=JO2lgHGjI/H4pkBrT3QY9+E0yEWU3kAxLNo0zyIutmE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C22G0ZPE5Y+8zKgEhKaVaCOZQ7EI32X0eJBMr7LYI9CCS6mWaIEJUu+mMobKquuxubN9IpMYw8tNGEoWOoZFUOv4GbqFyBuqX3/wuk+1yJzAaPV2FUBAHMoO9BZklFkUPf1XXHRhcmI/+84Oy99khPsVLuRsWRp6g7gy2eMk1XA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cli4eewq; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cli4eewq" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-359fea895b5so1844775a91.0 for ; Sat, 14 Mar 2026 10:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773508047; x=1774112847; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GCIZZ83Yc5ssG2jBwGB0tj+l0UN5cE4lj0Bvgi3e/Mc=; b=cli4eewqiHZekJdNWxrAxmPyLcA7m26ylsAgS4YmFK+zS3RRMCpY4srVSK4V+1ns3k xcdDCkB/OIF5JEaqi2uz0Wps2E3GlVq6i0t81sVEaF7v+E5ys/1VqyFLMLQiO6787Hau yJdSDKSgOOYRGlFn7fZHSrHkWB/r8YgSd8WAxDb1s2TxmPlNptzaDPGKQoZHRA10Ej7M xmyzQ1e1o46sLH6B8i14U8R4DKWzVcRKrl3aeowMDj1yuSX1fReGo7GeTFlGB85JDnhG sGzvUWvckK7nkLpPCZwuy2WDkzIjvIFwOC4errWeKq3K3BG4QZXylC5aHRFtJmlCcjB5 HcBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773508047; x=1774112847; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GCIZZ83Yc5ssG2jBwGB0tj+l0UN5cE4lj0Bvgi3e/Mc=; b=n/4N8MT14nrU3u4yH+mvn0GgprE/s/yzsw2sk81+yISQvDHTRTfkZTs1AVfY0j5EEs F8o4YWd8IxkoEQCkovMG4lS8VTd5yiaguqOAkKPPb7Lo+IwcuxQxMRFG2oRLHoyW++xQ joP8BiCyyPgn/P3A4b3irBLS9hcQ4luAbi87F2sGP5m1T/3n1XCESrqHADtO2Vu+J75l soBoDjAuEsh/ibzoWjSIBvPNoYnpSIYGLp3QoC+5EwA7mwff4Y2PZX7X+FBwbWPKk2Lf QB0KYJeJ+hBGQ8zZENNYALMcVvc+mkp1uielAa9wE+Nl8aqjcA3kax8raYRKic9hGA1C tFiA== X-Forwarded-Encrypted: i=1; AJvYcCUHU7KkFajETg/NT0sUl318yHtthDwtbhK4IOgS0nQLNY/Sra7K/W3FAq06THM1fWJfN0snR44rbPnQfZk=@vger.kernel.org X-Gm-Message-State: AOJu0YxNLHlQ6h85MmpmL1nfIP8pfpOkjDKRNOfYLm5MXRkrS3VJ5ouJ umB/0DZv4FCvHlJHNerNvipcl20iPMPKhZQHJb7c7CtuOWL1yTRoskad X-Gm-Gg: ATEYQzx24QLiAwIbnIZcy+5KAubNgIuTTizTpqbZKA0G8n5LWeeVds3Fc+vpSGkGFwW pEjg8LxDa0k0q3h+Rs/cjoTawZDWt4SwqcfM6gMufDzTJmVgpLU97MREAesJZk/ggRLyFuHBLOZ viIKdBX/iYyPOr9nQaAm/CzM/PGk8lRYu8KUcpjM0QpgDXE4jGetbOemFqAJSjQ0PSKCMQg2qC8 YDqkp8cvSLz072jw1BgOYe/bO9k38u+pBN4Vxwh/vAGJUKWcbFGpm/S14xNa/lmXtagHBOLYmsx t9lWIFDxs/ZptZew8wGrU+wafFYw25sDiBTIP80yZcIPwmEY/VDjaQVsmnUAwjNLR3Ly9aVudaI l4hbSIqxxZ07FVa3U4YOjAOp5wvpT6y2p0ihYQJvAoYcqXUq98FTKVPHf4wIos+JisVxZfr5ZH2 p/BY5CuLQpjThhuR1S5DBp3mhRWta6KnrLLYgedv0lYm0mzlXGWZ5P4SI9rnzsASm+BzmvaugJm 4ujy8e4+pG8Hz6oH2hDI06ix2E= X-Received: by 2002:a17:90a:e7d0:b0:359:ff8a:ee46 with SMTP id 98e67ed59e1d1-35a21e30c55mr7411173a91.3.1773508047470; Sat, 14 Mar 2026 10:07:27 -0700 (PDT) Received: from fedora ([2401:4900:8898:a35f:15b4:3058:14c8:4287]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35b90d3f572sm1600116a91.14.2026.03.14.10.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 10:07:27 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH v4 5/8] iio: accel: mma9551: sort headers alphabetically Date: Sat, 14 Mar 2026 22:36:06 +0530 Message-ID: <20260314170609.26827-6-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> References: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Rajveer Chaudhari --- v4: Patch added in v4 --- drivers/iio/accel/mma9551.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c index 02195deada49..31e5c3699c19 100644 --- a/drivers/iio/accel/mma9551.c +++ b/drivers/iio/accel/mma9551.c @@ -4,17 +4,21 @@ * Copyright (c) 2014, Intel Corporation. */ =20 +#include +#include #include #include #include #include +#include #include -#include + #include + +#include #include #include -#include -#include + #include "mma9551_core.h" =20 #define MMA9551_GPIO_COUNT 4 --=20 2.53.0 From nobody Tue Apr 7 07:32:09 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D485132E12E for ; Sat, 14 Mar 2026 17:07:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508055; cv=none; b=P75jnouRwDRp7LXZTQEzZvAKJbZ2tPMxUoAM4XpmbRpgcRSMlXiEh03fk2/m3zMkSvLlvKt+i/8jdKAmW05cg20eblucjs8wfCUEIaYZvCI/H1wznzH858WjhEwPJlE5Sli50BXi8+BS0uLGOSB3yzHO54M4eTe+vcLPk7IZ1Aw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508055; c=relaxed/simple; bh=yrd9gnH4G4XboAvtH3+r2nhqv/wL64oMNG1tqzjyoYM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pCqL0WN2Widw66gmoJoxq6OwRPxN8/++954jKDlGiG6wq5OyrDsJz7D1v+RupMBMKPr+fLuuiV5CAiB7t8kx+HZWHkkn0mnfPIyODfWINUsC3Nz5xDbWKiPocRPrQhqtJCBy6JAR00JJVpgbtGnPGJgG4xq4dbBOg2SVBH212JE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aCnvGKGu; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aCnvGKGu" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3590042fa8eso2096528a91.1 for ; Sat, 14 Mar 2026 10:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773508054; x=1774112854; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yddq5l/1nbJ4rOJNrryOQK4alZgEnsRtcdvwC6K0IHU=; b=aCnvGKGu23RK5IeczwngLAIVKbnJXWmua7pFW6+4QGT/tFRfRZCoPbCe9KIXsTLThT Rm9mURvvu67SDF+F75GBZzcP1iyvxjHUPvACGlbi3ho1RXiE/A0AT9tqz0YJsgT/tP5U mHNfCBwk4T21EzSZIjm6zs9kVAWjNgcmvNn9SeMxKXiVzredI719ofABUornruj/SXtw yBO77gl3ne5vimllFpS5NzzCO+oI6USnee2u5t4+LubOnic9xSLvrMAlD86NE27gfdj6 DY0LXyzCHwFVJEgmziDGR6ulw14aN5lyUjTcfpNbsOqp6/zE3Mhk7zlMYiVcty8UJMOv lhdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773508054; x=1774112854; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yddq5l/1nbJ4rOJNrryOQK4alZgEnsRtcdvwC6K0IHU=; b=F5mWzbdhCBJlBOR8kGn7AKzvWgG/s5BukQ17Uj6z0mSzHIEkrPCt1yKDaed5Ls7Xmo mPTlrhiIdwvDJEUrKYtMy7cSP2tdeLfgFpTxj9HtAna9IVV9MgFo0oxgMwMOi8sr4iD7 c6nH9zij9bBWor7Ee/NN33TY5ZniVIj87JBxYxCCwvZ5y1+42yjz6tcE0llZCihyNjWm d4W9Vh426Q57t7dcNX2m/dLhPdoNI9KTCAGeWZouI2M4hBxE+NB6ugLcrgjmg/G9hHJn Y2iVBS7roy1/91JHVwiFIaeYUgYMn3w2hARs7f2CPEDN3/OzgdR88uOY8+CdObNp/tWs fZ3A== X-Forwarded-Encrypted: i=1; AJvYcCWxymuoYDHllDX0Ezk7uMHJJje4Jnb2koZI0pzoYijKaL9iVCBxH8OAxlusxw9AQAjvU2T4tWCgl1eCKaI=@vger.kernel.org X-Gm-Message-State: AOJu0YwYxjlVodOPAo97npXbXr2heuS9a1IH4rPxYK2HjLMl/Wv3zRnQ 1K6pAJIaKC0KwVlzW7GHiTbZ3Ay9jnsvYZPhVLNlLgtD+b8NEYT6BphF X-Gm-Gg: ATEYQzzDoDhkzbhue0bG07MgRsPXSAFVRbGXudkjC3bLBc7NpzDGbKZYvG46SIAJ9FA Nbw1WNLikBFXD+5DUAwWRBMTpQDpHvTmZ8GcbwV+fY+N+EeitfA0lezQG2rmXWr3PLcZi4rC/Gx 7o5NyzN0QgypnvyY/IgjjwZItHrmizPJl0hdEH/7ilZDIpHoBJWgbdnE78+7mzBjtHjrRKVntX8 pi1H6J7giP+HSjowYfK3ODtja/dYG2xW39Yfp+HRSQnkPul3M/4Eqezr0f7f5R8u45tpIbhoKok ZmuRV985j14GF5zFQSrAZvRvoHSTcrIr0eBvjmpIbPWabpdDDuaZc3kR2gqdmE4bDg67E4zwmZK x7sRBkTIibsXCjKZuZ7U0gfZRQcTM6jY4u8cNa6ukH0nZbtoZBeVaKRqy35hsx8IRKSS9Tw3dbT B86fLXPCtsXcZeDHhH/tyelS8sSRPrfNE4/+Wwenr/iA5Df4ZZ+v8UGMjav5HdE4p77L/vZ2hEd pfCUptBHavTtVA6vZ4zMjbnC+o= X-Received: by 2002:a17:90b:35c3:b0:359:9cb8:db5 with SMTP id 98e67ed59e1d1-35a2200d7bamr6243213a91.26.1773508054194; Sat, 14 Mar 2026 10:07:34 -0700 (PDT) Received: from fedora ([2401:4900:8898:a35f:15b4:3058:14c8:4287]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35b90d3f572sm1600116a91.14.2026.03.14.10.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 10:07:33 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH v4 6/8] iio: accel: mma9551: convert to guard(mutex) Date: Sat, 14 Mar 2026 22:36:07 +0530 Message-ID: <20260314170609.26827-7-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> References: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in mma9551_event_handler(). This ensures the mutex is released on all return paths and allows returning directly without a goto label. Signed-off-by: Rajveer Chaudhari --- v4: No Changes v3: No Changes v2: Dropped Header alignment change --- drivers/iio/accel/mma9551.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c index 31e5c3699c19..0936b148e424 100644 --- a/drivers/iio/accel/mma9551.c +++ b/drivers/iio/accel/mma9551.c @@ -341,7 +341,7 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) u16 reg; u8 val; =20 - mutex_lock(&data->mutex); + guard(mutex)(&data->mutex); =20 for (i =3D 0; i < 3; i++) if (irq =3D=3D data->irqs[i]) { @@ -353,7 +353,7 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) /* IRQ was triggered on 4th line, which we don't use. */ dev_warn(&data->client->dev, "irq triggered on unused line %d\n", data->irqs[3]); - goto out; + return IRQ_HANDLED; } =20 switch (mma_axis) { @@ -377,7 +377,7 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) if (ret < 0) { dev_err(&data->client->dev, "error %d reading tilt register in IRQ\n", ret); - goto out; + return IRQ_HANDLED; } =20 iio_push_event(indio_dev, @@ -385,9 +385,6 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) IIO_EV_TYPE_ROC, IIO_EV_DIR_RISING), iio_get_time_ns(indio_dev)); =20 -out: - mutex_unlock(&data->mutex); - return IRQ_HANDLED; } =20 --=20 2.53.0 From nobody Tue Apr 7 07:32:09 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F70231B130 for ; Sat, 14 Mar 2026 17:07:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508062; cv=none; b=AS1HCstGdfQRzJSrzWba/pFRGBdj6MsXKKi8bbDl9AwmQrWcJYcc9rVOJPDkp3YqDdPNTGLEikmIaAIPO1trlTn3EX0yBXJDz6sgQAiroSBC4hsbQ6OWEm1z27xeGFohiPGjiI2G+Le1YlQ6MLs2CQ19AwoY8YWEneW9oYEUprc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508062; c=relaxed/simple; bh=Am4lh1Jkyp+tYV4F7zMTQJq7dkOHk6gWF/drmH2DpPM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ScCLwSRAYz9srReI5kN9BhhCaVqDbBiUJMDWVqIOzcRoxA4XFGAHapAGW4XYuykCkpVnPvmfiL5NglKdNkfbO0Q6CdtirsjYdLUN6uM/1h5Zb8GeyO0RcGyd0u+x+PMIj7kQuzNI1njCPrZkqu0q7poghy/uyIDAs/COYOca8B4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eljtXVn7; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eljtXVn7" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-35a09e0dd63so3420181a91.3 for ; Sat, 14 Mar 2026 10:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773508061; x=1774112861; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VZ+pX53j5zcNZgACPR+XlfPgVgurc7IbtYHecyELLbQ=; b=eljtXVn7JtY8D6IjU8Cf/AYLi8huMpqqzyzgHs/mQJjaiVb8p7gw4wFOr8s+Iy2fDQ zTEnnpjEEllbFuRgbDb80sIwu+2eqBzQd1XDYgTAikb+h4tjTGH8wrnUeZD+HKspLUwM E9bnKjEand08vuPoCxIbF9cLAl0FCaNayEdXFijY/O0qJ7cbjnkN5kErxcH2woCyqNpH sk/IRl+NQJdGAG1DY39Pj+g1rysiTjDFPKJSUtIs8LHGnEWIdKpznIV9nKcblgbXd3MF obYRmVfRmFLsqcfwGWWH+Mtdnobd0pznb1b0qIbCG2YE3qQO8kPCSUNA7o1jvvIC/ps7 D1Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773508061; x=1774112861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VZ+pX53j5zcNZgACPR+XlfPgVgurc7IbtYHecyELLbQ=; b=AETAlvbzzVZ1X8Gr6ktGo7qhDUat7+j8Rsw3V0mzEk3E7/eDXNLjeQEcKdZA+oKPJg buGZcNHj7lPdkxUkSmywjbpNcV+f3QXrkXrRpRUmSDDjy7P7uc3uc7BB2eddknsgl9bs ekPFh+jYh6Dr7hWaFJiQIZZl9IEhZmqjhXPw3phIn2BXvq7bAEyJVUm+RnzlkNsO4l9D Pkr3btiIFEcuxYhZFcIhZrWbw7oF4tbNHdHSMbtAIVtS6d34lqvQP+A83TCo0ywlRTx2 bTrX+PZJE6vHHyJ4eOP+ii2gMFqt1wKBRp6dwGCEUFVvFIehR78nv9qMLn8+lyzDMehP DgHA== X-Forwarded-Encrypted: i=1; AJvYcCX0tMXmULBPzv59P69qVlR2gqp0AXoDZ7vyO/hUEVdFkMZD/N04iHBWUmQtFIFp0st5L8wgCd7in5ScOPM=@vger.kernel.org X-Gm-Message-State: AOJu0YwqgzNAvQrIUXtC+Wvb1fEcezyjRO5FRR6a40XU/cCuy4UIFteS +oEaEWufEo6Db8muZBx8aCyAjfFL2PADjUoOv2sdrcXSHug2TsQ0Y8SW X-Gm-Gg: ATEYQzzO/pfB2AxHf1nI20920rvQBrKGTZoDegtUBzyDw3t4wjksNKM2nBSTag+yKkp n65/41vCd2BnAI7tTTB7eBLV3LUqnu1RnPbgwYDAeBuL9J25lup+K700HUCC2n5BwOGBGS4rrn1 gEX7dIIfdG30Ymy6K6tj7eR3i1kEmHNcr00qdzg/SmgDpaWVKCPafVmt0rLWcC2uzq5cPWeVU73 5woRvdhcM59U8Ob6Z4gKu7efpQ0D0IBpQfU4Rnl2tlLab6Eovl/7ee8+ujkfcCOsZLVk3f8ZXno BIXk5SYnf34NjSd9Ijv4QCNEUGaJab5VdIV/SZQ4fFq/cZ5X7EWZY84T2INVEpIwLSsKjUrGMCn /tSs27PPgj5SNJMq7B02aKjYZ8rX3URHN7pbvsn3HmdL9VfNxSjdQw84QShw81sqeI4dFDgzLi5 yRrePHBYgIF1ZaXW1CliN0PSuNo+aq0GL5onQa9ivLSOtYA2YqCS3IyPvTM3ajYR66umWPnvpvf JDh53icT8WMAm1loFrAkQb6bs4= X-Received: by 2002:a17:90b:3d83:b0:35b:8d89:719b with SMTP id 98e67ed59e1d1-35b8d89818emr1893009a91.1.1773508060828; Sat, 14 Mar 2026 10:07:40 -0700 (PDT) Received: from fedora ([2401:4900:8898:a35f:15b4:3058:14c8:4287]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35b90d3f572sm1600116a91.14.2026.03.14.10.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 10:07:40 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH v4 7/8] iio: accel: sca3000: sort headers alphabetically Date: Sat, 14 Mar 2026 22:36:08 +0530 Message-ID: <20260314170609.26827-8-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> References: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Rajveer Chaudhari --- v4: Patch added in v4 --- drivers/iio/accel/sca3000.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index 4a827be439a2..d61ad12aef78 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -7,20 +7,23 @@ * See industrialio/accels/sca3000.h for comments. */ =20 -#include -#include +#include #include -#include +#include +#include #include -#include -#include #include +#include +#include #include -#include -#include -#include + #include +#include +#include #include +#include + +#include =20 #define SCA3000_WRITE_REG(a) (((a) << 2) | 0x02) #define SCA3000_READ_REG(a) ((a) << 2) --=20 2.53.0 From nobody Tue Apr 7 07:32:09 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9375332AAC6 for ; Sat, 14 Mar 2026 17:07:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508069; cv=none; b=ecgempZrmb/q1J4M1/BwEXct+oPw2VDcU3ThEVqmnZqY5PqzY4KwGc2/fRQLyHBO1YBvG68w+FMa4LRG3z/NyEJ+1S4I1mUojV9AAIorYi4t0xhtDxSoGE+WIAQ2gGPD9uGE7sXXzls6EjAatZD9bLv8SLZHuFmkd86H8/UkcL0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773508069; c=relaxed/simple; bh=8HKw6n+cbamGQ4Fh1uNgeACj3DQHV9YloVHoTMkY6gw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GOemlbOTLmP64EIzgYhbgY+NBLiVUc4eanwp1fP3AJVB8GztBc+ZScmFb2sHGvWnjlrKp+XzV884Bu7E6QgBI9tHqb/5HW3/KoCimTVLCk/wrO2zDlItNNRVlQ7/Sz2e5UEYI8asg+bafjjDPV2mnf3AqqYjgOgFJw3JpICG+vA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cHeUZUR4; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cHeUZUR4" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-3590042fa8eso2096642a91.1 for ; Sat, 14 Mar 2026 10:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773508068; x=1774112868; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ywcmhQpDRW7pbrfJlNQkDkYjY/lD8dZ1Tgs0xdfUCKs=; b=cHeUZUR4CI3R9WscDvbjO/FD66Xzdl3cT8ZSWX87J+qpBhDX/muWLSZJjsPEuScFXK h0AqChsDIxfwsIz3+jv9xmDXyGmPLWLftQaMYuEbkcEm91YgI2a9yrMKgG+ebYoALbOO GkrVbMWCXvzI7PnPP4AOJ/aVz0uF/TrPrRAHnvnjVXDreZTXQbHIsxIOS1KrQ6Ko8iMq hEU7CPdF97twGVE8S0wWnZdZRTjq9nt6k6FVqJyDxyg+y8h4na5luYlGhZ5GBxjJQSGd Vkak6dYZAxZE7RzSdrSNRPjo+cxmGDQbGstdKt9/jT8TJp8RGMFut9CeVL8jeZ0JUZeE 1CrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773508068; x=1774112868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ywcmhQpDRW7pbrfJlNQkDkYjY/lD8dZ1Tgs0xdfUCKs=; b=X4npaOpUWjeYJNOhGlGrY+Nu0W7/UyQNMlyYG0YyJg7XKsGJNXu9FiuVfe4HS3Kw/M /lea2t4ogGhraAK8161mi456KpF1+Ba2mhN9Y3C9xkqOCCmzdlhXgyMmcqIr9mkJsjNx 0R1DehZ/ybCH56FidiK8uz83NIC6VeiuraezJihfOVsEdYqyYMxlGLqstyk+4DH4SOXp CCGuHNu1ryrL4p3SdFbdGLfgRxodG/ujd6WVa8HV0Nd5XW2mS50ZIBfnakUt8dA+9FAK 59KwpooulrFQ/Ft4JG1xFin2ENlN+VAH7gji7R24TH2jVGZSMKhZZKVsHjRGUpvQxuYj DFOQ== X-Forwarded-Encrypted: i=1; AJvYcCUEduKZWoz+sfCu1AW/zJ4EfGwjnVzdnCKMrVtJEPtWZMP0WL4CvaBguCdjEmJBI6FDyW91jBBcmDtRHOo=@vger.kernel.org X-Gm-Message-State: AOJu0YwEut0423b129sXJNopVXBe5RimNVl48xMh0GmVULK5mkQe39Ro t8KrtO96tht01+aXPcf+ZkIqITPbMeyENjXTw3UZzBZRq/9wMmhlZc1r X-Gm-Gg: ATEYQzx2TqGyWO2ks5l2T31FL8FM7+jjZ43zHRhkQY8aEgC9jIOpBgEUrYpxeq42B2S clfct8fLPB2XDHqFXVWwA2SR7aHH4j1fGlALPn3LVHMAqMH+PJ+XyMSQKURWBh4Zbc9oMdVABkK kicZl0sRMap+m7Ui930ZWOvhe7khB2fds7xi+LZDbRsQ4H9ahBogzEe67vW46RDKDG02VcQNIhC 58Dkc1VpImuRToXoQFZDF+yrQnja0nbxd2fEzVur714mn7zbgx01qdX8Auje0kG2XuuUp9ruN7e VNsj4rMdTWUjlG7DEOYIzzaMQekFS7WPuc0rBRfJets6OcYzfhfcEqpkCZKzF+6lWrt1YEg71F4 iFAc5O6ADhtS0wfvkNZjZwWsOTa84WLaoX+TSbWhC3NY+xybrIzEFzD/RJDF7ER9NWV6g37meyt GhFynQKmSWifZxPfdmEM6tYuv6Za8YZHz98WR0F1DtFc8UYgm55bTIVOH5xdIOoOLw+65xNOVMZ 8CDpJA24+YZW2lYqrWGvg5YL/s= X-Received: by 2002:a17:90b:390a:b0:356:2eff:df05 with SMTP id 98e67ed59e1d1-35a21fc5cf1mr6931834a91.16.1773508067935; Sat, 14 Mar 2026 10:07:47 -0700 (PDT) Received: from fedora ([2401:4900:8898:a35f:15b4:3058:14c8:4287]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35b90d3f572sm1600116a91.14.2026.03.14.10.07.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 10:07:47 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH v4 8/8] iio: accel: sca3000: convert to guard(mutex) Date: Sat, 14 Mar 2026 22:36:09 +0530 Message-ID: <20260314170609.26827-9-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> References: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in sca3000_print_rev(), sca3000_ring_int_process(), sca3000_read_event_config(), __sca3000_hw_ring_state_set(), sca3000_hw_ring_preenable(), sca3000_hw_ring_postdisable(), sca3000_clean_setup(), sca3000_stop_all_interrupts(). This ensures the mutex is released on all return paths and allows returning directly without a goto label. Signed-off-by: Rajveer Chaudhari --- v4: No changes v3: Fixed return statements to make it clear about good/error path. Removed Not necessary return statement in sca3000_read_event_config(). Dropped else statement to reduce indent of the code in sca3000_read_event_config. Fixed indentation. v2: Dropped Header alignment change --- drivers/iio/accel/sca3000.c | 138 +++++++++++++++--------------------- 1 file changed, 59 insertions(+), 79 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index d61ad12aef78..9703946f133d 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -427,18 +427,18 @@ static int sca3000_print_rev(struct iio_dev *indio_de= v) int ret; struct sca3000_state *st =3D iio_priv(indio_dev); =20 - mutex_lock(&st->lock); + guard(mutex)(&st->lock); + ret =3D sca3000_read_data_short(st, SCA3000_REG_REVID_ADDR, 1); if (ret < 0) - goto error_ret; + return ret; + dev_info(&indio_dev->dev, "sca3000 revision major=3D%lu, minor=3D%lu\n", st->rx[0] & SCA3000_REG_REVID_MAJOR_MASK, st->rx[0] & SCA3000_REG_REVID_MINOR_MASK); -error_ret: - mutex_unlock(&st->lock); =20 - return ret; + return 0; } =20 static ssize_t @@ -999,13 +999,14 @@ static void sca3000_ring_int_process(u8 val, struct i= io_dev *indio_dev) struct sca3000_state *st =3D iio_priv(indio_dev); int ret, i, num_available; =20 - mutex_lock(&st->lock); + guard(mutex)(&st->lock); =20 if (val & SCA3000_REG_INT_STATUS_HALF) { ret =3D sca3000_read_data_short(st, SCA3000_REG_BUF_COUNT_ADDR, 1); if (ret) - goto error_ret; + return; + num_available =3D st->rx[0]; /* * num_available is the total number of samples available @@ -1014,7 +1015,8 @@ static void sca3000_ring_int_process(u8 val, struct i= io_dev *indio_dev) ret =3D sca3000_read_data(st, SCA3000_REG_RING_OUT_ADDR, st->rx, num_available * 2); if (ret) - goto error_ret; + return; + for (i =3D 0; i < num_available / 3; i++) { /* * Dirty hack to cover for 11 bit in fifo, 13 bit @@ -1026,8 +1028,6 @@ static void sca3000_ring_int_process(u8 val, struct i= io_dev *indio_dev) iio_push_to_buffers(indio_dev, st->rx + i * 3 * 2); } } -error_ret: - mutex_unlock(&st->lock); } =20 /** @@ -1113,16 +1113,15 @@ static int sca3000_read_event_config(struct iio_dev= *indio_dev, struct sca3000_state *st =3D iio_priv(indio_dev); int ret; /* read current value of mode register */ - mutex_lock(&st->lock); + guard(mutex)(&st->lock); =20 ret =3D sca3000_read_data_short(st, SCA3000_REG_MODE_ADDR, 1); if (ret) - goto error_ret; + return ret; =20 switch (chan->channel2) { case IIO_MOD_X_AND_Y_AND_Z: - ret =3D !!(st->rx[0] & SCA3000_REG_MODE_FREE_FALL_DETECT); - break; + return !!(st->rx[0] & SCA3000_REG_MODE_FREE_FALL_DETECT); case IIO_MOD_X: case IIO_MOD_Y: case IIO_MOD_Z: @@ -1132,24 +1131,18 @@ static int sca3000_read_event_config(struct iio_dev= *indio_dev, */ if ((st->rx[0] & SCA3000_REG_MODE_MODE_MASK) !=3D SCA3000_REG_MODE_MEAS_MODE_MOT_DET) { - ret =3D 0; - } else { - ret =3D sca3000_read_ctrl_reg(st, - SCA3000_REG_CTRL_SEL_MD_CTRL); - if (ret < 0) - goto error_ret; - /* only supporting logical or's for now */ - ret =3D !!(ret & sca3000_addresses[chan->address][2]); + return 0; } - break; + + ret =3D sca3000_read_ctrl_reg(st, + SCA3000_REG_CTRL_SEL_MD_CTRL); + if (ret < 0) + return ret; + /* only supporting logical or's for now */ + return !!(ret & sca3000_addresses[chan->address][2]); default: - ret =3D -EINVAL; + return -EINVAL; } - -error_ret: - mutex_unlock(&st->lock); - - return ret; } =20 static int sca3000_freefall_set_state(struct iio_dev *indio_dev, bool stat= e) @@ -1280,23 +1273,21 @@ int __sca3000_hw_ring_state_set(struct iio_dev *ind= io_dev, bool state) struct sca3000_state *st =3D iio_priv(indio_dev); int ret; =20 - mutex_lock(&st->lock); + guard(mutex)(&st->lock); + ret =3D sca3000_read_data_short(st, SCA3000_REG_MODE_ADDR, 1); if (ret) - goto error_ret; + return ret; + if (state) { dev_info(&indio_dev->dev, "supposedly enabling ring buffer\n"); - ret =3D sca3000_write_reg(st, + return sca3000_write_reg(st, SCA3000_REG_MODE_ADDR, (st->rx[0] | SCA3000_REG_MODE_RING_BUF_ENABLE)); } else - ret =3D sca3000_write_reg(st, + return sca3000_write_reg(st, SCA3000_REG_MODE_ADDR, (st->rx[0] & ~SCA3000_REG_MODE_RING_BUF_ENABLE)); -error_ret: - mutex_unlock(&st->lock); - - return ret; } =20 /** @@ -1313,26 +1304,20 @@ static int sca3000_hw_ring_preenable(struct iio_dev= *indio_dev) int ret; struct sca3000_state *st =3D iio_priv(indio_dev); =20 - mutex_lock(&st->lock); + guard(mutex)(&st->lock); =20 /* Enable the 50% full interrupt */ ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1); if (ret) - goto error_unlock; + return ret; + ret =3D sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, st->rx[0] | SCA3000_REG_INT_MASK_RING_HALF); if (ret) - goto error_unlock; - - mutex_unlock(&st->lock); + return ret; =20 return __sca3000_hw_ring_state_set(indio_dev, 1); - -error_unlock: - mutex_unlock(&st->lock); - - return ret; } =20 static int sca3000_hw_ring_postdisable(struct iio_dev *indio_dev) @@ -1345,17 +1330,15 @@ static int sca3000_hw_ring_postdisable(struct iio_d= ev *indio_dev) return ret; =20 /* Disable the 50% full interrupt */ - mutex_lock(&st->lock); + guard(mutex)(&st->lock); =20 ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1); if (ret) - goto unlock; - ret =3D sca3000_write_reg(st, - SCA3000_REG_INT_MASK_ADDR, - st->rx[0] & ~SCA3000_REG_INT_MASK_RING_HALF); -unlock: - mutex_unlock(&st->lock); - return ret; + return ret; + + return sca3000_write_reg(st, + SCA3000_REG_INT_MASK_ADDR, + st->rx[0] & ~SCA3000_REG_INT_MASK_RING_HALF); } =20 static const struct iio_buffer_setup_ops sca3000_ring_setup_ops =3D { @@ -1375,25 +1358,26 @@ static int sca3000_clean_setup(struct sca3000_state= *st) { int ret; =20 - mutex_lock(&st->lock); + guard(mutex)(&st->lock); + /* Ensure all interrupts have been acknowledged */ ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_STATUS_ADDR, 1); if (ret) - goto error_ret; + return ret; =20 /* Turn off all motion detection channels */ ret =3D sca3000_read_ctrl_reg(st, SCA3000_REG_CTRL_SEL_MD_CTRL); if (ret < 0) - goto error_ret; + return ret; ret =3D sca3000_write_ctrl_reg(st, SCA3000_REG_CTRL_SEL_MD_CTRL, ret & SCA3000_MD_CTRL_PROT_MASK); if (ret) - goto error_ret; + return ret; =20 /* Disable ring buffer */ ret =3D sca3000_read_ctrl_reg(st, SCA3000_REG_CTRL_SEL_OUT_CTRL); if (ret < 0) - goto error_ret; + return ret; ret =3D sca3000_write_ctrl_reg(st, SCA3000_REG_CTRL_SEL_OUT_CTRL, (ret & SCA3000_REG_OUT_CTRL_PROT_MASK) | SCA3000_REG_OUT_CTRL_BUF_X_EN @@ -1401,17 +1385,17 @@ static int sca3000_clean_setup(struct sca3000_state= *st) | SCA3000_REG_OUT_CTRL_BUF_Z_EN | SCA3000_REG_OUT_CTRL_BUF_DIV_4); if (ret) - goto error_ret; + return ret; /* Enable interrupts, relevant to mode and set up as active low */ ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1); if (ret) - goto error_ret; + return ret; ret =3D sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, (ret & SCA3000_REG_INT_MASK_PROT_MASK) | SCA3000_REG_INT_MASK_ACTIVE_LOW); if (ret) - goto error_ret; + return ret; /* * Select normal measurement mode, free fall off, ring off * Ring in 12 bit mode - it is fine to overwrite reserved bits 3,5 @@ -1419,13 +1403,10 @@ static int sca3000_clean_setup(struct sca3000_state= *st) */ ret =3D sca3000_read_data_short(st, SCA3000_REG_MODE_ADDR, 1); if (ret) - goto error_ret; - ret =3D sca3000_write_reg(st, SCA3000_REG_MODE_ADDR, - (st->rx[0] & SCA3000_MODE_PROT_MASK)); + return ret; =20 -error_ret: - mutex_unlock(&st->lock); - return ret; + return sca3000_write_reg(st, SCA3000_REG_MODE_ADDR, + (st->rx[0] & SCA3000_MODE_PROT_MASK)); } =20 static const struct iio_info sca3000_info =3D { @@ -1507,18 +1488,17 @@ static int sca3000_stop_all_interrupts(struct sca30= 00_state *st) { int ret; =20 - mutex_lock(&st->lock); + guard(mutex)(&st->lock); + ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1); if (ret) - goto error_ret; - ret =3D sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, - (st->rx[0] & - ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | - SCA3000_REG_INT_MASK_RING_HALF | - SCA3000_REG_INT_MASK_ALL_INTS))); -error_ret: - mutex_unlock(&st->lock); - return ret; + return ret; + + return sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, + (st->rx[0] & + ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | + SCA3000_REG_INT_MASK_RING_HALF | + SCA3000_REG_INT_MASK_ALL_INTS))); } =20 static void sca3000_remove(struct spi_device *spi) --=20 2.53.0