From nobody Tue Apr 7 08:09:55 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4561926A0B9 for ; Sat, 14 Mar 2026 17:23:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773509013; cv=none; b=ceH0xMs11RBNWZW4U5rjuOS+jw1iIQx5F9g4MjVz3bBKE7aM9DazzmODt5C8Ot/PJwpJ7+G+EneIhb0tl9dRSbdjzjVeAcwxoqnmLTkbWF9h1gy218cPV9HkwLyiQo157mzJuoeMpsytuRtWXvdWOdwHrxUDLv8HvQXIDrOyY5o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773509013; c=relaxed/simple; bh=E0BUSPyjgvb1LseqcpTygrrSN2Z3lVaqAZT7C4kGJ4g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=J4Wzx/Dsor/BtaCcwEiqLB/bKY407McTXVal2BhT+JPZ+rwptkhSGwoUsdJNpHABAXKBvK5mQRANR/Pr5lwuo+763GnT6/jI15BXZqG6niwpKBJuF/qRYXuJ/56M4Dx/0H16rX38naeRnBaRggOQQfwIzloL70S7xLrX9Uk3OCw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YL807FJt; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YL807FJt" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-82748257f5fso2473216b3a.1 for ; Sat, 14 Mar 2026 10:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773509012; x=1774113812; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0Mtq4YyuwAPG+UVpZn2Qzh0Sv/d17ajCZRJYRYNkeEU=; b=YL807FJtTnPnL6afnSMcX5FmJlcZqSGK0yTRt6QZX0Wo2jzhbwicUontGqd0WoQNQh MJUfPBiPfQeUyKRAe8mRi3XRdtQAr2QoDHXmxLOkhiB5p326ROuU3EcWWKSvaqemsRRT XCv0bGTGub1/DkoV32sB/Bj+YKHtlfGdMiUXIDMM47YVoPiSOeUfpaZvkV+tbusreh5m VoCQ+LhyNaopprxCflqHL9/QcdqZHooGhCyZ9zdb2QiH1Y98DpcJ0iiZ92bOwNM41PK9 texyjFix95q7dK41LOeG6vi+kAy7DYP0/7YbVTJ0UiDR5Oc+UOr4uSVaB6nif00pT4ga fnIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773509012; x=1774113812; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0Mtq4YyuwAPG+UVpZn2Qzh0Sv/d17ajCZRJYRYNkeEU=; b=Xfknc8jPNJJiERGahnLlvtXS+5q0p5fcA2Lxpbd8/UXMiPFjOhLgn14g/rx0LsbleU kS4xBqFTiBRFlV6HWogh82IYuw8/IGxISS0qDcRLTk+p8zaIVR12UVF2814Lcvy+LePH z3FOJk/jrme2M9q1r56ue1777DkqVKEtR93D5ZfACSXBEzetsnmFPFMRyTgJbjutZGNO Qz3d/r7fOZCs5EuDegcfBS9dt5klwLouhS645uihELXVWerBSKdZhUlSCRJY+L1UWkCC hcmIVtXp8pGDe8wm9locRJi/ZjEEVN0kupAgtPbexILEk2IRLEsPz+sBxKgJB3XX3o27 +Mrg== X-Forwarded-Encrypted: i=1; AJvYcCVjYWsnXYXyN38nOrLMyXmp7ilgPyyvXKM8PZ+Z728WR/wLrZuV1DiYi5YoNGdAQKsvQROkzT0kWIxYwwE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyin7fKQy/FjuTg+Xpl3Ortw+nBfysL8elD4WkH9NMbmHcoACET ahjkaQwc3zkI0weOnPl+bl0/1H3LN1YdtIoicmH22uWQCwMwtW55NFoe X-Gm-Gg: ATEYQzzTx9sFmsoESez6FMCoIlcRyG8dZsC5vaDCsDi2FQ+sOxWoC8eOj3/+zWphmOv O4whshqwC6nLphkRnJwzgOJ0fLpBNfkegc2lNagG3yzEIwkDT1OuwV+BBvjfzXO3u8k301WGhqU MX9opMhonJczd7dbT6MNEQBQnaookZxWX83nYYDIGqshzvs+8AmLZsaZQHTUH/FHN64et734nUR r8E70ZXS7KRnnOof2kejVQ1s2HXvbnerRT5sfl8rDGdlhS4NpvbMLpCpMJkNPemsu28XZf7v8UH RyNJMkqElgnIuraMe8GpRcAOejvCvleGDaj/qLwKxBaBukEn1c4i+GQV1ve0JDjVZBeY3JhHqg4 9Ui6itsakbb5YuYbJZTFDRdLeSRXER+/i3OR2knBTdvKZaVRMTBauqc/E79TwtCn00CFpGc4rFB aYH3q1hyHsdTAMZ+eBiEphHu/ttZxZnVFRUvc= X-Received: by 2002:a05:6a20:4322:b0:398:7262:d6ae with SMTP id adf61e73a8af0-398d78a59fcmr10573961637.25.1773509011631; Sat, 14 Mar 2026 10:23:31 -0700 (PDT) Received: from ubuntu.. ([152.58.152.3]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c73ebb6336bsm5466035a12.21.2026.03.14.10.23.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 10:23:31 -0700 (PDT) From: Anas Iqbal To: linux-bluetooth@vger.kernel.org Cc: marcel@holtmann.org, luiz.dentz@gmail.com, linux-kernel@vger.kernel.org, Anas Iqbal Subject: [PATCH] Bluetooth: hci_ll: Fix firmware leak on error path Date: Sat, 14 Mar 2026 16:56:39 +0000 Message-ID: <20260314165639.180559-1-mohd.abd.6602@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Smatch reports: drivers/bluetooth/hci_ll.c:587 download_firmware() warn: 'fw' from request_firmware() not released on lines: 544. In download_firmware(), if request_firmware() succeeds but the returned firmware has no data or size, the function returns immediately without releasing the firmware, resulting in a resource leak. Add a release_firmware() call before returning when request_firmware() succeeds but the firmware contents are invalid. Signed-off-by: Anas Iqbal Reviewed-by: Paul Menzel --- drivers/bluetooth/hci_ll.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c index 91acf24f1ef5..91c96ad12342 100644 --- a/drivers/bluetooth/hci_ll.c +++ b/drivers/bluetooth/hci_ll.c @@ -541,6 +541,8 @@ static int download_firmware(struct ll_device *lldev) if (err || !fw->data || !fw->size) { bt_dev_err(lldev->hu.hdev, "request_firmware failed(errno %d) for %s", err, bts_scr_name); + if (!err) + release_firmware(fw); return -EINVAL; } ptr =3D (void *)fw->data; --=20 2.43.0