From nobody Thu Apr 2 19:13:10 2026 Received: from mail-qv1-f97.google.com (mail-qv1-f97.google.com [209.85.219.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 428FEEACE for ; Sat, 14 Mar 2026 15:28:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773502122; cv=none; b=if1iEWf1UKfl5lMztLgFdwgrn1HOcOFmJQ7tEW2SUi18EH92rlh9XrAjK3K58qrrzBqOnQU7tq4pCZQCpnr2P9idQ6Ol3dJ24ZrQ3dbVOQekZUDIwcUKxpiIsMPtQVjfvD7SZaa+4bhawcPGV+j8X43ELeRtA6CClpQrYDBAlMI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773502122; c=relaxed/simple; bh=4bMWKb/PqU0jSPJ1xG4UEpAHm5IvuJsRbhA4F2w+vQw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=K4doOL0GZaO42QiAJIlTHYPNpJeJuvDAkJDDnPSrJ0gb+PpVYYKzmp+aLqq8vJexTlPsrqBznXnr3y+Cje67QT8ZsSE9U7beOc1vkakZcYPho8CM5hFrN50GvgGV0xd3SayT6AIKeQ0duQz5+8w9IiPtzD5wFmpJFnJVqhBcGMk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=VQ8rbTSY; arc=none smtp.client-ip=209.85.219.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="VQ8rbTSY" Received: by mail-qv1-f97.google.com with SMTP id 6a1803df08f44-899fbf92bdbso41220396d6.0 for ; Sat, 14 Mar 2026 08:28:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773502120; x=1774106920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zskkPdD0Q07hR8gVC+nWLFJBnMEPwCpWyNd9QmkQ5dE=; b=jobtT6NVonWdPPcuxVl4RBe0RaRAxCLCOBgX57QAiETx0ic+3lwhABzxWj5+HWw3+u kl56C2qdncIAIy7E4Vi0NuNrhDSU4LUXj+HMlMV9MVg02EY0dEUUvrTeRkPbWNtT0Lsj NflthoFtyTmQ9mIFBkJJI7+V4SBH0G93aPC9SMpAIrUMhlhFJOn4xJDXGO+o9h9Z+cc1 LnYJu8WZkWImFqMEnlAeWzEbROQL1MlKLVDUrtgSgxlv+tL9adJWJDtxvxZ4K5yxUksB 5m8C8+Qoh1rpz3Uf5kht4ReR2Fusb4NeFKZqnpGDL768aiq9yOTkiy/tIL42bCgXZ88R ewTg== X-Gm-Message-State: AOJu0YxNyoYPjU2FNw6flGXI9xupYp/OQsPYkCR0qnav24ew7g2Do9/h y+o3Sz2+g2nA6GAZiQY6vz/ZDjJhq/yesc1j1iqbk6CcedpeTV/KtqWZfrsWl6JDsgOcXRANYsw sQZq9xoWL0AOx0Wj4nNuEzI8Ezg1QzE8Wy0BlgqTm5zize0uuWi47Ey9+S+Nr2NUMHscACC8tHt +rC6VJ1pyDklZxP/oz+T5yAJGkVB3AiQcCDfzG5a8Fx5xJkiatulMJ8GplHim76CJA6WT6UOK0a 6H6RAwIqUvJsdvrLu4= X-Gm-Gg: ATEYQzzHhnd0MyHhtgkFwGO9aOBukszV0kjJV7Svwjid2VQkl3YDcH+SLZW/kYua2i2 g9cNNrf6BHMyvw94RLXEzyJX71E3aR0VSGeF01qQy8k4H//HAAuuY38JeTyPvEI5da/nJwEVwLc cJXey+RY7P7fQNGF0ksnEtcPK+kYopfAmrjNKN1fti7WlCCokO/gdG4zhmb/LfN16XdOaY7IdK0 2ZN9/WmmHHsIuCxInQvFBRIhX/10OwBsXp7WTZ82xZW0e+9fFzQMFg/W05SuTf3OXTgNB+YNxeF Avjvg5LeJnvG/f/8f6PC4iYZ/l2vvkppht6I5zIlrzlbdTD6z3foBpdWn1Xb5LSFEpgGt9PPdnA /2JA3KJdLUwhb/uf8cogSYZp53BMadU8SFRsFBi7Bx2zxcZ4YYhPybcGIQirgBfiprRy+gr+1da PFfhl1UtPxX51BFRTMFi27gUxVspUw5DkOuFamcKORy4HboKn0TFc9+rft X-Received: by 2002:a05:6214:da4:b0:89a:62c4:5dd6 with SMTP id 6a1803df08f44-89a81d30f65mr108989866d6.22.1773502120139; Sat, 14 Mar 2026 08:28:40 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-14.dlp.protect.broadcom.com. [144.49.247.14]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-89a65c12893sm11426216d6.9.2026.03.14.08.28.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Mar 2026 08:28:40 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35a21d5246fso2033277a91.2 for ; Sat, 14 Mar 2026 08:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773502118; x=1774106918; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zskkPdD0Q07hR8gVC+nWLFJBnMEPwCpWyNd9QmkQ5dE=; b=VQ8rbTSYTV4u2uy7PU98fibW7IqZlNx6lp2qesLPMy5Hu5H1I1yLeYoAtOSWgYgKze wFlk7Bs3lu2MJhH2jt9FoozuFJGVf1vMzNysbD4YOZIXdRZqMuYJBH7CRYXr8ptvZ3ii XELwKBbqReuAhLA9WX0bpuTc4w0ehIr0eQO74= X-Received: by 2002:a17:90b:1b48:b0:359:ff8a:ee3c with SMTP id 98e67ed59e1d1-35a220ba7ccmr6884846a91.23.1773502118421; Sat, 14 Mar 2026 08:28:38 -0700 (PDT) X-Received: by 2002:a17:90b:1b48:b0:359:ff8a:ee3c with SMTP id 98e67ed59e1d1-35a220ba7ccmr6884823a91.23.1773502118017; Sat, 14 Mar 2026 08:28:38 -0700 (PDT) Received: from PC-MID-R740.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c73ebb7f2basm4338579a12.29.2026.03.14.08.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 08:28:37 -0700 (PDT) From: Pavan Chebbi To: jgg@ziepe.ca, michael.chan@broadcom.com Cc: linux-kernel@vger.kernel.org, dave.jiang@intel.com, saeedm@nvidia.com, Jonathan.Cameron@huawei.com, gospo@broadcom.com, selvin.xavier@broadcom.com, leon@kernel.org, kalesh-anakkur.purayil@broadcom.com, Pavan Chebbi , Leon Romanovsky Subject: [PATCH v6 fwctl 3/5] fwctl/bnxt_en: Create an aux device for fwctl Date: Sat, 14 Mar 2026 08:16:03 -0700 Message-Id: <20260314151605.932749-4-pavan.chebbi@broadcom.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20260314151605.932749-1-pavan.chebbi@broadcom.com> References: <20260314151605.932749-1-pavan.chebbi@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Create an additional auxiliary device to support fwctl. The next patch will create bnxt_fwctl and bind to this device. Reviewed-by: Andy Gospodarek Reviewed-by: Leon Romanovsky Signed-off-by: Pavan Chebbi --- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 12 ++++++++++-- include/linux/bnxt/ulp.h | 1 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c b/drivers/net/et= hernet/broadcom/bnxt/bnxt_ulp.c index 3705ef3a75c9..052bf69cfa4c 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c @@ -50,6 +50,8 @@ static bool bnxt_auxdev_is_active(struct bnxt *bp, int id= x) =20 static struct bnxt_aux_device bnxt_aux_devices[__BNXT_AUXDEV_MAX] =3D {{ .name =3D "rdma", +}, { + .name =3D "fwctl", }}; =20 static void bnxt_fill_msix_vecs(struct bnxt *bp, struct bnxt_msix_entry *e= nt) @@ -278,6 +280,11 @@ void bnxt_ulp_stop(struct bnxt *bp) aux_priv =3D bp->aux_priv[i]; edev =3D bp->edev[i]; mutex_lock(&edev->en_dev_lock); + if (i =3D=3D BNXT_AUXDEV_FWCTL) { + edev->flags |=3D BNXT_EN_FLAG_ULP_STOPPED; + mutex_unlock(&edev->en_dev_lock); + continue; + } if (!bnxt_ulp_registered(edev) || (edev->flags & BNXT_EN_FLAG_ULP_STOPPED)) { mutex_unlock(&edev->en_dev_lock); @@ -316,7 +323,7 @@ void bnxt_ulp_start(struct bnxt *bp) aux_priv =3D bp->aux_priv[i]; edev =3D bp->edev[i]; mutex_lock(&edev->en_dev_lock); - if (!bnxt_ulp_registered(edev) || + if (i =3D=3D BNXT_AUXDEV_FWCTL || !bnxt_ulp_registered(edev) || !(edev->flags & BNXT_EN_FLAG_ULP_STOPPED)) { goto clear_flag_continue; } @@ -520,7 +527,8 @@ void bnxt_aux_devices_add(struct bnxt *bp) aux_dev =3D &bp->aux_priv[idx]->aux_dev; rc =3D auxiliary_device_add(aux_dev); if (rc) { - netdev_warn(bp->dev, "Failed to add auxiliary device for ROCE\n"); + netdev_warn(bp->dev, "Failed to add auxiliary device for auxdev type %= d\n", + idx); auxiliary_device_uninit(aux_dev); if (idx =3D=3D BNXT_AUXDEV_RDMA) bp->flags &=3D ~BNXT_FLAG_ROCE_CAP; diff --git a/include/linux/bnxt/ulp.h b/include/linux/bnxt/ulp.h index 1a4643c46f86..0851ad3394b0 100644 --- a/include/linux/bnxt/ulp.h +++ b/include/linux/bnxt/ulp.h @@ -24,6 +24,7 @@ struct bnxt; =20 enum bnxt_auxdev_type { BNXT_AUXDEV_RDMA =3D 0, + BNXT_AUXDEV_FWCTL, __BNXT_AUXDEV_MAX }; =20 --=20 2.39.1