From nobody Tue Apr 7 08:06:27 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E443378839 for ; Sat, 14 Mar 2026 13:45:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773495905; cv=none; b=DuT1+K9vJ3jy/mPye/SUBnSkDimVvXS76n622KM0l3fq3hWNHbc1LRsOY0hNyXzQoNZmf1WiStvGWSLRobCs2Jspp+RsDbcpJTkiLPnlyTW+pODYbMlGzx4GHBePjdaHyqgDK0QuZpmvuLDCq0nD7EgVn/J7QAyUFxgcbaU0Jqo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773495905; c=relaxed/simple; bh=r4m5e2WdosUDMH7ILr8GzhL80uA1gU/E1S6oXWQRNik=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=a/Phqu5fM2g58vppN+y6sab1sEyVjQWUCKGnYk+xdcKhZgode9ZADTWnh6CRspPjM7GnYzC+lht4qdxqbwWZXl4yVgKJfz9+n3YKCh7Iw80dLvWE5LZSwTXeX+XFPGr25DVc4PpcaKCp0e6eB4UMDRiyFYMtsD7OqyTNvVqmggQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JMdQCjc/; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JMdQCjc/" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48535a0ef86so25628975e9.1 for ; Sat, 14 Mar 2026 06:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773495902; x=1774100702; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iDAtDiEdfu8Hby9nwe5A91QpCFcwVZToPSXmO71xa4U=; b=JMdQCjc/AEA5xFQvHUikynMDbwp7iWTl+SmbxO54nJxwbRHJKEquBE8LqQoF53VLx7 ReHrm4hcBDDEIHShdG6v7PXayBw91vaVyWsQDIgER+4F5UcPZd7hV6yxGRTDwM6h5a41 gftEqAcGt08o3cD7BxU/Rb0D/AkHMm0TvDz6izeaHWwUmr38ujzOygaTPBszWMnwFApO at7RgzI88N0yjF60c3fs1by1GESXGIA1K4AkUp6kR0y5DKa2F73f2NnVpQjrM0KHXFqa dNifUR1BoCqan2CQO3lXDmOr1Zdc0ILotFZEXgQz3hoejIadaEhHG+6aBqqYanmjMfhe 9a5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773495902; x=1774100702; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iDAtDiEdfu8Hby9nwe5A91QpCFcwVZToPSXmO71xa4U=; b=aYGeo4volPksjzjlzctHk43Khaw8IaNs2cTdldkNE6Yg4T/NCODgzE8R3ZJO2mWz2j MgT3XWexok4Cz0GghQPW5Flwgems58MoqXjxWo2LPAcOpVlc4ap4KD1Yxf1VKwGiII5Z H5xRQDCC332fWgvRqFDiLGM6aL0W39hXHCKEl5x1qDE7TWAOxOyhOrW2SFLqc2raFwaT 8/oRDFLGv3UQpW6fe+V5TUYyJO+JydAPo5MNn8RyMqd2wBv0MQxrZ+mUCqgLSS8kYPg7 i2R0r+9dH3G3BVFUCAASaOTnXaM7UeGfDHkOgzbp2fE3yyuckI79rlfZZh4G6fMNtU/S EfzA== X-Gm-Message-State: AOJu0YzYiN9lSIiB6GAbs8ocR8UEWTAiXaQgufkpkxkLytMfIw2gBhH2 jsGmjeTGjcfxd1n34AR7yBLqRIOQKoWVsJBSX81i07yY2MUJuFooW1JG X-Gm-Gg: ATEYQzyCSfFZrThCUM/S+jwZntE89bk1SwaYLz4BvZSTbB8JSTyAe7v28Nd06MJmyFX QtUFE8J6qOa1bntGHkoS4utTXACayaJ/YkSyiHCgZV0JO7E42s9y7qYA8/vwC3sAddJjWxTLuBZ qxzgSPLQLh7Ye9b8Mkd9aIMtwvodp1FjRm0lx4GmHdijQ2TSvXCdLeB/ahE/NwHI810r/cEf9ff qG2oaXMMvwjdCBkGniONoJbxkEasyUaLnQJRyXGVOk6QYulbVWkNw31gjxdE+cuOlvfGYKb7Snv wwxg5aXt6TTbTAkbTYIJIs/YrhPR6D2Jeu+CDDi+4ke8JMP2cYI41mFijuPzVHzXUEC/dG73voF 6gLp/11JmDfYrPbAIuii5/aa+35s1CID+R5knq/FLH31RimCNUKe9EDjxU/IlrV081QUTokGL/B sCdPGxNvWXVAiyoclAnxCC04JiDqiCj1OYFdd7zkYwghuZC5hfHnxaiOr094MN8aIPpGVc5wdF9 mx53h147N3YEbNsbQHk X-Received: by 2002:a05:600c:4ed1:b0:485:3d43:7c9a with SMTP id 5b1f17b1804b1-4855670e6dcmr118192995e9.25.1773495901583; Sat, 14 Mar 2026 06:45:01 -0700 (PDT) Received: from rozandragon.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b5f6c24sm256932655e9.5.2026.03.14.06.45.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 06:45:01 -0700 (PDT) From: David Carlier To: Tejun Heo , David Vernet , Andrea Righi Cc: linux-kernel@vger.kernel.org, David Carlier Subject: [PATCH] sched_ext: Use kobject_put() for kobject_init_and_add() failure in scx_alloc_and_add_sched() Date: Sat, 14 Mar 2026 13:44:57 +0000 Message-ID: <20260314134457.46216-1-devnexen@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When kobject_init_and_add() fails, the error path jumps to err_stop_helper which eventually calls kfree(sch) directly. However, kobject_init_and_add() internally calls kobject_init() which initializes the refcount and may allocate the name string. As documented in lib/kobject.c: "If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object." Use kobject_put() which triggers scx_kobj_release() and scx_sched_free_rcu_work(), handling cleanup of all previously allocated resources. Fixes: 17108735b47d ("sched_ext: Use dynamic allocation for scx_sched") Signed-off-by: David Carlier --- kernel/sched/ext.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c index 9202c6d7a771..c35c13da5a8f 100644 --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -6468,8 +6468,12 @@ static struct scx_sched *scx_alloc_and_add_sched(str= uct sched_ext_ops *ops, ret =3D kobject_init_and_add(&sch->kobj, &scx_ktype, NULL, "root"); =20 if (ret < 0) { - kfree(sch->cgrp_path); - goto err_stop_helper; + /* + * kobject was initialized, kobject_put() needed for cleanup, + * see Documentation/core-api/kobject.rst + */ + kobject_put(&sch->kobj); + return ERR_PTR(ret); } =20 if (ops->sub_attach) { @@ -6482,8 +6486,14 @@ static struct scx_sched *scx_alloc_and_add_sched(str= uct sched_ext_ops *ops, =20 #else /* CONFIG_EXT_SUB_SCHED */ ret =3D kobject_init_and_add(&sch->kobj, &scx_ktype, NULL, "root"); - if (ret < 0) - goto err_stop_helper; + if (ret < 0) { + /* + * kobject was initialized, kobject_put() needed for cleanup, + * see Documentation/core-api/kobject.rst + */ + kobject_put(&sch->kobj); + return ERR_PTR(ret); + } #endif /* CONFIG_EXT_SUB_SCHED */ return sch; =20 --=20 2.51.0