From nobody Tue Apr 7 09:11:38 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23CDC31F9A2 for ; Sat, 14 Mar 2026 08:11:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773475890; cv=none; b=tTMdiIK7KPSfuUPgKisyh+PzS9Q6dSkNAsif9pnpqyhXqjVbo5PlAJpHb+1F6e+Pq8+mFTM4GGu22vAXDyiYWCXTUCGv+RHUu9eskCP+BTYbndA+l9LW2ylHVTGOfNT2bd1B9U9Xt9FHiyg9YM0igHsoD8nc8onTp/DVvAdgXrs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773475890; c=relaxed/simple; bh=TmwxCr9IB9n2Y8Syw5S0VZE8T7ZEFTqna6cKBSYS2mg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ulPS+1FXVQaQupvxjXhgJIoVYVY5w7e5mpKKNRf/9nK6skv9dlZvlRM5csRTBp/7Cqi/wIcvnHtJkcPCPkp3ZJ0omZb6AJOklwCpcU8T7ZvVKuJUBVzU+tV9FwwKU1HFl2HxOom0e0DH8HEzImPksTbgs31hkWyyjE7OfFkPQdI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i45sKXp5; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i45sKXp5" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-829ac8d56c5so2807586b3a.3 for ; Sat, 14 Mar 2026 01:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773475888; x=1774080688; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=moWcmdhPCy40ce28NQlBUwpF1AcLuFP20ERgqSCK6nA=; b=i45sKXp5ouJL+sgkZKGf32DLf1kpAjlS4ypn+BML6F4poUqD75I/ANiH7yaOogG8Ci Vq7mIPApOjzIPnbck4XG6n/Y9V9ksberz27ch8OtlA4AxIpOFRGkMV7C+3rhKSZ9CTWv qPBybkhgPvdQPAKmdkB8YbikrqBxn8ildWk+ZrgBQaajQo7Gbpopn7Sv+MUj67Y9Wf7A hPYVR+Dxq2KPhtWw8uDDdLj1SEFbvy094U4Vt/F9lcbuLHKnrQ7dv41tj3RwBsGr7hJP INDecXiKRC80njaH5BMYd4fD2qPlUZlV7PnNdzI+UWOwckSRLjIWRUMe9RWocMiDUttj sCXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773475888; x=1774080688; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=moWcmdhPCy40ce28NQlBUwpF1AcLuFP20ERgqSCK6nA=; b=RBe3lovwR3KmpYz9rnFu19HUnObFpuH6z17r9mfX17YayabtK7vu63163BoweuBZwT s36VX+Mb7O8E5oPunnr/r0k7ay6UgQE0B+7DH8IpHLuj636OjEZAm2vj68tPOK4I0L3L PfHrthnzHr81l29uE/8wcIMiOtkVFikMbZRY+LJLHvsJMMEpa4NGhj2MiTIkzE+aHk+K EP4EnkBVppnaC3+Nn4LIzHPxDVze34+1BRAx67ScU9SZcni0T7CpboPaeu/dTuP3n0dV e8by8n3n3mKC/rCwobodv1SuJgi1Wo/dOCSLVGvmAa1jQOuC4TZX+Xqf/JeKzCzA8j1i oC3A== X-Forwarded-Encrypted: i=1; AJvYcCXe5FaNUeuCxC/TM5Ft550HO9baTf2tJZk5Fupe8Wgmq0u6eC13esN5oFMbeHtPfA8Uwmh/o1NI038Wjt0=@vger.kernel.org X-Gm-Message-State: AOJu0YzNJOFQ+I4gapLfKS17Yp7dhQ34WUGlJmf/pzriDPM2TETB5ZjQ b9DEKEbGS8RNIVrAImd5/p0sOx4nX2OgrnQwlgl0rIfxrDkGlcxWe/Bg X-Gm-Gg: ATEYQzwE/CAOR2tdrsvaN9IRBPRfrUmLLnpbcy/+o1C4N6xWkv7W/C+YbYjt6NBlJBZ HJqc6nazbj4jVPSA3nkLYW47yPYpKfLxVtSqxD5gAC8oJb07r+A8ntItknfkzKa52FYnh8Vtyrv m6pfhd4mTkx9fGvJzLV6j+lmYU3Cot/uJwEwckO7nGP1v4a9910jKruiiB9vn/Hk5Ydutml2iXS gRUBRoMlGrP7X+XMqqckAbgHrOYRwiHcrhC5CA8NMhQFxZCs3y8Htw9QuO/wop9YWq6FahWtCIH iYysTBPyQEDtGf5aWt5ML69JAaRAzhRApaIuvdZIprGnxV5LpsN1YnfBgKVkXOM5nY+nwZeeEn/ ZDNDeMtGq26AsMCfSu7MwaaKHgMtCLXS/+pqisDIOGZDuIHlqgIwIwDyYP3bHXoNFpvdeCFuwRu fIStOGd4aggEYOJDF+Rgq7CkoZ X-Received: by 2002:a05:6a00:2e21:b0:829:6f82:5953 with SMTP id d2e1a72fcca58-82a196d3440mr5539194b3a.5.1773475888359; Sat, 14 Mar 2026 01:11:28 -0700 (PDT) Received: from ubuntu.. ([152.58.152.9]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a0727e581sm7427942b3a.27.2026.03.14.01.11.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 01:11:27 -0700 (PDT) From: Anas Iqbal To: florian.fainelli@broadcom.com, jonas.gorski@gmail.com Cc: andrew@lunn.ch, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Anas Iqbal Subject: [PATCH] net: dsa: bcm_sf2: fix missing clk_disable_unprepare() in error paths Date: Sat, 14 Mar 2026 08:11:12 +0000 Message-ID: <20260314081112.177669-1-mohd.abd.6602@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Smatch reports: drivers/net/dsa/bcm_sf2.c:997 bcm_sf2_sw_resume() warn: 'priv->clk' from clk_prepare_enable() not released on lines: 983,990. The clock enabled by clk_prepare_enable() in bcm_sf2_sw_resume() is not released if bcm_sf2_sw_rst() or bcm_sf2_cfp_resume() fails. Add the missing clk_disable_unprepare() calls in the error paths to properly release the clock resource. Signed-off-by: Anas Iqbal Reviewed-by: Jonas Gorski --- drivers/net/dsa/bcm_sf2.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c index 960685596093..de3efa3ce9a7 100644 --- a/drivers/net/dsa/bcm_sf2.c +++ b/drivers/net/dsa/bcm_sf2.c @@ -980,15 +980,19 @@ static int bcm_sf2_sw_resume(struct dsa_switch *ds) ret =3D bcm_sf2_sw_rst(priv); if (ret) { pr_err("%s: failed to software reset switch\n", __func__); + if (!priv->wol_ports_mask) + clk_disable_unprepare(priv->clk); return ret; } =20 bcm_sf2_crossbar_setup(priv); =20 ret =3D bcm_sf2_cfp_resume(ds); - if (ret) + if (ret) { + if (!priv->wol_ports_mask) + clk_disable_unprepare(priv->clk); return ret; - + } if (priv->hw_params.num_gphy =3D=3D 1) bcm_sf2_gphy_enable_set(ds, true); =20 --=20 2.43.0