From nobody Tue Apr 7 11:33:09 2026 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17DC0351C0F for ; Sat, 14 Mar 2026 05:17:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773465435; cv=none; b=qgwxpDrKOugAie7vRZ6qhmpcIttZdSPF9/4RyHDLtYyTNhJ6SISsdnvMAmYah804n1AiCtzUb9cdkRGbrYP5VC1wiA3SWHC1dPmH2kSwPV4Le8ZqaPiRHFEPVk2MptE7JyQy0GFHRYVR+WMguMh8W3+62Usfyk1u6US4/McPmLo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773465435; c=relaxed/simple; bh=7jZU3029h2KdtbIUsGzL9XqTJpxSfSOlQeIQtiiAWgs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VYA1QQxs7bPAX4cBfLGXA0V5toZyCiRUGIe4o8LY3kTkjCu8FLLApc0sjeOQRJcdNrw44yfIXp3U7oHvOxlbxERebWUxlFe6RUASneN/k7hi01S6EQp4L1iyGSC9RiCA9wu2WmoAXQ0E8KnF+tjuDS3WR3bxbzJG/1islQugYEY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=njhEuA2G; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="njhEuA2G" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-1274204434bso2462137c88.1 for ; Fri, 13 Mar 2026 22:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773465433; x=1774070233; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ivWWjclT+Ru0LypYqCaQdIn8J9FFGj3uiMsBTd19u2U=; b=njhEuA2Gs6NWq6hD9pyy8nvRoqusa5M5Yvg05dzVFV1uBhuv4bN30dzmp4FT1E3E0U bXZq0DEJRPSWSUTEJl5HRYsEthftchz+/XDBvkloCK4Ag1UTK465SaknNx1FDtRWer2u laQcdkRhlfWW0Db6/vgIxh0yrB3IKNC0MNYbwxtMRUPo2pPXuMAczBpIRTjse/rIi1/g Iu1LI2mfK460++q5RNg/Rq1Iki2l+5W4KU9SPAXyoD3kTvgDfYJWsklcLVoAebUoznLZ JSqVzrx5CL+JSHMLNvE4qapGft2sY3yO9pe623XS+72nwbd4Eh2AF42eIa9/nJPAVLcM Uo8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773465433; x=1774070233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ivWWjclT+Ru0LypYqCaQdIn8J9FFGj3uiMsBTd19u2U=; b=inhX4gpAr0bA6Cbn052EvXESb6pstYv1rsk4TY6gCZHPfVdi76p5Kgip8ZmM7QGvuS a/uso7KBb24428nxnI4UbQjuFGkTECyKAA6i/DzSwxww+IE4/6s6RF63zynx5xjvHCsy oXIv4AokZ/2CtqD+F/xp6JxtgEXp1xAloh8xMJ3fd/BO7bGp24lU9cmAjiM3HZuhwdLs FpWoNrGj7yCjEiG8hgXJGSxCssAg2Tb+2jQkkagSeZkdSX1NtUtR1WEwJWIcCj0XYxEk enrb8rXd8yamf8gZOHFzpHACDnlZRaR0sUABHfYlRrCDvI5Ba4MVnMOFZDBmYkEJvFc7 3wKg== X-Forwarded-Encrypted: i=1; AJvYcCVJCEkrm4FHq/ZNOR6tyIVaN5vAtGh407Ss/MmPFJYSsK4ypqbHIc8lloeKKZ6GXPyIQJYWGqTzku6Tjgw=@vger.kernel.org X-Gm-Message-State: AOJu0YydK/zojGLnNqJnM4EuxkdsgLmi/cCOL5+Fxg0P2kF3DyZC0GbN k2nVA4MNO5GIO8//E+0pA+SIVrRhiEY9Wn85xTeu93RyTOeSAIPAZQtn X-Gm-Gg: ATEYQzyVkqWutGCNEIBrATkFH5PqfyTxkIR7ohIvbXK+2iunDfxg4PR18v+SJNxpfWi JUbPNqY+Us5AidMXNiyZLSUKCBZlhV+m+hfBJ9bPAKcVk9+1MOva2GBuvCBxHVTUY9UbFk9wkgM M6C8yaw1de3wjKTOZ/SBFMt0u8YtIkBN2s7ZVtHjAOkPYsd2H7x98ud78kugSXNmKHGBQgzYaCv 5Ro3ZNcDRZfr/i+TKf14fM7qy1K5MLXhRxASs9C8JIfwgilor8XQqN6BkKigSwCIQKGUtSCpypc fBOq6kBTyh8wy20nXM4Xb9yigTAu0vNkrah8G6EbTCflNtIo20AD8ARxJkf9Es9ANsi/YHyFMz1 BJJlrtCkurMH00We+rhXd+9l6XY74PGjaKEvh4n0OVEBf0ixbtRytsGP+YM54mrEh1ojwFdBLoc PIinJETwd26mEIa4xoFtHaaQs= X-Received: by 2002:a05:7022:41f:b0:11b:f271:835a with SMTP id a92af1059eb24-128ecb72641mr4293252c88.3.1773465433110; Fri, 13 Mar 2026 22:17:13 -0700 (PDT) Received: from penguin.lxd ([2601:647:6400:3ec0:216:3eff:fecd:e4ef]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-128f639a160sm4856196c88.12.2026.03.13.22.17.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 22:17:12 -0700 (PDT) From: "Kanchana P. Sridhar" To: hannes@cmpxchg.org, yosry@kernel.org, nphamcs@gmail.com, chengming.zhou@linux.dev, akpm@linux-foundation.org, kanchanapsridhar2026@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: herbert@gondor.apana.org.au, senozhatsky@chromium.org Subject: [PATCH 2/2] mm: zswap: Consistently use IS_ERR_OR_NULL() to check acomp_ctx resources. Date: Fri, 13 Mar 2026 22:16:32 -0700 Message-Id: <20260314051632.17931-3-kanchanapsridhar2026@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260314051632.17931-1-kanchanapsridhar2026@gmail.com> References: <20260314051632.17931-1-kanchanapsridhar2026@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use IS_ERR_OR_NULL() in zswap_cpu_comp_prepare() to check for valid acomp/req, making it consistent with acomp_ctx_dealloc(). Co-developed-by: Kanchana P. Sridhar Signed-off-by: Kanchana P. Sridhar Signed-off-by: Kanchana P Sridhar Acked-by: Yosry Ahmed Acked-by: Nhat Pham --- mm/zswap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index 26de0468e33b..6c6c14433556 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -786,7 +786,7 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, str= uct hlist_node *node) return ret; =20 acomp_ctx->acomp =3D crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to= _node(cpu)); - if (IS_ERR(acomp_ctx->acomp)) { + if (IS_ERR_OR_NULL(acomp_ctx->acomp)) { pr_err("could not alloc crypto acomp %s : %pe\n", pool->tfm_name, acomp_ctx->acomp); ret =3D PTR_ERR(acomp_ctx->acomp); @@ -794,7 +794,7 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, str= uct hlist_node *node) } =20 acomp_ctx->req =3D acomp_request_alloc(acomp_ctx->acomp); - if (!acomp_ctx->req) { + if (IS_ERR_OR_NULL(acomp_ctx->req)) { pr_err("could not alloc crypto acomp_request %s\n", pool->tfm_name); goto fail; --=20 2.39.5