From nobody Tue Apr 7 09:05:36 2026 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E03B31FC0FC for ; Sat, 14 Mar 2026 04:57:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773464275; cv=none; b=PS/Sg21O2fBLFMzuL7yCiGIdyRpXK4j0e2AKz3ervb5DAxHIRmRe3UB0eaH1xrvppCug3PBz+1WYzO5Ij6GYFeN/xZIZcdy17usynZctK2wZlZVN/CmRpxpsIK+m5TA/9OyiFCS0UXgHNVQKap38BrEjqDkIPomH0w0efAqE2TA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773464275; c=relaxed/simple; bh=Q7T7gEpRnDDwZL4aoZYYHdNq4RTmVw85HR/DS5ALarY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RECZqzr7ni2BSXBFWAWGF3fiTuynUwxAPOGm85K+Zeuoci1kvM3BUUQaUuFDraN36MGKSruLImVTPz66jGhccNcJ0/ltndMaPFLURfhFP7jJdok7wWAD4FdUU8LOWBUsGwhYJmrEqQKpZg4jHMBG61ICinekylhy0ZIm/TnDVwc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h/yZ0cIO; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h/yZ0cIO" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-79495b1aaa7so28368737b3.1 for ; Fri, 13 Mar 2026 21:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773464273; x=1774069073; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nkOHJmml1T2h8lU3WaH3WLJXiO/lx1Xa2aheZkpBFik=; b=h/yZ0cIOCWkHGC5fP7+yapZMAIA5E3jyaCY2VH2/0TcWeN4gX5ekTQF4JTJo/Vkq1P wnMMrHBWiGhhQ4S2rpoD1/JCyGr0BHLv2Ax3CTP4IgYabXJIl34v3MxBszF+9nLX7vHX efq9Ytg4tDtKIfCSB7nwA62pSUz6lox2i1VQBYl7Xi/Lt5pinpgpJXDIeWOB+Dkg2xXe 02ym+gIS1hMueN7AhfI82g+Qbakk7sCgUoXTQcMaZ6DtSMNyP0f3DF/wMPASjwg9jVZz yCD4Jc1suOrRPV4nOr5hXfPpFVUCREnhoEQUA03eBJoD9ROGwux63Ana78t2T3YrDvt2 NaOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773464273; x=1774069073; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nkOHJmml1T2h8lU3WaH3WLJXiO/lx1Xa2aheZkpBFik=; b=rwRCc4u8M//PugGj/OwPCZEMJPRpxX5TsgcX0qiU6PEMG3XjtNJZDxX/eM/JJvvL0U 8duTWpxRY0KriKyDc5eAzTqUbG79J8kL+2CtYHzYyFePfDxZmJvQfUfLUk1GnJq3l81a kkybOIEiba5L+ziNOauMvFxegoEOrPV48CCcCe0rRJ7/lAguP0izJByFsyRu5JmxABcw R1UlHRbZsLz4HfvzyWWelu7HxR9H1duGpHSkGpNObw2ycLYwJFXjYW9DukcA6Eh6M3Jl lguSSywpo4ZV+u3gR+ZMTIqT6xn4XT4F/Aj5eXh3asuONjYNo1gOK3XpVVXQahwfaAEa i3zA== X-Forwarded-Encrypted: i=1; AJvYcCWFk2Xn/CkvwtA/gXaEO5BXw+RQLFFpmHY1Y4Dul3acdz8vDdqu5oE+6P1rdADlTRT+3okkae/MUEuQFMA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/vG6d4Oa4c7RkJWH7i0L0LnkqPZ4wIJJPqb1gK+vZ6lMihlUS w26f1Bkx6HXBBnwAnohcMDg8jTzwNniGvqcIVMdB6S7uBrv9F/2QMFbu X-Gm-Gg: ATEYQzy+YED2q3ZJhxZEveBiQoqYalYTsheTmci19CSoU3kotGE+bQRNYxnhDExwQ9g I6Bm+4xC5ICRLcKvyrufY77VAHSAxmf8YQQrxUcaz6UFCFbNHco5AlkGJ4uWUIwhzG8ZJMmq6MC r/9yi/XZrz/0DGmCYdMqlrszjw+P/9gX8N1G2LTUss6P1ZL1nK8amdjIhd4FQCc1QShW9nfRtTb RMGQKkqwlKvqzvxuDS7V0hAHsw9FmyaQQCIEPYj6A6SzCj3LFo/HJKkLR5vl7ofpJPROHAX+R46 zR8gCH7Vqf0cn41uEH3gnoEpPy1sP1Jjdc8Zj1Npv47jNqvaA0CTuDzTyR+RxyYXShwb0P9zsIf wPBCan0v/S4277DMy494BFdfM5O1jAzX63WJvgV5GPQOHr2xm62U3uuveXDKXS5OeWvqjUcZi03 WSJOK9byka3QhwEuMceMXa+2TGOjgzmJjvGUzzeTqhbneuhixzqIHGooI7DpxDBEorr8lkEnNBC EpmXh8u/MZ4NpVK96ps/yX0 X-Received: by 2002:a05:690c:d8d:b0:798:6619:f1cb with SMTP id 00721157ae682-79a1c1bafd7mr61299877b3.43.1773464272826; Fri, 13 Mar 2026 21:57:52 -0700 (PDT) Received: from tux ([2601:7c0:c37c:4c00::5585]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79917de805dsm58007227b3.3.2026.03.13.21.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 21:57:52 -0700 (PDT) From: Ethan Tidmore To: Michael Margolin , Jason Gunthorpe , linux-rdma@vger.kernel.org Cc: Leon Romanovsky , Gal Pressman , Yossi Leybovich , Daniel Kranzdorf , Yonatan Nachum , linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] RDMA/efa: Fix possible deadlock Date: Fri, 13 Mar 2026 23:57:30 -0500 Message-ID: <20260314045730.1143862-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the error path for efa_com_alloc_comp_ctx() the lock assigned to &aq->avail_cmds is not released. Add release for &aq->avail_cmds in efa_com_alloc_comp_ctx() error path. Fixes: ef3b06742c8a2 ("RDMA/efa: Fix use of completion ctx after free") Signed-off-by: Ethan Tidmore --- drivers/infiniband/hw/efa/efa_com.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/efa/efa_com.c b/drivers/infiniband/hw/ef= a/efa_com.c index 56caba612139..e97b5f0d7003 100644 --- a/drivers/infiniband/hw/efa/efa_com.c +++ b/drivers/infiniband/hw/efa/efa_com.c @@ -629,6 +629,7 @@ int efa_com_cmd_exec(struct efa_com_admin_queue *aq, comp_ctx =3D efa_com_alloc_comp_ctx(aq); if (!comp_ctx) { clear_bit(EFA_AQ_STATE_RUNNING_BIT, &aq->state); + up(&aq->avail_cmds); return -EINVAL; } =20 --=20 2.53.0