From nobody Tue Apr 7 09:11:38 2026 Received: from mail-yx1-f50.google.com (mail-yx1-f50.google.com [74.125.224.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33B2F1C84DC for ; Sat, 14 Mar 2026 03:02:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773457373; cv=none; b=YFgGoVso6a2VtQkFN02yUaXe2ioVoD551hxQ6WvowPAGWv/xy6TatmftwBpyn+PaQUQkwixPJxr1o932M9XuqNqfW6r1ev2T7FPeV+Ut7z+KtvFsDyKUB/KrOb5jwPw1+Jx6O7ognFZPlbdETGgwSSR5SKWqsdHG+WFx2JnYbrk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773457373; c=relaxed/simple; bh=GQtnGMG+iwGnUDXIJP36UuAxoWcpNjtRkTYriXn/Q9M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tOZ6NMwubS8zblA9GIe7iQiXnnfZ/eq9WUlto5CJxYVDYu69lOibKKmbmKaop+zFMtr29Z4jpACRAVaizAmJ31it0ia20nVV0PWtYrOrrmKXnjARqVBhhF26f4uHVVK8nTo9QpR23PTx+lKMJch5w87jqXoHmvItCZ8kwOwTG0U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EfhGSE+J; arc=none smtp.client-ip=74.125.224.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EfhGSE+J" Received: by mail-yx1-f50.google.com with SMTP id 956f58d0204a3-64c9fcc24b3so2396488d50.1 for ; Fri, 13 Mar 2026 20:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773457370; x=1774062170; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Oc7FLdNxwtcVIDYDLuOycp4ocAPA1/t0REGOIAdfe5E=; b=EfhGSE+JW4Qaa3ZKzR31fMw9fWe+Q9+sgBtLqYhGQs78M7tcn9SQYK920jU7P7Ebs0 QIyJcWPkNY6j+7gQf7ipeVlDhZfps1Y4jGThnS34AvAPHXmto8BpqaALVjfZ9HY9Xlhd 05uocGqxpux+EvFzPD/lJc9uZGrMtNvIuF7LTyVRDWJl5GnrUzeul55W7VKlfFkHlDIX pP+26XIw5wPnEtaTgumbhnwsvQQc/GAaiKDEUpYDHkm0b1neyEmjluMLUIl5pppxF4Lx i/pVEa+kp5LhXhZC1TzM2HDZiP4ch1nZV1AQkmNQL71aCr0Zpt3FbeglTNMaGK9yR9Xo 5P2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773457370; x=1774062170; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Oc7FLdNxwtcVIDYDLuOycp4ocAPA1/t0REGOIAdfe5E=; b=YTPM45Y+bUqHNcFY576R3RyWKcqB9l61uNeNua6TInviMny6owaAv5VKg5FwMkXdB7 V0CPfKBX8UK4wAzVvBWtjS2Y1kUqzIUm5FXk4YjmMpLTm5g5uUb6yth8T64IkwwvQDRA FeQT+O5adFNudN6mCceD/ciqAGWMCKE+m+v3C70lrSWCEqTKtsSe0sdQXSN5KDDJCMEn fFB663icjWQIwajl2L1Nw7flCoIyFUu5wyF2BEsNgThmYUB5mdvO3LH5DbVXOL7TsrUN vQz65CnbnDc+VF6un69bhbpehTEJQCDT1jJJu+b9YLP0yCnAoD98bBYw/ESIuqlV4E+M 1kSw== X-Forwarded-Encrypted: i=1; AJvYcCWC6uJuvpuCvQaCkudnjlDX4JnlqvnZiMEa4tN6x32v1tNcAoEksZZpaEkkthoKHMoc1bztDN/zil1B9ag=@vger.kernel.org X-Gm-Message-State: AOJu0YwRxnfPffb7N6KLa0nJHhVYI9/pUfYU2JNhzxKmp84M+BPCuwsd XMWvi705CbjvrAbBfzD7xrVhf3d7p+QhcIVQktDVhhAxkH363i4UTtfIBFNcUR3O X-Gm-Gg: ATEYQzwy1VHwdSa3znMnL/qv6ZsUhDwyciD/znDaw1fmFvv/X3PHK1OHeMALAzz4+0F pS6fb9T24hB26ABTyCjNhEwVUO4VbkcqZa9dobdgh4LILf0L9AvTAz6CUyw0MLKw0wwux78V/JM SwNkeyOflH/dxvNNU6PKWaJlcz+U1mabRKVWIrKQELl+CMFdYfap6EW4BXJYFP0m8oP/3vzxW63 Py6afA6t9DGSCruUnofWSM6RSKK/ZqBljvEfdQDJNNJIfzD9J4HS/7u+i7FIJizToaCXmJnDLVJ 8W+Ni+ZpHyp4tkLBtqc4N5OCcW/y9DBYTMiSUVhMzuuzbc2i85V0/454tr44NhxJIZbzaWoGczx bCcUjuqcVtv6YdrV5iug5ruMWGgzlXq1FUlt+PR/waOmu9x1qDumtQFYrIjm8oIU09St1Vz1nV7 39d1VCa3TGSPIvB2xDwEc6ckBWMYxmIT5c5koQ0pqU/unrXzexD8biIfPfjS68mws8aQUxB3dHx HG0ztBtyR692E5d2Q/AESeB X-Received: by 2002:a05:690c:2702:b0:798:3efa:601e with SMTP id 00721157ae682-79a1c18dc3dmr56962457b3.35.1773457370097; Fri, 13 Mar 2026 20:02:50 -0700 (PDT) Received: from tux ([2601:7c0:c37c:4c00::5585]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79a231a54d2sm15338547b3.42.2026.03.13.20.02.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 20:02:49 -0700 (PDT) From: Ethan Tidmore To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Verkuil , Laurent Pinchart , Sakari Ailus , Jacopo Mondi , Tomi Valkeinen , Kees Cook , Ethan Tidmore Subject: [PATCH] media: subdev: Fix error pointer dereference Date: Fri, 13 Mar 2026 22:02:28 -0500 Message-ID: <20260314030228.1133429-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function media_pad_remote_pad_unique() returns an error pointer upon failure, not null. Add check for error pointer and extract the error code with PTR_ERR(). Fixes: a564839e630c1 ("media: subdev: Add v4l2_subdev_get_frame_desc_passth= rough helper") Signed-off-by: Ethan Tidmore --- drivers/media/v4l2-core/v4l2-subdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-cor= e/v4l2-subdev.c index 9efd14d4026f..7cb17e0a5617 100644 --- a/drivers/media/v4l2-core/v4l2-subdev.c +++ b/drivers/media/v4l2-core/v4l2-subdev.c @@ -2585,10 +2585,10 @@ int v4l2_subdev_get_frame_desc_passthrough(struct v= 4l2_subdev *sd, =20 if (!have_source_fd) { remote_source_pad =3D media_pad_remote_pad_unique(local_sink_pad); - if (!remote_source_pad) { + if (IS_ERR(remote_source_pad)) { dev_dbg(dev, "Failed to find remote pad for sink pad %u\n", local_sink_pad->index); - ret =3D -EINVAL; + ret =3D PTR_ERR(remote_source_pad); goto out_unlock; } =20 --=20 2.53.0