From nobody Tue Apr 7 09:46:55 2026 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36C9437D104 for ; Sat, 14 Mar 2026 16:06:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773504407; cv=none; b=AIkoQEeSSsJnHziDRmkuSwTa1hrVQccPKbVNu3WoOUWH7ihY39K2337zIm4rArQSgYr4y7Wb59dZirJlM9PNSqaS8R8KflJyEegMQMrrjpmjA74prEhzPm6UnV6h0sogxvFEnnZSIesr0xnsL6elRLH/rDGK052H1gtqTMsfVfk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773504407; c=relaxed/simple; bh=AAYQH8m5hJopiQqgeTngADuMlO+elqyJCsSOeSZcnBU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UA/JY0z8RCQh8t6RifJ3Cvhe/1fz2AXRsGLu8SJw3k74YXQOZCwWmLFdC6YS/vpWjelRF5QgQ//UBWdPWj+nwm2ha2OdDBJ/16ZErUYAzMExuqWRW/kDcwWYF8ctRHZbENAWjfKqJy3FC1iLI1D0FUu5rfH9brm0WOIa7BgbOUY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dGaiKDey; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dGaiKDey" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b942a41c5fcso442712966b.0 for ; Sat, 14 Mar 2026 09:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773504404; x=1774109204; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ztVKqP7Iue8aUh5WW0pabHa7SHe1KuIXZfJfBXrdn9M=; b=dGaiKDeyCS/zMpoONAWtHlh6/lm5+lp/RD1B9EeSGZ2u5oRIpW1Iirkmz6zYIloLUs /VEQqCH0R4Ju26RpDnC1TS3BAF8DBdY3Q1WBZn2Uc+aCHx1O3h2FCSuD7NOXd8cKJyew J7uWG3FghoA8CkNzjwbAEajbKB3PKa6EDxnl9TvygmQ7D3+SB4dAu+1gec9Pp9HuS2em 3BBpwDEj7DyjxSYc6iuY1TW/JVmo7U/pE/tUCSnHUkzJ/wit9T/7rU8xc4H5q+DmUNWl NSDJUXU3GBO1RC28jclfsIoF2DHlcKiXVfRlT2OpoKW5x6xn9oR1sY5RKL7fIDYahpB+ f2TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773504404; x=1774109204; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ztVKqP7Iue8aUh5WW0pabHa7SHe1KuIXZfJfBXrdn9M=; b=hMzzb7i5pgci4GZ26XW7aAYM1tr0EaUF77gKorrBPI1fEddA7YnMBG1i/crv0AL79Y puzvFPn4A2QHyITA5vBGP/n+WGoescain32fUDnP2AqviYGQmU57uLySN+d98Vd/DmHT oQDJWTplhavjw/JIqKmcvUEQshzG/gVQlMxNkDRR4VuIPo293+sL58uNzrsTR+baAjMB szf4bvN9oUllAJJhMAfRzEzGySFRzKSlDql9s24zIrsjGmtWBd8SvVGL5gI7qXiqvFN4 bq3uPZv+uykZ6ZNbWpWN+pFbTShx2uxMzYfCxQ5t3U5XS4E2RnPYQXK5R4LYOZ33D+b/ QZRg== X-Forwarded-Encrypted: i=1; AJvYcCW+sS+BhwLrFC62TXdB1a3bkUFPtApbeBZ3y4h2i0bfv5Pt7xuMR0diYpzUNj2u75pcfD94KOQ6grApWw0=@vger.kernel.org X-Gm-Message-State: AOJu0YxW5foGbEo5su8VhxxjbI9CpauhzD1vdj0eSb56/qoj4A6IHWUB RJFfYLgrOJysw192BMQCqgAI+6IxQ8Tu/E7JwE4kXQvAYxWn96B3I2HR X-Gm-Gg: ATEYQzzOC3b542HHLfE6JDVuFmZL/wsYBHH57WLkPZ41z07qEvlNDOxhIbampBV9Mrr o2hs0D+ky3bZbq2oRwzq/psLQybOJdG2ZhgvaeJZqSOri8iJJti2YC/26vAclqeLzm2AYCLskvU +zSNYd344JEXwlvdGO4VdYtj8aSoDWyDdOTcs3TDSkdl4+qp7P41QgSrgzhFz+qPrs0pIXOIuwu wHoeVwN+dXIkP3ZgHjpykOeJceoyLRKkaWvQmlO4UJqqikNilieaGv/TTHqbfOVZ6nXrrGhH3Ba yNQkjpYaGm4IYqqLlZqXySvFhMeKi/Ual52k5rdHAAnjnLOXb5H9Ls94sxFC9y8U8n1i/W9vvBd ctGKhopistc5h5ZTW8WkmLV7V+NVfso+7wv7JKLMZT5Wz2KjLCBkR40L3AYOFPz96F+uaz5dJxE dWKx/jxzXxxjrt3wQT2o/lbCoRtA== X-Received: by 2002:a17:907:746:b0:b97:6384:2317 with SMTP id a640c23a62f3a-b97650e5609mr440832566b.17.1773504404085; Sat, 14 Mar 2026 09:06:44 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b978b8625d3sm151722366b.52.2026.03.14.09.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 09:06:43 -0700 (PDT) From: Erikas Bitovtas Date: Sat, 14 Mar 2026 18:06:35 +0200 Subject: [PATCH v3 6/6] iio: light: vcnl4000: use variables for I2C client and device instances Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260314-vcnl4000-regulators-v3-6-3c4a48d30676@gmail.com> References: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> In-Reply-To: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 After moving data->client and client->dev into variables of their own, replace all instances of data->client and client->dev being used in vcnl4200_init and vcnl4000_probe by the said variables to reduce clutter. Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index c8bb1826b916..9b7cd3f0c8fb 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -362,14 +362,14 @@ static int vcnl4200_init(struct vcnl4000_data *data) int ret, id; u16 regval; =20 - ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_DEV_ID); + ret =3D i2c_smbus_read_word_data(client, VCNL4200_DEV_ID); if (ret < 0) return ret; =20 id =3D ret & 0xff; =20 if (id !=3D VCNL4200_PROD_ID) { - ret =3D i2c_smbus_read_word_data(data->client, VCNL4040_DEV_ID); + ret =3D i2c_smbus_read_word_data(client, VCNL4040_DEV_ID); if (ret < 0) return ret; =20 @@ -379,7 +379,7 @@ static int vcnl4200_init(struct vcnl4000_data *data) return -ENODEV; } =20 - dev_dbg(&data->client->dev, "device id 0x%x", id); + dev_dbg(dev, "device id 0x%x", id); =20 data->rev =3D (ret >> 8) & 0xf; data->ps_int =3D 0; @@ -413,23 +413,23 @@ static int vcnl4200_init(struct vcnl4000_data *data) return ret; =20 /* Use 16 bits proximity sensor readings */ - ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF1); + ret =3D i2c_smbus_read_word_data(client, VCNL4200_PS_CONF1); if (ret < 0) return ret; =20 regval =3D ret | VCNL4040_PS_CONF2_PS_HD; - ret =3D i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF1, + ret =3D i2c_smbus_write_word_data(client, VCNL4200_PS_CONF1, regval); if (ret < 0) return ret; =20 /* Align proximity sensor sample rate to 16 bits data width */ - ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF3); + ret =3D i2c_smbus_read_word_data(client, VCNL4200_PS_CONF3); if (ret < 0) return ret; =20 regval =3D ret | VCNL4040_CONF3_PS_SAMPLE_16BITS; - ret =3D i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF3, + ret =3D i2c_smbus_write_word_data(client, VCNL4200_PS_CONF3, regval); if (ret < 0) return ret; @@ -1998,7 +1998,7 @@ static int vcnl4000_probe(struct i2c_client *client) struct device *dev =3D &client->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; =20 @@ -2022,10 +2022,10 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret < 0) return ret; =20 - dev_dbg(&client->dev, "%s Ambient light/proximity sensor, Rev: %02x\n", + dev_dbg(dev, "%s Ambient light/proximity sensor, Rev: %02x\n", data->chip_spec->prod, data->rev); =20 - if (device_property_read_u32(&client->dev, "proximity-near-level", + if (device_property_read_u32(dev, "proximity-near-level", &data->near_level)) data->near_level =3D 0; =20 @@ -2037,7 +2037,7 @@ static int vcnl4000_probe(struct i2c_client *client) =20 if (data->chip_spec->trig_buffer_func && data->chip_spec->buffer_setup_ops) { - ret =3D devm_iio_triggered_buffer_setup(&client->dev, indio_dev, + ret =3D devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, data->chip_spec->trig_buffer_func, data->chip_spec->buffer_setup_ops); @@ -2046,8 +2046,8 @@ static int vcnl4000_probe(struct i2c_client *client) } =20 if (client->irq && data->chip_spec->irq_thread) { - ret =3D devm_request_threaded_irq(&client->dev, client->irq, - NULL, data->chip_spec->irq_thread, + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, + data->chip_spec->irq_thread, IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "vcnl4000_irq", @@ -2060,7 +2060,7 @@ static int vcnl4000_probe(struct i2c_client *client) return ret; } =20 - ret =3D pm_runtime_set_active(&client->dev); + ret =3D pm_runtime_set_active(dev); if (ret < 0) goto fail_poweroff; =20 @@ -2068,9 +2068,9 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret < 0) goto fail_poweroff; =20 - pm_runtime_enable(&client->dev); - pm_runtime_set_autosuspend_delay(&client->dev, VCNL4000_SLEEP_DELAY_MS); - pm_runtime_use_autosuspend(&client->dev); + pm_runtime_enable(dev); + pm_runtime_set_autosuspend_delay(dev, VCNL4000_SLEEP_DELAY_MS); + pm_runtime_use_autosuspend(dev); =20 return 0; fail_poweroff: --=20 2.53.0