From nobody Tue Apr 7 08:09:53 2026 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6909434DCE6 for ; Sat, 14 Mar 2026 16:06:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773504402; cv=none; b=PMx6NjqIcDG32O/p7VYYsBpIu69zKgSshDm+hLA4dmWuIFQqzHm/10rqZeuGAL2mw85t/M5p+KhgSRfMuprowZ2LwkolWMrDxKI1iQD3zxwh77yiOF/kpQWIDhTaKnrlOaN7OL2fQ9BTP9I1q0667Dmik1vK9p/i42OPIzaK5Bk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773504402; c=relaxed/simple; bh=lHEF6gffcSJSnQo4z2EbBuNrPboTiVaWCanIyhfeSeE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oCGiJvTqcHy/dXGNXe07Iodugs1zMT+oiX5pMXqBf5Pqd550yvbH2OsrAiTVhHF2/wVlSTBlXpDjKdYS1/D5XKG7C0ubFKpnnAtoHQWrsHf/WqWY6JGjo55rLTrSIiZS1BVWDx0nBXlXT6jfcWQbjU6OLNx3W2mWeHEpJb0jVkY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iW3Jcuom; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iW3Jcuom" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-661cfb9f3aaso4485032a12.2 for ; Sat, 14 Mar 2026 09:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773504399; x=1774109199; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=A+I3WG1paH1NyUuAIPAj7t3lCASphrEGmzEIZovUf74=; b=iW3JcuomsN5uwmuYAgh8XnBNYkOXoV3luzhQ99V+l6Bwv9qacQzW3RN3a7QjIyj8Z7 //Lic3exO5wkJneyPI+S8GhXCw4QL9DBj3FtVDphK4BhybgDFUKLJvxOGmD57hbqnx+r AwyKTAEjeEoJQKkqIlk3JjHiyfZPcBtzU8rFgAjNXIJ3lJCy312oquV3M/x6X4yr1Ioj EgqqPO/MEoeFbg6FGahv3uU5wO+YK5fTmJtKrfavIuyM/wxeFuxmk4IZ4BQcCXWoO3CD oqoJAiY4WY2X7TMsLvZyEgpTYXfSyhx8YLdbRX3j+SUEXKrIqPwO8lKnylTdoGkVgnOa kT6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773504399; x=1774109199; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=A+I3WG1paH1NyUuAIPAj7t3lCASphrEGmzEIZovUf74=; b=MXZVX6SrpiAy7T9/lUomnhvQxYQz/z8UIK1pU9gKfZRG3g7jJ8my2h+3txZ8OPMNg/ dhZVZLLHi1RB3p0cXnVX9v1F/mXTUSpYpupWRPm+cjt+ywn1O1CN1pQsmtl2A3AR9bLg QKBq0JNuuPOSCyYZ2s1z6Oh/BYmr3Zztx6mmxWNzu+K+Kp2Y4VO5ydcHGYESLKc4b9Zi tyVoVnx9hexVYNUyeDyeAeNZy5tjoo32tJtd/QhS5J8/TYSYlF9IqHxLoRH1jTJXDVVm gOac2LfzPx1RBpNmUW2MVL86S1taAhCNqLMwpzXBepfyz3PZmSg9ilUr+BY/6VdsimTo PzuQ== X-Forwarded-Encrypted: i=1; AJvYcCWtns0C+QDXNey8rvALriglsGAarOil27i3WOyx2N+O7+Y+fnEP0ncTV1inryOcPEp0UOhTEwmkW3xSKPk=@vger.kernel.org X-Gm-Message-State: AOJu0YwxjMy4Bkh8IzzV3DVpicB0trYpd6QdQTvb+80ZO73Su/kqQyvS ZMEPUBlmMZ6rHhb4pMSZeBrULnIlwAK1GZ5CnCN50HU3UiaY7HRCTCl8 X-Gm-Gg: ATEYQzw84J1TXW3rDbGBsiwuTVLzr6WibgMWQNafHJOQzXlw+01q9hLiELGRBgAoF++ yfKtEbLzN101mJiAfOKJ+HMs/RGDwDyVMF2sQqrxnybroqNonpsP1oMbmXEtWuMdNqxdSg7elBS KaiHhP4zq3pVPgVwo3Hl1NruJcki3WS4LD4xi3BqQcJgEITom3sk7eaKpuyDb0RL4RP2clzHT+l Ei8xrm0FNuVNIz1ly8ZNs0ZJjiaM0pK3les1PgeSNXEHNbOrMx+JDLeqI6kTWv/1Z5aQN5xahGj YzpK3EfiPBZtmHfbJ1Lb75F1WlHUt7XRD4SImJMfEGg48Ea+HyHyoGSdn+pT0nGJSGWU6zMzuBs cPazTcH693HlETaD8IUN8Pyn7OcEFk5qkBjnwybhYiZHTYjHkNE2YHWtUVLmQiu1W/51IiC4nWf SIFflrW3VRaiwtg0a+Bhz+EtFjCw== X-Received: by 2002:a17:906:3419:b0:b8e:8874:8384 with SMTP id a640c23a62f3a-b9764f8b1fbmr330896066b.4.1773504398404; Sat, 14 Mar 2026 09:06:38 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b978b8625d3sm151722366b.52.2026.03.14.09.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 09:06:38 -0700 (PDT) From: Erikas Bitovtas Date: Sat, 14 Mar 2026 18:06:30 +0200 Subject: [PATCH v3 1/6] dt-bindings: iio: light: vcnl4000: add regulators Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260314-vcnl4000-regulators-v3-1-3c4a48d30676@gmail.com> References: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> In-Reply-To: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 This commit adds supply properties for the sensor, I2C bus and IR LED anode supplies [1], which can be found in vcnl4000 ambient light and proximity sensors, to ensure the sensor is powered on before proceeding with setup. [1] https://www.vishay.com/docs/84274/vcnl4040.pdf Signed-off-by: Erikas Bitovtas Reviewed-by: David Lechner --- Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++= ++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.ya= ml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml index 2ba4d5de4ec4..a1b4c02db246 100644 --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml @@ -33,6 +33,10 @@ properties: interrupts: maxItems: 1 =20 + vdd-supply: true + vddio-supply: true + vled-supply: true + reg: maxItems: 1 =20 @@ -54,6 +58,9 @@ examples: compatible =3D "vishay,vcnl4200"; reg =3D <0x51>; proximity-near-level =3D <220>; + vdd-supply =3D <®_vdd>; + vddio-supply =3D <®_vddio>; + vled-supply =3D <®_vled>; }; }; ... --=20 2.53.0 From nobody Tue Apr 7 08:09:53 2026 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 864ED37755D for ; Sat, 14 Mar 2026 16:06:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773504402; cv=none; b=MkvcJ/5F5tqZvk6RlDavdlVHWGD/cj4SDPVHUd/878pH7dUOtUkU+uvLmObfCRUEe3qkIDxvlFT5tXymTs1gccLCV1zIZg5z8IE0fCyokRDn3zUatZxkKa8oFgNUG4F4V+LOea3ttcB7r96dUgDaLaz27XuYtCyxy/7LhTnR5u4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773504402; c=relaxed/simple; bh=yU/EQoZ1q596/CHvlN7YkhPccRT6mfDqWPXqpjdWn3U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dnbN9vUrFjjbbosGtDrtIxL3dSEcgtZ/CaYPciCl2DEezHEoa41gtzohQV1qGH2fs2CK2/C2/I6V+Zu13QncRu6YrXmtCiOMba3P66LQdSY3jcD06OvCyFTLuZFx5NOguc+NbweyXQcUU7efoGorBcYbOO5C/zBE/Ofdi62H95U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=InXjng05; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="InXjng05" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b976536806cso326068966b.0 for ; Sat, 14 Mar 2026 09:06:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773504400; x=1774109200; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zfIqfSEipe7Ni8DeiT4tR7mdwm129F2XmqEhRhL601Q=; b=InXjng0533pGZC0bIiIint9lnnbG1fMbU1aF903clZ1IZtJLoHiVnlpsnTD6K9OShJ MurP1C4iTWA0fH9V62ufxriT2ZXUia4Np18Y+kFI1crWlflGO5xcHjoQr4HH6z4NCjBO VWj6TVhJczYETTy2zn92ZQdU2lHwpPgKzw5mmIS3bP7cqOYjTR6Rg0Aa7ywBmBhaZFiq xVO7wXdcR4gYC1tx6sajqCubD9I9u/9VG9+9rvWXaCsmpR4uamyxdnN/dOwvn3uYDnK4 q+1tF/QD33bwvBV/hlbk2Qn2Y5sLrZYS9Wpa9HHng1uca5I3x3TSP7JGMqin0kjka0pv MRMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773504400; x=1774109200; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zfIqfSEipe7Ni8DeiT4tR7mdwm129F2XmqEhRhL601Q=; b=QKw0Ce4orpXR9ytVTAmCXLBjBZLWAIoqjlLpYbx51uvR7e1Oo2Ypif4MNrCvlGdTyo Dv+c35xTPdj3KsovJ8S5Chqrcn29kR4MnNzf2nS0kDCqi5a5MRRqTpKbQKXsTYjtP6qV ikZcqGeHaNI2OVM/0zW36CE4WbQUfgeW1NIituco6uLvQ3CvLnyMR53W681jglF90r+D PN5EZab2ggWm1Oo23AhBBWxU60p3s8QOUMhowIKzaLToi9cUyxBTsOgRWmDYxfkvs1Mr 8eUCRJSK42g+MQ85C31Kt8E/Esi5cw13ozcSqUDMxAO+SV+0ZLx2tWwsDSKUC7LPMqPz UTzw== X-Forwarded-Encrypted: i=1; AJvYcCVPCcnL9BWAFtCQe0GmUqE1OXH43YnzepsBx0jrhv4gcUgcXcYvox2Qk2hXkSBSP/T+Cso4utnoyWKbNqY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywegcw6OJfLIBwk8LrRdzCZdX5iEBG7uUI7g7m72ra2Bf5YVDXg PsdB0qZZFlcNMqpZUg2xPj0RtbsU+DyrFVuUF97a01rs/jQQFfvFLOOn X-Gm-Gg: ATEYQzxOERLpfkxgHW8LY2vpCs5MD0lb171IXi/RUNIz0q5XUWvJ4PkPPQuzCo2GLf6 qD9wr2NMAK/SiMKkV+8c/MjctJVf1BOJBEgOg37G+16LHfEPEO0dLaTpD91e/L2Pcy0Jw0uAQ6t 94nWK8Tl/6gpV9f/ejEH4AH2CacUZt9fcusEdlLHBhHU3NAi7dY0EvMTLQmx2i0ajwTltFrciuk aUMXkuPpDqFTkbAlNyreXf4rBuBRL8M4wnMUlDn01pdaDJr5LQVxuiOkz4PJiX6EV/QbCP3tYCD s9p7GsBDL64k3rpkek6rRk2kBc+rH1wX3O3j5IJfMkN/r45ct1k/31gHryWzYiBKUpII0PacrLM B7Y9SjXXALzsmmKqjfXwABGCmXX6CDJbRKCK29fsPh1Hm241YjVqtYjNTOsr0tJjD3aVYA81GMq SJVoWGg6eWQpsEzr99bwYqB2Uq4w== X-Received: by 2002:a17:907:7253:b0:b97:554:f100 with SMTP id a640c23a62f3a-b97650f31c6mr423401666b.20.1773504399716; Sat, 14 Mar 2026 09:06:39 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b978b8625d3sm151722366b.52.2026.03.14.09.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 09:06:39 -0700 (PDT) From: Erikas Bitovtas Date: Sat, 14 Mar 2026 18:06:31 +0200 Subject: [PATCH v3 2/6] iio: light: vcnl4000: sort includes by their name Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260314-vcnl4000-regulators-v3-2-3c4a48d30676@gmail.com> References: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> In-Reply-To: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 Sort include headers by file name for better readability. Signed-off-by: Erikas Bitovtas Reviewed-by: David Lechner --- drivers/iio/light/vcnl4000.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 5e03c3d8874b..939ff2d65105 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -18,12 +18,12 @@ */ =20 #include -#include -#include -#include #include -#include +#include +#include #include +#include +#include #include =20 #include --=20 2.53.0 From nobody Tue Apr 7 08:09:53 2026 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A96B8378811 for ; Sat, 14 Mar 2026 16:06:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773504404; cv=none; b=GcrqniX0dlAO0GStbTzhNum0ZBD38RRlIW0hgHOFUKyvfsE/AaDQrvdYCi7DmEpUg3pL/CyOyP6cF/7RqJSMkTcXFem6nvZ6KXeHD0tdt/uXj3AFbZk2yC4UVzXZeqfYNtPVuyeQ6wyEdETL6UQdK8WIoxsKeS1Qo+b3hufwrTw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773504404; c=relaxed/simple; bh=3QQmY5CvKjA1E5rLrX7dDBxYJh7qOARmrpAafvS7J+M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=a9RhQXsl8xA1K3CVhw5JpgAhwA+IzZsqWvo8rl+Xx5Hcr+mLknPsR33HBsFDg+Yp5UVtcLBlVClzunn6cmbQndNE34kJOsiFn/SttuVH4QUFj6l8zQAcZ8/NpXUq6Cfdq1YsASlhn+CbiHXa60kG8Wnd2HXZT8yv72mK7BPQf3o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Db0+Hzbg; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Db0+Hzbg" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-6631e0edcf1so4519057a12.1 for ; Sat, 14 Mar 2026 09:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773504401; x=1774109201; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Jgo0ap3z9r3Z/5/BkWKWT8DoiYsa3x1eda5HahP1HP4=; b=Db0+HzbgF5GmjcmoHiXDGdO1My9I5q8mAL5FCQvV2Jd3BVIOVbLSiFOcfpFyU2yzYw mo8H2DQOoLvr6rrjQjReAHmE9FAzMJm5ox9zv2goWBEc1W8DvzIGJYiBnTEu2M0Cz5h3 ZJMV0ox8iXPBV193iDFW9Mju7rck5JZzIUQ5f/iX5An7GNiatM9Ml76t+SeU3CVTZHrq 81kzhcQfIIrQxRacSjoehq6d5X3f879xNRumQtMK9m/2dPaDvn81qT+hiuwLXUGSifaI bR+3KF0pdr3Ws2rXvkK/22Wvw3VsYlhldy0S+cmpcNvyuKrXKm74a48YFh0IbDkxXkew PlaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773504401; x=1774109201; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Jgo0ap3z9r3Z/5/BkWKWT8DoiYsa3x1eda5HahP1HP4=; b=GVSLHSNWOrnKc8SnDmn4ewKZ7qqFuXd/lCDLB1L1YErB3xGVLRzx9k2Vtkf7LLUOcx 6rywAuTI+cAxo1ZPjA6c1llhzggqs3JageR58Pz4CwjgimAAcnDfNqHp4QvCfOFiMQjI oMMaDGr4HmKDv85Pv0jroSlhVGjKuxDCCk/coClz9HCyU4bJ4M+otMQrsy3ooA51xztf Ov9l0+8NzwNbNQLUGqu0xfnu3FXDF96rOmk6/2+WQtEs4ZQJ8Y9es+4co8aFoBhO7kPx +xMeGO6YkmuWnmuvnZnz+neHxOfh86lCWN5pGV+FVrc088DfQlyHJbfJ17kxgvZFZmPy 2SaQ== X-Forwarded-Encrypted: i=1; AJvYcCWghq9AH+evcsrYdTAEKrIjEcHozhpvIizU0VdOVNR8mch0TtLBmfctSM+rNvdAraOlCxR8FDe3LsdrEt8=@vger.kernel.org X-Gm-Message-State: AOJu0YzefYKSXAen8meEDN3K+DIyIemlhuKXPc78uht0eU67U2XzrKuV IkNCyqJDhsjN2gTI9AY9MK18S7IIqdtqv1kzx8tO62yu4ZY3xI4ZXcrz X-Gm-Gg: ATEYQzwpHknjCVbFbWkW4tOHMAy88cJB0zoexNLHXjl/yyM/Y2/qa1GhPEyUWpLUswv 69NffFSYhJSUGkdkOGL0oxWE1623v66yj7Qu5qZbfkuWMZCMQLRu2P4Gw35Hh6/HdcL5hBEsIzF mFk7QSi2Lma65ujb/7GI48XUKbKxWwV3R3Hz0Y5+2FMeqPwV05Rj8PDUHNLmvFKY9MeIphxsZ/V HBsElSwc4/BjTc2lR4SxGdeKnsrMmV//OzBeyIRUSGkAc9U4dpP3C/wEn22d+8zFscv4JsvSy3C JMESYdgzcyd4jMiazM5VyjU56iSf0boWWoZLaHvhto630YmoHHiuSEuIIkzdSrVnCz99edSEkXF MMzzgBuQlZG+YZEBOl8HbCB3VuxkJmB5JNTp4KSF30MNhBq4puX859lztlHmbKp/PcNzoKSdigD iihbLYYDcqyGWa/DylqjdxKThYyQ== X-Received: by 2002:a17:906:dc90:b0:b97:6a80:38b6 with SMTP id a640c23a62f3a-b976a803ab3mr374400466b.13.1773504400837; Sat, 14 Mar 2026 09:06:40 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b978b8625d3sm151722366b.52.2026.03.14.09.06.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 09:06:40 -0700 (PDT) From: Erikas Bitovtas Date: Sat, 14 Mar 2026 18:06:32 +0200 Subject: [PATCH v3 3/6] iio: light: vcnl4000: replace mutex_init with devm_mutex_init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260314-vcnl4000-regulators-v3-3-3c4a48d30676@gmail.com> References: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> In-Reply-To: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 Replace mutex_init used across driver with its device-managed counterpart, so all assigned mutexes get destroyed. Signed-off-by: Erikas Bitovtas Reviewed-by: David Lechner --- drivers/iio/light/vcnl4000.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 939ff2d65105..0ee307fc5ab7 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -356,6 +356,8 @@ static int vcnl4200_set_power_state(struct vcnl4000_dat= a *data, bool on) =20 static int vcnl4200_init(struct vcnl4000_data *data) { + struct i2c_client *client =3D data->client; + struct device *dev =3D &client->dev; int ret, id; u16 regval; =20 @@ -400,8 +402,14 @@ static int vcnl4200_init(struct vcnl4000_data *data) } data->al_scale =3D data->chip_spec->ulux_step; data->ps_scale =3D 16; - mutex_init(&data->vcnl4200_al.lock); - mutex_init(&data->vcnl4200_ps.lock); + + ret =3D devm_mutex_init(dev, &data->vcnl4200_al.lock); + if (ret < 0) + return ret; + + ret =3D devm_mutex_init(dev, &data->vcnl4200_ps.lock); + if (ret < 0) + return ret; =20 /* Use 16 bits proximity sensor readings */ ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF1); @@ -1985,6 +1993,7 @@ static int vcnl4000_probe(struct i2c_client *client) const struct i2c_device_id *id =3D i2c_client_get_device_id(client); struct vcnl4000_data *data; struct iio_dev *indio_dev; + struct device *dev =3D &client->dev; int ret; =20 indio_dev =3D devm_iio_device_alloc(&client->dev, sizeof(*data)); @@ -1997,7 +2006,9 @@ static int vcnl4000_probe(struct i2c_client *client) data->id =3D id->driver_data; data->chip_spec =3D &vcnl4000_chip_spec_cfg[data->id]; =20 - mutex_init(&data->vcnl4000_lock); + ret =3D devm_mutex_init(dev, &data->vcnl4000_lock); + if (ret < 0) + return ret; =20 ret =3D data->chip_spec->init(data); if (ret < 0) --=20 2.53.0 From nobody Tue Apr 7 08:09:53 2026 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F11E3793C1 for ; Sat, 14 Mar 2026 16:06:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773504406; cv=none; b=lXwzoMNlAVMaNR7jzTyPb12/tRDyRpTKlWXkqQSsCqnq7n5HcDFxRAZdV084iuCPYucVh86H8r2n+RjdEBrIFa6j/m+rvdOY6IWSQUN3K0Ktqs38ByS/OVfOJ0rQ1Ux2TdZuxfBPSUenSl4nNR5PsVT3Cc8vG9QQOvdlqJs/Mls= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773504406; c=relaxed/simple; bh=j6qWWe6QEp4AZVAT6HIO6TViQIm6aoaS6Zal4S7e85c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JTDEhfqO0/BW20d2Q9+iLCI2Ra328NxGhfE00fGGjucmmG9SuTOjtH35KcPTblB08vhBkWYvI9MxzFIhm6BceUGvx7yvF/rCOITN7+F8y4/Uom1aZQSBB/N+71YLOlmcwawhytj/a0XOQCqemFwPkCH35EcVcpxEdnGj1/Xuag8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YwhUlJB4; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YwhUlJB4" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b9358dd7f79so508737566b.1 for ; Sat, 14 Mar 2026 09:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773504402; x=1774109202; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pgQ8nZvVLHmAMjTgF6dNW3MLBAIvM4glDSXsOvEDdCg=; b=YwhUlJB445tKoZ1CRAnYSeqWBXS+3hEiTngSSs/xWTb3T7+c68p1aulsxcX9mPdXyR ctxFO6wv/0+7kx4/I2XnLsONDbwb2sfT95VsaRN2Du9JTfEEnx9jiJ7ZQug4hzxihLYx f/grZjcT8kh1qcWDn1wcC+JSzbLTLI+xj36RKbalY//glNcz2yQDDWRF4Z4kQV4bKE15 ULyciwpr3nokbwnPEQvWngxpZ6gBnWmOJ4/6+cM0kjfSDDg4qPoBNIfEeNJ2V/wgD44Q 2Nx9UFeeXmiF1dHWNXY3R7uHeYUTJwLuWtwnZmBCYRY+R7OiGLvFeIZIW3AwajUuaAJn kaoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773504402; x=1774109202; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pgQ8nZvVLHmAMjTgF6dNW3MLBAIvM4glDSXsOvEDdCg=; b=W5tkSaR7PJIkgpfk7qn3TPVDhO3mHtaDtesvJNv46ZyB0CT4mGiOELJ1ef44gqpZpe ke8Pb2huZculP85+ZQ00tP1Od6AL/BYkHBV4vOy9pYdbl9W82gpcDtLXDVbe6sjaEtDk i59YcVcPFJOemIVlrr6UvlWbYBjv4p51rucG9M9gDwlx8dTkEz3Jib2CvBeYJugZS+Cr 5JTFBpNR90KDsLB8r0IevSfD/57a30dYhScBTbc6jQ+pJp5ZqDUP5UzumDeuQAMkVFEv 74pqJXk0btSB6HgwPnzfN5tGcY092kdiTLUntd3k4ZnRtPj6qev+5oW9p1bdhPO+9/w3 JNeg== X-Forwarded-Encrypted: i=1; AJvYcCUBdqYLUoi29nE1gJPNIV84TbpjCPeeVhOroy7qU+g6v+hmuMBUZo3Sx+25NkY2U7mmjjM4wt6cXi4s6ms=@vger.kernel.org X-Gm-Message-State: AOJu0YzrAT5VgUWqwR2F95QooDzqUwAJaWBrNA9CdnEYwQ9dXVzV8Vu8 oi8JrDEtLlkojV4804dzGIaeLyxpT0ulMZnhhHpmlfeqbBn3x0x2Nv8U X-Gm-Gg: ATEYQzxs8w8G9OvWrByUdSqVyYYRIXRP+qcl1RF5wJyyzxgaSYRxUW5OUW2FWHqgNKl ou6khslr0i6uoVKpExXcmKeEnBYZpbd8RG4rP05HUkWCBBPtp+V9SlKj1B7ORv2q3eV4Yh/U3PF Qx6Iu7MPqSQO5cT/WM9rcxSg+99kqW8v6V76iaFYW6YRXWwctNprKdbYnyNThQdPSdhHwtAFtMI QPfZGJ8TBIgo1Q4dOvOhXDkcHTbbQZXVUjjkm+UNQK+PrQ5hySkxPSgbNFLGwprUQdtlIc77o+b ModO72bEOeQt6zCva1xnvOLVBZAi2M75Y0bbu25SHJatBUgkG9inFccCpa7NvV0IH/u5E3N4zMx yiaK8KyrP1bIYRp+/c2X2kKD4Xi3Bh087iiACkhdg5EoGRNgHJCkj7KeZ653m/eFYUgCfOvRJM8 CJyXIdnUUJ3p/B/RvugUwJY+HRmQ== X-Received: by 2002:a17:906:e96:b0:b8f:7aa8:d9a4 with SMTP id a640c23a62f3a-b9764fc9c3dmr278758466b.20.1773504401926; Sat, 14 Mar 2026 09:06:41 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b978b8625d3sm151722366b.52.2026.03.14.09.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 09:06:41 -0700 (PDT) From: Erikas Bitovtas Date: Sat, 14 Mar 2026 18:06:33 +0200 Subject: [PATCH v3 4/6] iio: light: vcnl4000: add support for regulators Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260314-vcnl4000-regulators-v3-4-3c4a48d30676@gmail.com> References: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> In-Reply-To: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas , Raymond Hackley X-Mailer: b4 0.14.3 Add supply, I2C and cathode voltage regulators to the sensor and enable them. This keeps the sensor powered on even after its only supply shared by another device shuts down. Signed-off-by: Erikas Bitovtas Reported-by: Raymond Hackley Reviewed-by: David Lechner --- drivers/iio/light/vcnl4000.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 0ee307fc5ab7..e501db7249d7 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -24,6 +24,7 @@ #include #include #include +#include #include =20 #include @@ -1991,6 +1992,7 @@ static int vcnl4010_probe_trigger(struct iio_dev *ind= io_dev) static int vcnl4000_probe(struct i2c_client *client) { const struct i2c_device_id *id =3D i2c_client_get_device_id(client); + const char * const regulator_names[] =3D { "vdd", "vddio", "vled" }; struct vcnl4000_data *data; struct iio_dev *indio_dev; struct device *dev =3D &client->dev; @@ -2006,6 +2008,12 @@ static int vcnl4000_probe(struct i2c_client *client) data->id =3D id->driver_data; data->chip_spec =3D &vcnl4000_chip_spec_cfg[data->id]; =20 + ret =3D devm_regulator_bulk_get_enable(dev, + ARRAY_SIZE(regulator_names), + regulator_names); + if (ret < 0) + return ret; + ret =3D devm_mutex_init(dev, &data->vcnl4000_lock); if (ret < 0) return ret; --=20 2.53.0 From nobody Tue Apr 7 08:09:53 2026 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A567637B036 for ; Sat, 14 Mar 2026 16:06:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773504406; cv=none; b=dzNs2ruE6LPqNUSg7rhHGdr5jb7/4HxfQz24JVFJKZ3skCgU29RtyZ8STg4Njy4BpBun7dnG6eUrEE/SvRHO8CoJW6p1pnwi7JWlAlaSCB6/RwzSCvQwhD2FTpIkF5YyY+dBU3FaSW1EWT/l9dPDEuxxNNeXlDYVJCnrxmuSbWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773504406; c=relaxed/simple; bh=ewacY4CtjcZ9Q6nfX9avDl3jskAs7cDNt4STGuQgQMI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=T2mPBqwENAp7fRNFXstOs+qnsfr5eqYxostJmTOi3gupDF90mU7Pl9UhQnAFr8KhuuaeVFCCnXgW7XSyUzStExbANRvo3r/YKuGeUEs36LEPWLA4xTVhxfxjCM/AgLpDkuzftD9qBocLh653fDTxtcHW5zSvppTK9uDQMJc5STo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KP/o+utc; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KP/o+utc" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b9789425fc5so97076966b.1 for ; Sat, 14 Mar 2026 09:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773504403; x=1774109203; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nfmCl3VC8crQVQSKGIh/XriSOgp+m5SIVFUaVS68dLI=; b=KP/o+utcjt6WLnHR6tr6bexxj/BDDH2mWoVlJ1IQV+l+L6tSjhuWB/lme+Tnge6u4J GrmxuxHUEMDicLUvoEjx3ZAdookgS8XG9tTWhz17aABinRn5/AkCCXC0M0MMB+J+uXhX nY/9lgVjVEohSX7XrO/JPkgQIL3XvPtph1n++ixBWiKy93xayByMH6EwObGCyzs9CYjP EyYR3gbyue5G+dySBtxgUrfFWVsMCKFN+ktgYL+GHudFMyDqnwIFfksxiAQchX4QaOba IImUPm0cXiRWXRjblu/y8tNMWTyzslcLqbKD9hOEtmUIZTklXCm2ignbSPfpZ15968/d ibSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773504403; x=1774109203; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nfmCl3VC8crQVQSKGIh/XriSOgp+m5SIVFUaVS68dLI=; b=N3V+J2RTdq8w+cTzwXDV1n2djkpHpmTOdWa7D8h0r+AUagFxtLp1MiV2UZXQG510Q8 QcrwulxrtBPSC9wIfAi+jTG2W3lKvKkoVq9Jv8SGQSt2zmFRwUuOY8oV8cuTq+ZKZ0o6 tmYUt4wxWIlzGIbsT8ZgPsV5LnyAk2Bx2rnnQjcTZmnmuNUWkcfLZcx1/ZOszD/6PWfE wWnjm256Tka9Sm3iOdhsU7moapqVoeuU30P/6Ws3p/Zs5LTH+pOtKfgpMeKjNijj5EAT Mtl72m4FAcQRPNtS+AuZJf/54V+lPpQCXHZzNRudELzhCTTVvoqr5xti1PHZFrgQe+Dt WpfA== X-Forwarded-Encrypted: i=1; AJvYcCVKoRx7DCdxgfSWkAyAj0CcCMwnwG0CcwjyaEA7pnZJzYxX2Tnzir7H0kcV8G1+Sj1J+OEvkMFY2KiZSN4=@vger.kernel.org X-Gm-Message-State: AOJu0YxVRKMUNR1ulyL4IITnzBgV4UL4aLWGmvTfAg5TTPKEK17gyuvb wcAx9OmOWp+/p7HA7lsO1neZiUR48DrnoVo6lYUXfhTPbc/dVtiP4DcR X-Gm-Gg: ATEYQzwrnPrz9m2jrCIrwRft+4VEzcxODxydsKcVox2ZFIHpeospLSwawltDEHIquCA BY2AWL7mEZQWpQ2sHlaGtdt9WGnOWdnFwN45CFm3dEjO/loWTkleW2KKsIdOXxyNEiz41xMXna8 26vFz1tEk/CYyN3HvR/RbTJN76j+hCHxJT5xJuEF62Zd3C0PdOEZm5jH43MV003Z7zgpDgfU5Ri w4GCR5jn4itYj0yIPaxUfbidbqPRcuhAP16isKmOlpKjukrcLyCwWqql2vT6bn7XCSjhOA3uJyb M9JkRgBJr2blahAecVUyMmNGSfqQ/5vB4dBLNb83CX4fkW5Nwl5SxPSZcaIcCRPjoP0/dx4H4wt EqEgsKOjhn69jxEcz8rDlf3J7WehZ2Xvbz1xFT05C0XDkh7KDWKb6wX52QdshvUxC9/J0Mps+f/ G+lrgsheB/DBnJgkdmcrUOkM/Oww== X-Received: by 2002:a17:907:e8d:b0:b94:231f:26ca with SMTP id a640c23a62f3a-b973ffd3b49mr587744166b.20.1773504402922; Sat, 14 Mar 2026 09:06:42 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b978b8625d3sm151722366b.52.2026.03.14.09.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 09:06:42 -0700 (PDT) From: Erikas Bitovtas Date: Sat, 14 Mar 2026 18:06:34 +0200 Subject: [PATCH v3 5/6] iio: light: vcnl4000: remove error messages for trigger and irq Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260314-vcnl4000-regulators-v3-5-3c4a48d30676@gmail.com> References: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> In-Reply-To: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 The error code is available in the log after return. Remove duplicate error messages to reduce noise in dmesg. Signed-off-by: Erikas Bitovtas Reviewed-by: David Lechner --- drivers/iio/light/vcnl4000.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index e501db7249d7..c8bb1826b916 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -2041,11 +2041,8 @@ static int vcnl4000_probe(struct i2c_client *client) NULL, data->chip_spec->trig_buffer_func, data->chip_spec->buffer_setup_ops); - if (ret < 0) { - dev_err(&client->dev, - "unable to setup iio triggered buffer\n"); + if (ret < 0) return ret; - } } =20 if (client->irq && data->chip_spec->irq_thread) { @@ -2055,10 +2052,8 @@ static int vcnl4000_probe(struct i2c_client *client) IRQF_ONESHOT, "vcnl4000_irq", indio_dev); - if (ret < 0) { - dev_err(&client->dev, "irq request failed\n"); + if (ret < 0) return ret; - } =20 ret =3D vcnl4010_probe_trigger(indio_dev); if (ret < 0) --=20 2.53.0 From nobody Tue Apr 7 08:09:53 2026 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36C9437D104 for ; Sat, 14 Mar 2026 16:06:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773504407; cv=none; b=AIkoQEeSSsJnHziDRmkuSwTa1hrVQccPKbVNu3WoOUWH7ihY39K2337zIm4rArQSgYr4y7Wb59dZirJlM9PNSqaS8R8KflJyEegMQMrrjpmjA74prEhzPm6UnV6h0sogxvFEnnZSIesr0xnsL6elRLH/rDGK052H1gtqTMsfVfk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773504407; c=relaxed/simple; bh=AAYQH8m5hJopiQqgeTngADuMlO+elqyJCsSOeSZcnBU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UA/JY0z8RCQh8t6RifJ3Cvhe/1fz2AXRsGLu8SJw3k74YXQOZCwWmLFdC6YS/vpWjelRF5QgQ//UBWdPWj+nwm2ha2OdDBJ/16ZErUYAzMExuqWRW/kDcwWYF8ctRHZbENAWjfKqJy3FC1iLI1D0FUu5rfH9brm0WOIa7BgbOUY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dGaiKDey; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dGaiKDey" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b942a41c5fcso442712966b.0 for ; Sat, 14 Mar 2026 09:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773504404; x=1774109204; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ztVKqP7Iue8aUh5WW0pabHa7SHe1KuIXZfJfBXrdn9M=; b=dGaiKDeyCS/zMpoONAWtHlh6/lm5+lp/RD1B9EeSGZ2u5oRIpW1Iirkmz6zYIloLUs /VEQqCH0R4Ju26RpDnC1TS3BAF8DBdY3Q1WBZn2Uc+aCHx1O3h2FCSuD7NOXd8cKJyew J7uWG3FghoA8CkNzjwbAEajbKB3PKa6EDxnl9TvygmQ7D3+SB4dAu+1gec9Pp9HuS2em 3BBpwDEj7DyjxSYc6iuY1TW/JVmo7U/pE/tUCSnHUkzJ/wit9T/7rU8xc4H5q+DmUNWl NSDJUXU3GBO1RC28jclfsIoF2DHlcKiXVfRlT2OpoKW5x6xn9oR1sY5RKL7fIDYahpB+ f2TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773504404; x=1774109204; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ztVKqP7Iue8aUh5WW0pabHa7SHe1KuIXZfJfBXrdn9M=; b=hMzzb7i5pgci4GZ26XW7aAYM1tr0EaUF77gKorrBPI1fEddA7YnMBG1i/crv0AL79Y puzvFPn4A2QHyITA5vBGP/n+WGoescain32fUDnP2AqviYGQmU57uLySN+d98Vd/DmHT oQDJWTplhavjw/JIqKmcvUEQshzG/gVQlMxNkDRR4VuIPo293+sL58uNzrsTR+baAjMB szf4bvN9oUllAJJhMAfRzEzGySFRzKSlDql9s24zIrsjGmtWBd8SvVGL5gI7qXiqvFN4 bq3uPZv+uykZ6ZNbWpWN+pFbTShx2uxMzYfCxQ5t3U5XS4E2RnPYQXK5R4LYOZ33D+b/ QZRg== X-Forwarded-Encrypted: i=1; AJvYcCW+sS+BhwLrFC62TXdB1a3bkUFPtApbeBZ3y4h2i0bfv5Pt7xuMR0diYpzUNj2u75pcfD94KOQ6grApWw0=@vger.kernel.org X-Gm-Message-State: AOJu0YxW5foGbEo5su8VhxxjbI9CpauhzD1vdj0eSb56/qoj4A6IHWUB RJFfYLgrOJysw192BMQCqgAI+6IxQ8Tu/E7JwE4kXQvAYxWn96B3I2HR X-Gm-Gg: ATEYQzzOC3b542HHLfE6JDVuFmZL/wsYBHH57WLkPZ41z07qEvlNDOxhIbampBV9Mrr o2hs0D+ky3bZbq2oRwzq/psLQybOJdG2ZhgvaeJZqSOri8iJJti2YC/26vAclqeLzm2AYCLskvU +zSNYd344JEXwlvdGO4VdYtj8aSoDWyDdOTcs3TDSkdl4+qp7P41QgSrgzhFz+qPrs0pIXOIuwu wHoeVwN+dXIkP3ZgHjpykOeJceoyLRKkaWvQmlO4UJqqikNilieaGv/TTHqbfOVZ6nXrrGhH3Ba yNQkjpYaGm4IYqqLlZqXySvFhMeKi/Ual52k5rdHAAnjnLOXb5H9Ls94sxFC9y8U8n1i/W9vvBd ctGKhopistc5h5ZTW8WkmLV7V+NVfso+7wv7JKLMZT5Wz2KjLCBkR40L3AYOFPz96F+uaz5dJxE dWKx/jxzXxxjrt3wQT2o/lbCoRtA== X-Received: by 2002:a17:907:746:b0:b97:6384:2317 with SMTP id a640c23a62f3a-b97650e5609mr440832566b.17.1773504404085; Sat, 14 Mar 2026 09:06:44 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b978b8625d3sm151722366b.52.2026.03.14.09.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 09:06:43 -0700 (PDT) From: Erikas Bitovtas Date: Sat, 14 Mar 2026 18:06:35 +0200 Subject: [PATCH v3 6/6] iio: light: vcnl4000: use variables for I2C client and device instances Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260314-vcnl4000-regulators-v3-6-3c4a48d30676@gmail.com> References: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> In-Reply-To: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 After moving data->client and client->dev into variables of their own, replace all instances of data->client and client->dev being used in vcnl4200_init and vcnl4000_probe by the said variables to reduce clutter. Signed-off-by: Erikas Bitovtas Reviewed-by: David Lechner --- drivers/iio/light/vcnl4000.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index c8bb1826b916..9b7cd3f0c8fb 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -362,14 +362,14 @@ static int vcnl4200_init(struct vcnl4000_data *data) int ret, id; u16 regval; =20 - ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_DEV_ID); + ret =3D i2c_smbus_read_word_data(client, VCNL4200_DEV_ID); if (ret < 0) return ret; =20 id =3D ret & 0xff; =20 if (id !=3D VCNL4200_PROD_ID) { - ret =3D i2c_smbus_read_word_data(data->client, VCNL4040_DEV_ID); + ret =3D i2c_smbus_read_word_data(client, VCNL4040_DEV_ID); if (ret < 0) return ret; =20 @@ -379,7 +379,7 @@ static int vcnl4200_init(struct vcnl4000_data *data) return -ENODEV; } =20 - dev_dbg(&data->client->dev, "device id 0x%x", id); + dev_dbg(dev, "device id 0x%x", id); =20 data->rev =3D (ret >> 8) & 0xf; data->ps_int =3D 0; @@ -413,23 +413,23 @@ static int vcnl4200_init(struct vcnl4000_data *data) return ret; =20 /* Use 16 bits proximity sensor readings */ - ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF1); + ret =3D i2c_smbus_read_word_data(client, VCNL4200_PS_CONF1); if (ret < 0) return ret; =20 regval =3D ret | VCNL4040_PS_CONF2_PS_HD; - ret =3D i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF1, + ret =3D i2c_smbus_write_word_data(client, VCNL4200_PS_CONF1, regval); if (ret < 0) return ret; =20 /* Align proximity sensor sample rate to 16 bits data width */ - ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF3); + ret =3D i2c_smbus_read_word_data(client, VCNL4200_PS_CONF3); if (ret < 0) return ret; =20 regval =3D ret | VCNL4040_CONF3_PS_SAMPLE_16BITS; - ret =3D i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF3, + ret =3D i2c_smbus_write_word_data(client, VCNL4200_PS_CONF3, regval); if (ret < 0) return ret; @@ -1998,7 +1998,7 @@ static int vcnl4000_probe(struct i2c_client *client) struct device *dev =3D &client->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; =20 @@ -2022,10 +2022,10 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret < 0) return ret; =20 - dev_dbg(&client->dev, "%s Ambient light/proximity sensor, Rev: %02x\n", + dev_dbg(dev, "%s Ambient light/proximity sensor, Rev: %02x\n", data->chip_spec->prod, data->rev); =20 - if (device_property_read_u32(&client->dev, "proximity-near-level", + if (device_property_read_u32(dev, "proximity-near-level", &data->near_level)) data->near_level =3D 0; =20 @@ -2037,7 +2037,7 @@ static int vcnl4000_probe(struct i2c_client *client) =20 if (data->chip_spec->trig_buffer_func && data->chip_spec->buffer_setup_ops) { - ret =3D devm_iio_triggered_buffer_setup(&client->dev, indio_dev, + ret =3D devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, data->chip_spec->trig_buffer_func, data->chip_spec->buffer_setup_ops); @@ -2046,8 +2046,8 @@ static int vcnl4000_probe(struct i2c_client *client) } =20 if (client->irq && data->chip_spec->irq_thread) { - ret =3D devm_request_threaded_irq(&client->dev, client->irq, - NULL, data->chip_spec->irq_thread, + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, + data->chip_spec->irq_thread, IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "vcnl4000_irq", @@ -2060,7 +2060,7 @@ static int vcnl4000_probe(struct i2c_client *client) return ret; } =20 - ret =3D pm_runtime_set_active(&client->dev); + ret =3D pm_runtime_set_active(dev); if (ret < 0) goto fail_poweroff; =20 @@ -2068,9 +2068,9 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret < 0) goto fail_poweroff; =20 - pm_runtime_enable(&client->dev); - pm_runtime_set_autosuspend_delay(&client->dev, VCNL4000_SLEEP_DELAY_MS); - pm_runtime_use_autosuspend(&client->dev); + pm_runtime_enable(dev); + pm_runtime_set_autosuspend_delay(dev, VCNL4000_SLEEP_DELAY_MS); + pm_runtime_use_autosuspend(dev); =20 return 0; fail_poweroff: --=20 2.53.0