From nobody Tue Apr 7 07:35:40 2026 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 677FB3264D4 for ; Sat, 14 Mar 2026 22:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773526703; cv=none; b=PxcHWL42D7q66/pfL2cFnLqO62MUei4a8bPbNvrdIJyloMMxYvN5ztRukwTj3We3Y/dTZtGiQHIeiKp/IE82MT+UwuV1zx/zPluE3vgtKAqLX3cfkHO2oJpWgYlclcXmDT6/pwY5jskIDc1G37J3TW2jCuC4PWq7WKDjx1q8rgM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773526703; c=relaxed/simple; bh=bKcY4Y+E9DqhFkvhNYpy3LHkEQMdezB6JBUJ9ambGWY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=eaRYsLIebvD+pO2zLoBGrmy9HPk25KuEyT119H+N5UFeGL4ln669aQZeUvvO7W9Lyy1J0xMbmO8DzMwKhDOCoPUP5l2xcu+o8tvUuAQG2XAhzxfYCpIVhhhaHPy0/4Q3TGGMahNQNHWTwsvDAZVOfKHUaxWO1vWfg73f7v44zAc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Y8P1fDtR; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Y8P1fDtR" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-40423dbe98bso1192897fac.2 for ; Sat, 14 Mar 2026 15:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1773526700; x=1774131500; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=uDbUEHxvZ6LbG5yA0b6crCNwXlRJDt1sD43ttVBDLD4=; b=Y8P1fDtRPGsFOmibxI1DqUWs5O0wHchm5XbmzqQFAIhRZnepC6sReV7pnpOaZBgAQw lnnrGG36tyQZ8JpKsWLgVvr6n1PQgUOHm917U3JqjhwUBFmgmJS5hlD8Ow3IhBfvMX0T m7vjKmM8aDs2AhKIuUn0IAYUYJUbE6E8zSPEMRlqp7PT5I1w8D4LZe+mO9yoBZatvMhT 1qEC8qv+AiU3ayuYSaBUD4LvPpja34EoEvu1VwI9GHSyzto0f7YQFWqeNytGuv4Af1yd 5sxaj/kq/BcQyV10zhUYROCTdH+Sqkya/Y8UOcL6q1pBs02uD4R/pmsQTB0wbJtU4orx qQ9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773526700; x=1774131500; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uDbUEHxvZ6LbG5yA0b6crCNwXlRJDt1sD43ttVBDLD4=; b=fE4kbxeDIU/aSFjAX7ErHlyMsFts6KN95f6T6Mg6mLtBlxQdJDV4Y2FesiKe4QyGMa SMIEkxKMfwc0mL5E2S1xpWuJshBXH5bj8h0GKHK0Lv69f5vt70ri4qLSjoA0Nz0jqbjU v3PRXCV5HACTdI/5kam4Qn4rENWKNlXV+iFFS8wAvnnzmdrFamXlvs/kAz/g9MJ1e7Q0 MCgPWlt2QZ7sdHjNMfi0qlZ/pgfVeRk8QWkx3EUyxFt7bdx5pC6mzouaC7EuH6Wfr576 m41AtXxpGm23hyDI1pw4jcJbOJYjiGHBEK57QM90DBJCd4MgNzasOIMLbnq32Hz8xYp1 g4CQ== X-Forwarded-Encrypted: i=1; AJvYcCWZNLMc5MZ5PYTJDpEQcMdYOsHH4SCwYiAS3Aj6g5yAB3D2fsQ8TeSYqGos1IxMMwq3cz+AQeJEMNWueLc=@vger.kernel.org X-Gm-Message-State: AOJu0YyRpY5GrlLhlA9/m2pPL56uHnwAEgOzvByzwja82y2iT6nV5PeS op9fPQmHClEYBauAg0DLpr5OPSfIOV+73w4wEw+IlEhTMAusXic8ff1Or5guynoXaXM= X-Gm-Gg: ATEYQzymjVSzB2NTgEXpj9q2+DuIeNNMu7Zrsj0RZ4euddWCCMKiewP/ca63eYqIgjo E8XTDje6/jx/61CGHiRBBEPe2X6eySmXCsgwrPOpSWX/hNZ77Wp00qFzbJsI0YvgxZsdnw5yn0P +4Rd2w8fRvL41AdbChEdEtSAo5+XDVoTtbxE8r7yjOR6/hF0ALnaDLcAG+kpybnD/+QvtDWBdTD ZHlghM/0y0YZJnjmkLFiTbkplTvH64zhbZ8vl8U8EFm2juxRf5xNRIk6XtTd1POKmeqX1euHnSC ZYB5mv1Eqn9Qg9ouZuf0iQC2SubVZYDxhAQ4+Uf+UzBZFiXfDdxZtGFL+P9Nzkz8z6koGl5Q36v BtrgGpcEROSgr/X37K0HILzhOMGLNmKbx8Lv3dGAOFh8jdrqWLkCeEY+X8zQo3PVgiJM6n7YBbC Z4kV/zdOUQJI/smLp2RrOagnBboSFsOCO2Dhemitw= X-Received: by 2002:a05:6820:1349:b0:679:96f:3f04 with SMTP id 006d021491bc7-67bdaa60223mr5518895eaf.53.1773526700359; Sat, 14 Mar 2026 15:18:20 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:500:f27f:adf2:8637:6bb9]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-67bc8efae1asm7679293eaf.3.2026.03.14.15.18.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 15:18:19 -0700 (PDT) From: David Lechner Date: Sat, 14 Mar 2026 17:18:10 -0500 Subject: [PATCH] iio: light: vcnl4035: fix scan buffer on big-endian Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260314-iio-light-vcnl4035c-clean-up-scan-buf-v1-1-400d273eb026@baylibre.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXNQQqDMBCF4avIrDswmlShVyldxHHUKSFKYkQQ7 960XT2+zf9OSBJVEjyqE6LsmnQJBfWtAp5dmAR1KIaGmpZMbVF1Qa/TvOHOwVsyd0b24gLmFRO X7fOInXNEg2nFdgSltUYZ9fj9PF9/p9y/hbdvHK7rA2M8CB6JAAAA X-Change-ID: 20260314-iio-light-vcnl4035c-clean-up-scan-buf-7aa00d36e470 To: Jonathan Cameron , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Parthiban Nallathambi Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=2662; i=dlechner@baylibre.com; h=from:subject:message-id; bh=bKcY4Y+E9DqhFkvhNYpy3LHkEQMdezB6JBUJ9ambGWY=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBptd6jvoxYGvHGymRs5PkwluWepv/h0jurCjKoF TpgeHx276aJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCabXeowAKCRDCzCAB/wGP wOGFB/98JSVkD+O7YQXtOQTR2w/vt4CzHtUWxUEzekpEbaGugP6vgTNVOIcCj4f4NhHmMUj9xT8 mxWD6Rn94hD67g88mCRfd8XIlnUEPn8W2YyU001H8GEwB84jB2A8HAfRNxNerXmnXWJV+C9fyD/ ZlTM76CD1e4i9gqebBAT75+sZVV+p5abc0rlptqNQszkyowULv9n7Rpez0ct/qRih4hSTEXpPcf VP/+WWKVj0S3tdwJ21ZuuvebqylB9RQA6m1d/LyFxKKdxP0NELJNzX46ezlkcXr57f9CKZD/t7H IuEbVOK8zgTkt4M/O/q22XaMzpawe0RqdkaOdID9PfGVGa7H X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Rework vcnl4035_trigger_consumer_handler() so that we are not passing what should be a u16 value as an int * to regmap_read(). This won't work on bit endian systems. Instead, add a new unsigned int variable to pass to regmap_read(). Then copy that value into the buffer struct. The buffer array is replaced with a struct since there is only one value being read. This allows us to use the correct u16 data type and has a side-effect of simplifying the alignment specification. Also fix the endianness of the scan format from little-endian to CPU endianness. Since we are using regmap to read the value, it will be CPU-endian. Fixes: 55707294c4eb ("iio: light: Add support for vishay vcnl4035") Signed-off-by: David Lechner --- drivers/iio/light/vcnl4035.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c index 963747927425..16aeb17067bc 100644 --- a/drivers/iio/light/vcnl4035.c +++ b/drivers/iio/light/vcnl4035.c @@ -103,17 +103,23 @@ static irqreturn_t vcnl4035_trigger_consumer_handler(= int irq, void *p) struct iio_dev *indio_dev =3D pf->indio_dev; struct vcnl4035_data *data =3D iio_priv(indio_dev); /* Ensure naturally aligned timestamp */ - u8 buffer[ALIGN(sizeof(u16), sizeof(s64)) + sizeof(s64)] __aligned(8) = =3D { }; + struct { + u16 als_data; + aligned_s64 timestamp; + } buffer =3D { }; + unsigned int val; int ret; =20 - ret =3D regmap_read(data->regmap, VCNL4035_ALS_DATA, (int *)buffer); + ret =3D regmap_read(data->regmap, VCNL4035_ALS_DATA, &val); if (ret < 0) { dev_err(&data->client->dev, "Trigger consumer can't read from sensor.\n"); goto fail_read; } - iio_push_to_buffers_with_timestamp(indio_dev, buffer, - iio_get_time_ns(indio_dev)); + + buffer.als_data =3D val; + iio_push_to_buffers_with_timestamp(indio_dev, &buffer, + iio_get_time_ns(indio_dev)); =20 fail_read: iio_trigger_notify_done(indio_dev->trig); @@ -381,7 +387,7 @@ static const struct iio_chan_spec vcnl4035_channels[] = =3D { .sign =3D 'u', .realbits =3D 16, .storagebits =3D 16, - .endianness =3D IIO_LE, + .endianness =3D IIO_CPU, }, }, { @@ -395,7 +401,7 @@ static const struct iio_chan_spec vcnl4035_channels[] = =3D { .sign =3D 'u', .realbits =3D 16, .storagebits =3D 16, - .endianness =3D IIO_LE, + .endianness =3D IIO_CPU, }, }, }; --- base-commit: ff0843ceb1fb11a6b73e0e77b932ef7967aecd4b change-id: 20260314-iio-light-vcnl4035c-clean-up-scan-buf-7aa00d36e470 Best regards, -- =20 David Lechner