From nobody Tue Apr 7 10:54:10 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDD692BD5A8 for ; Sat, 14 Mar 2026 01:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773450569; cv=none; b=oV5ZIJMls76EzpsVmOjsxTAN+Bqa+OljclDgM10XQnboCXYxWjzSWA0EWgyVhXxWQwTzMKHTNy/XKjGjVjN9yBhpEgVJYtmrX3usMqwIy5nCknSpCCeQE55iHWydhz9cUxSlubdhXdwXAeSnX+y2/WlrWqr90Lp5HMP4spAFy3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773450569; c=relaxed/simple; bh=okgHbNzqiXYxc/6yXGiXxswgZJigmkKqeXcAutwbh2U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nDLR9kzrCxdTWfz2OIaPpJnjxADDhKXwgItnU+olyn6fy8baaqbgv5GB5ZqROsF/JmR4hv8dczQY27pndVWeA5ZFaX7CMfdeQz8BtGoxWo2r/dOGeA9SCS94M4uqfa2A2qlAiwe0wLfxkNpId0lPWbxZyHD+3kBs6N1gg2K9k1s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SLKoeO8f; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AoIRop24; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SLKoeO8f"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AoIRop24" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62DNH1dL2772639 for ; Sat, 14 Mar 2026 01:09:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PqAtWAY9FAqIvdzkP+oLI4lRLzY7loPC33zOvhTcaJU=; b=SLKoeO8f4dgOy7mS MoRr53rOuDkxR68sbQug8F1nNRaBWSUd6mIqQKNdotob1iuY/7ff5uaT/AzkQwe2 dT3Rj6p5zJ3B2v00PjCto4DYiL6Q+DQZBe90nnwPWAbyZP2x9TF4ThkHW38/Hd1g IlUNs/ghBR3w2mk986widj0baNj1gH8Pi6/YSvjZXgEHjTAwx4p46Hr2BumgLVx5 cyx7pWhrfnh9sUEur4SMUIw95iVbosHqZ3yRd07Q+4+CKa3KgJqNGDjCco+hpmXj EbXINVfrOuBBynmGt8d1DXvXbG1XHeFELKzdOJcM1dyPVhlmBR9u+cgMWvinNr9L zZJDfQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvfh7txfa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 14 Mar 2026 01:09:26 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd7d4cc049so2772751385a.0 for ; Fri, 13 Mar 2026 18:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773450566; x=1774055366; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PqAtWAY9FAqIvdzkP+oLI4lRLzY7loPC33zOvhTcaJU=; b=AoIRop24O78vVLOLB+Nfe/K8WlkN4uVDKNtvCOnshIOnYOg53Lb77c8tRozRO09H82 MnxmUVU1tRvsu0+3nL6o5Mx3tipiiRQZJ6xciDXfJ2BN9mSzKtlHJkxOEak30Xa9rYyD 6feEjD/NdzkTp1wZ+w0w69Ma1vsv8ENUUoeGqM9stf/gZzcdWAbvGo5cus7JnqZxc9s9 mKk1ldpWG3zTkjRuh3Bp9D5eX0PlVCX7x2it+aIwyIIQyaw9n+DYA32gS0Ltvi58AJhx 2yBShKeq/v7tnr863PSgt4B4EMnx61lukkilKnV0DV+C/UpH7n29Knsqwipf1+xpb3hj oWSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773450566; x=1774055366; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PqAtWAY9FAqIvdzkP+oLI4lRLzY7loPC33zOvhTcaJU=; b=C+Kr0d6rBROF0XJKpGpSOZsWxbeK42CDacyAeAScC87TSDHljC6UzZqo5UClrRTMH2 SR3pdAe8AGfFXQYQvfqoSRxf66LwFs9fzqEy+dlFCNg8qRZiH9K0qNjQre6tMgZU0ib5 YO6HSdt7JDAhveXCCNWkhZYTwfWirEKhEVILmDmoYUY4wH79Qxi+vSRc7zWC+UqI2SRe Jip0gFftbR9aYh5YzZEFC52ll4gtNk0c07f+ih+oNSEooK4JkudUx79rLPT8TYWZW6Ow YiOk0/rDeJETelT0Q3iHTx4EVJS27Po2Kw0Xms1fHaN4vB2Tao8JCAMUFjiVIoWbuev7 h/8Q== X-Forwarded-Encrypted: i=1; AJvYcCVJ/VBxDF1hgI6lmSs17s4V78IBhOqllSrHyIjjDeyuBVlpWWvRNcOF7QqTIaU03XCtkpKmYEvvafcKfxk=@vger.kernel.org X-Gm-Message-State: AOJu0YyT5N9LY9EezbEjNhgjMH9xZ80l/BrhIuVeteCBV8tFitbSG0wt juYexmgB9CBXdOXhyHqbSjkSl69QOH+xvJXK/hJJuf2aZcYvpk0CvEvsNO/xRnNnnfYDQjyv3sZ 0U7HoBHbP0PQQZP9fPX+pLJ79AIchXUfsreJ9bBW06BcdedHVP7B2v6FbZZFNMGThBDE= X-Gm-Gg: ATEYQzzpNJBW4uJsP0JVdDL/sfxbXEbAYSWqJ/jVeJg2sxVeqoo5MsTSfBb7G+rVu0k cQ7ZmiAt1CoH3AwKOXbR6pokEsnsODyDPk+1bgofJORfSEdEtnMlvgXo3k+ip+TuBIetA0mQ09K YsJGnzk3NX45ZWOmaD9Qzvvepgk/IFVJ7jQXELwZohV9xDmDkXHYtpMJONpCBLU6CBTV0z+W3o7 +GfNbV4wHSI+FNW/SGWKacH2jtu4IyqKxIGcv8pCWHjoTmKM6hmpiSHM2nWBUjec3KYHCbE/Dj0 5CMvjt0u7CLf0uqkHksJH6QkfV/KJvvIsyXwPXoHyU3kkoMNnGoCHbkFNCpebErbzpNQlkss1x5 FW9HnUSw3TrBUevTGTsAbdsnC80neb4EjSHO3Jnp7Eu8+SFbodj8qWhZtg+lsJfQr2dEtNvYJbn FPMqTARbZevknOFqhzWHEv5pCREfmULXRaVaI= X-Received: by 2002:a05:620a:4623:b0:8cd:8d50:169a with SMTP id af79cd13be357-8cdb5b8a3bfmr755063385a.54.1773450565943; Fri, 13 Mar 2026 18:09:25 -0700 (PDT) X-Received: by 2002:a05:620a:4623:b0:8cd:8d50:169a with SMTP id af79cd13be357-8cdb5b8a3bfmr755060685a.54.1773450565543; Fri, 13 Mar 2026 18:09:25 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a156366b22sm1806805e87.77.2026.03.13.18.09.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 18:09:24 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 14 Mar 2026 03:09:08 +0200 Subject: [PATCH v5 04/10] drm/msm/dp: Move link training to atomic_enable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260314-hpd-refactor-v5-4-0c8450737d64@oss.qualcomm.com> References: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> In-Reply-To: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jessica Zhang X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1716; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=JI7bZYAZgZZoG3QbCYkVN62ORKAZ93CC/pbTrYikaXc=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBptLUzvSvRU0YMLXy9h7xpFPKQwsTjACPD3ArMl C4jgvcRQx2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabS1MwAKCRCLPIo+Aiko 1Y4xB/9UaFY1JNob4h3aSk0mKkF9ebTmHHwh/OdSZS8sAQZv0mNBREBQpLU/Qe/X6aH9RJhGqo7 xpVmr3AT8g3gVQO8sryfGijOJXexdwMrqYAnc4u4OWC2Y70ilj+eIMVhq9E3KHXf9G2owxZRwng WUSOUYGhi1QYeg/2wmS8CTSAW9nU9CDaovmwgM9nLEvaZJYF0I/9etpKLH+RjkGnBP7HTUkpG8i +N1qeLI7owHTltmhNxW/zrnFXFIWy6bKODuSN6KM29LLYMqhalSycosziNdcsjo1+dpafBi505u Dms6iPoG09CtOlgBQC4JqqlSVYSTTddTa9QT/9ZgqCbYSAai X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: PHNJ9neNbtr-goEnnXmi5MKnXqOcfSks X-Proofpoint-GUID: PHNJ9neNbtr-goEnnXmi5MKnXqOcfSks X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE0MDAwNiBTYWx0ZWRfX9zuAkDcH17SP s57GHwKNRIziVlEZsEBYNcHoXKsMgCZBpacAUZbHPZ1p1RFDTPA0uSiZt8tFrEqJaChjWJAhf6y aH8AGjpVly7k8DRgWZ5XAE+Wn2JtOZi1J8aaeNrl59VY2Z6lLH+DTnv0bBUqk6E3tGBMMi02O8M w2E79sDY6HbvMPUKF+l6SqOwJxNTrYD6u8Udvq8hdtp5bU7buuT1pTX6bUE+O7wPJ/MgR7a+nNr PVpX3SArBFBTmZI4oLvQQIccNvlcR2LrQBLm1ON2VoT+6betLdxOvxt5lrx6dawVoRKVPTJ5P0n bdgVdFS+QJ7JmSZhjCRUWXaWLjegDJrAk3+C55R9Ti3Zf0skcv5JTAz4HI3HGndk0J47+3co5ww YKMCoB88eTTNaPLlFGuysd41vYWrZH3Cn3fF2aPMKVLsSQByqbdYhJTJqeEC7ZqZi5Ztt430pk+ VNN9yLwxE85aubZYhnQ== X-Authority-Analysis: v=2.4 cv=BpiQAIX5 c=1 sm=1 tr=0 ts=69b4b546 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=IoBVowuyLm_M3JZO-XQA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_05,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 phishscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603140006 From: Jessica Zhang Currently, the DP link training is being done during HPD. Move link training to atomic_enable() in accordance with the atomic_enable() documentation. Link disabling is already done in atomic_post_disable() (as part of the dp_ctrl_off_link_stream() helper). Finally, call the plug/unplug handlers directly in hpd_notify() instead of queueing them in the event thread so that they aren't preempted by other events. Signed-off-by: Jessica Zhang Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index a05144de3b93..e7b1ed5491c4 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -436,11 +436,6 @@ static int msm_dp_display_process_hpd_high(struct msm_= dp_display_private *dp) msm_dp_link_psm_config(dp->link, &dp->panel->link_info, false); =20 msm_dp_link_reset_phy_params_vx_px(dp->link); - rc =3D msm_dp_ctrl_on_link(dp->ctrl); - if (rc) { - DRM_ERROR("failed to complete DP link training\n"); - goto end; - } =20 msm_dp_add_event(dp, EV_USER_NOTIFICATION, true, 0); =20 @@ -1695,6 +1690,11 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *= drm_bridge, force_link_train =3D true; } =20 + rc =3D msm_dp_ctrl_on_link(msm_dp_display->ctrl); + if (rc) + DRM_ERROR("Failed link training (rc=3D%d)\n", rc); + // TODO: schedule drm_connector_set_link_status_property() + msm_dp_display_enable(msm_dp_display, force_link_train); =20 rc =3D msm_dp_display_post_enable(dp); --=20 2.47.3