From nobody Tue Apr 7 10:54:09 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2466026ED41 for ; Sat, 14 Mar 2026 01:09:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773450566; cv=none; b=ffCRpXM6FSGhKhehijua5Em86m/DMtNJSDHqEelzK4DrDmW2hEx53rRRoWq9EExm+u4pTm7ssDTyqrRCN79ZOA1cAyDoelBEqsARYM6GrEjWnCDGtpNfsiut5igcdD+qOrNvY6fS4C2urOX2rJRxGrRx7w7DF4payJM5yyi+vR0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773450566; c=relaxed/simple; bh=LPHhajodLCFrdH7G7QitIxc+DezXxi+iOPyKRDEeXY0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QNWSu5HENmLzMz1+y8qciLd1T/kEnJZ9sx1q4MkyDFQumpnw3Ptf2rtdFANjA/AvlJJovfVgrlduqNxHEWmrB8d+ue7T1uYd/WAIaYnTgZZ/MB1z+goZumuaf4t7k2Gp4qFE7E7oP/Tl04J8ezzHyidZNAb3bwBSfGbCpfwVPGw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IywVHW35; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SLfjiD/H; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IywVHW35"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SLfjiD/H" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62DGHZrh481530 for ; Sat, 14 Mar 2026 01:09:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pzVpX0vOq62SAEgnYrHTEusxqWZeEyyGEwRMXWbZKk0=; b=IywVHW35D64eBKqG BeOFZTrqkA5iVDTNsPer29OPudwL98ljqgD1eHAgkV9NbKltw36SGsQ3qK6QnlxG Hn1cM/F5e1tTwV0G4FB3h149z621eZ5dE536ngDc5GuXkSt1xpVRJDER2FKLPk5C tYpntrKrtFkI0uS6m5iwy08Efg3UCGabyhS2quixuKvUnQY8frSa1zLFazPNJCx0 Cj9PM7qNMbwF0/n9yVODjQOpTxtCno19EEn7ZXLS5tjIP7CHi+4NYXzHCE9y3TzL ueB7XjQk9bNI6NL1rotvjwB3+24vk1ib0brCAapv3woMJLDCkEUdEjaBbj/4HXQ8 j0bYVw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvfh7txf2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 14 Mar 2026 01:09:23 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd81ce6fdcso2485253285a.3 for ; Fri, 13 Mar 2026 18:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773450563; x=1774055363; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pzVpX0vOq62SAEgnYrHTEusxqWZeEyyGEwRMXWbZKk0=; b=SLfjiD/HxdLF4H+nkoSWJic16IUqn+4HEFZNYAf9L+Duc+JElfjc6aYQmJdRAuhwKq E7huWFHDfNgvJPJukfr3aRbcvYkSm8hCJWmscDqHeCuGAC/wSdNMOK030hMRwBBhoGXA siAm6StULztNxMdCIjCwbJaqOvnp5q1NTCxNWYr4sZOcrsK+9IaiavYYQ6qDiYpGdBU+ r9JwCk1JlBsb+tpZvrlPWlPdnGTuP2lorXuDx/E4J/HVarjBWKB87LgsD1DPWtb4xk2J m5t9ZOM8jUkNKJMb9bpV175XsoSrV+3ZETVZEbWCXn0yHx/p45dpl4U+94kxZZefnH1D 7jfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773450563; x=1774055363; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pzVpX0vOq62SAEgnYrHTEusxqWZeEyyGEwRMXWbZKk0=; b=CShIHC3QMpNNDJA3B1LgZMQn0F8dFrXfULPr20YlCag9gFnT1BD92qVRN7DnaORszY omoVSvkNvcqFkmQYHjnwCpqkNn9k6It07FFbBaBxbRSgNCD9Z5P6X9W4qoXYPhldi2R9 g1mjrgGhzDv2tiNkD+ho3NHNwsVfRyRvH6458GKlvx+N4cC8kyjauZmCFb4FDI6rEyuF K7Sb8rhhJdAHxrWjLuj6UGDdq0RDgAC0XMDPNVcIomL5M1YPRrSQHEcGI2U2Sm+PPA5z BlJK+MtNSxxR/wviFRS/sFvTmcOdblsSAVMwDO1ZRDWvWaXt0ZJoV23fSTLeqlW/T0s2 QhRA== X-Forwarded-Encrypted: i=1; AJvYcCWTgAwlKFzuWj+C1ImfrMrZv0WOO+dy52QJ8DZlaGP76WDCb/hCnidcNAsTGNZLZemYSFDm087iuSPBXeM=@vger.kernel.org X-Gm-Message-State: AOJu0YzzuRGSU00bCfcL3s5Lb8jn2JAECtbT6JTJjVkylK7yYLO7voTG Xjobt0L+gbetxiMKwVbYoPSEgOJluz1CXWzmupij+CS7X+wCYdzuB4L4qBOU59wQNpa5yW2s5Nm /XRbaz/Gp0vsLvCy8evZA0cutZUgGX/U9Qz04Dq0n85Aks6o304/Jug0u2sqqr9si4/o= X-Gm-Gg: ATEYQzwbYgSPBmAkyPNVF4IA7Z70PR+8G7cS3pi6WHl0OHjhfKDpqZZyhTr6+M4irP9 UxTqM/YfRd8Qa+Slg4xmwHD6djZQZ6vcEX+tFwjgTAVYuLWn8h6VxyQxWx+1Z1kS5QGyjR45bQI UvwCGMVQjmRcRElU4fgH8tMGjC6p3LP6G3S9ZipN763TWcTgl1LXxsgOlnVDqtyY/36A1pX4JaA UBVsZyFiePuUL1Bbdswjf4TD+4h9PAwGSC4+htlDVJUjr8GNty6Yj9QmZN38xOY1rn7Ldr2PnsD APjt5ardEcIvDngcpQPJYBXie9qf78j9jTzT5ekP9bClhSJnnyuVcDhiY3sh9kkPWIzB/81fAQ3 eAO7WW9JdwKOPBONuoX1JJxtDDdlfQ1gCxavzwFLdYxZxLPjgXDIbF683V4paLrNzMZ59WU/Qui 53WQqPcVE6ujrwhyMLk6kQeT5aLqnh2BNoLxY= X-Received: by 2002:a05:620a:3195:b0:8c6:b247:4c with SMTP id af79cd13be357-8cdb59ff4aemr800776985a.2.1773450563363; Fri, 13 Mar 2026 18:09:23 -0700 (PDT) X-Received: by 2002:a05:620a:3195:b0:8c6:b247:4c with SMTP id af79cd13be357-8cdb59ff4aemr800774585a.2.1773450562940; Fri, 13 Mar 2026 18:09:22 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a156366b22sm1806805e87.77.2026.03.13.18.09.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 18:09:20 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 14 Mar 2026 03:09:07 +0200 Subject: [PATCH v5 03/10] drm/msm/dp: Read DPCD and sink count in bridge detect() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260314-hpd-refactor-v5-3-0c8450737d64@oss.qualcomm.com> References: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> In-Reply-To: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jessica Zhang X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4422; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Fflo70A3oSMP6LkHXNPuDEYg6XV8ot0GBkcmgzq2Sd4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBptLUzSX0Yvt+mbPHdcgYX/8JV/EIlm8oX59QLb v7OgZfSiEmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabS1MwAKCRCLPIo+Aiko 1XqFB/9wKZJq9LxL11bSOqiNpbCmdspf5rAtBMF7Lh/1flH7eirIkNkwtuSh1f1lOZmHQod13v5 6SiTzPdY8EHcz9CEe/qvUi5t6qroB83+AjUz7D3BNy3whNHMYkfRdRkX8zcu9V2CD2EG5JzmtRE QALNFS74iW8+b6A4VekcaL9OsCajS3FphsdP+n+i5U3pr1dB8U4gH64SrBBwavuLt6Y7tnP+fJh qNnEfLmfE4yP7Ij/pwJgb2BPxkd9Oag40r8dPnqzwJrpH9GaRzlO6xKeT23k4ZflqtnwuTcrR7a GIUPfSUx5TY5HznvwPHI/oQmPBzcsfftHTDf6N961rqB8DBE X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: GMPCSyf9CuIT5Zoc_dSN6qjYcv_F-O1s X-Proofpoint-GUID: GMPCSyf9CuIT5Zoc_dSN6qjYcv_F-O1s X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE0MDAwNiBTYWx0ZWRfX4epe0JbOCqp2 lQpFkLXq1t8rouXhJ8gcUHyNXB5D2du6V/+bbod3bAjvM6SEL2nVdMgf5jmVxORBY+MZAbsuEzV 0Yv+dSpGYSyOMwoo7PmkQjQ7elxoA9fg+GSc05zvcbdMAI/wFPdt9l4PJldJx/JLzKAXzCTJdqt TDsAqlMWEPWdnd9vJHbpAoYaLbFT7uOpCVCk0RXDJ44tjA2EmaspVOZI51qYf6DL1czeX1TP3OW T7oLi2KmhyYtZlMsZdGiHhzzv35Pus19hkPVw4B/+Bi4irN2QIGkTxsshz5D8KUdX84NkOGwvsk CkG1NaXk0Vo76vcLk5b56aCEX8jcs2u/v3YtM3v78U0yeWVFR+gHeysu9csT/YiJaJmXftx8caR 3+V3rW8Kzw5OF79ffxn4ta0X4LDEwMQwCbWrY5UWXo6nY0OHSRDO/YgSeSxlBxmruY+8JzKiRi7 A8dEgzWPI/33cM5fREQ== X-Authority-Analysis: v=2.4 cv=BpiQAIX5 c=1 sm=1 tr=0 ts=69b4b543 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=jcEwYMPARZwhhGfK5pwA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_05,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 phishscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603140006 From: Jessica Zhang Instead of relying on the link_ready flag to specify if DP is connected, read the DPCD bits and get the sink count to accurately detect if DP is connected. Signed-off-by: Jessica Zhang Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 60 +++++++++++++++++++++++++++++++++= ++++ drivers/gpu/drm/msm/dp/dp_drm.c | 20 ------------- drivers/gpu/drm/msm/dp/dp_drm.h | 2 ++ 3 files changed, 62 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 5997cd28ba11..a05144de3b93 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -1151,6 +1151,66 @@ static int msm_dp_hpd_event_thread_start(struct msm_= dp_display_private *msm_dp_p return 0; } =20 +/** + * msm_dp_bridge_detect - callback to determine if connector is connected + * @bridge: Pointer to drm bridge structure + * @connector: Pointer to drm connector structure + * Returns: Bridge's 'is connected' status + */ +enum drm_connector_status msm_dp_bridge_detect(struct drm_bridge *bridge, + struct drm_connector *connector) +{ + struct msm_dp_bridge *msm_dp_bridge =3D to_dp_bridge(bridge); + struct msm_dp *dp =3D msm_dp_bridge->msm_dp_display; + struct msm_dp_display_private *priv; + int ret =3D 0; + int status =3D connector_status_disconnected; + u8 dpcd[DP_RECEIVER_CAP_SIZE]; + struct drm_dp_desc desc; + + dp =3D to_dp_bridge(bridge)->msm_dp_display; + + priv =3D container_of(dp, struct msm_dp_display_private, msm_dp_display); + + if (!dp->link_ready) + return status; + + msm_dp_aux_enable_xfers(priv->aux, true); + + ret =3D pm_runtime_resume_and_get(&dp->pdev->dev); + if (ret) { + DRM_ERROR("failed to pm_runtime_resume\n"); + msm_dp_aux_enable_xfers(priv->aux, false); + return status; + } + + ret =3D msm_dp_aux_is_link_connected(priv->aux); + if (dp->internal_hpd && !ret) + goto end; + + ret =3D drm_dp_read_dpcd_caps(priv->aux, dpcd); + if (ret) + goto end; + + ret =3D drm_dp_read_desc(priv->aux, &desc, drm_dp_is_branch(dpcd)); + if (ret) + goto end; + + status =3D connector_status_connected; + if (drm_dp_read_sink_count_cap(connector, dpcd, &desc)) { + int sink_count =3D drm_dp_read_sink_count(priv->aux); + + drm_dbg_dp(dp->drm_dev, "sink_count =3D %d\n", sink_count); + + if (sink_count <=3D 0) + status =3D connector_status_disconnected; + } + +end: + pm_runtime_put_sync(&dp->pdev->dev); + return status; +} + static irqreturn_t msm_dp_display_irq_handler(int irq, void *dev_id) { struct msm_dp_display_private *dp =3D dev_id; diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_dr= m.c index fd6443d2b6ce..e4622c85fb66 100644 --- a/drivers/gpu/drm/msm/dp/dp_drm.c +++ b/drivers/gpu/drm/msm/dp/dp_drm.c @@ -15,26 +15,6 @@ #include "dp_audio.h" #include "dp_drm.h" =20 -/** - * msm_dp_bridge_detect - callback to determine if connector is connected - * @bridge: Pointer to drm bridge structure - * @connector: Pointer to drm connector structure - * Returns: Bridge's 'is connected' status - */ -static enum drm_connector_status -msm_dp_bridge_detect(struct drm_bridge *bridge, struct drm_connector *conn= ector) -{ - struct msm_dp *dp; - - dp =3D to_dp_bridge(bridge)->msm_dp_display; - - drm_dbg_dp(dp->drm_dev, "link_ready =3D %s\n", - str_true_false(dp->link_ready)); - - return (dp->link_ready) ? connector_status_connected : - connector_status_disconnected; -} - static int msm_dp_bridge_atomic_check(struct drm_bridge *bridge, struct drm_bridge_state *bridge_state, struct drm_crtc_state *crtc_state, diff --git a/drivers/gpu/drm/msm/dp/dp_drm.h b/drivers/gpu/drm/msm/dp/dp_dr= m.h index 9eb3431dd93a..6c0426803d78 100644 --- a/drivers/gpu/drm/msm/dp/dp_drm.h +++ b/drivers/gpu/drm/msm/dp/dp_drm.h @@ -25,6 +25,8 @@ int msm_dp_bridge_init(struct msm_dp *msm_dp_display, str= uct drm_device *dev, struct drm_encoder *encoder, bool yuv_supported); =20 +enum drm_connector_status msm_dp_bridge_detect(struct drm_bridge *bridge, + struct drm_connector *connector); void msm_dp_bridge_atomic_enable(struct drm_bridge *drm_bridge, struct drm_atomic_state *state); void msm_dp_bridge_atomic_disable(struct drm_bridge *drm_bridge, --=20 2.47.3