From nobody Tue Apr 7 09:35:46 2026 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E28DA363C72 for ; Fri, 13 Mar 2026 16:38:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773419884; cv=none; b=dwnlQB21STXGYd+ODR8W9/TeNMA1OSzivEaQ6CHDCGmuPbSmPCy6nSwjghVMO6mSm4jA1h1zdjH+Wvmvt+qWk52QmoMK1DnMjas1QNsaQqFSFAsQvHXept6nqJ58+jWSrNKVcN/KkmpaHdVo19A/wdkvTcX/9yAq4aMVaLhg69E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773419884; c=relaxed/simple; bh=W1XXsPRnx1fqT9I5G1u82x/nU+gRo2BxmmcTnMIdPR0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=JHeAoDvhtkmhu2Oz3l3E0X84rhNny82VuKYu2lgavKZgf8FaOToHgb9PF6dOSbk5DRDLFApeA/36nLhyRijNMEHfZd78oDU+SSMyKu6Uu0NeyMLotHzIGa9Rtu2kH9kuk2SYP/+nX3meyuTLiv7lq2RQ1z1bayXZweBQLXBhexs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NZX5acw+; arc=none smtp.client-ip=209.85.221.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NZX5acw+" Received: by mail-wr1-f65.google.com with SMTP id ffacd0b85a97d-439c5b40f60so2041271f8f.0 for ; Fri, 13 Mar 2026 09:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773419881; x=1774024681; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=i7CXb8U44RcRKmxQ742u8FVm/RdCaen6B3HL3nk1lw8=; b=NZX5acw+E/NCRxNMYgG1BT6OiajYhvlf+3ApOikVLnCfJ6Z8AllSlbIJfp9ovH1r4x 4ZEjcjQvizwFDUWT9KOU53d0UE4jnMZ8L9mHvENQ12N5Y41rj8/4w46shDd1iPnpeNRu 4ztU9/NGKTpnc7Ry7T9ybzxfskAS+JbVrZU8Uj2XXSuEeInmSaw+HXmZs6PiyewYq4Rv G3qKXz+yDH4MrbmLD7DhQqan6KBvtb5oAuA4kAu298Se0BP3P6hGiSfiztynCDpIGA+V ZMg46sW5Lukb5Yv/LgdLrSO51Ow2cf+PuHbYMR+hIdpBMNvNUzQIjXKzez8n077cc0XB 7xDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773419881; x=1774024681; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i7CXb8U44RcRKmxQ742u8FVm/RdCaen6B3HL3nk1lw8=; b=MDNwHI1Yv86NKaq7vEnmHvZGrh+w82LE0hIRKgnm8/1+I18LTntstj2WkiXUWMGjCQ 1fuLaGZ/jEi3KHtzW6vFVuZC0HQRf6zGHrmIu2Z9jnPzre7YU9Z6Zikh0/5oh254K8/9 d9DvojyYVt5wCA0bnD5DlRPj+cHA7TM7wEzIJUA0sQs0QitSriB1qDa0sb15IuMX9Pm2 u71nohdI5ftC9XkFXuvtGj1k1qvYUhO2vzWyHbve20kVygG2U52PiBpt4/qXAknArVVj pPMRc0Q3GTsTFs4SvKWrUMAhV2zQBkddxwPN0bci6vGdNbdLi+e2Z95cyIelzttblKdf hTPQ== X-Forwarded-Encrypted: i=1; AJvYcCWC5178KZuCLg70SpzRmKicS61SomeCLxLQkc3ThYr6GNzDh26CvQsfUw7cpqbmiXh/tjdr28K501nYehg=@vger.kernel.org X-Gm-Message-State: AOJu0YwiBKrUBxt8GziDAwZt5y/bISHibZY6E5e0YhK8WQGJrzN26YxX vQSmjlAG7bScO7oyJhlc58oSGnVSJ3Zd9CLCe6nzmKrslSxcg3PTUZvk X-Gm-Gg: ATEYQzwD7CDrVoXYMDSL4RRTZp9bHTnCyFS2dyB8fUr/JQaeBltLgCFNNzF1w6oypAt 3ketBCndcwI8I5I2Ou5C5eUnuZCR186ZNpNxQr7AwZRIIPo1yT5D46ju7GvP1j5wmH+eueqaVMe RBNrkRLKCNjGrEy9oH1eDCr5L4yqnFZ58gJO7mot59YiZMt0SqrcrxF7FUM46s0AVFPG/uXkzA8 7EP69M+Z4Vw4RTcULiMFQ+eF3V6jYPR/w8RsduJ9t8f/wDs+KlbaTrTFSNxvnO5HnehjmLTB3yo hwwu+OuRe7CbKEUyrXln/CYqQzu3+CtHlutDqx+gqaE2BIhNcJrFrmtFWP9yggl0YXK5ETR3UCp K+GtO5U9ToPfWdc75+0orKW74wAUZtPTvUv/fahnsRcLyCDmc4p/+UhNuSnwY1edmb7cP4fk+88 mdXqoMeioBIOJJDnnLsXIoEV7x3Yb2+jtVpB0U+krvHUH7QH7/PXM= X-Received: by 2002:a05:6000:2509:b0:439:b811:11de with SMTP id ffacd0b85a97d-43a04d7c5a0mr8180809f8f.7.1773419880912; Fri, 13 Mar 2026 09:38:00 -0700 (PDT) Received: from DESKTOP-BTQF5RC.localdomain ([85.110.79.247]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe2273d9sm21369695f8f.34.2026.03.13.09.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 09:38:00 -0700 (PDT) From: =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= To: gregkh@linuxfoundation.org Cc: ethantidmore06@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= Subject: [PATCH v3] staging: rtl8723bs: Improve error handling Date: Fri, 13 Mar 2026 19:37:41 +0300 Message-ID: <20260313163740.454-2-b9788213@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Remove unnecessary ret variable and goto exit pattern. The function now returns immediately when an error occurs. Additionally, ensure that intf_free_irq() is called when pm_netdev_open() fails to avoid leaving the allocated IRQ uncleared. Signed-off-by: Bera Y=C3=BCzl=C3=BC --- V3: Fixed patch description. V2: Used int_free_irq() in error condition. V1 Link: https://lore.kernel.org/linux-staging/20260312131933.29505-2-b9788= 213@gmail.com/ drivers/staging/rtl8723bs/os_dep/os_intfs.c | 28 ++++++++------------- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 7ba689f2d..e86b8af8b 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -1124,35 +1124,28 @@ static int rtw_resume_process_normal(struct adapter= *padapter) struct pwrctrl_priv *pwrpriv; struct mlme_priv *pmlmepriv; =20 - int ret =3D _SUCCESS; - - if (!padapter) { - ret =3D -1; - goto exit; - } + if (!padapter) + return -1; =20 pnetdev =3D padapter->pnetdev; pwrpriv =3D adapter_to_pwrctl(padapter); pmlmepriv =3D &padapter->mlmepriv; /* interface init */ /* if (sdio_init(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ - if ((padapter->intf_init) && (padapter->intf_init(adapter_to_dvobj(padapt= er)) !=3D _SUCCESS)) { - ret =3D -1; - goto exit; - } + if ((padapter->intf_init) && (padapter->intf_init(adapter_to_dvobj(padapt= er)) !=3D _SUCCESS)) + return -1; + rtw_hal_disable_interrupt(padapter); /* if (sdio_alloc_irq(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ - if ((padapter->intf_alloc_irq) && (padapter->intf_alloc_irq(adapter_to_dv= obj(padapter)) !=3D _SUCCESS)) { - ret =3D -1; - goto exit; - } + if ((padapter->intf_alloc_irq) && (padapter->intf_alloc_irq(adapter_to_dv= obj(padapter)) !=3D _SUCCESS)) + return -1; =20 rtw_reset_drv_sw(padapter); pwrpriv->bkeepfwalive =3D false; =20 if (pm_netdev_open(pnetdev, true) !=3D 0) { - ret =3D -1; - goto exit; + padapter->intf_free_irq(adapter_to_dvobj(padapter)); + return -1; } =20 netif_device_attach(pnetdev); @@ -1168,8 +1161,7 @@ static int rtw_resume_process_normal(struct adapter *= padapter) rtw_ap_restore_network(padapter); } =20 -exit: - return ret; + return _SUCCESS; } =20 int rtw_resume_common(struct adapter *padapter) --=20 2.43.0