From nobody Tue Apr 7 11:18:09 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DE4C39F170 for ; Fri, 13 Mar 2026 14:16:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773411415; cv=none; b=hdLZCVhO51biUYGsbD2d4d84ReIadjl4C8vpjIO0LG8sH2ezDMTODv2YD1KE3PFb6HQA5/y5ixfEWw+21ifhvKimuuV2RfGrONlTZWzbVyynsgw2sButpOlvg8uCasBf2qQqHnByCp+zW0Nq/iSfGeLZ8Ro2R+FHkt8g8NUi/UQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773411415; c=relaxed/simple; bh=RuN0Ldv/9U7l8QmtqeZ4T/0OtDq1G+qZAGOb5aRaWnA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZoSOx86fHCfpsWNmgcXtTe3T+cIoHBw3odRyq00PoKilnVzhtzn04ynIS7EWlr+rwZ3BOwJnI4kLANcJB3TZAw5ZMpRh3COaR1Idk11KY5/xGptH+xzwkdJ83aw9/jVNxXIh3sQ/qotImRr0+iVaA8TztV8yyoxp2rXF72i61kE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KApzdeHq; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KApzdeHq" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-48541edecf9so23553105e9.1 for ; Fri, 13 Mar 2026 07:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773411412; x=1774016212; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EF3xeTr8UCb4d17q9UmVHZHAuKNnKdi+DQOBeYCIjiY=; b=KApzdeHqdGNF1DTHgfL/EuxbW1ybyPXGlmr6sVX94eH8K8FFZLqUPVCCe/hqffTwIs VIbbYc1ny11PeHr7sOvzMO7mQiEJnpPReP1wXynXYwUYxjcxt0lsRbWVHiiueDzmTvnk QrNky+mhkQ13Exx87KuPgtqGf6O0lXMcW9sB4WbOOWkxK581ybbhNKtpt8S5vEhifSiX xaJrC2Z19UecejqQLs06q0eKXgtqtA4m+1JnPqv1v5+YN1tgWZoP7oby1x5mWiBl6Kgp ziqqjNzbmz6qD+DW6L7OdGSkJyRnTB3xvqXPvPYZJIlvOuwqglRjKfaaIfHwuOS06qZi 01aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773411412; x=1774016212; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EF3xeTr8UCb4d17q9UmVHZHAuKNnKdi+DQOBeYCIjiY=; b=i4DxScz0Lv9G6ypq1mNdD8J4ReqlOxpJOgaZbne4eS51ZrOlKhFqHWjSksBQvgKDdy eog85grak3LY58ltH9qTDcKa/+qIzUn6vyy5scfsMCF5lwVD+Q3D8MkJ49iIvi5VuI+b uiU4jps4L70s3Fiy4kaTNfJBWEeEhCjbLwAs78EjBn1csMRS1RW+2OGK2oFD6FDRW2sf BTu6Pxbzc+44yCmgQaSPSjQ9SNYVZfXG4tusVgXCL+HAAZ7RiGm6oa9hUtXD9ROPIAYD f0lNKVIA4EOks9UL1KWmHfXUC8ilz4q1EnND1tB4ya94zE3oGhe+85o5YkN3kXW+pzUu 915g== X-Forwarded-Encrypted: i=1; AJvYcCUKvzb9bMm2oVPIqU7QqzXTAs83Et7Gu5TJsNmeJz2kcbo6Uq/+cnaiWfbiERKDYn1Y00JxAHXlsuLfCqQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwlYuaXSvmYs8vyABQAx63Vs42sUcyexc+ax4JmxXncSIGTLZnQ /3nMW7DKPelF4Col9FfrXgBbXB2WYJyyYQkq1UGJatP0U8fCBjX0bXGXZxUVegtt X-Gm-Gg: ATEYQzzuvRR9ZGKH96K4oOs/aMoQSIdNomKPOblE4rKLVsWH32vS88+Zs4fBZmDM2iX ABWEgbJCsSefkpCpTlUEICMNwxzbqbo+DLTmK49R2EtwjNFsdo0SUQpYXFdErsTh5fnz7GJGgJ9 a4VaWwigj7WtOZWX5z305x9TGMeORwKVi7mrdZRpEUyuncCd9NDSeUdAU5DsAAvCED5SihVCqG4 dqXReYFUycW7C1Y5Yf0YrttoW7vYsmP3FaFnzuD2dM3zLEBteVkCeCeWq6HiVS3A0TSEBSz0Fmb DkveU0Ot1gjdsFcVHiCxQSFb+6P+SDqhVbMsCb0DsCncYM1oRJmOrxjC+TsCRhJJZPm8vKAHw+U 32ElPBrguAJn2p1jCvkLBHesYRyACYVdIaFmK9DyQFO9V9PDxN84UF4wpgjtqtsRqrVu7FsMBq+ dSbLpQGYMcKkDyr/ji/runWwU= X-Received: by 2002:a05:600c:2284:b0:485:3f58:d9f with SMTP id 5b1f17b1804b1-4855670c0a0mr39350665e9.30.1773411412197; Fri, 13 Mar 2026 07:16:52 -0700 (PDT) Received: from fedora-dev ([2a01:5a8:304:153c:d983:1bac:a686:ee59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854e67ea40sm164214205e9.7.2026.03.13.07.16.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 07:16:51 -0700 (PDT) From: "Nikola Z. Ivanov" To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, enelsonmoore@gmail.com, kees@kernel.org, oneukum@suse.com, n.zhandarovich@fintech.ru Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dbezrukov@marvell.com, irusskikh@marvell.com, "Nikola Z. Ivanov" , syzbot+48dc1e8dfc92faf1124c@syzkaller.appspotmail.com Subject: [PATCH net v2] net: usb: aqc111: Do not perform PM inside suspend callback Date: Fri, 13 Mar 2026 16:16:43 +0200 Message-ID: <20260313141643.1181386-1-zlatistiv@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" syzbot reports "task hung in rpm_resume" This is caused by aqc111_suspend calling the PM variant of its write_cmd routine. The simplified call trace looks like this: rpm_suspend() usb_suspend_both() - here udev->dev.power.runtime_status =3D=3D RPM_SUSPE= NDING aqc111_suspend() - called for the usb device interface aqc111_write32_cmd() usb_autopm_get_interface() pm_runtime_resume_and_get() rpm_resume() - here we call rpm_resume() on our parent rpm_resume() - Here we wait for a status change that will nev= er happen. At this point we block another task which holds rtnl_lock and locks up the whole networking stack. Fix this by replacing the write_cmd calls with their _nopm variants Reported-by: syzbot+48dc1e8dfc92faf1124c@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D48dc1e8dfc92faf1124c Fixes: e58ba4544c77 ("net: usb: aqc111: Add support for wake on LAN by MAGI= C packet") Signed-off-by: Nikola Z. Ivanov --- Changes since v1: - Replace calls for all types of PM https://lore.kernel.org/all/20260304155734.110734-1-zlatistiv@gmail.com/T/ drivers/net/usb/aqc111.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index cbffa9ae1bb6..dd53f413c38f 100644 --- a/drivers/net/usb/aqc111.c +++ b/drivers/net/usb/aqc111.c @@ -1395,14 +1395,14 @@ static int aqc111_suspend(struct usb_interface *int= f, pm_message_t message) aqc111_write16_cmd_nopm(dev, AQ_ACCESS_MAC, SFR_MEDIUM_STATUS_MODE, 2, ®16); =20 - aqc111_write_cmd(dev, AQ_WOL_CFG, 0, 0, - WOL_CFG_SIZE, &wol_cfg); - aqc111_write32_cmd(dev, AQ_PHY_OPS, 0, 0, - &aqc111_data->phy_cfg); + aqc111_write_cmd_nopm(dev, AQ_WOL_CFG, 0, 0, + WOL_CFG_SIZE, &wol_cfg); + aqc111_write32_cmd_nopm(dev, AQ_PHY_OPS, 0, 0, + &aqc111_data->phy_cfg); } else { aqc111_data->phy_cfg |=3D AQ_LOW_POWER; - aqc111_write32_cmd(dev, AQ_PHY_OPS, 0, 0, - &aqc111_data->phy_cfg); + aqc111_write32_cmd_nopm(dev, AQ_PHY_OPS, 0, 0, + &aqc111_data->phy_cfg); =20 /* Disable RX path */ aqc111_read16_cmd_nopm(dev, AQ_ACCESS_MAC, --=20 2.53.0