From nobody Tue Apr 7 12:53:57 2026 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD30E397E7A for ; Fri, 13 Mar 2026 13:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773408194; cv=none; b=LgsQZxdMl6ASac+k7PeEbQBJhoePIOt0XqEq/oo4PpMoHJcefqTnRxicZXcNHCoKyGwHO+I9jhxjq9VUG/+6nOS3UJRrfxWX4Tuoi2jP5IJlqW6GwsdLURmjNT99snTepP/dYb+f4SbLdV08e2E8QnkyaD3KGsrOMI6RRfos3h0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773408194; c=relaxed/simple; bh=nT2X+0ltTDZpc2Ke/Nts5WB2aC9+0FZsv4JIXPNa2T0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UAvkpFrdng1kj1c4/PoSG8BsTiEDGs63K6rtof/9TO+UNUzn7XqRJbx2U/a8KWtRam0FVvCWYCY/LK522v9e+X/S5njLaZt3F4jwD4O4sHryMwXy9AqZN6B/sdSv341akU0b0H/KYbnHgvwhKQfe7IbxceEFzyygCWpYVi5SVLs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VrFpQf8p; arc=none smtp.client-ip=209.85.167.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VrFpQf8p" Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-463a0e14abfso1411933b6e.2 for ; Fri, 13 Mar 2026 06:23:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773408192; x=1774012992; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6DJe7q9AzKIA5JE9j9dS7BkLMe6yLjsp/ulkOtgleYM=; b=VrFpQf8pGUr+Vtf9voUUD6dCK8ftNs++iRmZj0vn2dggdL/UgJypoo8SSNs4EMY/kI EchnYI/rYEtpl5WY9FSJBcQCqg5K3lZK9q1c7C+pfRo0AOwzAMoBmuD/9+ROBO7Yw/8P KtMMizLazoqXIUsOpIIjxOimF8jbdLY/jkrCp9OzUYZoJqFX06H+/cH4p//Wyzrm3YGF Sugm+rx3KjpynYc3F3z6TrBaLlLpyMRVhm/hSaQ/yFKeaPekF/o4xbbMX+4K2ADcqP+D tCI765ddHHAZ9HQxcP8jhPq6vZrz0o8MFBRa+Rb/VBkYOussm8dZFttVAeq2G0fibF86 n7JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773408192; x=1774012992; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6DJe7q9AzKIA5JE9j9dS7BkLMe6yLjsp/ulkOtgleYM=; b=l6v7ij8ofzfJBXt+k/aoFLu5aY0y3foiC9NwEPPZTRqz/LnBEIBZBv1QQlFnk3ooTi zjCPiTwy07SSnID7DRZ+yIBSYVBAq+qJ0fgTSXEtVz8CuWKUZ5Z2U0A89Sl4TCTyyynj Fo+U3oE+EbIMRNG5nC1vGHT/YgwWgeGN8i5Ej/ma1f/Z+6bBYMW4O+JBgICE+tkVrRml PYt81AI1ZY3HyYx137S71xjrX/PbjlCeAfq/JbPOdJ+OSvAcMFYxgGMAOa36UzW0N9pW kwiSfLYyKFUtFwlMrr4nSGhKnEVli59xWHSVmIQF66tPwyr/lwT/Tz7lnrWBWcyXuqR+ QeHg== X-Forwarded-Encrypted: i=1; AJvYcCWNmhRCbtZa546zs3hIGjg5sh2u4832zcp+MxeRmbdYynk2WLcqD+cnTHEsfGJCRvRu+9gL/4dSC/+lzaI=@vger.kernel.org X-Gm-Message-State: AOJu0YwNNOHVTpha/0VTJgfy3iGR8WLOkWs6yPOAPNQE6xMgcNrgKQy3 ooMZCAagd+6mhIr1xijeqZE3OSuGFDRZoLpLSrsPJ5aDgJOJnteb4x1a X-Gm-Gg: ATEYQzzDM0oLKE/k0/B1Xoi6uEK6/Nd8NUTTS3LVRgUus2eNx2/k+WKWhprT148TQnO 3vivQ/a5UcixvWnqaW71ylowgImtRrOxLAelruYXTMr/Vr3tilGDoIhv8/KenO3hxZXCKMfSdrk 5dkNt8BAKbR7tQnlj7N9mgVXnJB3VJ//iYedhM+ZotKzFjHk0sMuZ91uIbr3T5X2L66+RvG2+bQ /JZAIoEItNcdTRdoiV/wJsdRvO7peuTNO3qYlE3xxBRRzB02lFW1E5FRKFoehMNVlNK5SlfWUW0 Tloguti4kxpRODWVRXi52rccIw1jd0aT+vsNK0rp9rqJx1HwLeuJQxsqeORqfc6aGVw9GordZS6 /mTwW1k7W2LUoWEDdr9d4El48sDvOyBkQAFyYuO4v87XMgM+wOrkP/JiYgsTO2Kq7DUAKxkc9F+ XceYzcbcl6yZtvkJmyv+gWGjjfHPX9+xF6CWGFcOfemdha30kNlvqeYCCBJXg= X-Received: by 2002:a05:6808:514b:b0:45f:59e:1e06 with SMTP id 5614622812f47-467570a2074mr1690601b6e.4.1773408191750; Fri, 13 Mar 2026 06:23:11 -0700 (PDT) Received: from frodo (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 5614622812f47-4673434a35csm4795987b6e.20.2026.03.13.06.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 06:23:11 -0700 (PDT) From: Jim Cromie To: airlied@gmail.com, simona@ffwll.ch, jbaron@akamai.com, gregkh@linuxfoundation.org, Jim Cromie , Andrew Morton , linux-kernel@vger.kernel.org Cc: mripard@kernel.org, tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, christian.koenig@amd.com, matthew.auld@intel.com, arunpravin.paneerselvam@amd.com, louis.chauvet@bootlin.com, skhan@linuxfoundation.org, pmladek@suse.com, ukaszb@chromium.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: [PATCH v11 08/65] dyndbg: make ddebug_class_param union members same size Date: Fri, 13 Mar 2026 07:19:33 -0600 Message-ID: <20260313132103.2529746-9-jim.cromie@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260313132103.2529746-1-jim.cromie@gmail.com> References: <20260313132103.2529746-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" struct ddebug_class_param keeps a ref to the state-storage of the param; make both class-types use the same unsigned long storage type. ISTM this is simpler and safer; it avoids an irrelevant difference, and if 2 users somehow get class-type mixed up (or refer to the wrong union member), at least they will both see the same value. Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 2 +- lib/dynamic_debug.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index a10adac8e8f0..441305277914 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -104,7 +104,7 @@ struct _ddebug_info { struct ddebug_class_param { union { unsigned long *bits; - unsigned int *lvl; + unsigned long *lvl; }; char flags[8]; const struct ddebug_class_map *map; diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index a9caf84ddb22..ffa1cf7c2c72 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -811,7 +811,7 @@ int param_get_dyndbg_classes(char *buffer, const struct= kernel_param *kp) =20 case DD_CLASS_TYPE_LEVEL_NAMES: case DD_CLASS_TYPE_LEVEL_NUM: - return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl); + return scnprintf(buffer, PAGE_SIZE, "%ld\n", *dcp->lvl); default: return -1; } --=20 2.53.0