From nobody Tue Apr 7 12:53:56 2026 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C52F832E137 for ; Fri, 13 Mar 2026 13:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773408190; cv=none; b=qf4A19stmQHNJC57C6zoPwUrOpXcGk1ZQV7uZgvJuazjLI31kug99R8apl9UU9RNKP/V/EvOsJ6tw3Ky1sVPKQR5M1BY49AAQp97508/bx0jeHTcjjIPScJHpNZFQm0DULvakDwtzPz9Ctf/VapfJSnmXos9rVPYFYj2hzHkQUs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773408190; c=relaxed/simple; bh=6qEnUlc0QW37ApD+4VV5gg8sRlLcSuU7c6UrMPZMZns=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IqkfZpHhWqvur4oJYxZGefQQOO6SH6eUMwAsVg5zFKi8nDBMGhwR5FK4YzPxSnyZM5+fWji2a1dFEtQVtndhCpRNpwvWlPvHCUZ6jM+UXz2SlLHifTITqwqd2b3q2dQjdmCnzJJmRHsAZ6z/EpEGAV4exu/ofhAGGaLoxj8iK08= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=knyMHfCv; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="knyMHfCv" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-464bba3a9easo1493120b6e.0 for ; Fri, 13 Mar 2026 06:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773408188; x=1774012988; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R/SjSwC+RMF8YRDI51sil3K6xHtCNjZlX0uljPPVd8o=; b=knyMHfCvskvxcUnNvR25PcJVNzVPIXDUa7xX773rJR7HO3ZzG4iK1gCpSdMpNLJvIQ HsmvROVJ8dTuvp+JI8wNQEe41DUVmdIusijSqW38HlQdvOtS7N5FDmmfuBdnithsmiKB 2izdd/Xwmr2ixK1pSBLvlmEgx6VYZpoQb2WPVWAeYjF8sInSrgKtZtu+3mTYlcfkEMgT nvRjPhSX4FlXMRSKP4GjLFhx+eJlCT0FJhOYuncJwRtNgtrfK/i2pMjS9vNcGdCgeMNO AmWGDJ65NqxqYDUqcRuuPCC0AfZsMG9R38lBLi3aPpPRSS5cBmnhMCXQssvXopPbnpvE OfLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773408188; x=1774012988; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=R/SjSwC+RMF8YRDI51sil3K6xHtCNjZlX0uljPPVd8o=; b=rMI8O7PN/wjffhl5lzZnB7r5tvAhSLuzDamtD2jHwsHpU5bHjNHCSFirDSAAqYuJ+L jDV72J6LUOvEwMwDdC5eVFnlCxC+HefVbX707En//qFp7gYQBz7EOiEvOW51abPLtyGb K3ohBz3H3Hq0jJ3u2eW9sT2lQMgRwOsO5frFNVDjEYAKTTU4CESWeQFsAHoFASh0BJs5 0WEwAaZ5OWdJfZlUWCDzd1w2DDNXVQyG3Okt96ArKQ31yvZPAuq/QYgaFUnEApBWoQl+ bQLQvX55GCvVFQVA2pfmervNd4ubsNOGJmaMRVG0KZsbR9u45wkN56yqzjtjCxgzVROZ BhWw== X-Forwarded-Encrypted: i=1; AJvYcCV06bvBuEuXd7CetGgYld31Pe5EpSBbiEHGkosecOmy9eBK8vPf/HjXkgFpB37ejTHz78Rn2+lO4z1zcgk=@vger.kernel.org X-Gm-Message-State: AOJu0YwMb949Nj3+eOVEVVlNV9dWJZ1S7Yr6BlVbfEUdbsFcMthRLCRx dJSkW32Wq6ZbNh8wnNBJwcNzfuXTvfbYK+hKIqwW4v411itkwfTvqC9X X-Gm-Gg: ATEYQzwCZMeQMhL52chMFgDEzzislDYItnMsAxUwEXBdKRjyvVp7d/7w1zDyXlEvByX zydc73O6GeFGqXNDePP9XGNbYVmoxkFeL+1hWOH/hLB5dLcNDXuv9tXmfb1xvzA2KEYPHRxGsHk I9R8AjeijmE4049+FtXFxgvnv3BALg5CdQiJWlSSBwZowYbYBIInffxBFi3jdtA5gZYurGkqf1+ iupfbZs36mrmUaIjyAZ03ctgcM/lJaDSQ0fYOUnNExNpX1eMpwTNwTgLMaB5LOsgTGMzTd15U1v xQN/97shvu7Q10XKvuLy3Fl5HzJSWX5LQbsN7DWJYiu6PHr2cLYQlAPmsdqwoCFsg8s3Ewz430+ Q/Rry8mTEu3S9DHjlHr9BAjQaKuKoDY9zHSAtcCxsULca77F4rvUB18kkh/r1olbjc45QFq12Ef 2zkJMn+lfqqEsVWSeG8Ji71pgygzmjeTnZbUq05y/rAR/5pKMF X-Received: by 2002:a05:6808:c188:b0:45e:e088:5f3e with SMTP id 5614622812f47-467575cda13mr1872198b6e.49.1773408187615; Fri, 13 Mar 2026 06:23:07 -0700 (PDT) Received: from frodo (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 5614622812f47-4673434a35csm4795987b6e.20.2026.03.13.06.23.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 06:23:07 -0700 (PDT) From: Jim Cromie To: airlied@gmail.com, simona@ffwll.ch, jbaron@akamai.com, gregkh@linuxfoundation.org, Jim Cromie , Andrew Morton , linux-kernel@vger.kernel.org Cc: mripard@kernel.org, tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, christian.koenig@amd.com, matthew.auld@intel.com, arunpravin.paneerselvam@amd.com, louis.chauvet@bootlin.com, skhan@linuxfoundation.org, pmladek@suse.com, ukaszb@chromium.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: [PATCH v11 06/65] test-dyndbg: fixup CLASSMAP usage error Date: Fri, 13 Mar 2026 07:19:31 -0600 Message-ID: <20260313132103.2529746-7-jim.cromie@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260313132103.2529746-1-jim.cromie@gmail.com> References: <20260313132103.2529746-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" commit 6ea3bf466ac6 ("dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes") A closer look at test_dynamic_debug.ko logging output reveals a macro usage error: lib/test_dynamic_debug.c:105 [test_dynamic_debug]do_cats =3Dp "LOW msg\n" c= lass:MID lib/test_dynamic_debug.c:106 [test_dynamic_debug]do_cats =3Dp "MID msg\n" c= lass:HI lib/test_dynamic_debug.c:107 [test_dynamic_debug]do_cats =3D_ "HI msg\n" cl= ass unknown, _id:13 107 says: HI is unknown, and 105,106 have a LOW/MID and MID/HI skew. DECLARE_DYNDBG_CLASSMAP() _base arg must equal the enum's 1st value, in this case it was _base + 1. This leaves HI class un-selectable. NB: the macro could better validate its arguments. Reviewed-by: Louis Chauvet Tested-by: Louis Chauvet Signed-off-by: Jim Cromie --- lib/test_dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c index 77c2a669b6af..396144cf351b 100644 --- a/lib/test_dynamic_debug.c +++ b/lib/test_dynamic_debug.c @@ -75,7 +75,7 @@ DD_SYS_WRAP(disjoint_bits, p); DD_SYS_WRAP(disjoint_bits, T); =20 /* symbolic input, independent bits */ -enum cat_disjoint_names { LOW =3D 11, MID, HI }; +enum cat_disjoint_names { LOW =3D 10, MID, HI }; DECLARE_DYNDBG_CLASSMAP(map_disjoint_names, DD_CLASS_TYPE_DISJOINT_NAMES, = 10, "LOW", "MID", "HI"); DD_SYS_WRAP(disjoint_names, p); --=20 2.53.0