From nobody Tue Apr 7 12:55:39 2026 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B6F0399346 for ; Fri, 13 Mar 2026 13:23:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773408204; cv=none; b=lbhmsNnwWGyI3AEZruKFUgBOWghtpYgX4S5mLtTYbKC03lVJd4PLUvOCfx15pS11ShqA2GoQj2jfFauGU3N1ndA1Vor7N/B1t0Xn9if6VrCNaM5IiSeqKjB9MIlN+WDR1P9Coc6+Zs/tRrCyE4jjcHCvVWrYb1pj6CzMOzzksuA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773408204; c=relaxed/simple; bh=PBAFi7y3YRuwq9TlfBtroorgB24BQAwGr2rvA4abp3A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Eb9HslEPCI3voELHl//S3z/y5EX3uuP80Bjk6+vIpjKU+bC+llItQBOdqTUlIC9A59+UdpDq9Vd1sSPdiI4Ff5xzkxK/Tt17umWFRgOdQCgrRDx5qmb78oH6wN4tWEkJ2CO2rEGHP109Ymq0BC9hzq05/KBvZFI1a5FUlekRae8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l+zj7EBk; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l+zj7EBk" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-46726528f1cso1546012b6e.0 for ; Fri, 13 Mar 2026 06:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773408202; x=1774013002; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Lr3BXrtiuAvHSgc8/DPsjTxu/hA/+WXgrNkg64S657g=; b=l+zj7EBk+i93DYqbd00IRf0SQw+dZOur4l4lmHYcb/RnSkZH7RHxMiVpqyZWf+WvGj kp8dQVwvJ37+leCFr89EopSKWo8tFvy3n5/63Mu+ZhhBjQWsR8wOfVjQeniK02Ya0jzB hUTPjcfe7x7qBJTBrFWOxZO4F0CH/29/q9DEqYGgBKepmNoZRLvDJE/FdkQwQzKxQwma //p2MBpq6b3iFg81B62IA6OUcNLn+yKc3j3uHGEIRx5COlY+3OTalhyckOWF+CKpVM6F RuN5pWJkqWFZINL6D4JAknbGVZy0ATh6mKaFdhvOfjAdvDZow6RZXcSkylDHKuABZY2Y V1Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773408202; x=1774013002; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Lr3BXrtiuAvHSgc8/DPsjTxu/hA/+WXgrNkg64S657g=; b=Hk5sfA9YVBMyo9CZVrsdbUcpIBdN3RTO37u/xLhMI4TRBvm1yO/28av3ZE+DR5kliU tTKo+1GKfLbNp0KO7PYga32YxawjZV2H98myRY2r9mbJvEWef4K5CGjCO8pNzUcNIQCS x7QZJxyUVfRHga/lPNwtac8/8Z9oKmcV26t8Jm6PfCiv8pyTJBioFE1Is14QB3+j2Fgj IHSB++5VNbzXbWi4EH9RCD2vXy20/NeL8UD9UT3hnW+uTaMdBBN2Nc5sZ7+jIS83TY46 4Kr0JiMTG0OWHB7o1NpYQTstRhYdZutfCXq4zBU72sCFnn/V7kT1pKFvzN0unlRx7frU 2TMw== X-Forwarded-Encrypted: i=1; AJvYcCV2Q4iMlx77D81HOAlMenJaQi16Icsaf+IASmvvNvj99xodbckFp6hvaFVmlV3jPlvDFs21dWfFAkzQfH0=@vger.kernel.org X-Gm-Message-State: AOJu0YxlWLb3Csk7WDm2IGu8uvZOF4zKTkhJHlg5w/KWc4lflx0KDk8h maHUZ20NC6KASidZ/dBgOEwTlcxU7/WDIbsNqyqF+2wKBaduyK/8Rhrx X-Gm-Gg: ATEYQzwMxB7DawBHTwSfL7ZvXicic78q1KDM/9w7cGbXoht/8zRPMR4uVawb+TkF2Z/ Uyw307ICN2O4er/jinL+7qghhBoavxwlmf5u68FUnU8gVCvmXvdJuylVEey37SFUvOdmjEAECNT GD9iY0tUE8G07qN+iPKILyfRNNODB8n3TOrfr0cNR50Gm5+lvZlUvqXTN/O8A3wXms9mhjcpvMW BP/PtYFKs+4oACFk0a3ESgSfiVq4D+wjimtWeyn1ANv7VppD46/Gg6AaPHNt02C8SeY0msIPVDm kc+B2I3VO/ISUww6d6fkJnquimX+gG8/RZDYnXEntTqkG2VufTfq3OUEm5UevvRacfwpPSPqsxK DAc7nAlXEtnPypibw08KsRlXfU2qVOaJmxhk29mqmI67QwkGpYtAcmoC+ZtW5Uwa122GvM0L2WT +1s0EFZBYcMKDxaSCcONv9DG4owxVv99Db15WO3kAly9GNKrnZGgJN5rmshaU= X-Received: by 2002:a05:6808:1a21:b0:467:13b5:8ae6 with SMTP id 5614622812f47-4675704ae1cmr1541416b6e.4.1773408202078; Fri, 13 Mar 2026 06:23:22 -0700 (PDT) Received: from frodo (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 5614622812f47-4673434a35csm4795987b6e.20.2026.03.13.06.23.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 06:23:21 -0700 (PDT) From: Jim Cromie To: airlied@gmail.com, simona@ffwll.ch, jbaron@akamai.com, gregkh@linuxfoundation.org, Andrew Morton , Jim Cromie , linux-kernel@vger.kernel.org Cc: mripard@kernel.org, tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, christian.koenig@amd.com, matthew.auld@intel.com, arunpravin.paneerselvam@amd.com, louis.chauvet@bootlin.com, skhan@linuxfoundation.org, pmladek@suse.com, ukaszb@chromium.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: [PATCH v11 13/65] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Date: Fri, 13 Mar 2026 07:19:38 -0600 Message-ID: <20260313132103.2529746-14-jim.cromie@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260313132103.2529746-1-jim.cromie@gmail.com> References: <20260313132103.2529746-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" old_bits arg is currently a pointer to the input bits, but this could allow inadvertent changes to the input by the fn. Disallow this. And constify new_bits while here. Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 4313c8803007..a18f4bc63473 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -607,7 +607,8 @@ static int ddebug_exec_queries(char *query, const char = *modname) =20 /* apply a new class-param setting */ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, - unsigned long *new_bits, unsigned long *old_bits, + const unsigned long *new_bits, + const unsigned long old_bits, const char *query_modname) { #define QUERY_SIZE 128 @@ -616,12 +617,12 @@ static int ddebug_apply_class_bitmap(const struct dde= bug_class_param *dcp, int matches =3D 0; int bi, ct; =20 - if (*new_bits !=3D *old_bits) + if (*new_bits !=3D old_bits) v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, - *old_bits, query_modname ?: "'*'"); + old_bits, query_modname ?: "'*'"); =20 for (bi =3D 0; bi < map->length; bi++) { - if (test_bit(bi, new_bits) =3D=3D test_bit(bi, old_bits)) + if (test_bit(bi, new_bits) =3D=3D test_bit(bi, &old_bits)) continue; =20 snprintf(query, QUERY_SIZE, "class %s %c%s", map->class_names[bi], @@ -633,9 +634,9 @@ static int ddebug_apply_class_bitmap(const struct ddebu= g_class_param *dcp, v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi, ct, map->class_names[bi], *new_bits); } - if (*new_bits !=3D *old_bits) + if (*new_bits !=3D old_bits) v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, - *old_bits, query_modname ?: "'*'"); + old_bits, query_modname ?: "'*'"); =20 return matches; } @@ -691,7 +692,7 @@ static int param_set_dyndbg_classnames(const char *inst= r, const struct kernel_pa continue; } curr_bits ^=3D BIT(cls_id); - totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, dcp->bits, NULL); + totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, *dcp->bits, NULL); *dcp->bits =3D curr_bits; v2pr_info("%s: changed bit %d:%s\n", KP_NAME(kp), cls_id, map->class_names[cls_id]); @@ -701,7 +702,7 @@ static int param_set_dyndbg_classnames(const char *inst= r, const struct kernel_pa old_bits =3D CLASSMAP_BITMASK(*dcp->lvl); curr_bits =3D CLASSMAP_BITMASK(cls_id + (wanted ? 1 : 0 )); =20 - totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, &old_bits, NULL); + totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, old_bits, NULL); *dcp->lvl =3D (cls_id + (wanted ? 1 : 0)); v2pr_info("%s: changed bit-%d: \"%s\" %lx->%lx\n", KP_NAME(kp), cls_id, map->class_names[cls_id], old_bits, curr_bits); @@ -755,7 +756,7 @@ static int param_set_dyndbg_module_classes(const char *= instr, inrep &=3D CLASSMAP_BITMASK(map->length); } v2pr_info("bits:0x%lx > %s.%s\n", inrep, mod_name ?: "*", KP_NAME(kp)); - totct +=3D ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits, mod_name); + totct +=3D ddebug_apply_class_bitmap(dcp, &inrep, *dcp->bits, mod_name); *dcp->bits =3D inrep; break; case DD_CLASS_TYPE_LEVEL_NUM: @@ -768,7 +769,7 @@ static int param_set_dyndbg_module_classes(const char *= instr, old_bits =3D CLASSMAP_BITMASK(*dcp->lvl); new_bits =3D CLASSMAP_BITMASK(inrep); v2pr_info("lvl:%ld bits:0x%lx > %s\n", inrep, new_bits, KP_NAME(kp)); - totct +=3D ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, mod_name= ); + totct +=3D ddebug_apply_class_bitmap(dcp, &new_bits, old_bits, mod_name); *dcp->lvl =3D inrep; break; default: --=20 2.53.0