From nobody Tue Apr 7 12:55:39 2026 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 144B9398918 for ; Fri, 13 Mar 2026 13:23:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773408200; cv=none; b=U1rbxOf8cAMh857/8nQNBM5e7rzHz9zB4iqbDjDXRwNY45KcRKCgq2/98c/SFmc7P/JAkAcYZojgVXYmVv/QjmNepgjCXxzz7aqUtkthACgpqFCklFVjG9TNTt4faeAVBNnw0jIkI/P0uQHpRB8Oa6AILQ+zYLEnn/FIrs1Z8fc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773408200; c=relaxed/simple; bh=S6gUrn6AElwN551VfXZR8sAzEWfpnwUQMkcCkNtZGhE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ngdzXAO0nmbppzAJnEQWcGRaff6O90vZ4H/BP6t73+a8HhE9MIqJxj4LJ2nCrnAo0LHPwD8T2owWts2g0sSF4a4ql6eKYpoS33mRbL+blPH26zgUErsfmSIqBhVpCoZA+YUXPT/0KvacYDeUgjVDI6xUQ3IgcEMAzFyA1cK9AfA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=htlovex3; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="htlovex3" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-46704177543so1450550b6e.2 for ; Fri, 13 Mar 2026 06:23:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773408198; x=1774012998; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sNdSdlXltBKavjCpq8HaVo39jGQFAT2gyMj0g9RRu6w=; b=htlovex39/4lhBYpDc0VZc+ZdVntj8eQtDp7W4fYnlKvzxekycOMHPbKLj7G1UJKET TLQSA6cU1l6r60F74XO69+ny8tXIavjoaZ3ds7uXdLMmZd/iwg0hTIH6c56qKWwT90bg KMFPaksqg8vb0m1X6/EqLKRXi4IhhEiespSn6QHRz/pOWdGOlMwM9f7X9sp4U/H0DukT Q24VxU7/E8TnwElGYKFTMuGvrGyNpcDrMfVpyFWvuxK9gIwQI6MqbSGe94BHwOJYC1lT Skz81s5X8lfZGiUvZTSDcvTl+iEQETiJLD212H0Du+GeHvlw4y5x0NyqlwAlysJ3rVbN JO5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773408198; x=1774012998; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sNdSdlXltBKavjCpq8HaVo39jGQFAT2gyMj0g9RRu6w=; b=KrGVKvcty78YoSEO299cGt0KP8/mQYus9Ud+8ZDqNmXitCztspW6fbiFI2q39T5eeN ynO2I6dnZq3VdED/H2Ihs2E0RyyY+uS+nPf1p7r0JWqyeFSAsGGHph/MyhwTdTBDXq1u Fr4GnoYVQdS3EHcsBzjIm5/HLKSVdm+rlN4Sf1Tg+vo2rJ1nPCTBhZTFTGGQdseugVYp e++tmscR/fjUCPYaz3pfoawqGDX1RCes1QpoZDjD4/NkqlWSBiaQEZY9DIwQBIeOtEwx pAaWFqg2KkJQKWk91V6Tb692lnbX2SRf7Is47lft8vSJkrQgvg4FFweQOwHVInzU9YBt lLmw== X-Forwarded-Encrypted: i=1; AJvYcCX6hy9YfSbJHV6hSNcv4ryEmp8yOGKXqp0fLhYt1vzoK6w+MdIS+4qBpP8173NH5Rf0DkEqLWiU6vXOhng=@vger.kernel.org X-Gm-Message-State: AOJu0YxLl8AHO4VlO/nVKMw9r9VN7sKdXpO8T/7NhpVPPiomrG31BsNN ZpIURAp+PV9lHLXq8OpWLYKijN4PdYdZaxeLWDq7/lHc5otEoX+6+3uuIzlqLA== X-Gm-Gg: ATEYQzzT2eFq3gbAm5ueS76n/pKpR2oa9D2QOvYl84g7ZdcvE+rnVExrtu2nOZyt5+f v5zbTWrEEpMHSP50Q9GUyk9zfErkKbUcQnaYsd+3+JJuVnye350MHc9vMK0c6EoV8a4nKQnS7o8 2LicTi7jkgdXWVLFO1X5JTCAK5wQiksNRVTbYl04Do/Uaf31MWsPkN0DG9LhJu5XacGU12up9yD CH3qxRrXgwhQU7aLRXgS+cUNc8Fez7JrHFn44c67/qquub5yY9RHR3DtKdqEes0MM87b6xNSZAl SVBPc5Zi17ix0kCFLF5dmNRGCQRLQbXkoswCp9Lp7+lOIty7/MqZiWxGZpATx2m3fTN1Ge4RZVE axup9y7VNyHQIH1F0I11c5wGtWtK2A1esqCNyQSOfAmSgBJuZmQdQv67XQNEBCRk6h+KvMs2Ieq Fetmo/RUIHn498ZwG8FhtJdSbhNzW4HW60fhfIvLwqlZocq84O X-Received: by 2002:a05:6808:1b10:b0:467:254:b90 with SMTP id 5614622812f47-4675704a335mr1610159b6e.10.1773408197894; Fri, 13 Mar 2026 06:23:17 -0700 (PDT) Received: from frodo (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 5614622812f47-4673434a35csm4795987b6e.20.2026.03.13.06.23.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 06:23:17 -0700 (PDT) From: Jim Cromie To: airlied@gmail.com, simona@ffwll.ch, jbaron@akamai.com, gregkh@linuxfoundation.org, Jim Cromie , Andrew Morton , linux-kernel@vger.kernel.org Cc: mripard@kernel.org, tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, christian.koenig@amd.com, matthew.auld@intel.com, arunpravin.paneerselvam@amd.com, louis.chauvet@bootlin.com, skhan@linuxfoundation.org, pmladek@suse.com, ukaszb@chromium.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: [PATCH v11 11/65] dyndbg: reduce verbose/debug clutter Date: Fri, 13 Mar 2026 07:19:36 -0600 Message-ID: <20260313132103.2529746-12-jim.cromie@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260313132103.2529746-1-jim.cromie@gmail.com> References: <20260313132103.2529746-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" currently, for verbose=3D3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op=3D'+' dyndbg: flags=3D0x1 dyndbg: *flagsp=3D0x1 *maskp=3D0xffffffff dyndbg: parsed: func=3D"" file=3D"" module=3D"" format=3D"" lineno=3D0-0 c= lass=3D... dyndbg: no matches for query dyndbg: no-match: func=3D"" file=3D"" module=3D"" format=3D"" lineno=3D0-0= class=3D... dyndbg: processed 1 queries, with 0 matches, 0 errs That is excessive, so this patch: - shrinks 3 lines of 2nd stanza to single line - drops 1st 2 lines of 3rd stanza 3rd line is like 1st, with result, not procedure. 2nd line is just status, retold in 4th, with more info. New output: dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op=3D'+' flags=3D0x1 *flagsp=3D0x1 *maskp=3D0xffffffff dyndbg: no-match: func=3D"" file=3D"" module=3D"" format=3D"" lineno=3D0-0= class=3D... dyndbg: processed 1 queries, with 0 matches, 0 errs Also reduce verbose=3D3 messages in ddebug_add_module When modprobing a module, dyndbg currently logs/says "add-module", and then "skipping" if the module has no prdbgs. Instead just check 1st and return quietly. no functional change Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 9575b92a8deb..3ae9ecabdad1 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -276,9 +276,6 @@ static int ddebug_change(const struct ddebug_query *que= ry, } mutex_unlock(&ddebug_lock); =20 - if (!nfound && verbose) - pr_info("no matches for query\n"); - return nfound; } =20 @@ -511,7 +508,6 @@ static int ddebug_parse_flags(const char *str, struct f= lag_settings *modifiers) pr_err("bad flag-op %c, at start of %s\n", *str, str); return -EINVAL; } - v3pr_info("op=3D'%c'\n", op); =20 for (; *str ; ++str) { for (i =3D ARRAY_SIZE(opt_array) - 1; i >=3D 0; i--) { @@ -525,7 +521,6 @@ static int ddebug_parse_flags(const char *str, struct f= lag_settings *modifiers) return -EINVAL; } } - v3pr_info("flags=3D0x%x\n", modifiers->flags); =20 /* calculate final flags, mask based upon op */ switch (op) { @@ -541,7 +536,7 @@ static int ddebug_parse_flags(const char *str, struct f= lag_settings *modifiers) modifiers->flags =3D 0; break; } - v3pr_info("*flagsp=3D0x%x *maskp=3D0x%x\n", modifiers->flags, modifiers->= mask); + v3pr_info("op=3D'%c' flags=3D0x%x maskp=3D0x%x\n", op, modifiers->flags, = modifiers->mask); =20 return 0; } @@ -551,7 +546,7 @@ static int ddebug_exec_query(char *query_string, const = char *modname) struct flag_settings modifiers =3D {}; struct ddebug_query query =3D {}; #define MAXWORDS 9 - int nwords, nfound; + int nwords; char *words[MAXWORDS]; =20 nwords =3D ddebug_tokenize(query_string, words, MAXWORDS); @@ -569,10 +564,7 @@ static int ddebug_exec_query(char *query_string, const= char *modname) return -EINVAL; } /* actually go and implement the change */ - nfound =3D ddebug_change(&query, &modifiers); - vpr_info_dq(&query, nfound ? "applied" : "no-match"); - - return nfound; + return ddebug_change(&query, &modifiers); } =20 /* handle multiple queries in query string, continue on error, return @@ -1246,11 +1238,10 @@ static int ddebug_add_module(struct _ddebug_info *d= i, const char *modname) { struct ddebug_table *dt; =20 - v3pr_info("add-module: %s.%d sites\n", modname, di->num_descs); - if (!di->num_descs) { - v3pr_info(" skip %s\n", modname); + if (!di->num_descs) return 0; - } + + v3pr_info("add-module: %s %d sites\n", modname, di->num_descs); =20 dt =3D kzalloc_obj(*dt); if (dt =3D=3D NULL) { --=20 2.53.0