From nobody Tue Apr 7 11:14:48 2026 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 769EE372B22 for ; Fri, 13 Mar 2026 12:49:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773406163; cv=none; b=JDCHwo81HXowBz+CwJiSGVp/V1pcuAFlOsyGhpAzfS9Jjt+rrPga6eBz4SxxSZ6YpjvUwGJU120RKfzyl5AbMzMYLa/Q6rMvBDMDMIiN80mRvxkYsoPB26ud7LG2xF7cffYj3EsSTs0DKe1IXHGXj23uwPiikAZH44XAzxoe4hc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773406163; c=relaxed/simple; bh=YX8DYrvANKwmCN46nhqzvNj0wKv6Y9mNMCkpfTSdD8c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Dt9J6FYRWCK+yNwhuMa1kSYZXKCE08yif+LiH61egcjIdjWNBk5+KmV/iHDisGiGd0PxX9Cem+uRgosb046XPP+blMIgphsp6GVSDfUoxgPsXD+qrVuysG2mFWBD0vppJ51sI0BjGffFKiY+IuwP3wudAmN1IbAo6/nRSUtthZw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XtT8RGeH; arc=none smtp.client-ip=209.85.128.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XtT8RGeH" Received: by mail-wm1-f67.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so17440345e9.0 for ; Fri, 13 Mar 2026 05:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773406161; x=1774010961; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1saJ09mUSFnv5wvSt1w6UXZlmb5ycX3irFzPT0gfncs=; b=XtT8RGeHoG5vj0Hii0RUzLaeFsacQ+ZxkXlnGcuRBfPCepgF2Onwjn3qh1Elv5/8DB XqyxAXekX6nWlukl+RrzgzFAiwCPZsFen7JGkKa9uk0HII2ySbaBOoJdhkkn+mNeAEC1 342Os9dr4QQZDOrfYrRFfnxDWgysHeTMNprWY0/WZU58Nw0iqaVOHxdHo1S5/SNWUKc2 bbO7tS5CxKFZie9LCQhBcu7QN59i7tf9YDIWdIgXWchq+xe+ASDb50kU9tPCzsMWWSRY vt3ULMtYJo4WuDptqyVEaM25HTU3Z/uR5DfTJBJLMWnSM3268WdyvNri+ob+fhVOQjvB 6xFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773406161; x=1774010961; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1saJ09mUSFnv5wvSt1w6UXZlmb5ycX3irFzPT0gfncs=; b=r/M1fGdO5R7bQA4UAgLOng6cdhLfSed9rfElR98oUP9FcPxoDIVpkIIMJwXL8z3BM1 fbukAqNeGJl5DApOKzImMYrDzNrH72lVhPwQS9MmJXiG8YgZr9S2T9t7Pm4EFcWdv3SO gLNy4Jl6vcYmSYkvbRtTQm61NCIxARKgrxGypfe3f15S6jRgrTAZSIlmujNhi9jC6oJF zMo5HHlPduawfLVA5iBynAn7AMKWy2eCQv2XpzbMjnUCnvc8aoX2dGdkRT5fPTdtmeZB vqrVWXoXe4xZ4EovNPweIq365iOcRGTaNZUb3/yGGqrcYHCIi+8iqGLWmea4/Eze3WBt ULZg== X-Forwarded-Encrypted: i=1; AJvYcCXKhvrBRRxN0hKf8nyFe0dNntNt33HecPyBoEnVMS8/o7pyWpDvb68RSVHiSIG1O17LS0wAu9ahARO941I=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2rM3M2OkkjJfXDrjuCp7MXfL2IxDRxiDY9ksR4GoDlSsm9Nvu u50cHzlXkQF9q4jNmNqjqkJJ/JqJnIW7Y8uQAsPWR3z5cuyPQJ/4vBMF X-Gm-Gg: ATEYQzxJDGj8W+Kn+UuJVjkEWbOVvo1aQMqn0RMcaFxRaRdB8lbPqw07P6/aUF5ZCsO wSozlblkjOWWre6YnQlDmbU3G6/sW9L8m7a1RXzC3jWHolh4hCgbEcM3rB2NNI+SUO4ahTITYNC kRY/zDPXXKWz/l+WHEm98an8wN3TdcXJ/sfchME4+01lvmBmwhxvjKHYRsGjkrEJZlGG5o+lnKc JvsLQ0MAjRckQlRPkGyjVRGTf7rsDcj6uVm4PVi65Qc9M8or6nGVpTVBwcnzuw2/sgRSCayhqGU n+6Q7PvRvL8ywNDDYh5wiUphpvYYjNsuuH3eIcAcGzptSpJjDm9L2GW5Rkdlt4xBk8/MlExIlc+ DaQAXeuppg+RDmLDSIyyURfjWjC3rWyagbwUuha/QXpoBi7qurI8PDKuqkwyO8bfB9ORY85vM1x gs/FqkOBCtgXUu8mauVlU5jaRiEtnDUaq1wu0I5BTH X-Received: by 2002:a05:600c:8b45:b0:485:4526:ee05 with SMTP id 5b1f17b1804b1-48556700c0dmr50666915e9.19.1773406160368; Fri, 13 Mar 2026 05:49:20 -0700 (PDT) Received: from DESKTOP-BTQF5RC.localdomain ([85.110.79.247]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48557c89186sm60296075e9.1.2026.03.13.05.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 05:49:19 -0700 (PDT) From: =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= To: gregkh@linuxfoundation.org Cc: ethantidmore06@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= Subject: [PATCH] staging: rtl8723bs: Improve error handling Date: Fri, 13 Mar 2026 15:49:08 +0300 Message-ID: <20260313124908.579-2-b9788213@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Remove unnecessary ret variable and goto exit pattern. The function now returns immediately when an error occurs. Additionally, ensure that intf_free_irq() is called when pm_netdev_open() fails to avoid leaving the allocated IRQ uncleared. Signed-off-by: Bera Y=C3=BCzl=C3=BC --- V2: Used int_free_irq() in error condition. V1 Link: https://lore.kernel.org/linux-staging/20260312131933.29505-2-b9788= 213@gmail.com/ drivers/staging/rtl8723bs/os_dep/os_intfs.c | 28 ++++++++------------- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 7ba689f2d..e86b8af8b 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -1124,35 +1124,28 @@ static int rtw_resume_process_normal(struct adapter= *padapter) struct pwrctrl_priv *pwrpriv; struct mlme_priv *pmlmepriv; =20 - int ret =3D _SUCCESS; - - if (!padapter) { - ret =3D -1; - goto exit; - } + if (!padapter) + return -1; =20 pnetdev =3D padapter->pnetdev; pwrpriv =3D adapter_to_pwrctl(padapter); pmlmepriv =3D &padapter->mlmepriv; /* interface init */ /* if (sdio_init(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ - if ((padapter->intf_init) && (padapter->intf_init(adapter_to_dvobj(padapt= er)) !=3D _SUCCESS)) { - ret =3D -1; - goto exit; - } + if ((padapter->intf_init) && (padapter->intf_init(adapter_to_dvobj(padapt= er)) !=3D _SUCCESS)) + return -1; + rtw_hal_disable_interrupt(padapter); /* if (sdio_alloc_irq(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ - if ((padapter->intf_alloc_irq) && (padapter->intf_alloc_irq(adapter_to_dv= obj(padapter)) !=3D _SUCCESS)) { - ret =3D -1; - goto exit; - } + if ((padapter->intf_alloc_irq) && (padapter->intf_alloc_irq(adapter_to_dv= obj(padapter)) !=3D _SUCCESS)) + return -1; =20 rtw_reset_drv_sw(padapter); pwrpriv->bkeepfwalive =3D false; =20 if (pm_netdev_open(pnetdev, true) !=3D 0) { - ret =3D -1; - goto exit; + padapter->intf_free_irq(adapter_to_dvobj(padapter)); + return -1; } =20 netif_device_attach(pnetdev); @@ -1168,8 +1161,7 @@ static int rtw_resume_process_normal(struct adapter *= padapter) rtw_ap_restore_network(padapter); } =20 -exit: - return ret; + return _SUCCESS; } =20 int rtw_resume_common(struct adapter *padapter) --=20 2.43.0