From nobody Fri Apr 3 06:46:20 2026 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013032.outbound.protection.outlook.com [52.101.83.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD8052BEFF5; Fri, 13 Mar 2026 10:57:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773399479; cv=fail; b=eHw5hcnTFe73p0R6972c0EbQhntbgYRfj8fpgCaunyetSstk8dyVwKFWfffhXlKE0wNsEMnGOiDTbamOmvKS7G68Ctkg6F125perBAX5kbbTYAoZhM8FBt1J/TVz6oWYH+hl21/ApOLORYiakOXby0IrgD/dp+VmkidFahqT6EY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773399479; c=relaxed/simple; bh=YWeBnTeTg8WTqjzsdS/gx3ClSbXF8kH4ZhieGAJoNPg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=J3gjeS3O4TuLOygytuYVZMhaAGIszHQD5CmS5Nj9x7Qk5Iv755RjYNbkbdte5Wy0duzqyrlRFl4NEZJmuv0Kn8I44XQUolU2QCDVqeZCxU384N6Hgnr0x7PBFIcpiXUpRENiMmyIX2P6T9MGJ9E30lpME2avR6AvT/OIUqfZ2no= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=MRBRSX6f; arc=fail smtp.client-ip=52.101.83.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="MRBRSX6f" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cbWxVOXLGqBzlDN66dhLIWD/1IXzKKx/ugPXaMy3BlUw9cctQRFZymgMdURUspzZLD8aM/NkB8rkiEHm0Dj/CqtCsd0DDqo1wk8bI/EcBh7Fh7D80NdZDnl+2yxy1Of6Psf0L/agDbAnLAzYdyKVhhdT2+DctxnsHCFZrxBRxgmlZVfxuB/yUVOr/h1SO0mn95OC4Ru6DT74ek0tvfRtWQCWTEHv34FSTs1XDSrrhlD1Q+NKAgAHHpQbvxmBDcldRUkOIIQUI5WqhQkU2TzKUDeQmgL6rTi9Now1YSX9Flv1Jo9LCH4PhHLbcaCdy7PkS3l1pfHlJVjrDfJAq5i/ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=51vt+44h+IDY5mYqvB7015hSbJwP2stAqIgMEc1EQwc=; b=WWhMRnzgQnyM14n2dTm4PTEQAn1w0ByKiJET0PN9Q5yJe9adJSPFBwOycTpbuBDADcXORfPCwgalKBymskEQC4VKNY5KJ4JwkSxZKOz3iBUMyKIRgBlvG1UhCGQMUJEgOfzAAwIo2NNgvIH7/Bet2uI/3E4+QfyNr7GHgDk5Boe65gDWaGKbIqDSKaD5W0Ghjt0cI0bRSy7wshrbpc+m6y8f3NDgaLul+/kcEE9P+gzs/26ylbfYnE6CPYiXcwOZDOwTq+4CNZKFIJlxeiqMFw3t2Cg7IdLtOZM7ZxS0iMXVZrXsEx/KaFCp4RFxsmJLiSRo8nT3b8wqHu6lEUxFTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.59) smtp.rcpttodomain=lunn.ch smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=51vt+44h+IDY5mYqvB7015hSbJwP2stAqIgMEc1EQwc=; b=MRBRSX6fcmkZ63Q8EWq3mzrmk7ADfCU7dBeX661UreH52U339OIhSnTdJoqhAeY2qiGgI/aYda7cvh1cEvLQnhavDtOa3du1mu8f0CGT+jarYDI+t0afqkg8KvtmVjIeb+H3dtaxkz9DffTAEWHxHhdyWjMs2azX2ek0e/5ZpWKy9nBXhl+RwihWqlEAZEX3bw57zyfen0IXxlvUuvusgeqGf/zAjyhnmd8SkZg2JekFqGBCUqbsw0H9GMSPF7qaijy8zQiZglTfHNpt9j0v+qL8fCEn0FfausTi0P84vuAIHX1HZzRXleFMNe0ZhLsi/c0e8pugv3dJkGb7QMlvwA== Received: from DUZPR01CA0215.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b4::9) by AS8PR10MB6889.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5b5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.12; Fri, 13 Mar 2026 10:57:52 +0000 Received: from DB1PEPF000509FD.eurprd03.prod.outlook.com (2603:10a6:10:4b4:cafe::51) by DUZPR01CA0215.outlook.office365.com (2603:10a6:10:4b4::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9678.29 via Frontend Transport; Fri, 13 Mar 2026 10:57:55 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.59) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.59 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.59; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.59) by DB1PEPF000509FD.mail.protection.outlook.com (10.167.242.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.17 via Frontend Transport; Fri, 13 Mar 2026 10:57:51 +0000 Received: from STKDAG1NODE2.st.com (10.75.128.133) by smtpo365.st.com (10.250.44.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Fri, 13 Mar 2026 12:00:09 +0100 Received: from localhost (10.48.87.194) by STKDAG1NODE2.st.com (10.75.128.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Fri, 13 Mar 2026 11:57:38 +0100 From: Christophe Roullier To: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Russell King , , , Maxime Chevallier , Vladimir Oltean , Christophe Roullier CC: , , , Subject: [PATCH v2 1/2] net: stmmac: fix pinctrl management during suspend/resume Date: Fri, 13 Mar 2026 11:57:16 +0100 Message-ID: <20260313105718.359614-2-christophe.roullier@foss.st.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260313105718.359614-1-christophe.roullier@foss.st.com> References: <20260313105718.359614-1-christophe.roullier@foss.st.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE2.st.com (10.75.128.133) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509FD:EE_|AS8PR10MB6889:EE_ X-MS-Office365-Filtering-Correlation-Id: f3cbec5e-0f8b-420a-cd68-08de80ef5f61 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|82310400026|36860700016|921020|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: /OQ2Nq9xYUzSMQASEDONwGmUG98QIREmOK4GuhmOSPAtBPO6ZkkolXWjiTxJ+XGJInHnNYAw/OWTYzdjwhoqvKW54SVRiZXkVcokupWgkK93jffVrv4heuqgbTZSXRGsLPOXodRZ8uLb6ue5uAxzMjpj5TWYoNP5tPSRQsE9dMAm5IF/8fOv6rDIXw3JbEQp556U86IQiEjLnjD9gjRXdwmbGd/Jtsffgan/mBsjBNBYyX7xx7f+B2B8oioXSOcOTMKWoPRq/2xK1Fr5Gr+teRneIi+XOZ3xr1UF0V+Z7C3xI2TP0Mhr4NiH6Q6L/7Q7YLy8EVAnrXDlZSixWmh+JEqpILj5gkor7UbSSiqa80idMMEKlg8IWSGzA8y1YDVuPH0sK39SU5P3Gsgj13Gmn88TO5gCJxSKkJeVo2x5jYrI5xGJ6d2LqO9bErS2PbrwOHq0ofuq+8rrb5aDNTT14wHtousY4gn7TZ+PtA4lrckycNMfcI1QVyVYTnoE2x2r21FgW/bH65PvaaIXP/8Atyq60ivZdzfZmaiJdtKn34uriTO+YU0rkymWO7B0Kgh7VnNX/X8cY62lH3MkQW0UX9lfBDebehDs/JueseMNIV6oif8w6l95EHBpXlZcpuWrTCopkamwzxtQ+AQ50S7FTa56unPsQQsGP8XowMx8/IUqhO5EQRPlVN/gAEdhVmq4ngPf0OE8y22UKzXQLChRNfq5g20I7AgjFstoxZ20pNdyAHxGRJlFssC3+SvEkg66S2Y1ScMg4IQEoyczFtTpbMTJ7bKoXTqmv3fbogSqwlNvzSdLigkOPjJVuNvz9aYi X-Forefront-Antispam-Report: CIP:164.130.1.59;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(82310400026)(36860700016)(921020)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TJcSO0XGfJSQua/kvGSpwp/pvv7qa4B7ADZg4MivnXBMEzwf2cQ5k2I6ZyuqKuHffPcLn38zNfSkb6Fw/lE2xrOSP5kNTW8QHe/rpsKRCNgjEiFRgiRuXN39JPe4QBo6XMIHnrwxN1c0JCRfFwouYg5jYe7G+bY6GwqeHGIa+E/uS5XfJOPz5odDXIEkF20lTs6lKyBiQ3jgPaDjleGaYIQAWsMKLReVdlHsF0/IXdx5doJfkE769LKdBOp6U9Wi30TWM17z+MGGfHm9SDDE+w077E3UPtwbxVYT6GAfvQMg78cGsjGfSYuVe310gXBoc07HXg4ZiZLG1DnF7V3syYx48jtpiBGdgPPeWsqrn1Tya1iFNXW6euySCfONauco9mRXfqasy+f6qWYql3G10pCy0UXqVrrcOgdWudJVAirxek+mQ7LyBYXwY8Yzj7QL X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2026 10:57:51.7913 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3cbec5e-0f8b-420a-cd68-08de80ef5f61 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.59];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509FD.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB6889 Content-Type: text/plain; charset="utf-8" In the deepest low-power modes, the pinctrl configuration is lost and is never restored if the interface is down. This commit ensures that the pinctrl state is set in all cases. Signed-off-by: Christophe Roullier Reviewed-by: Linus Walleij --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/ne= t/ethernet/stmicro/stmmac/stmmac_main.c index 11150bddd8726..26ac1cdc561c2 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -8150,8 +8150,11 @@ int stmmac_suspend(struct device *dev) struct stmmac_priv *priv =3D netdev_priv(ndev); u8 chan; =20 - if (!ndev || !netif_running(ndev)) + if (!ndev || !netif_running(ndev)) { + /* Select sleep pin state */ + pinctrl_pm_select_sleep_state(dev); goto suspend_bsp; + } =20 mutex_lock(&priv->lock); =20 @@ -8252,8 +8255,11 @@ int stmmac_resume(struct device *dev) return ret; } =20 - if (!netif_running(ndev)) + if (!netif_running(ndev)) { + /* Select default pin state */ + pinctrl_pm_select_default_state(priv->device); return 0; + } =20 /* Power Down bit, into the PM register, is cleared * automatically as soon as a magic packet or a Wake-up frame --=20 2.43.0 From nobody Fri Apr 3 06:46:20 2026 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013015.outbound.protection.outlook.com [40.107.162.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C54E12BEFF5; Fri, 13 Mar 2026 10:57:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.15 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773399468; cv=fail; b=fWgAZUDaG2tmpQMLx5BP0mA2aCZb9A+hygIuEnxptnHPOmrgiNMpDfrtZFSRmll1kTG6H+RHOYUUQK5nHKYQCb72ceQjMr4br/9QpdurqPVJ4NNWiS+n6y/O+4OMyRFIR6SFt9Cz1AgAXkHWKg7kCFUt2wXmgYQuzYWqPNiUC/M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773399468; c=relaxed/simple; bh=IhUDZXidQIR/5xm5DdRfpijg94FxbX21yktc10jOz68=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Mgk2JCl2ubyyatq1IG4f5z6buNUekftNtGQYnmR+9dGxVBuLQJGigUzvtlAJXts+ZqtAVylpJG46l0tndLMhfMhD2wYCf5HVoCNIWMllsrUbullrjb9qOpCw+3YVqICHqMAa/oxMss9QDUXvmitwqdQecD8FtJ5MYUhHJ6KztCo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=k2/DjPeG; arc=fail smtp.client-ip=40.107.162.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="k2/DjPeG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hIMz1jh16vM4tXZpwbO7EC/XAKsnO5fzoVhAHo88+5tHVDoMLLRfcjYcyjHooVjSLGV/DNILmrfUAaXR3+i4W+yVsuyRZ0BDLGkhc6NU08Jd0z7i2jIkHgzArcgTtDE7aHBHY3pGvED9s+xA+OQ3G++SqeNKGsAUbx4na1YLezV15EVFbiRzfnAiqf/O0ImR7k2IfXZW42SdQyW6VCTd2hve5I8TKzIbiW3+Py4yEyC4PM/mylK9+cToGDHbSi3TbC3U9ew8N1qkYf2uASzmASQeWE4MIaBphGaiNp9PEVmOcskhhTs5MTAF0KE9FUr+bK2MPPmABtqRSxGQUBgPMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SYtLkffXcghrqEz9c92EUpXP0OAIWFAcQwu5IlJoR3k=; b=i7jcUoqCyXyvW136EHz6YpCU2uMwqYsGqVHS+vo5WaInbRKFtJWBaWgS+6Sst2lCFVoYCDnRtVuCUPri3svOc02kHuuC77Az3OgUYL11BQikLvmjAMMM2F4Av0NTWA9GE3M8vMOLhUEy/mstdibqLwrRcop5DOJSacYofRJ8KV5HUHLq6ejzBEwKEMuNjVLjRQY4vRMeqzSxIZobVJ3VFkUntUlCpJdqm9r5q+tKCZ6jXXaYn1kFG8qUSrOdT2XFizTfuSjaqn9GaC7KkFMwMcCy6K7gqS0MWFfx/uDzDvtAGym999Qd7KQghjf31XrVqpJ2Ibltm22mafRgMl7Npw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.60) smtp.rcpttodomain=lunn.ch smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SYtLkffXcghrqEz9c92EUpXP0OAIWFAcQwu5IlJoR3k=; b=k2/DjPeGhiqcBpOWezHfXwV5tJRLrNDNkS/dHPF28bREv4sXz3e5GJgsrsn5+gCbkCwx9u9YmsqIf4zlE5wXFyBdaTwYk97C15zkTh0dhSFQjN4mA6BjPsrpIrKAC3d11wcrHT0FKxLX3Qmmr6+lhXAvRuxoendxmqLHqeOrK1snf3uZFcU0OGabITTIUT2TndIL0rVM1FZhfcPUX3dKS1V32+Hg6tYcsLt3eyxy9YsDdXDO+HvrDVp6y6MFIMZWshLYUgGYK6OmAIcDtvmDzOJq0eMsrQZDlu7k/OeAKE7Ojiyaeike486NwVU5lJYGMMtl9kws7WmA5vZm/Cv0nw== Received: from DB8P191CA0009.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::19) by DB8PR10MB3781.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:167::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.15; Fri, 13 Mar 2026 10:57:41 +0000 Received: from DB1PEPF000509EE.eurprd03.prod.outlook.com (2603:10a6:10:130:cafe::ed) by DB8P191CA0009.outlook.office365.com (2603:10a6:10:130::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9678.27 via Frontend Transport; Fri, 13 Mar 2026 10:57:39 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.60) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.60; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.60) by DB1PEPF000509EE.mail.protection.outlook.com (10.167.242.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.18 via Frontend Transport; Fri, 13 Mar 2026 10:57:40 +0000 Received: from STKDAG1NODE2.st.com (10.75.128.133) by smtpO365.st.com (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Fri, 13 Mar 2026 11:59:55 +0100 Received: from localhost (10.48.87.194) by STKDAG1NODE2.st.com (10.75.128.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Fri, 13 Mar 2026 11:57:39 +0100 From: Christophe Roullier To: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Russell King , , , Maxime Chevallier , Vladimir Oltean , Christophe Roullier CC: , , , Subject: [PATCH v2 2/2] net: stmmac: manage error case during stmmac_dvr_probe Date: Fri, 13 Mar 2026 11:57:17 +0100 Message-ID: <20260313105718.359614-3-christophe.roullier@foss.st.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260313105718.359614-1-christophe.roullier@foss.st.com> References: <20260313105718.359614-1-christophe.roullier@foss.st.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE2.st.com (10.75.128.133) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509EE:EE_|DB8PR10MB3781:EE_ X-MS-Office365-Filtering-Correlation-Id: 31b64024-d894-4241-12de-08de80ef5889 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|36860700016|376014|82310400026|921020|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: TvyonEfMHvLD6QHaZdcJDbEoIXj25TbuHmyOkMP4yc8PKg1aBRIVT6/PaygbMTLnrFF0z3ZlaQgJdb4eSZ1UYlxWyUwD3qdeoTTVUYTxzx07fDwgR1003xQS4gTN0qVBUM3vD0lxXjf5ySo2Qwo+1rtag62ZmQyj/aTjJnwKVSQAHfb/Ly93qv/H3H/qbM9qV6T7V3zpuTayHKXiymqKNsPJAaNo1EG1RqOE/EVkA31asChRgHzHHi4froC/2iklP5EOjAVbGShwMMinDqWcCCbhh6JV1ubmm0IdKrkXyhnU90rUU3WjDBMPKjNqEGJvXoxgjbi/V8BIezRML0gEU0ITz1/0uuhOqWBKo62h4fhagYhAmIFdEdZeOrgr//NZBoD5ecEqnUzx9X82fRUEowMSzXcLHa75kRIwTMwjsy24XG9Kg8eZKGInkiuHiixmKR6p4SMjqg0VKC9MLi0KraNCHKYe0ztqaZAItOzm8XI74e+FX96befGEumC1CDd49nG3UtW/VS95tqZBJ0RtVKMo0b5zTkfI27St+Iu/RxGLnnwOHpQpp00cfhw8+SL1145puezQZWxz3BwpkY7l71llgltbsvZres+rxYzFNtI7d3uXORvOWcx7tKhepLinwhU2Vb1XT4vVubb4aojTjnnvWIm3+TBHmz4hKcspG7B7nH9uP6TzKphdsKvsYPDJsI/l9bnvO4MtEzesLqZrS0F3vc2P6dacTFVn52v0130mlld9HzcngDxQazqI3LvnBJ87zEHtpIC0phRpQU7q8OeoNxNRETcUPEAKvk1J4OlrsSgTWjS31wk3onH+EhxT X-Forefront-Antispam-Report: CIP:164.130.1.60;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(36860700016)(376014)(82310400026)(921020)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ywi9gMnoGpzeyJ6dXTwf0oUMkK3KuuVPToynuZExYGJ5DHFR/MlWjuRRGLZNxGUhby6r3Es+7QDUcJda28GVwra2arXBNquQ4dxuz73yVn9fxIzfbB/JfZb9CMtjg1GU4igUljyi+jDhCm57/ld1ec8yQY23rbXdyUTad5p3cvTQkVzIfqzeH8eoQtIPNV5zcl8LllAdX5sI6LKJIQ0aQsMqhMK1HcT51+LK4+qT0KkrQZ1XxWKP/tFNZQ8RJwvGnQocABnqEUkXFCgWkadZt5PO1IADax76GqGwoZutNaCy2t0/w/Uk7HcD8+R2gY4PqA+mTrEKlNxDztEPA9d6eT5+i9H0D4+fS+fIthqbDxouoq5nwUgBuZwNEQ9zgrcyXHZLO6uGuSrZGJGSnVWTCl4Q6OBrrFOS6lpYdY8UTfiuOU1Mho36oGIVaZTY1Sms X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2026 10:57:40.3029 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31b64024-d894-4241-12de-08de80ef5889 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.60];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509EE.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3781 Content-Type: text/plain; charset="utf-8" In case of error during stmmac_mdio_register, pm_runtime is not cleaning before exit probe. Signed-off-by: Christophe Roullier Reviewed-by: Russell King (Oracle) --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/ne= t/ethernet/stmicro/stmmac/stmmac_main.c index 26ac1cdc561c2..c3eaeffcb6aee 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -8057,6 +8057,8 @@ static int __stmmac_dvr_probe(struct device *device, error_pcs_setup: stmmac_mdio_unregister(ndev); error_mdio_register: + pm_runtime_put_sync(device); + pm_runtime_disable(device); stmmac_napi_del(ndev); error_hw_init: destroy_workqueue(priv->wq); --=20 2.43.0