From nobody Tue Apr 7 12:54:04 2026 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B245836F432; Fri, 13 Mar 2026 09:24:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773393885; cv=none; b=tt+NdY0XyNQZz4u9GNySBrcKndSmmYVLXu0tIijFpWFNwxxe54FANdkZrLoU1LKoxk89gPXDbtgAcPoPO7xtqBzrGHYLYJWxYRZcQ6//Y1kM4CAqvy1nkXkjHb+xuw1Rt7xcCxbsqRb0H5EW14r9sAYpvgOHl/iJAMm7bpafCJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773393885; c=relaxed/simple; bh=qkCssjwQ6xHfILIG/0YeecVw+n9kEcmrQqoPICmcohU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p9EeHFCmBboANco96IzMkElxYle1nM4bcxJSqSelxX8eT51VWt5o3XvK+X2nFlG3bUGfhBW2wuG5bCoZqfSY6RWqZYjcRqjAi4vaB0pQemY8XHJkmG+c40nJnOnQqiHqazKh2gxR3VPcxg9b4YJBopJfRylmkRNh9YfXf5T9QyE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=NE7nEJJu; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="NE7nEJJu" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 083651A2E23; Fri, 13 Mar 2026 09:24:42 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id CB87A60027; Fri, 13 Mar 2026 09:24:41 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C560910369DD1; Fri, 13 Mar 2026 10:24:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1773393881; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=HeFNpkruOmIcHovjLW+aFCk9gvji8MHWFyaMG1utC/c=; b=NE7nEJJuD2qHF1ZHgOaxOemSVCA+tqOhHLJlECdWKUe1DY1Sl6BZo9/UjP7VblAgGBCh+X szluIutldeoIhmwdo14noIxQgE0GURUIWftMI1Eq2ngcQxPNeGGE0koijlVfHp2b8DkE5K RbUqM4Q0yl21SwGQ8CIznjhkXUdry4Z//LRGb3IQMwkHpbHTyAiTN5OzxmbQZ+ubIQN4dm VNOP8ZktWcvLCTZchjJj5N/rMFVOtPnGmIbbVcYcBv0eJig9oqel9XrN0nlXMJMZl6WzS+ HnXsd9/vZkTEGncQw+IhsZGkdSp2APjkKsyW2GUhyYSUJ3na2FH3jCYNcvg9VQ== From: "Herve Codina (Schneider Electric)" To: Wolfram Sang , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Wim Van Sebroeck , Guenter Roeck Cc: linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Pascal Eberhard , Miquel Raynal , Thomas Petazzoni , "Herve Codina (Schneider Electric)" Subject: [PATCH v2 1/3] watchdog: rzn1: Fix reverse xmas tree declaration Date: Fri, 13 Mar 2026 10:24:14 +0100 Message-ID: <20260313092417.294356-2-herve.codina@bootlin.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260313092417.294356-1-herve.codina@bootlin.com> References: <20260313092417.294356-1-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" Variables declared in probe() don't follow the reverse xmas tree convention. Fix the declaration in order to follow the convention. Signed-off-by: Herve Codina (Schneider Electric) Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- drivers/watchdog/rzn1_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/rzn1_wdt.c b/drivers/watchdog/rzn1_wdt.c index 96fd04fbc2a2..b7034eac91d0 100644 --- a/drivers/watchdog/rzn1_wdt.c +++ b/drivers/watchdog/rzn1_wdt.c @@ -101,10 +101,10 @@ static const struct watchdog_ops rzn1_wdt_ops =3D { static int rzn1_wdt_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; - struct rzn1_watchdog *wdt; struct device_node *np =3D dev->of_node; - struct clk *clk; + struct rzn1_watchdog *wdt; unsigned long clk_rate; + struct clk *clk; int ret; int irq; =20 --=20 2.53.0 From nobody Tue Apr 7 12:54:04 2026 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB9BA379EFC; Fri, 13 Mar 2026 09:24:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773393887; cv=none; b=OsVf5B66tkEzmlL1epOCLFrRawi+axU/lCJzuKlozO1MehK1fs+wE53r0sL1EQj/E1y8D6Psl5aUtn9RsL4bHyxEIwIzr1etco5T7dESKt+cRDF5utCcjJHEmRtZ7UURF00ID8XVvN2tHMyhuOIst/PTaHdYIK3OLBrvRqszwI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773393887; c=relaxed/simple; bh=Qt3ZDT/2XZ2Gk5tU2c5HYGzHYX+19Rtxn+0VOyRn2mM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kh0i9SYggIoQYt4GqGHoUkJ6o3nuNECa/ZlMRBMPKyjvwJLzfLhoK9M71VdbPdT1+qoKky/+Ul+vgniQtDrzBOCV27pqWWlWWvGUAW0ClmzHNVxHsixGhhZsiDB0MxLp78NiObFzaw+9YC4DU3nuX4Njjb8XqYdDLP9oV6zXeog= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=T3u4VVtA; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="T3u4VVtA" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 5D4971A2E24; Fri, 13 Mar 2026 09:24:43 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 3229860027; Fri, 13 Mar 2026 09:24:43 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 92EA810368C86; Fri, 13 Mar 2026 10:24:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1773393882; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=EMW5EU8HgoMFqKlp2Z2bzKPzG2PRYsuDMfOvCVxf+io=; b=T3u4VVtAIACiXGv55nf2loYkBr9Bl2Vfa1xH3gDKoTOROgTDvG8E2AHUIBVENv1PKkY4aP gJT/P9Pd/0nFy9kUdaiTDzBkWtGG8NH2XdeQbXD2mHFuIDH0AeD03y5ktrjJ/bfcW5lgH/ NTin9T9q0TSjTOVYwGi4A4+scAHJmKBL4dkwfWz6HXOZxKNkASqqEQZNYmH3Ue0I+OBKCK smZMF/yzgrGaI2e+l3ReI4Wm2yCE6JJ26xq+58FHdjYbyV4ATzrNq5kcCBkiukooxm7DiO zqf78p79ql/A0cKXmKb+3HnApFCEYx1FBqT4OaosKNe8hNIEFaD3MC+sCFNkZA== From: "Herve Codina (Schneider Electric)" To: Wolfram Sang , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Wim Van Sebroeck , Guenter Roeck Cc: linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Pascal Eberhard , Miquel Raynal , Thomas Petazzoni , "Herve Codina (Schneider Electric)" Subject: [PATCH v2 2/3] watchdog: rzn1: Use dev_err_probe() Date: Fri, 13 Mar 2026 10:24:15 +0100 Message-ID: <20260313092417.294356-3-herve.codina@bootlin.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260313092417.294356-1-herve.codina@bootlin.com> References: <20260313092417.294356-1-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" In the probe() function the following pattern is present several times: if (err) { dev_err(dev, ...); return err; } Replace them by dev_err_probe() calls. Signed-off-by: Herve Codina (Schneider Electric) Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- drivers/watchdog/rzn1_wdt.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/watchdog/rzn1_wdt.c b/drivers/watchdog/rzn1_wdt.c index b7034eac91d0..98978b5cc5b4 100644 --- a/drivers/watchdog/rzn1_wdt.c +++ b/drivers/watchdog/rzn1_wdt.c @@ -122,22 +122,16 @@ static int rzn1_wdt_probe(struct platform_device *pde= v) =20 ret =3D devm_request_irq(dev, irq, rzn1_wdt_irq, 0, np->name, wdt); - if (ret) { - dev_err(dev, "failed to request irq %d\n", irq); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to request irq %d\n", irq); =20 clk =3D devm_clk_get_enabled(dev, NULL); - if (IS_ERR(clk)) { - dev_err(dev, "failed to get the clock\n"); - return PTR_ERR(clk); - } + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), "failed to get the clock\n"); =20 clk_rate =3D clk_get_rate(clk); - if (!clk_rate) { - dev_err(dev, "failed to get the clock rate\n"); - return -EINVAL; - } + if (!clk_rate) + return dev_err_probe(dev, -EINVAL, "failed to get the clock\n"); =20 wdt->clk_rate_khz =3D clk_rate / 1000; wdt->wdtdev.info =3D &rzn1_wdt_info; --=20 2.53.0 From nobody Tue Apr 7 12:54:04 2026 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1E8F388365; Fri, 13 Mar 2026 09:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773393887; cv=none; b=ogfi0mB8OV/92akfhuycnUmCVa1ciIvSvHG+9zpth7/+I3DaEwNrG9gPqEUptt0lOQ+4GDOrzXYZY64iBfcGOTH+ZCj1gYSILZ4TZ0HAHxS7OCn0G2tGLAXZb6XprXM32EQO1XtEker0vlTaL9anw4zeBtR75GpZbNa9ILRNaoM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773393887; c=relaxed/simple; bh=r4MRcQQ5fLzSlLSMWtmjAFlFGJfP1WaE9lWedeWl40E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DCC4Mr0rXuBo4s8jU4N+e+HI2SX8cUGSsJ7vPw/oF8ZegAcZaohSy5ENvxf+MLGaTBiQj+NTOCAhTPhRED7sjnPVOq4HwCUh6RRnxBYhYaBWQgugkAbdleqJvin+VNMunQa9u6T29xlhLS2CkxCGTWHMjGREpPueSdxere3m+gc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=qHi0jlhX; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="qHi0jlhX" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id D2765C40435; Fri, 13 Mar 2026 09:25:06 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B9B3F60027; Fri, 13 Mar 2026 09:24:44 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id DA4FC10369E63; Fri, 13 Mar 2026 10:24:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1773393884; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=2m01zqv2yjjJhgTpMDzF0wiCkkyg/bS6uB02evTAf9A=; b=qHi0jlhXeqoBjKFwCYdZp1XsCDnEhcQreVcyZ5vuXIIZGCb8MXzoq9oQh61vrZS1xKvpms T5xNKLYRN2zJZTfcMW1vFZ1a67TVVhD464n3lUdPHdZXtv1hd9gwPHqKvZ1k3ACMHmmMoa ISz9ULzXEGJuhIKHTzoXkHalO84Onmult9UKK4C5fLAKT1ypblvHUBxhzjTKGKymgkms+y oaBuUNZCywCGPLCp8MFtySEYQBHOyODwgxGlXyos6ZMfhlhCqvdzAG7f07zIMqcu2QWG16 zwggGiiAU0Uif+NE4l3Ix79/b6Ey9+1u+0cXh0Up7doO+sfgCJCM9Dzr6Gsn1Q== From: "Herve Codina (Schneider Electric)" To: Wolfram Sang , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Wim Van Sebroeck , Guenter Roeck Cc: linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Pascal Eberhard , Miquel Raynal , Thomas Petazzoni , "Herve Codina (Schneider Electric)" Subject: [PATCH v2 3/3] clk: renesas: r9a06g032: Enable watchdog reset sources Date: Fri, 13 Mar 2026 10:24:16 +0100 Message-ID: <20260313092417.294356-4-herve.codina@bootlin.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260313092417.294356-1-herve.codina@bootlin.com> References: <20260313092417.294356-1-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" The watchdog timeout is signaled using an interrupt and, on this interrupt, a software initiated reset is performed. This software initiated reset performs, in the end, a hardware system reset using SWRST_REQ of RSTCTRL register. The watchdog itself is able to control directly the hardware system reset without any operation done by the interrupt handler. This feature allows the watchdog to not depend on the software to reset the system when a watchdog timeout occurs. Indeed, when the watchdog timeout occurs, the watchdog requests a system reset using its own hardware dedicated line but this reset source is disabled at the reset controller level. To benefit of this feature and be robust against software issues, enable watchdogs reset sources. Suggested-by: Wolfram Sang Signed-off-by: Herve Codina (Schneider Electric) Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- drivers/clk/renesas/r9a06g032-clocks.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/clk/renesas/r9a06g032-clocks.c b/drivers/clk/renesas/r= 9a06g032-clocks.c index 7407a4183a6c..a0734182d112 100644 --- a/drivers/clk/renesas/r9a06g032-clocks.c +++ b/drivers/clk/renesas/r9a06g032-clocks.c @@ -1342,8 +1342,9 @@ static int __init r9a06g032_clocks_probe(struct platf= orm_device *pdev) /* Clear potentially pending resets */ writel(R9A06G032_SYSCTRL_WDA7RST_0 | R9A06G032_SYSCTRL_WDA7RST_1, clocks->reg + R9A06G032_SYSCTRL_RSTCTRL); - /* Allow software reset */ - writel(R9A06G032_SYSCTRL_SWRST | R9A06G032_SYSCTRL_RSTEN_MRESET_EN, + /* Allow software reset and watchdog resets */ + writel(R9A06G032_SYSCTRL_SWRST | R9A06G032_SYSCTRL_RSTEN_MRESET_EN | + R9A06G032_SYSCTRL_WDA7RST_0 | R9A06G032_SYSCTRL_WDA7RST_1, clocks->reg + R9A06G032_SYSCTRL_RSTEN); =20 error =3D devm_register_sys_off_handler(dev, SYS_OFF_MODE_RESTART, SYS_OF= F_PRIO_HIGH, --=20 2.53.0