From nobody Tue Apr 7 14:19:03 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB384387572 for ; Fri, 13 Mar 2026 09:19:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773393578; cv=none; b=t+UjOhE2tKrOEZ8AL62DtpODTGyz0IFvqgXQ4gedgWlPX6u5Dxqx1rf+Fbj39QEmeJTF0SNuWooS5AOjocABsaNWppDYciGdKFHIpcGYBl8Xm9+vctsRnY+TOfNlxRf6lfjHPxA6OXimnSLsB7HWpRDcv0QH6KC7nM8UJtU8rnA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773393578; c=relaxed/simple; bh=FWu6tPjDmTZWot86Gn2D7mJtq0N2N8QUEU4pkK23KDE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PBk278y5jQKWcdBhftLuNMDN+HdIG2fY7RhcXK0qTobklKrzth2YS4X+fIpyc7amVNRouimdwyg2hZxiCK3Rw36SAS0V6z/4JoUnRnzQoLBHJdzHol7BA3bQWeiU3g0w33jJYjY33WjYDGSya+YW1r2PrJ7Ctu3FjyvlrSPbPiE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OP77kA3K; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OP77kA3K" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ad9f316d68so9416895ad.2 for ; Fri, 13 Mar 2026 02:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773393577; x=1773998377; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YDCQazt9i8yqJpCaeowDxLqYJ0vL7DVtVMhK6VL3FYA=; b=OP77kA3KHnBn1o46G1k9VIzM5cS/QNO4cSHkQbbJponJzzHQo8yELjTDdSn87LPexd PQvpIZpg0piTKnwNw7HOoZrdfvEE3GVT/VpMiR45YIqaluIn4LjC0lViGDq2dlOzOoF0 QonSQHAO+l0cNFWLqmaT7MwKym7E+89buMSkAtANhkrk8x/mJLcFEdaNgaY0UHnfXoy5 DS0mo9YdJkEk2zslVVl19Rq8BVToAsGmAI2SWLpc/Mfo/cktVxTSLm1Z/LT9PEk+pIrX OZuptU3niV24o45i5/ei7m45900dTiq+ep31zMcmXcGTByL2a0v9o+2AWTMLGhJnRGM2 ZyQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773393577; x=1773998377; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YDCQazt9i8yqJpCaeowDxLqYJ0vL7DVtVMhK6VL3FYA=; b=CnfQbsuWKK7PAvnH+glvbGFq5k8SVywXUx1IaRAd5+XCfT8pCbExhvMCDKGM4XfBJI +TxnNzcPCux3sA9JIExzK2tg2SlS4We3SNxP0FvYuDdEbRqzheEf61kXrdLqujLOMBjO tXsHGTetIaywg2ZkjZ/RAKG3cZyKxtyKWay5ZMD5BT074EQ7RRWgyDGeR/nzP+u/IcmW f+CHqs8T7cXeSZH2ON2Vvkj4MiTt2QWlQTlVAoFN/mXcn/j6feyEkv9lPQc0oLSnfJpi 16p8wqL99nBWisbBssVLJMcVoYE9A+fGixBIzliVJsiTeQfxlqP6tWHO7QV6xMUwB9iD HBYA== X-Forwarded-Encrypted: i=1; AJvYcCXZUEGtPjLxYGGAPbRKiasCNxJf8e+ghi8bDOyNJWGIb8Kd0lxp0Tipr/bbbSMrENSxJBEwVOId7E5KO54=@vger.kernel.org X-Gm-Message-State: AOJu0Ywkl3pyHpSf30cW9qu47sPWMORmbn4qaVdXgRR+IJDPmO2coxSO Ibji73cFKT57N0NczbM+cMaCHa7KUzPhy5rrKnOQlMVvT3YG2zQgYd3p/BEb0dZreyc= X-Gm-Gg: ATEYQzzCVqn8KO7r3iKcbrJzgEcyvXQk0K916zmzaZgwgM7A7rz3uaQWHiewQ5YWeAH rTSqPh8hUUvdEO+416Um4fzaB6tXZ956HgMyhF5Oc1aLSrEOkbzKirJfebdepZZQSNpt8d+Znta RIghzyL8bpRJUtAO5jTUt3XPRaLWD1EC/48vKyiOs5KSGc2q6WwqY2VmcQYV9P6TZxdMhNzfzDb qEwni13Xv9sh1EN8H7yNRjmMB1cog9pM1OVqeVtmWlLMIvN6fG/2pWl/Cl/xNUTG4Lar4i2Ha4D cvkTifbl3fNq2ZbyCv2EmG+U0kxCJ8POzOy9vGx8X27yLeUU6ENYRQDwqw9FKIuENBeR/JshF4q 9/KcrQvneB8UzDfFpaIjnzDMCM/Q0t4XCbpOBl/V/AOHiVhb0gOdKfryLjA0oLeR/wAPyuSEnje F10DCdQMmrBu6jsNSVvTDhUcCbpz6Js5wLFpp1kV2ubg2pQocbiDI1zMFJVWjcwi+4KrZ04LM= X-Received: by 2002:a17:903:181:b0:2ae:456d:b836 with SMTP id d9443c01a7336-2aecac98716mr23178895ad.47.1773393576883; Fri, 13 Mar 2026 02:19:36 -0700 (PDT) Received: from kernel-fuzz.. ([103.172.183.54]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece7ee1d8sm16742135ad.55.2026.03.13.02.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 02:19:36 -0700 (PDT) From: ZhengYuan Huang To: dsterba@suse.com, clm@fb.com Cc: wqu@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, r33s3n6@gmail.com, zzzccc427@gmail.com, ZhengYuan Huang Subject: [PATCH v2 1/2] btrfs: add tree parent check to btrfs_buffer_uptodate() Date: Fri, 13 Mar 2026 17:19:23 +0800 Message-ID: <20260313091924.570554-2-gality369@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260313091924.570554-1-gality369@gmail.com> References: <20260313091924.570554-1-gality369@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" btrfs_buffer_uptodate() only checks whether an extent buffer is uptodate and whether its generation matches the expected parent transid. For callers that also need tree-parent verification, this is not enough on a cache hit, because a cached extent buffer can be reported uptodate without being checked against the expected level/first_key constraints. Extend btrfs_buffer_uptodate() to take an optional btrfs_tree_parent_check so cached buffers can be verified before being reported uptodate. For now all callers pass NULL, so there is no functional change. A follow-up patch will use the new argument on the relevant cached-hit path. Signed-off-by: ZhengYuan Huang --- fs/btrfs/ctree.c | 2 +- fs/btrfs/disk-io.c | 14 +++++++++++--- fs/btrfs/disk-io.h | 3 ++- fs/btrfs/extent-tree.c | 2 +- fs/btrfs/extent_io.c | 2 +- fs/btrfs/tree-log.c | 2 +- 6 files changed, 17 insertions(+), 8 deletions(-) diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index 561658aca018..c008b847200a 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -1493,7 +1493,7 @@ read_block_for_search(struct btrfs_root *root, struct= btrfs_path *p, reada_for_search(fs_info, p, parent_level, slot, key->objectid); =20 /* first we do an atomic uptodate check */ - if (btrfs_buffer_uptodate(tmp, check.transid, true) > 0) { + if (btrfs_buffer_uptodate(tmp, check.transid, true, NULL) > 0) { /* * Do extra check for first_key, eb can be stale due to * being cached, read from scrub, or have multiple diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 900e462d8ea1..8773f1f7ea46 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -116,13 +116,21 @@ static void csum_tree_block(struct extent_buffer *buf= , u8 *result) * detect blocks that either didn't get written at all or got written * in the wrong place. */ -int btrfs_buffer_uptodate(struct extent_buffer *eb, u64 parent_transid, bo= ol atomic) +int btrfs_buffer_uptodate(struct extent_buffer *eb, u64 parent_transid, bo= ol atomic, + const struct btrfs_tree_parent_check *check) { if (!extent_buffer_uptodate(eb)) return 0; =20 - if (!parent_transid || btrfs_header_generation(eb) =3D=3D parent_transid) + if (!parent_transid || btrfs_header_generation(eb) =3D=3D parent_transid)= { + /* + * On a cache hit, the caller may still need tree parent + * verification before reusing the buffer. + */ + if (check && btrfs_verify_level_key(eb, check)) + return -EUCLEAN; return 1; + } =20 if (atomic) return -EAGAIN; @@ -1046,7 +1054,7 @@ static struct btrfs_root *read_tree_root_path(struct = btrfs_root *tree_root, root->node =3D NULL; goto fail; } - if (unlikely(!btrfs_buffer_uptodate(root->node, generation, false))) { + if (unlikely(!btrfs_buffer_uptodate(root->node, generation, false, NULL))= ) { ret =3D -EIO; goto fail; } diff --git a/fs/btrfs/disk-io.h b/fs/btrfs/disk-io.h index 57920f2c6fe4..aef106484dbe 100644 --- a/fs/btrfs/disk-io.h +++ b/fs/btrfs/disk-io.h @@ -106,7 +106,8 @@ static inline struct btrfs_root *btrfs_grab_root(struct= btrfs_root *root) void btrfs_put_root(struct btrfs_root *root); void btrfs_mark_buffer_dirty(struct btrfs_trans_handle *trans, struct extent_buffer *buf); -int btrfs_buffer_uptodate(struct extent_buffer *buf, u64 parent_transid, b= ool atomic); +int btrfs_buffer_uptodate(struct extent_buffer *buf, u64 parent_transid, b= ool atomic, + const struct btrfs_tree_parent_check *check); int btrfs_read_extent_buffer(struct extent_buffer *buf, const struct btrfs_tree_parent_check *check); =20 diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index dc4ca98c3780..54daa8672272 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -5584,7 +5584,7 @@ static int check_next_block_uptodate(struct btrfs_tra= ns_handle *trans, =20 generation =3D btrfs_node_ptr_generation(path->nodes[level], path->slots[= level]); =20 - if (btrfs_buffer_uptodate(next, generation, false)) + if (btrfs_buffer_uptodate(next, generation, false, NULL)) return 0; =20 check.level =3D level - 1; diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 14da72a9a950..93eed1d3716c 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -4574,7 +4574,7 @@ void btrfs_readahead_tree_block(struct btrfs_fs_info = *fs_info, if (IS_ERR(eb)) return; =20 - if (btrfs_buffer_uptodate(eb, gen, true)) { + if (btrfs_buffer_uptodate(eb, gen, true, NULL)) { free_extent_buffer(eb); return; } diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c index 30f3c3b849c1..ff1a83d26598 100644 --- a/fs/btrfs/tree-log.c +++ b/fs/btrfs/tree-log.c @@ -456,7 +456,7 @@ static int process_one_buffer(struct extent_buffer *eb, return ret; } =20 - if (btrfs_buffer_uptodate(eb, gen, false) && level =3D=3D 0) { + if (btrfs_buffer_uptodate(eb, gen, false, NULL) && level =3D=3D 0) { ret =3D btrfs_exclude_logged_extents(eb); if (ret) btrfs_abort_transaction(trans, ret); --=20 2.43.0