From nobody Tue Apr 7 12:52:09 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D205D17A300 for ; Fri, 13 Mar 2026 05:18:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773379082; cv=none; b=RbfvCRW/UWtqV/z3+VipJl5jVBRDjzhrR+1ESdiV2DXkeioXORGahaz+KmMDcRloOCkLHWvnKHKflFOad61+n1xm2AJ0UnlGolMGAOe+hSiU3WnaOBpzOlAz80lbfowQGexKi+OM8yyjEXz78WCNY3WYa8LBaBCKAX2NTg6Ec0o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773379082; c=relaxed/simple; bh=QjSNKiwcKsupCBLoljsfpqeDHHQ/Tdt5ErDqa2TIttg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=X0ugVa6EDX7orpOKiFDJJ0bvKV4iyTwR9ZDUHr8kY4tGCytyMP+0Cv+tso4Kr2PGeCLU4gK6oe6bakuMeCSoc5P70qQPTS6yW+wn0/eKSd6r60pxkC59734TnLqT+TsbuVTTYJGxR7LZKOFu9S8MBycjtoyP5xl33L+zgQXnW64= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gDaHaeo5; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gDaHaeo5" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-439ac15f35fso1570771f8f.0 for ; Thu, 12 Mar 2026 22:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773379079; x=1773983879; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LNvEijc63DJq7x7a4CNbPc7z8yRE48FjWUXkW0Z4Wy8=; b=gDaHaeo523n3qGRAT+rYxDLdShWH+oq5hLE8WQhVg1S2m95Myk7RP8zoXRbu5pelLx F1gJgN3FdGsRdKRBHf+GBqyfkePkGtuGzyrL4RXUiyeeHiEZBCmQMISO6n9pcVEXYJEs EGcg05KvKSFDBNz3Fme4Eu8f9bYL4PX4q5HBw9saFmT3D2v0n4YkZvRkUBh8GKM+tWn5 tp9w4sDakkM/xnAkmNWmJro7xcdQDjmjnV90aD9WfKwPCJFF/z8B3Vf4upcpjOoIWSL3 2fJ8O4v3Kd7YpWDBErBV0Crn0kFvdBw96cP/f1BfzRVMRR27iEFiCif1wD7pCoXaJzsq p61w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773379079; x=1773983879; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LNvEijc63DJq7x7a4CNbPc7z8yRE48FjWUXkW0Z4Wy8=; b=krcxV/O699MLcClt/Hfm47UuCq3eP+VzxQhKYjOXZ5kgbbj1IfUUqpILiSQIicq7rU UzU2eW3CHP4OT8HY/p0JkCt+0oVeQjC59xpMEl8tDhkl89/DffhxAQIkdqNZH5+mOPrV xLF207WWcC5rDXwccLZgJJS6LXYm8nkM6v/lgZAChrmZkQ5T9NePb5SboyU92VlFiEAA j3TiuYbnINFxdu5cPyDqYvHhxducfe0mFnBHI/9mBTxege/txTBxoCG/z1nyukrRgZ+Z cmwZKiTddv9Ttn5KbA9ixH5imSI2LW+TRWQUpW7QxaChuR087QT40S/ngMFAtKHzz+is kRxA== X-Gm-Message-State: AOJu0YzTyUgbp5WzSyIMqB0vZIzQuVxWSn3ix/lpynyBM87+N2/ngr6O no2/YzvryWwj/MXwpBt5gy6y1boAyibt/TFSwtuDo2o7MHgAfvmTEdPT X-Gm-Gg: ATEYQzwDFQH4V7MdL7jjLipbo67UrbqD7Sd3SFQCIYNh5DKIs9tE9G34aHHT/0Oyqy+ T6TFqH+hYke16K7i7VVMNGkYxqwvGNbUh+WdO/muCtOhw449TJ24dU+6VmvB0VYKjr0gwR3RV6j mbQhRp64YwhxdIvDyrud3VXauCQQ0vTt2il5PQasy1VyLwEVrzeP8xAiel+N+snJ9z1NaMUHS7v 2KphPHZp1y65Ao0G0tadLX4vjNpBztOPZgXvXwafCCzeDLiK7X5igxd1N8SMe9t4c/jpU86D16U NKsST50MTFlA96U69ml9eZeOMzsxv69QhR5A4MZONkQ4xz6pHbBhXjAt5FameSp6TLhcpcURrc+ Cgz8JZ+IdpaNoEOCkv3PBOQd+WrRtz+xCxcDL1fMSRhrYTCRzVO8TdFUtaTq9sSVjLM310zxkmX xYiBaNuFJzuUgqwhDKdl7VzwMqnNinkNnfophxOA+t9q0DKjub3ImTRcYnuRI+BeUtpAICA3Nee Z+8Or27lO7BXwtTAng+ommYEVwWc60= X-Received: by 2002:a05:6000:1887:b0:439:fe98:20f9 with SMTP id ffacd0b85a97d-43a04daf124mr3968245f8f.27.1773379078907; Thu, 12 Mar 2026 22:17:58 -0700 (PDT) Received: from rozandragon.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe1a737csm12569417f8f.10.2026.03.12.22.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 22:17:57 -0700 (PDT) From: David Carlier To: Tejun Heo , David Vernet , Andrea Righi Cc: linux-kernel@vger.kernel.org, David Carlier Subject: [PATCH] selftests/sched_ext: Add missing error check for exit__load() Date: Fri, 13 Mar 2026 05:17:55 +0000 Message-ID: <20260313051755.60597-1-devnexen@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" exit__load(skel) was called without checking its return value. Every other test in the suite wraps the load call with SCX_FAIL_IF(). Add the missing check to be consistent with the rest of the test suite. Fixes: a5db7817af78 ("sched_ext: Add selftests") Signed-off-by: David Carlier --- tools/testing/selftests/sched_ext/exit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/sched_ext/exit.c b/tools/testing/selft= ests/sched_ext/exit.c index ee25824b1cbe..b987611789d1 100644 --- a/tools/testing/selftests/sched_ext/exit.c +++ b/tools/testing/selftests/sched_ext/exit.c @@ -33,7 +33,7 @@ static enum scx_test_status run(void *ctx) skel =3D exit__open(); SCX_ENUM_INIT(skel); skel->rodata->exit_point =3D tc; - exit__load(skel); + SCX_FAIL_IF(exit__load(skel), "Failed to load skel"); link =3D bpf_map__attach_struct_ops(skel->maps.exit_ops); if (!link) { SCX_ERR("Failed to attach scheduler"); --=20 2.51.0