From nobody Tue Apr 7 13:09:33 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 630621A9FA8 for ; Fri, 13 Mar 2026 04:06:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773374786; cv=none; b=IhPDayGBI2/eaNyp4WNdrbTlpik3V0eFW6udGBJnKINsmbYW3oG1u9ZHz1WMRJDn9fB6v2ui5jzvoBjsCnTTPNM8tv0CSaYFeBRtdgMFruxr5ihpdq1tJmUPHKuQMti0Hj5RM6iYpi3rBy0C2vozwkMi3iwvulpofz7h839XBEU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773374786; c=relaxed/simple; bh=Ccb7/rrFkWTefSKTgc4VB5t8QmMBzWsjuDWfEug+R5s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WB+le/CnrtMZoRlXsUp3wTPrQnnUhlYhMOxp6pei6bcTJ4GVtQMe42xwZoiktR7yv97CjVE9Y5CvYQhd/GXpEF0SYWBMbSaNdhXs6H7KPl2zKI4bip4BMiSj5GI/lle429nYpmHqyID271CK956xNqkRhMX3MXGalLl/qB9cpJo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hldKoajK; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hldKoajK" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-82a15b44c3cso390964b3a.0 for ; Thu, 12 Mar 2026 21:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773374785; x=1773979585; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MZbSvC8sAuSPUZNbLT6g7eFzZMKiQ1pz/Tp17o9W3DA=; b=hldKoajKAFz4kdwRadE2N05T34zqqC+fbwO0fZf0UjP1eXPJTSEpyFzFzJ+hOkD1S7 ucHwOLG6Tt+Cy6Hp+iMRhyhj/tNiTi6kaQFPMh2hUIMd/5T4dA2XR/HikyuUOil2cjUH c5FzenoPLOPIjK9gB7hu2UBCDSBJZtu5LaxA6YFPfFcGt2hJCsPc/Zyg9GwArG2+Ygla GxrIpkDcXBcOQgRlQl3XMDlTKGjscvUu4OxcUTWnoi2gRdHNOP+5zFRBsryNTb+Q041z Q3LEEDKpePFOd/0AcJNDHhi1c2oaQpye71i/PF/FowAQrtUvaoGJbW/p8XVlrO7z0ZX6 ICjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773374785; x=1773979585; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MZbSvC8sAuSPUZNbLT6g7eFzZMKiQ1pz/Tp17o9W3DA=; b=ZQKDK4Wpos8zvt3F+SpDMtig0qF5F3kZD97oXJGKG5F8h6VwFMO8eBvb5saVk5XMFt nXDEUZO3poZWtmtwNEuw8euHds+6cymkT9oEJqZ3M7WliOgGmoF0+b94XMKF1FJk6U+4 HWXRo95VT7IE00m0Wz5jtWuz4tsgFAR3+uk8Vqm8dyuxQ6ccC//PRcdMOmk3CKt1FgPX hjkOeA6kKyRprNdgVOOowrKesBBx3b7j4AGr8ub3VVs84MNRRz+9bl//B+2B0RtfMNt6 GfsYfuPVoVRi8A57chaNDPTnDyyVgOmYrffPaenkoGj0+XckW1ERkIZKCKoDf3Pm8u5U hqyQ== X-Forwarded-Encrypted: i=1; AJvYcCWexm8jwC4zhTk2GLwhhMdMfhSwtzOPtjJdRXqddtQxakxfnHMCCLc2orF02cCtObTRBMiwIeLHO1Wy6KA=@vger.kernel.org X-Gm-Message-State: AOJu0YyZiLXTtROZHYgiqXn+D9RcAJJsGRAW/roLO4ob9vSCJiaNMH8O sZFMImWWdeNCAamUd3NEo7GXlRzS72XT8T/Y8U35Kf7WCaEJaroohY60 X-Gm-Gg: ATEYQzxB83vGo+b6keBDQRSE6RQ2TaQaXgv1GzmlmTpjCTrPZl+KN5KcewT5AJCgCD6 oakcT3iaKPq7+5BDUKkERMydsvpin9lRVS/FIPyG8t4mCR0+IKbwjwXPA9tOXQrT9RiizrOfguC acDwXkIu/Ylu85Hl1GH5OdF2pGy9+Cz0rSOsztYrZW4ynnH5vNXUN14miijtgeFZs3cjNYqio2T GcPEhwtGc7LBCvjXg/7SQS3AcibvuB+JwAXMkqZGLYHYt8T4IzgV3S56QGj53ldXg5yhZDq2yOh CYD84U3NM1OksdNy9Z4bc6B02C2j+xoYOOxFmuV0aUBoUebcRaIOWm8RL1mkFgkodrgXy/nNgV3 YfZku0jKqjnRC+ITyNEYRBUJxB9oH1BWC3BEXMJk2WR6hXWtJ9becobxH+Z3wkbzZZcjtuyy2Ge ElJwwgYumXeji+vINhEVSm X-Received: by 2002:a05:6a00:7084:b0:824:a7bb:e8fc with SMTP id d2e1a72fcca58-82a1983fc2dmr1224093b3a.24.1773374784697; Thu, 12 Mar 2026 21:06:24 -0700 (PDT) Received: from lgs.. ([223.80.110.53]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a07384b27sm4523373b3a.53.2026.03.12.21.06.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 21:06:24 -0700 (PDT) From: Guangshuo Li To: Kiseok Jo , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chenyuan Yang , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v2] ASoC: sma1307: fix double free of devm_kzalloc() memory Date: Fri, 13 Mar 2026 12:06:11 +0800 Message-ID: <20260313040611.391479-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A previous change added NULL checks and cleanup for allocation failures in sma1307_setting_loaded(). However, the cleanup for mode_set entries is wrong. Those entries are allocated with devm_kzalloc(), so they are device-managed resources and must not be freed with kfree(). Manually freeing them in the error path can lead to a double free when devres later releases the same memory. Drop the manual kfree() loop and let devres handle the cleanup. Fixes: 0ec6bd16705fe ("ASoC: sma1307: Add NULL check in sma1307_setting_loa= ded()") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- v2: - Replace kfree() with devm_kfree() for mode_set[] error cleanup. - Clear released mode_set[] pointers after devm_kfree(). sound/soc/codecs/sma1307.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/sma1307.c b/sound/soc/codecs/sma1307.c index 4bb59e5c0891..5850bf6e71ca 100644 --- a/sound/soc/codecs/sma1307.c +++ b/sound/soc/codecs/sma1307.c @@ -1759,8 +1759,10 @@ static void sma1307_setting_loaded(struct sma1307_pr= iv *sma1307, const char *fil sma1307->set.mode_size * 2 * sizeof(int), GFP_KERNEL); if (!sma1307->set.mode_set[i]) { - for (int j =3D 0; j < i; j++) - kfree(sma1307->set.mode_set[j]); + for (int j =3D 0; j < i; j++) { + devm_kfree(sma1307->dev, sma1307->set.mode_set[j]); + sma1307->set.mode_set[j] =3D NULL; + } sma1307->set.status =3D false; return; } --=20 2.43.0