From nobody Tue Apr 7 13:07:51 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABBAA1F5423 for ; Wed, 18 Mar 2026 01:12:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773796337; cv=none; b=Ym9ZmiuKFpV7KkbgLFfZfFwM/rPuRpnXBDoOofb4NPXDhu0nb5nmLkxz/2GnBQG/XgiW+f1TFOfRwT1ccI/pdd6i19hq16Yw66DC+VXyXx2352EPbgOKq7zLcNmJfR+GqUN1ZKAQRpS5TxQ00fhmfv071HpNT+RueArfV3g1lG0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773796337; c=relaxed/simple; bh=Lx4+kIMrv6PnfDvEM91QLSsocfjTwTm5yssi2Lm2bCs=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=aWx/CgwB0V/evMG4+Hymd8jkTqUVJO6t4zCUOMmmReB/zg4MH94gCDIbWmff0zi0LTd0/+AlMYRgHBp0hqy5WAk6dpR1ikVgUWcUkmFkAwXXb88QJ8V0abEiQW24hsSWGtpkzOXqmumPHtZrqI/g6KZxRy4u7hsBuX2PQFQS9tc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vQglnnr8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vQglnnr8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37537C4CEF7; Wed, 18 Mar 2026 01:12:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773796337; bh=Lx4+kIMrv6PnfDvEM91QLSsocfjTwTm5yssi2Lm2bCs=; h=From:To:Cc:Subject:Date:From; b=vQglnnr8R6YmdaWJqHAavlGCPT1zQ7Q6/mY3SpvtL6KTTjUV9pQhqROgbY+h5uR2m Wms31OELLajeP0O3hCkL0HqaQngrMcB/zLjFdLrlAmHWUEQxoWRfkA7Cm47TvxVPsr QETASo+N++VRjH3O3xLx3rlP7ouA3LpEnJ8paEgMdd0ex4J7nvINWgvbt44/tO3pE6 pOhZa3X286m3jU1GQb9tSYkjBHpAfRjmv6okVcZNM3lJ6//vhkY5RUnQGDuBh0fisL Fw1ffzR6QVN+JTfd/em0IMr4SHxzDDnZEd7IUhs/EG1QHUbdTy0yvi8tkCSCPjBvPT UvJ7bKYxBN0wQ== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: [PATCH v2] f2fs: call f2fs_handle_critical_error() to set cp_error flag Date: Fri, 13 Mar 2026 10:24:32 +0800 Message-Id: <20260313022432.93815-1-chao@kernel.org> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" f2fs_handle_page_eio() is the only left place we set CP_ERROR_FLAG directly, it missed to update superblock.s_stop_reason, let's call f2fs_handle_critical_error() instead to fix that. Introduce STOP_CP_REASON_READ_{META,NODE,DATA} stop_cp_reason enum variable to indicate which kind of data we failed to read. Signed-off-by: Chao Yu --- v2: - add missing 'return' to fix compile warning fs/f2fs/f2fs.h | 21 +++++++++++++++++++-- include/linux/f2fs_fs.h | 3 +++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 660bf88a376f..94cf1e78d892 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -5073,8 +5073,25 @@ static inline void f2fs_handle_page_eio(struct f2fs_= sb_info *sbi, return; =20 if (ofs =3D=3D sbi->page_eio_ofs[type]) { - if (sbi->page_eio_cnt[type]++ =3D=3D MAX_RETRY_PAGE_EIO) - set_ckpt_flags(sbi, CP_ERROR_FLAG); + if (sbi->page_eio_cnt[type]++ =3D=3D MAX_RETRY_PAGE_EIO) { + enum stop_cp_reason stop_reason; + + switch (type) { + case META: + stop_reason =3D STOP_CP_REASON_READ_META; + break; + case NODE: + stop_reason =3D STOP_CP_REASON_READ_NODE; + break; + case DATA: + stop_reason =3D STOP_CP_REASON_READ_DATA; + break; + default: + f2fs_bug_on(sbi, 1); + return; + } + f2fs_handle_critical_error(sbi, stop_reason); + } } else { sbi->page_eio_ofs[type] =3D ofs; sbi->page_eio_cnt[type] =3D 0; diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h index dc41722fcc9d..829a59399dac 100644 --- a/include/linux/f2fs_fs.h +++ b/include/linux/f2fs_fs.h @@ -80,6 +80,9 @@ enum stop_cp_reason { STOP_CP_REASON_NO_SEGMENT, STOP_CP_REASON_CORRUPTED_FREE_BITMAP, STOP_CP_REASON_CORRUPTED_NID, + STOP_CP_REASON_READ_META, + STOP_CP_REASON_READ_NODE, + STOP_CP_REASON_READ_DATA, STOP_CP_REASON_MAX, }; =20 --=20 2.40.1