From nobody Tue Apr 7 12:55:15 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B773F36D9E7; Fri, 13 Mar 2026 07:40:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773387647; cv=none; b=flFNq+brbSpfem+Q8jibo5I5Ay+OGO+BvpnYJ6n+cLC0pDTniBJYRRwa3+9BKpzOB5Pd9LX3+Yv6Qlp6bklwTHsykYmV0rhDzk3bXg190KIJaIY1XZwBlFEvBqWqL/4LVPhNZIcUIyMw1eqL/ZkS3FhaI8XramzBO4bAo0UER6U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773387647; c=relaxed/simple; bh=93GwS9PIRZ6UbEeV7xsdhQi57hubLHK6iKxhSGlhOKY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iPWRzA0ymUWZJODHlNda89MgGZ9IwMjGbVl3yJ1i8tr9PFj20IBVHpjCh4vGYCPw6YIDcfuzwVPgdt13uaYUNnEyCIozvQ71sXlBbJ7H4Xo1ge8HBUw1opNMyYRnS3TJoP0yAzCFPgyJru+x7/b+uJimShEuOcKDjy7DLd3lg7o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aexHNWc9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aexHNWc9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6112C2BC86; Fri, 13 Mar 2026 07:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773387647; bh=93GwS9PIRZ6UbEeV7xsdhQi57hubLHK6iKxhSGlhOKY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=aexHNWc9Rn5QDbi8u8KGhhSzKla4B4ikUlrx53qJnKmbU9a7yU5L0dKl252D94JT+ 0xcuIkHAZ+m8ZyyQ9X+Qjf34gx3NkGha317apkAOMdzYk6/MILoOddHoSghGiXZSFs o9jkMVncFIayREnxCf+kdmPZqgGmjqFEqqcNQCqBi4OnfuaUsZuuiiwwWJBjbuLgx3 6BatAQKkvOjNiT3dSm5KFZMuIf+Gql/hVg5QQ4/uXRYm3WsNh1TOxCmBNKA1f1473Y 5+ZnPNc5TVvr4pQGts0VbcJv4fXnv2nJDPr/9we1oy5HxxMtczYng8DxO805tyFskO Bi/t60m8i8mpQ== From: Benjamin Tissoires Date: Fri, 13 Mar 2026 08:40:24 +0100 Subject: [PATCH 1/4] selftests/hid: fix compilation when bpf_wq and hid_device are not exported Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260313-wip-bpf-fixes-v1-1-74b860315060@kernel.org> References: <20260313-wip-bpf-fixes-v1-0-74b860315060@kernel.org> In-Reply-To: <20260313-wip-bpf-fixes-v1-0-74b860315060@kernel.org> To: Jiri Kosina , Shuah Khan Cc: linux-input@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires , kernel test robot , stable@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773387643; l=2088; i=bentiss@kernel.org; s=20230215; h=from:subject:message-id; bh=93GwS9PIRZ6UbEeV7xsdhQi57hubLHK6iKxhSGlhOKY=; b=hPaq2ikNpPLvL2yIFZ81/fX3qVAEZCCJnFTH1JcYgntZXIV+zTOVSI34Mwakwgxa9eaXHdyf3 /7CfoLk9qqIAW8awG8j4AcjVmSlMxtwq+pRCoqRR1vJRjDuzMNeCo49 X-Developer-Key: i=bentiss@kernel.org; a=ed25519; pk=7D1DyAVh6ajCkuUTudt/chMuXWIJHlv2qCsRkIizvFw= This can happen in situations when CONFIG_HID_SUPPORT is set to no, or some complex situations where struct bpf_wq is not exported. So do the usual dance of hiding them before including vmlinux.h, and then redefining them and make use of CO-RE to have the correct offsets. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202603111558.KLCIxsZB-lkp@int= el.com/ Cc: stable@vger.kernel.org Signed-off-by: Benjamin Tissoires Acked-by: Jiri Kosina Reviewed-by: Thomas Wei=C3=9Fschuh --- tools/testing/selftests/hid/progs/hid_bpf_helpers.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tools/testing/selftests/hid/progs/hid_bpf_helpers.h b/tools/te= sting/selftests/hid/progs/hid_bpf_helpers.h index 80ab60905865..2c6ec907dd05 100644 --- a/tools/testing/selftests/hid/progs/hid_bpf_helpers.h +++ b/tools/testing/selftests/hid/progs/hid_bpf_helpers.h @@ -8,9 +8,11 @@ /* "undefine" structs and enums in vmlinux.h, because we "override" them b= elow */ #define hid_bpf_ctx hid_bpf_ctx___not_used #define hid_bpf_ops hid_bpf_ops___not_used +#define hid_device hid_device___not_used #define hid_report_type hid_report_type___not_used #define hid_class_request hid_class_request___not_used #define hid_bpf_attach_flags hid_bpf_attach_flags___not_used +#define bpf_wq bpf_wq___not_used #define HID_INPUT_REPORT HID_INPUT_REPORT___not_used #define HID_OUTPUT_REPORT HID_OUTPUT_REPORT___not_used #define HID_FEATURE_REPORT HID_FEATURE_REPORT___not_used @@ -29,9 +31,11 @@ =20 #undef hid_bpf_ctx #undef hid_bpf_ops +#undef hid_device #undef hid_report_type #undef hid_class_request #undef hid_bpf_attach_flags +#undef bpf_wq #undef HID_INPUT_REPORT #undef HID_OUTPUT_REPORT #undef HID_FEATURE_REPORT @@ -55,6 +59,14 @@ enum hid_report_type { HID_REPORT_TYPES, }; =20 +struct hid_device { + unsigned int id; +} __attribute__((preserve_access_index)); + +struct bpf_wq { + __u64 __opaque[2]; +}; + struct hid_bpf_ctx { struct hid_device *hid; __u32 allocated_size; --=20 2.52.0 From nobody Tue Apr 7 12:55:15 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6201936F40D; Fri, 13 Mar 2026 07:40:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773387649; cv=none; b=dkBk/FqgIYvrblhbanv6ntv1QAdRtc9MBK9xo8oQulnVL6hfLuYNolbpUYMpLpLojZdwp9Pv8yz3MpJD1lzca1UO67Ef1wXITdbJdh3DI4nekvEx+U4bXFjn1+dbpvyWPo7x658UQfY9Q86d7ne6pX91GUutAkDMQu4nwJlWwYk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773387649; c=relaxed/simple; bh=0sZQ+czOgztMPQpfgVSOWELt/G9sQl4X0UukyDA+KrE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dnUz+1N7DuEvyLBYvRzWdsyyHdI3slMoNeIvyTVNwEn8zVVqcuQBQ6HosWDKp+KUd+Gi3MF9jVuGHm7ucwt/WVNIhkeWrAmL1rsdnF4a9v3Mwj3pa1DWEWDSOWWf0cgRlBtq/sfP3kv+OCTul/O3p7+YwRqAvUAWLOIDrhUM+PE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mMDEaqNq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mMDEaqNq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5C05C19424; Fri, 13 Mar 2026 07:40:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773387649; bh=0sZQ+czOgztMPQpfgVSOWELt/G9sQl4X0UukyDA+KrE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=mMDEaqNqcbeb7LsNYR1fljQ9hsHvrABePqn29O/qMQtQsagL07q9FOsvtr2nUxc8i TqPmZ5UZiouwC4pKUwRzu1G2kWkvOUGtb9b5kAWjJvlOIcwpu29FZMQ7v2Pp1eysgB cB/o8TZ2vL2lg7tv+eT+hB3I2o0UwlEDbvKbafvDFpgXjLSfhkljvLgmgGpLVrCPX2 3F3VhSEUIQ4CxPk+u9Q5t4F/vOCf7H7lSKBjYGgIiZiH8jVpLpF8CY63hLDzqKLW9L +cKYgf2b9D0bgc3uFcMLYB1KSZqLVuTmEaK52LCJZ45n4hJPP39hHc8Rad+kR9aFRf Ky9qHIRsPrMNw== From: Benjamin Tissoires Date: Fri, 13 Mar 2026 08:40:25 +0100 Subject: [PATCH 2/4] HID: bpf: prevent buffer overflow in hid_hw_request Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260313-wip-bpf-fixes-v1-2-74b860315060@kernel.org> References: <20260313-wip-bpf-fixes-v1-0-74b860315060@kernel.org> In-Reply-To: <20260313-wip-bpf-fixes-v1-0-74b860315060@kernel.org> To: Jiri Kosina , Shuah Khan Cc: linux-input@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires , stable@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773387643; l=951; i=bentiss@kernel.org; s=20230215; h=from:subject:message-id; bh=0sZQ+czOgztMPQpfgVSOWELt/G9sQl4X0UukyDA+KrE=; b=hJIXco5EJPmc7XEmh3QD0+/IMn1m5GYxsQJIOSLAaLCIRcJf+EfCExqFwkxE8k00QryldA3s6 h02fajwfwIIBYqWR3gHaFzk57Wbh2mpKwGmurlwc2Let9zunxUaV6to X-Developer-Key: i=bentiss@kernel.org; a=ed25519; pk=7D1DyAVh6ajCkuUTudt/chMuXWIJHlv2qCsRkIizvFw= right now the returned value is considered to be always valid. However, when playing with HID-BPF, the return value can be arbitrary big, because it's the return value of dispatch_hid_bpf_raw_requests(), which calls the struct_ops and we have no guarantees that the value makes sense. Cc: stable@vger.kernel.org Signed-off-by: Benjamin Tissoires Acked-by: Jiri Kosina --- drivers/hid/bpf/hid_bpf_dispatch.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hid/bpf/hid_bpf_dispatch.c b/drivers/hid/bpf/hid_bpf_d= ispatch.c index f3d15994ca1e..50c7b45c59e3 100644 --- a/drivers/hid/bpf/hid_bpf_dispatch.c +++ b/drivers/hid/bpf/hid_bpf_dispatch.c @@ -444,6 +444,8 @@ hid_bpf_hw_request(struct hid_bpf_ctx *ctx, __u8 *buf, = size_t buf__sz, (u64)(long)ctx, true); /* prevent infinite recursions */ =20 + if (ret > size) + ret =3D size; if (ret > 0) memcpy(buf, dma_data, ret); =20 --=20 2.52.0 From nobody Tue Apr 7 12:55:15 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 050A1370D77; Fri, 13 Mar 2026 07:40:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773387651; cv=none; b=kY+8aQVtmxhuUljskVIgHyasJlI6Ni3Tua+f3jmYg7xJKrd1QOU9hBBLBvmlZqTt6BAwwa34qCKFWxu2nw1F6Wl5IAbwBkHyaICFoaZcf+zlwYk1atvgPH0Htz5vF8ZvVNYeEZSZm24eYW0dMldwOTAWHeT7Gn5bPBDa5CEXE9s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773387651; c=relaxed/simple; bh=3QqmwPcVZc8k3uaBkDLUg8TP+fsY6XrK3YKva52D7Bg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=k0KGXcF9xdRIvz1ySjeGeNTaiXfIm2XFZh6M+SSe2oByCRfmGJoywpDlIcTXy81sH0cm/+wpnvBeTVY6V2WoYWwHQhE7JO2flJyb88WmqLKt/In3tPaAXjjBLzCpoxxNW23JD1zRd/YeDhPbRSWAaTL2rm+EGPNkoDE6IZaOSgM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gMgkgYZd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gMgkgYZd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9BAAC19421; Fri, 13 Mar 2026 07:40:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773387650; bh=3QqmwPcVZc8k3uaBkDLUg8TP+fsY6XrK3YKva52D7Bg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=gMgkgYZd4/MURMcZLKZGLE0DU6Algn4+iNBh9zGuTvCqX5XFItLz4ZW1gcxd0nkNU /KyqtxI8vP9B1wDJo5NxhrV34rBkRUrQ5ZbEEh1S8flVXeVtcvFKqDOh8ndSeUPdy5 KBL5/1IY4ZSTkcaW+A9pleymw/VyxLbgighiym1fMMeIG0IW5eNmDAe8WqbCl6WRSv MYLqzG9CQVHAflr3X246rl8mVceVhLxYiF3s7TVs2dWc16scEIsM4OYasJoU1hKKwk fLS1nDJtLDy54Pj7Yy7i7Wog7p0TIZBrCKBCZp2i6014bbrsLzhif0Sz2C4UVBXCKj BFyA/iaAQ5ESg== From: Benjamin Tissoires Date: Fri, 13 Mar 2026 08:40:26 +0100 Subject: [PATCH 3/4] HID: fix LEDs when report is unnumbered Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260313-wip-bpf-fixes-v1-3-74b860315060@kernel.org> References: <20260313-wip-bpf-fixes-v1-0-74b860315060@kernel.org> In-Reply-To: <20260313-wip-bpf-fixes-v1-0-74b860315060@kernel.org> To: Jiri Kosina , Shuah Khan Cc: linux-input@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773387643; l=1378; i=bentiss@kernel.org; s=20230215; h=from:subject:message-id; bh=3QqmwPcVZc8k3uaBkDLUg8TP+fsY6XrK3YKva52D7Bg=; b=B/AC2wrmv/5lOkOT0WFr5V+ywh6F72cGsnnEUYorpFw5S3a+GlsSjuQnDE1rxQFYJV/R8kbvy HF3LJ2iCxHSCwN2CuwLZk2oEpXLunHTbFNU61saQ1rsduw27LRc7RV7 X-Developer-Key: i=bentiss@kernel.org; a=ed25519; pk=7D1DyAVh6ajCkuUTudt/chMuXWIJHlv2qCsRkIizvFw= Both usbhid and i2c-hid are expecting the first byte of the incoming data to be the report ID. It should be set to 0 when the report ID is not used. Currently, we are not enforcing this, which means that if we enforce HID-BPF for LEDs, we will not be able to send them. Note that the allocated buffer takes into account that extra byte, so this is safe to shift the data buffer by one. Signed-off-by: Benjamin Tissoires --- drivers/hid/hid-input.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index d5308adb2894..eb84f63c51b8 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -1830,9 +1830,9 @@ static void hidinput_led_worker(struct work_struct *w= ork) led_work); struct hid_field *field; struct hid_report *report; + __u8 *buf, *data; int ret; u32 len; - __u8 *buf; =20 field =3D hidinput_get_led_field(hid); if (!field) @@ -1863,7 +1863,14 @@ static void hidinput_led_worker(struct work_struct *= work) if (!buf) return; =20 - hid_output_report(report, buf); + data =3D buf; + if (!report->id) { + data =3D &buf[1]; + len++; + } + + hid_output_report(report, data); + /* synchronous output report */ ret =3D hid_hw_output_report(hid, buf, len); if (ret =3D=3D -ENOSYS) --=20 2.52.0 From nobody Tue Apr 7 12:55:15 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 190C633F5A9; Fri, 13 Mar 2026 07:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773387653; cv=none; b=PP9+FBXbe0azYsSjsKY1ScnXHTK+10qmqRRkdzQb39zuzD2vIPvDqc1fC3cEey26pIS01QV/Okg4H3TZmvrZB08Nc3DSzbiW5gk7dYsYCrs5+vH2zHYdj77uzEKigVCrCyVX5hOm2rs2tyuNFNDaYQCv+C3D1Luy0Jo7Jy9RIlI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773387653; c=relaxed/simple; bh=Thj684RK4cIwq/IRarl5yywXidXSKskpD/hdLathcwA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HH85GWFJfrOmMqXwuWfZg6szugH+0uFfFZT5V4utuVhXVCUnUoC0W6mJBzBB5JL8pEynJtlN3rbNtlV3CkQYAfFL8z7sAqHUpB0Xvnlv+48B1WGeGn8OYlGRvYfZ/ZPEJnQ/l4lhTXhdg0IzlpRfgt+8WpCEnUVvVEzAnoRCLu8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LHUgawgl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LHUgawgl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 530E6C2BC86; Fri, 13 Mar 2026 07:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773387652; bh=Thj684RK4cIwq/IRarl5yywXidXSKskpD/hdLathcwA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=LHUgawglK4HqNko+QOpRamHHZcyI/nEpaoBBnm/JUCSe5G46Cf8NJKyu1sVwhbQVq WkQ1hGULbqB5S0pUeW/bEPrjIQMAgF9LmcMPMlCZHzBXW97DjfZBIvwVT/SHBoHAXQ kWUXaq5CbQ05iIcUurfhTLv6ZhtVXhamfgF9Kp0K7ze2sEkNt32gGlDWIRy4p5nV+T zaxIOjPp5HpEu+kGihr+POR7W5iSyAse1jj8HpUHozRIRPcs42DshSKsBzj1spdt0H SetZo+LeihjYhH26UiW69G+9bE9B+hhUGAFN5XU9BlDa7l8xIMSfU1EooXdsjM6Yfi 4cRUkk6qvFnEA== From: Benjamin Tissoires Date: Fri, 13 Mar 2026 08:40:27 +0100 Subject: [PATCH 4/4] HID: do not bypass HID-BPF when setting LEDs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260313-wip-bpf-fixes-v1-4-74b860315060@kernel.org> References: <20260313-wip-bpf-fixes-v1-0-74b860315060@kernel.org> In-Reply-To: <20260313-wip-bpf-fixes-v1-0-74b860315060@kernel.org> To: Jiri Kosina , Shuah Khan Cc: linux-input@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773387643; l=989; i=bentiss@kernel.org; s=20230215; h=from:subject:message-id; bh=Thj684RK4cIwq/IRarl5yywXidXSKskpD/hdLathcwA=; b=QbbIk87/vU1g9TmFIwh+vIF+/yo/qn6ojDdjwidiZr9WQ5U/7TLhExdHPa4qDSofjxSrBTpX0 HeeqorxKOwsBvsnHPFcAaGS5NT1gG+hxxhbW1sx3n1ALBhzE7cwSqzk X-Developer-Key: i=bentiss@kernel.org; a=ed25519; pk=7D1DyAVh6ajCkuUTudt/chMuXWIJHlv2qCsRkIizvFw= Right now LED workers are using the special .request() which is asynchronous but bypasses entirely HID-BPF. This means we can not tweak a HID keyboard. Drop the asynchronous (only used by usbhid), and rely on the common implementation. Signed-off-by: Benjamin Tissoires --- drivers/hid/hid-input.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index eb84f63c51b8..f0a77a4b2a42 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -1853,11 +1853,6 @@ static void hidinput_led_worker(struct work_struct *= work) =20 report =3D field->report; =20 - /* use custom SET_REPORT request if possible (asynchronous) */ - if (hid->ll_driver->request) - return hid->ll_driver->request(hid, report, HID_REQ_SET_REPORT); - - /* fall back to generic raw-output-report */ len =3D hid_report_len(report); buf =3D hid_alloc_report_buf(report, GFP_KERNEL); if (!buf) --=20 2.52.0