From nobody Tue Apr 7 14:23:43 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C4A232ED32 for ; Fri, 13 Mar 2026 09:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773394955; cv=none; b=vFAUWGrnUezk2mcn6yIrJzPuaIscVDB4s1PjVjlenbXWKNEF6gmgOfVG7i3MZQhNTaOyB8EWKoIjhlYrheQ4rtf2SSTzEuiWWcFKgrNQ9Ra2JVKydZr4zENu3w2DGMr3P9sYXE1P5EebLPp8NEMr2zFyHla3IANPHyUK25DLGM8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773394955; c=relaxed/simple; bh=8C+Bfl5w+ESq4aJnG7TTnkk5YDJVGnCoPOSKfHiEKKk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=t//Si2Rt9sLLIRmzA6BsWlJCHJiE6cG6MDbrygOmKTIhjS7Ip8Z6xeGC+SAbH5ZnFHao+I6W6Lu2Vk8+dT7vy+4XTOYgg5WXE4uPvfPkDKLbf/y7Hgd53TNWDzXwrUmZ7QDTkCilFfcrkV0cBpjtXQe/D78i8+134fTYW/p+a80= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U/lAngTI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Y2wCnFzc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U/lAngTI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Y2wCnFzc" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D5toNo1574831 for ; Fri, 13 Mar 2026 09:42:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Jt5AGeXSm57vPQPDFY6A5jMUvS2MQ9bHne5IvcZiYRQ=; b=U/lAngTIuCb/DWWD PiNY4rDJVKALjKH2IPVJDFppjsSdWitsOEu6xLAqaKIyEiP1mIsjNjUP5i1L9XyM 7TLsBDzo2UG2BQ2QBFVAlER1vsQcyHUFagLpPl8Y3dRuhe+1uJg2Mimg0/WSPc1B kcf0W1nn1h7zACGnVRk0ir4jB906zvOOtXv2XzPcmO3SpEy9ZqEWfnyqWPUPIpR+ FuHHNUTVM0lcyO6QbHGQsmBJnih+VpuLhVJ+BOj6Y0ct5gGZTXyqYehSwL48UfQ+ qWPqnn+jDKcE+i6vPEikyZpQWQqDXTcA5GPhFnmnmsLAHVEmeOlX5cPDmFS0rtaX uXXJIw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh53ng97-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 09:42:32 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-89a116bf0f8so109686426d6.0 for ; Fri, 13 Mar 2026 02:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773394952; x=1773999752; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Jt5AGeXSm57vPQPDFY6A5jMUvS2MQ9bHne5IvcZiYRQ=; b=Y2wCnFzcb5W0F3gvUSSc0DAmEWob37JO43FTFejbW5Ymjr4AGDCubqgg2PriaGDoGv eNdtVCZ2jq1rF9R/4ZtB6YGJbeOX98h4WwCz/zRJw1P8h0Eeco+E8/1Bs/nrD3Cs+W7z OlS3AnqT/MbFvk3Nmx50s4+jGrz9UY0Btx/0xRHY7OaCP3bvVuxUI1hUg7wJ+YsZZf6S zEE474zY7J3FjClEqZs5fsvIDNYAuwDVU/mNpyrBOVq+XZGQbQGwjNqraCRipsk6aC7m lyp/pw0RA4GNFFx8d0hBWBo853NZpF+qGoUxjetVpiFdfAr9Z2AAEoU5cankUN7aaigB 4KPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773394952; x=1773999752; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Jt5AGeXSm57vPQPDFY6A5jMUvS2MQ9bHne5IvcZiYRQ=; b=MEJBjd4aWjM+vWNs73JG1EKCPVS6adrKAZ/9zWzG/dl9j2qsZ3XzlzpqXErsyfjJoe 3poN8k1/O7Om3x3pnvQKndJaZBZHeem8yaFDBXbcuY69Gh4m9vGl7KHvtEGZs5WsHZ/o 6Ybc78ytktZkPfqlrpJmPpFzC8eVuWAqd6FZ10yHocrGE+eCjYg2nRHXtX73CaYmDnlD pu/1WW/ng0TiiOhD5owMFNKkQNKZyPxfcMkDvIPWj8deeJHBQ4TocJnyYqJcNcZ0ifNy rKRdcXEo+kEScoYCcGIRxB5/c9csrNK6B+r368GKNktqrMp95mGqFWAOufH845FQjbwU 6CLg== X-Forwarded-Encrypted: i=1; AJvYcCXkN9thOm6FGwcZoQqnSa9JMHmrfuxfCm43jaUJj+e/p3xQJ8K0e9bAuQ+Hvv6iUGMHU8vrnOvaSzQLgAQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+RPV6vjyvvly6Qj/TUVuPbTJ4CAQAtFq4B52sg4kwiYXDWNx9 ScFrxcmYK/EK8o8Wgq1I7/OUZ5jN8BHrBQHxlr+fnyrJf8Jz4fMN6BqKTL7OFX1Dwzo3bNp6Ar3 wdWycW9AKXX1+rSm52J/oSM8b+h+nSUP4tZJcZos3SMTWtEnQMV2cjo1htXJHzs54ljc= X-Gm-Gg: ATEYQzwwiylHENU3PEn2dB1Ct6AVDrpJV47qovDsSpb6268h0j72UMCQnaqQyfyHZXZ AVBJpKODYo3g8K2xtjFgWAIf2n+PDbFnhikmJ9OjdL9kApuvWkw6Y/npF8fv4WyQCq3iluFGhWy 8HASVaaInA1Ru7ArsKqSMOA2PrxOs+WxNi0P4a+DI7FooBk5lojTTn3SNzL34dHbH/I9Epl9rJX HVjpsbVJLA9aiuvr2tPwHoA5ahTktQF+wUAUFhTZtRiQLO/oGi7I0IvMf5shzeit94gJUxoOr3f iM3oGXM8uWkLkj5t2Fa6+/mWcZR6w9r67mefSrSShCp0xy5YigsPb4dxtpoNF8Ie5r3ynaBtD9S ejIVYQOmSDmZUpLEkEOb7jR57Rgpa1+iWe8BvV1BxLF4z0uAN7Jc5JW9Ls7eTdeaoqH3mxeE0S1 q5Dcovs/xpvzju X-Received: by 2002:a05:6214:19c8:b0:899:ff66:8152 with SMTP id 6a1803df08f44-89a81ea6211mr41110256d6.39.1773394952196; Fri, 13 Mar 2026 02:42:32 -0700 (PDT) X-Received: by 2002:a05:6214:19c8:b0:899:ff66:8152 with SMTP id 6a1803df08f44-89a81ea6211mr41110016d6.39.1773394951760; Fri, 13 Mar 2026 02:42:31 -0700 (PDT) Received: from WENMLIU-LAB01.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89a65d0a7b6sm54663656d6.44.2026.03.13.02.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 02:42:31 -0700 (PDT) From: Wenmeng Liu Date: Fri, 13 Mar 2026 17:42:14 +0800 Subject: [PATCH 1/2] media: qcom: camss: Fix csid clock configuration and IRQ offset for 8775p Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260313-vfelite_fix-v1-1-2ee7de00dee7@oss.qualcomm.com> References: <20260313-vfelite_fix-v1-0-2ee7de00dee7@oss.qualcomm.com> In-Reply-To: <20260313-vfelite_fix-v1-0-2ee7de00dee7@oss.qualcomm.com> To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Hans Verkuil , Vikram Sharma , Suresh Vankadara , Wenmeng Liu Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Wenmeng Liu X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773394942; l=4548; i=wenmeng.liu@oss.qualcomm.com; s=20250925; h=from:subject:message-id; bh=8C+Bfl5w+ESq4aJnG7TTnkk5YDJVGnCoPOSKfHiEKKk=; b=2hshOiChSGIgowfhQXkX79N7NUDWsDYFzPEJc4yBZvZTiJ8kERNOfjwYpyXFXUQ9sHl8Ty8MC SyZqWlCrVxRCbPLAZvd654I2QMJcDrSWuK+ULgkiSB2Sks3praYlc+2 X-Developer-Key: i=wenmeng.liu@oss.qualcomm.com; a=ed25519; pk=fQJjf9C3jGDjE1zj2kO3NQLTbQEaZObVcXAzx5WLPX0= X-Authority-Analysis: v=2.4 cv=ZN/aWH7b c=1 sm=1 tr=0 ts=69b3dc08 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=st_MFZYYFGq7bypRZrYA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA3NCBTYWx0ZWRfX3BEAql/gh08Y O7mkOJYeHkfrdS3Z8GDH97yEDWojX+uR1Qy0ODWDZ1+jj7Wluyx0LMYVNvdTcBYa9gMn7/ekHo0 Iq+kuxL8hyJnOZRTx8eUpJ2eolAfWWyUxuc/wQH+Lue2mYNUMdmD2YGcnVjm01dy//M0hhf1LYd VLE+xAOycsCBIKk2+AwC20b3qdrhOH4bA4b10wIbYMeAku8aKATl0tUxf1Xy8za7ywm2/bDRZdk JO1pCVf4vCNAQzI+087ZAtYpHB49DLLmt/YaMjJ6jCtEZkviDnt6OFQDUDcPPlpI8uy6yHFgMtP qYJ4eeMiE2modPDcA6ZMzXbSgx8iazyXpAB1tLy5KsiDGXxks1vJCRWtG3KjFqbHnO29wYAn9H9 DP2Y4LU/cS8KxY0g8kfVgjJ54/dkzKK+pEnZJIGz9p83EIQyIhrzAV3968I6HOK28CbLKmdx9Nc hqcWNYV+US7IuEC1hkQ== X-Proofpoint-GUID: GZdeKtF9FTYEfJNbE_glZLTTcx_TxSD0 X-Proofpoint-ORIG-GUID: GZdeKtF9FTYEfJNbE_glZLTTcx_TxSD0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130074 Fix two issues in csid driver for 8775p platform: 1. Simplify clock configuration for csid lite by removing unused clocks and correcting clock rates. Only vfe_lite_csid and vfe_lite_cphy_rx clocks are actually needed. 2. Fix BUF_DONE_IRQ_STATUS_RDI_OFFSET calculation for csid lite on sa8775p platform. The offset should be 0 for csid lite on sa8775p, Fixes: ed03e99de0fa ("media: qcom: camss: Add support for CSID 690") Signed-off-by: Wenmeng Liu --- .../media/platform/qcom/camss/camss-csid-gen3.c | 6 ++-- drivers/media/platform/qcom/camss/camss.c | 40 +++++++++---------= ---- 2 files changed, 20 insertions(+), 26 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-csid-gen3.c b/drivers/= media/platform/qcom/camss/camss-csid-gen3.c index 664245cf6eb0cac662b02f8b920cd1c72db0aeb2..bd059243790edeb045080905eb7= 6fef3b12caae1 100644 --- a/drivers/media/platform/qcom/camss/camss-csid-gen3.c +++ b/drivers/media/platform/qcom/camss/camss-csid-gen3.c @@ -48,9 +48,9 @@ #define IS_CSID_690(csid) ((csid->camss->res->version =3D=3D CAMSS_8775P) \ || (csid->camss->res->version =3D=3D CAMSS_8300)) #define CSID_BUF_DONE_IRQ_STATUS 0x8C -#define BUF_DONE_IRQ_STATUS_RDI_OFFSET (csid_is_lite(csid) ?\ - 1 : (IS_CSID_690(csid) ?\ - 13 : 14)) +#define BUF_DONE_IRQ_STATUS_RDI_OFFSET (csid_is_lite(csid) ? \ + ((IS_CSID_690(csid) ? 0 : 1)) : \ + ((IS_CSID_690(csid) ? 13 : 14))) #define CSID_BUF_DONE_IRQ_MASK 0x90 #define CSID_BUF_DONE_IRQ_CLEAR 0x94 #define CSID_BUF_DONE_IRQ_SET 0x98 diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/plat= form/qcom/camss/camss.c index 00b87fd9afbd89871ffaee9cb2b2db6538e1d70d..4a0bf8acd7645f8cd8c1b4cb9b6= ff6f3a54d42e8 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -3598,9 +3598,11 @@ static const struct camss_subdev_resources csid_res_= 8775p[] =3D { /* CSID2 (lite) */ { .regulators =3D {}, - .clock =3D { "cpas_vfe_lite", "vfe_lite_ahb", - "vfe_lite_csid", "vfe_lite_cphy_rx", - "vfe_lite"}, + .clock =3D { "vfe_lite_csid", "vfe_lite_cphy_rx" }, + .clock_rate =3D { + { 400000000, 480000000 }, + { 400000000, 480000000 } + }, .clock_rate =3D { { 0, 0, 400000000, 400000000, 0}, { 0, 0, 400000000, 480000000, 0} @@ -3617,12 +3619,10 @@ static const struct camss_subdev_resources csid_res= _8775p[] =3D { /* CSID3 (lite) */ { .regulators =3D {}, - .clock =3D { "cpas_vfe_lite", "vfe_lite_ahb", - "vfe_lite_csid", "vfe_lite_cphy_rx", - "vfe_lite"}, + .clock =3D { "vfe_lite_csid", "vfe_lite_cphy_rx" }, .clock_rate =3D { - { 0, 0, 400000000, 400000000, 0}, - { 0, 0, 400000000, 480000000, 0} + { 400000000, 480000000 }, + { 400000000, 480000000 } }, .reg =3D { "csid_lite1" }, .interrupt =3D { "csid_lite1" }, @@ -3636,12 +3636,10 @@ static const struct camss_subdev_resources csid_res= _8775p[] =3D { /* CSID4 (lite) */ { .regulators =3D {}, - .clock =3D { "cpas_vfe_lite", "vfe_lite_ahb", - "vfe_lite_csid", "vfe_lite_cphy_rx", - "vfe_lite"}, + .clock =3D { "vfe_lite_csid", "vfe_lite_cphy_rx" }, .clock_rate =3D { - { 0, 0, 400000000, 400000000, 0}, - { 0, 0, 400000000, 480000000, 0} + { 400000000, 480000000 }, + { 400000000, 480000000 } }, .reg =3D { "csid_lite2" }, .interrupt =3D { "csid_lite2" }, @@ -3655,12 +3653,10 @@ static const struct camss_subdev_resources csid_res= _8775p[] =3D { /* CSID5 (lite) */ { .regulators =3D {}, - .clock =3D { "cpas_vfe_lite", "vfe_lite_ahb", - "vfe_lite_csid", "vfe_lite_cphy_rx", - "vfe_lite"}, + .clock =3D { "vfe_lite_csid", "vfe_lite_cphy_rx" }, .clock_rate =3D { - { 0, 0, 400000000, 400000000, 0}, - { 0, 0, 400000000, 480000000, 0} + { 400000000, 480000000 }, + { 400000000, 480000000 } }, .reg =3D { "csid_lite3" }, .interrupt =3D { "csid_lite3" }, @@ -3674,12 +3670,10 @@ static const struct camss_subdev_resources csid_res= _8775p[] =3D { /* CSID6 (lite) */ { .regulators =3D {}, - .clock =3D { "cpas_vfe_lite", "vfe_lite_ahb", - "vfe_lite_csid", "vfe_lite_cphy_rx", - "vfe_lite"}, + .clock =3D { "vfe_lite_csid", "vfe_lite_cphy_rx" }, .clock_rate =3D { - { 0, 0, 400000000, 400000000, 0}, - { 0, 0, 400000000, 480000000, 0} + { 400000000, 480000000 }, + { 400000000, 480000000 } }, .reg =3D { "csid_lite4" }, .interrupt =3D { "csid_lite4" }, --=20 2.34.1