From nobody Tue Apr 7 11:18:08 2026 Received: from sonic310-11.consmr.mail.ir2.yahoo.com (sonic310-11.consmr.mail.ir2.yahoo.com [77.238.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EABC30E82D for ; Fri, 13 Mar 2026 16:18:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=77.238.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773418715; cv=none; b=JsBhSgy4vi5HxqqNuaukP7Y3LNittz3ddTUYzQE5gJLoDA0nD9zGIwY1Xxeoal77xXC13fMEESRhTRoGjWaI+bsqjjQY1hWbUAh/Pedxj6WtPktMEW7rHbUqUEO0IoTvrYAWnudWnx+9HDsihqlPyacPF8WAVgcjwdWvPodgQ58= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773418715; c=relaxed/simple; bh=43iHeHcqLmWDLlWsITqoi4SJ2eUkzhJoF5R7wUzzA9U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc: References; b=sESvpKqhkHqT9LEFuB4Mv1zM8wLSkP/yrdJt+EJbK3USD9BCTXUZL+Hrqlkh1pjPsoH6YlcCMc1wAGBuvZ6hAMlxty6aPy/3OBwcdsa50sCImcpUsZMHcGmWDBuFPGF3R9QqR1lo0UuCY0E0D6y7Dbi6QAMaClRP4TAMqyYnyos= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.pl; spf=pass smtp.mailfrom=yahoo.pl; dkim=pass (2048-bit key) header.d=yahoo.pl header.i=@yahoo.pl header.b=q/MvF1BY; arc=none smtp.client-ip=77.238.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yahoo.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=yahoo.pl header.i=@yahoo.pl header.b="q/MvF1BY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.pl; s=s2048; t=1773418705; bh=7VJNKyt1jpaZ5THYtvZIgtVZYfR2eVsvgGL2cla3lqY=; h=From:Date:Subject:To:Cc:References:From:Subject:Reply-To; b=q/MvF1BYR2NLX+JU2jdYOitsygdfCXLsfura1P7sWPF2AGPGnsnQrtifmNI40pySNKRS1iV0aGRvAByRDJw0VaJk2DdUiWt8TbomX9bApCAz5ZHGMIRbfv9+0Tt1pwow14mOARzvGdnFaghnPQ9h/XvOLmXDyn7NJFThGKhdiUIc8VMJNeO+gdPMF0VpBIf+mlQMHT8yld5FEI1P4P10pqkKxfYGFgXJnaZiKWmBNgEyO0k0hXilLnJAcnluVGl+sq8whR2PYwyGXZELFNDWWOxOx3+uvHQ00PiTk1elgR+iAMsZ9yyOhA52cAXCjOZY0QaGonav+yT79wLuqC028g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1773418705; bh=bIgzII/B5q2AVkVavbnlEW45IUk7AhbtA9rMKnh5ohj=; h=X-Sonic-MF:From:Date:Subject:To:From:Subject; b=XBgsj9Xb9Ol4ISNWGUyDe3KsWt+rrzPkmESWMcgerTH6MPeWAK8CF/wZoONWOGOIfec8aokC9LvKRStekRMJDf0DvVR7Jluo15OIvcsy8MjXvCUx24CX5XrACStqsAmL2cmAa7FLiotIDkzggGeY6bMesAWqmeSPaNyq3HQV0isKSTwjpGVmo6OJz+mTJ1W2n6Fc3A9Yy6xPiX1EFV//pSjILK17Olxyo/oHk8VLo8ti4O4Kvdvc5mhF9TE1+ZJkpN0Z89MzWety4SmFaZh1YDudSUWvVTKwCkKf5fm3rJSEvx836Wu57vr+bsyrWZvYFQxjRHMrp2mKKaWvrm0GcA== X-YMail-OSG: goqabTgVM1mj2lLXzr7D7oid87xLNZ9ot8EkVl4YQ7x36B1bzitvevj_aDl6V8r 4wcvzZwyaNX.X9C3DqyEr3L5kY4rQU8v7kJDmpD2hTsCfmCBDjtJP6UBP4k32GARFlLIBllvlLLB 776cz6VlFrt_b4rTl_42Isa6yMlS8dyKGedjbwmkgmwEjbneqIHfNAFxBObt5sVKy7dHYdRwSz.7 Ju5e69N..tiRs3GTVwM1q.Suv20kiyWCSXs3ywlPRp01fV_6Wdthao0kg3sAGHaS6rYZqvtGQqoZ hO.UMEkuJMrn.vovXA6cqeeLeKxEw1vYB29uYViVAGjHBUVYX5cUUa_3YPxkfGPxJSHLTJrOHUyP BuMVKmRqYXR3Yzqd18JO1C8XCjikz73TBFzZhSlvPS3vnQwlOe.JTFnw..DDzOo29iF4DuUIwMrJ nXvc01KvCzl8GmsLTfus1FJBeZt.zF0q0I2.7t5FePkMO16j69LXJoUaWrW8enEIfQqH0R8K0iQD hlPFmPSB1ePVbckMMPJobpU3bCW8XebRRdtnxNu1F3qbliShp0fl8uwfUyuRfKEl_rACHinB5LlD wLXd294K3DSsMB.huhrln5HrzxCkMiV6wswD85l5VS8J6lK2H7SjJKAgWfa8jsBNTbDmcjohKyu_ PDcB8IGMeKzZyt5C9T9dsRtjsgB7bxLtkaF4yVoxNreCf_8sAVXfsqVV0V6V34itKMZNJEzjZVNB gpq5r7pvrLA7y7S6KvumStwifiA9j0hSFVyp9xX552L4oRbhtAlF8YEkv39H0hkmtf1T_jm6eavp em1GveL3g7Tgi9MxVXDT48fAj2Ndy1n9_SvF3VMUCSbnYGmFvTLqgR61DN6IeR5T52vmIZdEd60B Lq4Hs.rjwdNSXh_9BVsNR3zwxpypRc9lCuIZuU1X42YGe4Dy8X_Aw7lNMe1PgcI6uPosmJlCB7Tk vCUcqITKG0OimGNHhQ8tZBoc0yIewBOg25EF3dgv7d8AEkAQPQAq1BBTnb7aflqiF69uoLwnjudY YTvgUg92zKvxoWx4oUROtZ9hf7G.JWzOA0omAsPnSKyRAl2BpxJMKcJmTegH2pIf97_dR1ghzmdV 334p91V1Hilh2o3KA4gNHagjBRLtgA5Bq82exsnGqALsRY5Kwz1uvI0V.LN9LH7A2_Q5Hajljljf G7xeYH0Q_0SP65Lcuq1P2IByKSs3olqXdjcpEt9ppVzSybwsn_8GfCS6TwnioOvQLHA6WdPAWpWw uJj5P5_cg6wTfyr9FcZqEhLitCh0mJklI.O6ntBAI05hl1Vm5fHsvdxu_8sRLlIq8u_h9At1YRJJ cZ7_CZryM.SLsGsKWhUe4Zhx_qUUw7NMfzotXGZmmrUfbe6OSiDCcevBZffiDD_erS_N3SY3a2fG B_yAoudGJDmSFsC2Cxg5GzvbL2MWphPKF2MacnmaS365hEiRqfnPe8Rd9pr6Zxa72sVkT3NqwNcw p3mA_lcNXK0xwS4M4YHUnYt.dyAuORn_exGODk_ChwMT4FW8BeNhfKJCltiVtXKK7ZgcW4YYNrCz CTvSLGmq3JFd4htO3YL6uN_LziW1sAIEMAo.KfZfcakc9BLgU8xEuq6_z7Mb9t0bWlJDckay_Uk6 L9wKwjGQh7Fy1CU10YSc3oMEHNqqEso8o_Ofe5BEGUrl3QZtkm9_vumVGq8_l4Dx8k0qmMv6YrvR TDuEmI7PIIItVngD_S_sKPIAe3QPfTxTf5M7b1FvZXP.8QY13XGUagjbu3aLFsSYjCAC5jRUwu39 0qgOI.O_x.DpBB1UQO_K01fBf8ouTY29IDvAI7kek7oA9YYknpcfn0ZFdXp9zxSGUJ1AENtHqUxH AxW9tgAOH7QvHRdq6csLunP96wf5LDFaqpTmW.r7VlNJsQq5NKbPrdQ3AeFtYPoNaRekQGPZ1HXa uAWdivp02l5LuSyA.sjsRkVoi1HL4zorqtj2Hdg9pYduVtdZmmx2q5qNHC4F1RKm9U.laRN642w7 XAgi65RedEWAyWxyoausCqQQmNfVg397EhFgLw.dlgQ4ceG_eFottbTIdVcm2Q0FhPTl090xt.kP KQ5g6vx5fo3FuGBj20slHONP0wB6qPQP71XgbiOoAWfUFc2kmc_.aeMC5_wUmi6up1uudk2dvfFw Hci.GCsngoMV00330xlSt63oL1jj9_j9Aa1hH63iDJN0H7owPqOdMoT1OCuFHzK0fGunMrqnKx2I EMOE5heEsrjfCZYR.YbcpodKcT5F974eQT.sRfwh07izAyk3vIHEyABTfCGOAd_TqRCrb64lDcz1 AT4BD2Wv_5U9_oy7Jdg-- X-Sonic-MF: X-Sonic-ID: 7f8f46a3-9abf-42c9-b107-d8b63d4c6b35 Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Fri, 13 Mar 2026 16:18:25 +0000 Received: by hermes--production-ir2-bbcfb4457-p7tzh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID d939675e202b65f50bac81e278ddbc12; Fri, 13 Mar 2026 15:47:57 +0000 (UTC) From: Tomasz Unger Date: Fri, 13 Mar 2026 16:47:54 +0100 Subject: [PATCH] staging: media: av7110: replace C++ comments with C style comments in sp8870.c Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260313-sp8870-cleanup-v1-1-2d5069c4eec5@yahoo.pl> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/x3MTQqAIBBA4avErBP8Lesq0UJsqoEwUYpAunvS8 lu8VyBjIswwNgUS3pTpDBWibcDvLmzIaKkGyWXHlVAsR2t7zvyBLlyR+c4YyQeN2g9Qo5hwpec fTvP7fk3oydZgAAAA X-Change-ID: 20260313-sp8870-cleanup-c6552094e4c9 To: Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tomasz Unger X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773416876; l=6043; i=tomasz.unger@yahoo.pl; s=20260311; h=from:subject:message-id; bh=43iHeHcqLmWDLlWsITqoi4SJ2eUkzhJoF5R7wUzzA9U=; b=hLjl1htnBMXe0WYg9oHmubJ3HfghxcsC//Q29+/xH84rtIgZVrJsOPomLymy5P+4mfu7jOa0R ot2bdM9qLrxBaacl8srbHmczVxEKQfhn2GCod1ewbu7FsGCxpO/mJ4y X-Developer-Key: i=tomasz.unger@yahoo.pl; a=ed25519; pk=EPPsO91uz/0J2cTQ6ol+dgxYaieEc9dKSXWUb51n46c= References: <20260313-sp8870-cleanup-v1-1-2d5069c4eec5.ref@yahoo.pl> Signed-off-by: Tomasz Unger --- drivers/staging/media/av7110/sp8870.c | 52 +++++++++++++++++--------------= ---- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/= av7110/sp8870.c index 29fb4934c039..47a1eb22ef49 100644 --- a/drivers/staging/media/av7110/sp8870.c +++ b/drivers/staging/media/av7110/sp8870.c @@ -109,21 +109,21 @@ static int sp8870_firmware_upload(struct sp8870_state= *state, const struct firmw if (fw->size < SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET) return -EINVAL; =20 - // system controller stop + /* system controller stop */ sp8870_writereg(state, 0x0F00, 0x0000); =20 - // instruction RAM register hiword + /* instruction RAM register hiword */ sp8870_writereg(state, 0x8F08, ((SP8870_FIRMWARE_SIZE / 2) & 0xFFFF)); =20 - // instruction RAM MWR + /* instruction RAM MWR */ sp8870_writereg(state, 0x8F0A, ((SP8870_FIRMWARE_SIZE / 2) >> 16)); =20 - // do firmware upload + /* do firmware upload */ fw_pos =3D SP8870_FIRMWARE_OFFSET; while (fw_pos < SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET) { tx_len =3D (fw_pos <=3D SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET - = 252) ? 252 : SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET - fw_pos; - // write register 0xCF0A + /* write register 0xCF0A */ tx_buf[0] =3D 0xCF; tx_buf[1] =3D 0x0A; memcpy(&tx_buf[2], fw_buf + fw_pos, tx_len); @@ -149,7 +149,7 @@ static void sp8870_microcontroller_stop(struct sp8870_s= tate *state) sp8870_writereg(state, 0x0F08, 0x000); sp8870_writereg(state, 0x0F09, 0x000); =20 - // microcontroller STOP + /* microcontroller STOP */ sp8870_writereg(state, 0x0F00, 0x000); } =20 @@ -158,10 +158,10 @@ static void sp8870_microcontroller_start(struct sp887= 0_state *state) sp8870_writereg(state, 0x0F08, 0x000); sp8870_writereg(state, 0x0F09, 0x000); =20 - // microcontroller START + /* microcontroller START */ sp8870_writereg(state, 0x0F00, 0x001); - // not documented but if we don't read 0x0D01 out here - // we don't get a correct data valid signal + /* not documented but if we don't read 0x0D01 out here */ + /* we don't get a correct data valid signal */ sp8870_readreg(state, 0x0D01); } =20 @@ -243,7 +243,7 @@ static int configure_reg0xc05(struct dtv_frontend_prope= rties *p, u16 *reg0xc05) =20 static int sp8870_wake_up(struct sp8870_state *state) { - // enable TS output and interface pins + /* enable TS output and interface pins */ return sp8870_writereg(state, 0xC18, 0x00D); } =20 @@ -258,29 +258,29 @@ static int sp8870_set_frontend_parameters(struct dvb_= frontend *fe) if (err) return err; =20 - // system controller stop + /* system controller stop */ sp8870_microcontroller_stop(state); =20 - // set tuner parameters + /* set tuner parameters */ if (fe->ops.tuner_ops.set_params) { fe->ops.tuner_ops.set_params(fe); if (fe->ops.i2c_gate_ctrl) fe->ops.i2c_gate_ctrl(fe, 0); } =20 - // sample rate correction bit [23..17] + /* sample rate correction bit [23..17] */ sp8870_writereg(state, 0x0319, 0x000A); =20 - // sample rate correction bit [16..0] + /* sample rate correction bit [16..0] */ sp8870_writereg(state, 0x031A, 0x0AAB); =20 - // integer carrier offset + /* integer carrier offset */ sp8870_writereg(state, 0x0309, 0x0400); =20 - // fractional carrier offset + /* fractional carrier offset */ sp8870_writereg(state, 0x030A, 0x0000); =20 - // filter for 6/7/8 Mhz channel + /* filter for 6/7/8 Mhz channel */ if (p->bandwidth_hz =3D=3D 6000000) sp8870_writereg(state, 0x0311, 0x0002); else if (p->bandwidth_hz =3D=3D 7000000) @@ -288,7 +288,7 @@ static int sp8870_set_frontend_parameters(struct dvb_fr= ontend *fe) else sp8870_writereg(state, 0x0311, 0x0000); =20 - // scan order: 2k first =3D 0x0000, 8k first =3D 0x0001 + /* scan order: 2k first =3D 0x0000, 8k first =3D 0x0001 */ if (p->transmission_mode =3D=3D TRANSMISSION_MODE_2K) sp8870_writereg(state, 0x0338, 0x0000); else @@ -296,12 +296,12 @@ static int sp8870_set_frontend_parameters(struct dvb_= frontend *fe) =20 sp8870_writereg(state, 0xc05, reg0xc05); =20 - // read status reg in order to clear pending irqs + /* read status reg in order to clear pending irqs */ err =3D sp8870_readreg(state, 0x200); if (err < 0) return err; =20 - // system controller start + /* system controller start */ sp8870_microcontroller_start(state); =20 return 0; @@ -337,16 +337,16 @@ static int sp8870_init(struct dvb_frontend *fe) /* enable TS output and interface pins */ sp8870_writereg(state, 0xc18, 0x00d); =20 - // system controller stop + /* system controller stop */ sp8870_microcontroller_stop(state); =20 - // ADC mode + /* ADC mode */ sp8870_writereg(state, 0x0301, 0x0003); =20 - // Reed Solomon parity bytes passed to output + /* Reed Solomon parity bytes passed to output */ sp8870_writereg(state, 0x0C13, 0x0001); =20 - // MPEG clock is suppressed if no valid data + /* MPEG clock is suppressed if no valid data */ sp8870_writereg(state, 0x0C14, 0x0001); =20 /* bit 0x010: enable data valid signal */ @@ -490,7 +490,7 @@ static int sp8870_set_frontend(struct dvb_frontend *fe) return err; =20 for (check_count =3D 0; check_count < MAXCHECKS; check_count++) { -// valid =3D ((sp8870_readreg(i2c, 0x0200) & 4) =3D=3D 0); + /* valid =3D ((sp8870_readreg(i2c, 0x0200) & 4) =3D=3D 0); */ valid =3D sp8870_read_data_valid_signal(state); if (valid) { dprintk("delay =3D %i usec\n", check_count * 10); @@ -526,7 +526,7 @@ static int sp8870_sleep(struct dvb_frontend *fe) { struct sp8870_state *state =3D fe->demodulator_priv; =20 - // tristate TS output and disable interface pins + /* tristate TS output and disable interface pins */ return sp8870_writereg(state, 0xC18, 0x000); } =20 --- base-commit: 0257f64bdac7fdca30fa3cae0df8b9ecbec7733a change-id: 20260313-sp8870-cleanup-c6552094e4c9 Best regards, --=20 Tomasz Unger