From nobody Tue Apr 7 09:18:43 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95E473DFC62; Fri, 13 Mar 2026 18:45:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773427531; cv=none; b=HvXt6hdJ/97mbJ22GE0dYgA/ig4TWroXMOrkKpOQdY/Nc5d2X+Bu9duZ5oAbs56jt58aoeq4p5RCoA+M7THqM8qiZ3LUlc1QifBeZ5hRVIIYSQsSsUkq5OaD5xKJ76rgSsKYrFcuHDqEXv84xH6kfTWQl8nwiqy9oESTGYK4ulo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773427531; c=relaxed/simple; bh=VsdJVy3sTJ50eCmktjm1NaHsn25vDLcl0SM75ClV9Rc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mDx3AFJPfufMbsq7JOB//mGmI5s5LkBcBBh0VtFzOD0p6WgJdgpkQt5d1kIb+uLeRV1PJ8BO3hYQYsVOHnkwXLZX8kpKEiuUwRSAq7ZcGSl8N/jd74eTgHqhzHwiEt7d9sY79avYWdVXiDEg3DULBlCYuW4sh5FprC9WakQHSnY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bnRXa1VH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bnRXa1VH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7497C19425; Fri, 13 Mar 2026 18:45:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773427531; bh=VsdJVy3sTJ50eCmktjm1NaHsn25vDLcl0SM75ClV9Rc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=bnRXa1VHVvVJD916byi9EspKw1wm50hd014CssWBokfTTHS1RQj/fqei8TbUaoPxg I3LSXNM9UnNvI8m60HKTCnOazhIYR8K78zrs1OYuozI7ANEibH9dtBNWVyZwqRNcpo +0msMrdNWpDZ9gxY4cuoxifKeDHM7BZizx474vAd5IkserERo60ei+nM7m2jRpXR80 2zpzOsqrRl3p20fqV7KDoAVgITQUQ8CgIl/XbUib1czO92SJdn5penuSby2I+CDAXY qgfWzl+L2YVoT7ZbVZlPGC4HBq0jex5Z645nswqphtR2ni9uR7Mpcng8fI6vJ1tgef gmSCu+0XuKuwA== From: Jeff Layton Date: Fri, 13 Mar 2026 14:45:20 -0400 Subject: [PATCH v2 1/2] nilfs2: fix 64-bit division operations in nilfs_bmap_find_target_in_group() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260313-iino-u64-v2-1-f9abda2464d5@kernel.org> References: <20260313-iino-u64-v2-0-f9abda2464d5@kernel.org> In-Reply-To: <20260313-iino-u64-v2-0-f9abda2464d5@kernel.org> To: Ryusuke Konishi , Viacheslav Dubeyko , Christian Brauner , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Paul Moore , James Morris , "Serge E. Hallyn" Cc: linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jeff Layton , kernel test robot X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1652; i=jlayton@kernel.org; h=from:subject:message-id; bh=VsdJVy3sTJ50eCmktjm1NaHsn25vDLcl0SM75ClV9Rc=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBptFtHgVz5Ez9M7BPwQSQgBYWYjhduyOwgFLCpY DWRyWnpzcmJAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCabRbRwAKCRAADmhBGVaC Fbd0EAC63ze4Y0h/N6pFbgd2cBbOYxz2B088CZNe2BUbP6nCDHTiMjMZBD949ZSjLAqHANjmlWl A8FjxrrfrtoMY9xC+yKL0wVcosbXxfo6J0+kiJIlINPpXBo72tRLyAPZHE16STU6NRN8VRzWY5S +ApvfCBKSKYhm3GlHILWjjdee2MGaqzyVr7psG4WM7A1DVWQzE1RxLuR/shmUih2fi42wN8DUIF 0+8igziop0SJ75ZLqpXK7IYbCe6mCCyjR4cJxdSYq4yRXb6udacHo2ZuapYkuTAGBpU8XDlPpbq rdP/FDAIi2PJbnVr4tnN0lQDnwRx/dYI33OdNL1FsJRiXeG1zusWopJ8kR6fiSNUayixVcsvpi5 oS1CbRuNzWL9t1HAUwWd20kfofn6914xtln044ygpil9j/Frc5ldXwkMlXfDAUtfrG/ORFobQxV LYX8VLsX6O8J8UoeUwHilauukPE1khN7vck+okftq0X6cSMrha5L70zH8ykWjUjp/TLKCJv6USc NFr5GAzFSYlKuKRGQnJgh5bhZEf6HSivYH0PlV3Gh6E8z1KR6JzlGP36ZBz7yJiZN8Ug9xHrxlb 97qIfn/YWt4PBfCUX0BTEAjWjTrbKcv9+4mVZl27WFIulUyyi5FUU5ObM/XIzq5nF/89/8M4DwE skgJ2M8X2JKptZw== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 With the change to make inode->i_ino a u64, the build started failing on 32-bit ARM with: ERROR: modpost: "__aeabi_uldivmod" [fs/nilfs2/nilfs2.ko] undefined! Fix this by using the 64-bit division interfaces in nilfs_bmap_find_target_in_group(). Fixes: 998a59d371c2 ("treewide: fix missed i_ino format specifier conversio= ns") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202603100602.KPxiClIO-lkp@int= el.com/ Reviewed-by: Viacheslav Dubeyko Acked-by: Ryusuke Konishi Signed-off-by: Jeff Layton --- fs/nilfs2/bmap.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/nilfs2/bmap.c b/fs/nilfs2/bmap.c index 824f2bd91c167965ec3a660202b6e6c5f1fe007e..abcf5252578ad24f694bfccf525= 893674bfcb4bc 100644 --- a/fs/nilfs2/bmap.c +++ b/fs/nilfs2/bmap.c @@ -455,11 +455,14 @@ __u64 nilfs_bmap_find_target_in_group(const struct ni= lfs_bmap *bmap) { struct inode *dat =3D nilfs_bmap_get_dat(bmap); unsigned long entries_per_group =3D nilfs_palloc_entries_per_group(dat); - unsigned long group =3D bmap->b_inode->i_ino / entries_per_group; + unsigned long group; + u32 index; + + group =3D div_u64(bmap->b_inode->i_ino, entries_per_group); + div_u64_rem(bmap->b_inode->i_ino, NILFS_BMAP_GROUP_DIV, &index); =20 return group * entries_per_group + - (bmap->b_inode->i_ino % NILFS_BMAP_GROUP_DIV) * - (entries_per_group / NILFS_BMAP_GROUP_DIV); + index * (entries_per_group / NILFS_BMAP_GROUP_DIV); } =20 static struct lock_class_key nilfs_bmap_dat_lock_key; --=20 2.53.0 From nobody Tue Apr 7 09:18:43 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 049403E0229; Fri, 13 Mar 2026 18:45:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773427533; cv=none; b=amibnnThqcWBu762wOpHBGh7RiW8qPZJzrCQ/iZT5kO1CDwSo1Uh6JXMyVPvcxPIVRTnUMLDyjtEZZjNCIew/9Zn4jsrJ9lZxhr6TYOiRcAOJGSrQXZHm6YxtRbHmkohp0kM/MaXrfy464RWQkpi9kOgGVBKIHMtgGP6Y2bSwyY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773427533; c=relaxed/simple; bh=Vytham6oPFTdVP7zlc8wsX2dbeVuNOdhbpe3qUY80eE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bsAwdcjx5WHAo/3oBxc5Omx0+dCJqeYjdgyI9pbaE/7h6UDGQ/6m5PcPEfHcPbWPZ79G3kDZFTg363W+iJ/X9YEF6t+S21uNKdIxTCkeHKT7/3+FdCLEWJU1QPaQWUX3pV+Y2/a0xxJKSpURKvGFc76roiQV5Uu8SYe1lP1TBe4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PYtz5RvO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PYtz5RvO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F053C19421; Fri, 13 Mar 2026 18:45:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773427532; bh=Vytham6oPFTdVP7zlc8wsX2dbeVuNOdhbpe3qUY80eE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=PYtz5RvOFHnpksyifzWqrlcNXD2mHixGwo2ZnIHp+6xKrAc1RCwElMZT56yO5H2Tn 6Yh05DQWwXyZ0nkoqVReUaEADDYXaRpXKZyxeNw4KylJY/jZdTQjXKIpMam5bPZCVp +xMiXFpsOghYgE5iOYSx5JcQfBCno9D/HVWpRM0pgZZAK86po9ontPVMFif2N4jV5L T4V07FVs7Sr76drRFa0OE5d48E2mJR8PvhrAoiWkRJy6wpSTroAQ2r9GXMg03Tq1Ir OXSYyoxpU+qeBj0thU8pXO93XzgdLUT1oHWPcmhvVjuhz95LImcEalC3qcU4M+joMU T0dVtuhn755zg== From: Jeff Layton Date: Fri, 13 Mar 2026 14:45:21 -0400 Subject: [PATCH v2 2/2] EVM: add comment describing why ino field is still unsigned long Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260313-iino-u64-v2-2-f9abda2464d5@kernel.org> References: <20260313-iino-u64-v2-0-f9abda2464d5@kernel.org> In-Reply-To: <20260313-iino-u64-v2-0-f9abda2464d5@kernel.org> To: Ryusuke Konishi , Viacheslav Dubeyko , Christian Brauner , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Paul Moore , James Morris , "Serge E. Hallyn" Cc: linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1386; i=jlayton@kernel.org; h=from:subject:message-id; bh=Vytham6oPFTdVP7zlc8wsX2dbeVuNOdhbpe3qUY80eE=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBptFtHVGsrqAxYGtXuCQ/JYxGPfWUNgo1lLCSUj /YxSVapIHiJAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCabRbRwAKCRAADmhBGVaC FX92D/9nua2e1HJ7hFrbi3pC4jkry5qKaxJSkox+XIxiA8MDyoZt64+/KPhETaU4oby4jAT9dJ2 C3Go+zYOdk2t4kKIQ0UkhYEURTLkSW4/Rs8vyt/vchtzt8Fk5VPbY7Jv15rs6pMZLNx1FjZVBuN w7op0eT46v+tiPK3uoRAfE3nZu8bL8BUMriCATH8ySeCQRFiexmRJm2yJBZN1YtB1tgFUvSMfBt 1zYagMr7xuZYGIsDcnYWe0H3ugfyOVB9ayg7c6WsIUwqF4RWxbvkSrLm6PRKSkq9tHgWM0Lwz3I vixeTLgHswtGFp9LohAct1BZA9lyc7o6NGoPt0xSATQdVpAUG8/IBLMryeiGpjJiiDDItDtR9yW f8gTIlz4WOBRUkAOD9tmtf/nyOC4z1jve/OGROLXvmNVh3wPr/sC4tlV6oEegioOGEkhikEsq9a t/PsX86yAyGvcDhBSz8Uv4+oo5jmIWaKVwXkPrommyaeglc45/RrrUj2fM6Nwrh39tTfhhOTbZV FIOkr67djnn41oHUqn3DRTWvUovkCp8Y79PycPOxGeQOGVwikyV+seLXezk1nvAb6GvVQ9c0Obr GZbgFsvnmocoGQtt0xk3n/lK+1nLSDf/QgDxig1O0pj8+RHxWvlRefaiR9IClqgJUQQ0sSghyi5 zUdFI6+aED4iOCQ== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Mimi pointed out that we didn't widen the inode number field in struct h_misc alongside the inode->i_ino widening. While we could make an equivalent change there, that would require EVM resigning on all 32-bit hosts. Instead, leave the field as an unsigned long. This should have no effect on 64-bit hosts, and allow things to continue working on 32-bit hosts in the cases where the i_ino fits in 32-bits. Add a comment explaining why it's being left as unsigned long. Cc: Mimi Zohar Signed-off-by: Jeff Layton Reviewed-by: Mimi Zohar --- security/integrity/evm/evm_crypto.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/security/integrity/evm/evm_crypto.c b/security/integrity/evm/e= vm_crypto.c index c0ca4eedb0fe5d5c30f45f515a4bc90248ec64ea..1c41af2f91a60a714878ff93b55= 4c90e45546503 100644 --- a/security/integrity/evm/evm_crypto.c +++ b/security/integrity/evm/evm_crypto.c @@ -144,6 +144,12 @@ static void hmac_add_misc(struct shash_desc *desc, str= uct inode *inode, char type, char *digest) { struct h_misc { + /* + * Although inode->i_ino is now u64, this field remains + * unsigned long to allow existing HMAC and signatures from + * 32-bit hosts to continue working when i_ino hasn't changed + * and fits in a u32. + */ unsigned long ino; __u32 generation; uid_t uid; --=20 2.53.0