From nobody Tue Apr 7 11:21:00 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9507399013 for ; Fri, 13 Mar 2026 13:53:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773410018; cv=none; b=sdimHvRtPWorKnrue0hbalCEMCbe7hiM9Oc9tlrqUrjSOgt13fpKOQZfNNgOJzFPMy9iJvIxwI1Qzg007C2gSK+PMiYBQx+KwgQmba5Z95bAb0880bddwnvd4DyuNVz6Gk5HjO3FR74QD4jZ7lPopLgQLifH0v3Fon+3IB3C2f4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773410018; c=relaxed/simple; bh=TrCdImSus03fQxnuCdhKZOvel6k0XW4oA6lvm5eRWDU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=AVwdvl7Omg5jOwU3707ZmvbUfH5M+kGN4ZzSfh0uNQmP/fFS28cDiWys9Hd6MRNQ2vCnaguA7xu53P35P9Lr5eKNcdTc042XfAjREtwMH0WxtYbXf4/sCbWlx+kNEFRmET9eUsQbN/aXDURCLT9OaGDZ+vbusMq1AJAIZe3titc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kDT/+9YQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Jpqh8kOY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kDT/+9YQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Jpqh8kOY" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D8vEjI481675 for ; Fri, 13 Mar 2026 13:53:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=xZKRgfOKHQVJGs25wrwwgK WUyR1Q+6l/FFjlEiaQ6PI=; b=kDT/+9YQxyZD92JD2tx2W0FVRUp3x2gvZMPdje tm3uz+Cx1sSXsD4vJEk3wPOJLgQMbJI1nhvGaqD8/TWDT4+4KK1DYPvHSSkcRnQ0 /1N0b2XwlKJnPuqKHUcNDK2u0IFAWVcA129V0/9BqeqR1bWvANGwIUvys8iQMcZ0 HNT2dqtbHym9oNx0b553zxLQI6TQJ8ASwhzY7k/jf6UFmXYcEYEBcj8Xu+dqfHsG RHp9g6mpxpkridUhN2/YFsS46c0I8iKavmW184rc8ylYqKE4TePFvaiMLeDsm+3D P8uUblrRE1xpsguD8nPs+CFQzkoXs7BMisqtReA29tWvra9A== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvfh7rym4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 13:53:32 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd7d66afceso1454046985a.3 for ; Fri, 13 Mar 2026 06:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773410012; x=1774014812; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=xZKRgfOKHQVJGs25wrwwgKWUyR1Q+6l/FFjlEiaQ6PI=; b=Jpqh8kOYUYEepzKaQyRoBtgLARVPDmMUSll8n9hymg/51fary8xUsluc+jxLMz14jM JAuZfI0J00+LNXvaDqin9Y83mydLmnhwGHY913wZ2vAEThP9eLByKDuKCgiMl2GF5yoE kli7v/qhl4NYDXXHQG07WTE/DTtyJAHYs4sicKYVPQRzwdBWeoW0uGWHzJU4MRa7Ujci JBP9mU6CpJAbkjEj98JBgPdERjWvT6kwKK/P95fiK69ZUdw0LUa1Nv6D46jTxPiXmFNb akh38tCYs1LeOVioL2fJVgUDJlKfca0FDVSjog7TTw+y7JueiELokGAYzuIOfnAdIYic 5MDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773410012; x=1774014812; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xZKRgfOKHQVJGs25wrwwgKWUyR1Q+6l/FFjlEiaQ6PI=; b=K7WGl/qRN2QnhvDQAKvaQIhbIqRZr6weMzCp7p84QO7JAjvwv5nVM3PaekvTnES/zd HzCdCiifseQ9JbJq80aHrNWxbKfhuT5Lqad9Q72Rxjn1r5DYQvgFUSYNNz1VR2jqko1w rBvydsJBsEUhmXtgQ1VRGTy5tWY9afCRF9AFJyqxFcttaMk7TP52Gsjsbfsg/OtLVj4l zDw4GFD6D1wQvawLDLVP815IOXMJOr9tSABBXlIpu5x9D7oxXSzsHgsNQ/fseP/GAyzp LlI22kZQy7eoeq5KONYjMbO4+Xwocqv6oBTnTr+jRJ4/o3wS0R5W/d0GX3Rh9UqjdSSy R5AQ== X-Forwarded-Encrypted: i=1; AJvYcCVTmwUTbtPQTJDS6aZGmYZ6Lve39wPWfkiYnM1VS66lePUNfPUNI2yO8rIdYEAxagS9Rmr4T8e84w4LuCU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1nxQxyMidNVVkRYG1cdsBDRwOxisicbRZzxSygDFSidbEuKZN virT+raia0O+o/lZXJil/K7Ccbbt3QQGVm8iGwkM9kiIiU6YMXXZDv4DGhuKDNPamWZ48i4AB30 9rt0/IeERwCz6GR4SPjtpQddExNQmNEIfWsZzR5Qe1UbVMjCTI6UkkIuv8ypyg5vjuOk= X-Gm-Gg: ATEYQzySR6HHW67owLRxOyecQo/4qsgNmmnSBEDy1x6Srd20WvlU8p1+aXntME/4eM6 6wUs4GCzr7OOZve8GRNW0AP35vCw/qASUiafzIwfnexUi2lwOfhcSAsGp7+dws62tBXauMNHOiF sfVrktUWU3roy+tbmmO0ptSmofOaGcXzYN9w6N0o41vz+HBtYm6lOcYg6tbm/ZLhrW9GXnMQ3SO TQWyuvbrOvh4syi5VerQzYFsAhrm7ZJE7p75pgW6hF6W3UEtamIv5IzxRU648My6X8K7Yw4tPqX 98xiObhgN8hSYrpQpjdXGid9C38OnaqUO/9CuS9H53O8LJcWUO+2aAjvUEyt09i0eufgkGkemCy vmvGhgVTfRL3jW+hvfwy36j43nkg= X-Received: by 2002:a05:620a:4095:b0:8cb:5176:ee5 with SMTP id af79cd13be357-8cdb5b71732mr446532285a.62.1773410011652; Fri, 13 Mar 2026 06:53:31 -0700 (PDT) X-Received: by 2002:a05:620a:4095:b0:8cb:5176:ee5 with SMTP id af79cd13be357-8cdb5b71732mr446526685a.62.1773410010974; Fri, 13 Mar 2026 06:53:30 -0700 (PDT) Received: from hackbox.lan ([82.79.95.133]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe20c0b4sm19515600f8f.25.2026.03.13.06.53.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 06:53:30 -0700 (PDT) From: Abel Vesa Date: Fri, 13 Mar 2026 15:53:22 +0200 Subject: [PATCH v3] arm64: dts: qcom: glymur-crd: Enable keyboard, trackpad and touchscreen Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260313-glymur-dts-crd-enable-kbd-tp-ts-v3-1-66c5ddfee97d@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIANEWtGkC/42Py27DIBBFf8Vi3YkA2xB7lf+ouuAxTmjjF2CrU eR/LzitlEWldoO4aDj3zJ0E9A4DaYs78bi64MYhhfKlIOaihjOCsykTTrmgJW3gfL31iwcbAxh vAQelrwgf2kKcID8eqaFGy2NTUZIok8fOfe4Nr2+PHBb9jiZm7PeEx3lJ1fExRrQKCGbsexfbo muoUrZjRkhDnrXaYpdiSSrbzOnDj102UzbZ2Qlo2dF0x0bWtF0rkiUuLsTR3/atV7Z3/nvBlQG DWmDiStEoKU5jCId5UddsfEjHXrHyJyzjf2N5wnIupUasTC2qX7Dbtn0B8NvVuLEBAAA= X-Change-ID: 20260309-glymur-dts-crd-enable-kbd-tp-ts-c80c0cb78940 To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Konrad Dybcio , Abel Vesa X-Mailer: b4 0.15-dev-7ae85 X-Developer-Signature: v=1; a=openpgp-sha256; l=5304; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=TrCdImSus03fQxnuCdhKZOvel6k0XW4oA6lvm5eRWDU=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBptBbY/ceZJSOjdSurXNa3/pjQ/uEP9VaXbrVd+ WdYFJHIpt6JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCabQW2AAKCRAbX0TJAJUV VtZ+D/938gX0reEP/1Rc7sQElhRzl6DGV5V/wn6PuUSouMAjdaWlFhDCRoPsZHcx98e/JtCxHTW 9AgUzrtglgRz77jr77a9CaknbVSqR//c1F8VpYyiXoh5DBFLoNQcHV6/6xVNv3EyPn9mZgy2fB3 AGSw9EDIcAzSOjORZHnarAY/MYvyfcFeGvAGc9M8h6tWT768cjnXqtYL1Y+UXyH+EqEoHyPXVyw D9bBomryQVuEKUn0nJ8k5ehqlAwR+b7HnGZMog5S0TseSYfbPca957rKf/EnQUmYZCnd/4eloBf 0rIuW7F1rxzqgRWRZ9cIIeivozU96SAgQIDvUOGyAko8dA/Dt8rvmDdGqIdlGfY3Jpzk2rO2R3g nsBOq4K3+aG7l7olbmlC9wbP/B4KYm0Jlz6Pkji1s9lhA04wr4XEpL47ao+cVvNWSiJiOLyMYdX vpZBPQoXK8sMmg2nveEh67b0m54/heP8h6tbF9/CbvvGkBNQghqHzwCr22BekR0XgWiqYoJabtx 9tupV77DIoImTWToOHrpw9TwtjZVe9GaNiEQOwqSDob7tSUgYJyN8w7Vj1Y8TqAZKCxyojwsf8H ZkAUKRo+qZWEpLHGQthZ6/xJ0BV1vvfx1GLKnDuyvWYRUtnU98MGv8qK/yRFD0LDb44FpqZjRyI gkefSGXjng6BEDA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-ORIG-GUID: ddzW0lCa0X71TcsFILIIKoktInjr8_yI X-Proofpoint-GUID: ddzW0lCa0X71TcsFILIIKoktInjr8_yI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDExMCBTYWx0ZWRfX1ElXocxVihcv fFUPBhKo+taSOeO2aJ1iIsDIdYZmzVr1N65Kny+5AOorh9GDHfs7lRXHXUCRKuG01ofSRg5ZZWJ 7ubCLOYaUlX6MDW4e+9H9TdanGoEBgs8u5aM3dLbAjehPhAsAaFXVWYC1nrTYjYGNWhAbPC2BkA cgtt4wDC7PhVWwFpFJl441neQXs9dU1FpHTj1Pruna3fGaE4or1cMxs1LjDlpTvZz0uQ33yqG7n 4lmmLvwUSmp1AaPp3QA3gnjRuapiVADlW5MTvjQ5O1svagVg8OC/YaeYrKr/z8jr1gkdF9NJY8r 1bOlX2luucxZbxG4O0ErzyDtTb3c1ZnKDdyhZYA2hqsF5oyJzy6r2tkGvw/iFrwBI4tL8S297Gz OgrphQ1G8XScaPMgLDqUptnMmz+JcX+pKL1t6TR9OtNetAcAWYgRI8l+gOF7uvJ8mrAuuBoR+cp YXabO4OaIkmhMs7hJmQ== X-Authority-Analysis: v=2.4 cv=BpiQAIX5 c=1 sm=1 tr=0 ts=69b416dc cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=iKs3dpp2RB4k51ZqCjcyjQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=-RH2vHZGa4pziAc3uSgA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 phishscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130110 On CRD, the keyboard, trackpad and touchscreen are connected over I2C and all share a 3.3V regulator. So describe the regulator and each input device along with their pinctrl states. Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- Changes in v3: - Picked up Dmitry's and Konrad's R-b tags. - Drop the output-high and add bias-disable to the reset pin of the touchscreen default state. - Link to v2: https://patch.msgid.link/20260312-glymur-dts-crd-enable-kbd-t= p-ts-v2-1-2277bee4c564@oss.qualcomm.com Changes in v2: - Rebased on next-20260311 - Re-ordered pinctrl properties in vreg_misc_3p3, as Konrad suggested. - Dropped next level dependency patchset. - Link to v1: https://patch.msgid.link/20260309-glymur-dts-crd-enable-kbd-t= p-ts-v1-1-56e03f769a76@oss.qualcomm.com --- arch/arm64/boot/dts/qcom/glymur-crd.dts | 117 ++++++++++++++++++++++++++++= ++++ 1 file changed, 117 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dts b/arch/arm64/boot/dts/= qcom/glymur-crd.dts index 38cdcf662ba7..5089ff7cdca3 100644 --- a/arch/arm64/boot/dts/qcom/glymur-crd.dts +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dts @@ -13,6 +13,8 @@ #include "pmk8850.dtsi" /* SPMI0: SID-0 */ #include "smb2370.dtsi" /* SPMI2: SID-9/10/11 */ =20 +#include + / { model =3D "Qualcomm Technologies, Inc. Glymur CRD"; compatible =3D "qcom,glymur-crd", "qcom,glymur"; @@ -139,6 +141,23 @@ vreg_edp_3p3: regulator-edp-3p3 { regulator-boot-on; }; =20 + vreg_misc_3p3: regulator-misc-3p3 { + compatible =3D "regulator-fixed"; + + regulator-name =3D "VREG_MISC_3P3"; + regulator-min-microvolt =3D <3300000>; + regulator-max-microvolt =3D <3300000>; + + gpio =3D <&pmh0110_f_e0_gpios 6 GPIO_ACTIVE_HIGH>; + enable-active-high; + + pinctrl-0 =3D <&misc_3p3_reg_en>; + pinctrl-names =3D "default"; + + regulator-boot-on; + regulator-always-on; + }; + vreg_nvme: regulator-nvme { compatible =3D "regulator-fixed"; =20 @@ -446,6 +465,64 @@ vreg_l4h_e0_1p2: ldo4 { }; }; =20 +&i2c0 { + clock-frequency =3D <400000>; + + status =3D "okay"; + + touchpad@2c { + compatible =3D "hid-over-i2c"; + reg =3D <0x2c>; + + hid-descr-addr =3D <0x20>; + interrupts-extended =3D <&tlmm 3 IRQ_TYPE_LEVEL_LOW>; + + vdd-supply =3D <&vreg_misc_3p3>; + vddl-supply =3D <&vreg_l15b_e0_1p8>; + + pinctrl-0 =3D <&tpad_default>; + pinctrl-names =3D "default"; + + wakeup-source; + }; + + keyboard@3a { + compatible =3D "hid-over-i2c"; + reg =3D <0x3a>; + + hid-descr-addr =3D <0x1>; + interrupts-extended =3D <&tlmm 67 IRQ_TYPE_LEVEL_LOW>; + + vdd-supply =3D <&vreg_misc_3p3>; + vddl-supply =3D <&vreg_l15b_e0_1p8>; + + pinctrl-0 =3D <&kybd_default>; + pinctrl-names =3D "default"; + + wakeup-source; + }; +}; + +&i2c8 { + clock-frequency =3D <400000>; + + status =3D "okay"; + + touchscreen@38 { + compatible =3D "hid-over-i2c"; + reg =3D <0x38>; + + hid-descr-addr =3D <0x1>; + interrupts-extended =3D <&tlmm 51 IRQ_TYPE_LEVEL_LOW>; + + vdd-supply =3D <&vreg_misc_3p3>; + vddl-supply =3D <&vreg_l15b_e0_1p8>; + + pinctrl-0 =3D <&ts0_default>; + pinctrl-names =3D "default"; + }; +}; + &i2c5 { clock-frequency =3D <400000>; =20 @@ -626,6 +703,19 @@ key_vol_up_default: key-vol-up-default-state { }; }; =20 +&pmh0110_f_e0_gpios { + misc_3p3_reg_en: misc-3p3-reg-en-state { + pins =3D "gpio6"; + function =3D "normal"; + bias-disable; + input-disable; + output-enable; + drive-push-pull; + power-source =3D <1>; /* 1.8 V */ + qcom,drive-strength =3D ; + }; +}; + &pmk8850_rtc { qcom,no-alarm; }; @@ -664,6 +754,33 @@ edp_reg_en: edp-reg-en-state { bias-disable; }; =20 + kybd_default: kybd-default-state { + pins =3D "gpio67"; + function =3D "gpio"; + bias-disable; + }; + + tpad_default: tpad-default-state { + pins =3D "gpio3"; + function =3D "gpio"; + bias-disable; + }; + + ts0_default: ts0-default-state { + int-n-pins { + pins =3D "gpio51"; + function =3D "gpio"; + bias-disable; + }; + + reset-n-pins { + pins =3D "gpio48"; + function =3D "gpio"; + drive-strength =3D <16>; + bias-disable; + }; + }; + pcie4_default: pcie4-default-state { clkreq-n-pins { pins =3D "gpio147"; --- base-commit: f90aadf1c67c8b4969d1e5e6d4fd7227adb6e4d7 change-id: 20260309-glymur-dts-crd-enable-kbd-tp-ts-c80c0cb78940 prerequisite-change-id: 20260109-dts-qcom-glymur-crd-add-edp-03f0adde9750:v4 prerequisite-patch-id: df42484b224c01014637ec5a8f56bab459890557 prerequisite-patch-id: d986d8d948eaf7b80028b2244750dc7aff7de307 prerequisite-patch-id: 7ec5f802a334d96421d8f95d4d9e9773655cc947 prerequisite-patch-id: 8d9e016b49979fa817cf9eab70b809fdb9d4656f prerequisite-patch-id: 6a291fd702870ca28d64439313d498593996b741 prerequisite-patch-id: c96958ab5c5605fb9577645ac5bfe5912cdfebfe prerequisite-patch-id: bfa283218723a48e54fcd842484b004c877339b7 prerequisite-patch-id: 346f2db0933c551a039f63b945f989a5c8320657 prerequisite-patch-id: 919020405b70d588fa4356a5cbfb44e67006102e Best regards, -- =20 Abel Vesa